fastlane-plugin-firebase_app_distribution 0.2.7 → 0.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0ac0c2dc12f234aed77fd40f52be02c88131789e574e7081cd6d78153cda45a6
-  data.tar.gz: 27c04b470cd424a3d847d372a42be4caaac85ff519a7ddaa3edd6a7706139186
+  metadata.gz: c5690358deeb4e414dbfa9de99dd70aec8eb3a58ef77ebb03a9617ffdfb38c38
+  data.tar.gz: aa55223435954d0a72a283434ec9ee045bf4b7eb28f3a1f6584b20d1a8723bb7
 SHA512:
-  metadata.gz: 849acba39932e5a61fa292ae8266173d5f4763f9239ba90de6ff74291db0e5ebf1cfbcf6fc55aa6eba29b9a9d75ae610a935ac192c9eebf062c3fd26ea3da2c0
-  data.tar.gz: 5d382aa5887b3d5c1c993323f4332ca0d09bc04fea91e37be73494c67a8425d97e00d36c7c9c9680c1a1493b8d25ab797281798e46220876ef206a990086b4c2
+  metadata.gz: c01a0eb7cb2bca6727529de5a056f936e846438b379b218ca545febb649c0136a9a67c1ed54c36cd386ec06247bb8c3dc88dc812478e5a7ebf0fdde1dbc09dcf
+  data.tar.gz: 7fca01eadddd637a2b7252100a9187c289930d186ed95aef0bb769f9f19da77bf2588989d779d3b3103b4b869ee09db0e424f3aca8052684cb16ce5989ca04f6

data/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb

@@ -8,7 +8,6 @@ require_relative '../helper/firebase_app_distribution_error_message'
 require_relative '../client/firebase_app_distribution_api_client'
 require_relative '../helper/firebase_app_distribution_auth_client'
 
-## TODO: should always use a file underneath? I think so.
 ## How should we document the usage of release notes?
 module Fastlane
   module Actions
@@ -34,11 +33,7 @@ module Fastlane
         app_view = binary_type == :AAB ? 'FULL' : 'BASIC'
         app = fad_api_client.get_app(app_id, app_view)
         validate_app!(app, binary_type)
-
         release_id = fad_api_client.upload(app.project_number, app_id, binary_path, platform.to_s)
-        if release_id.nil?
-          return
-        end
 
         if binary_type == :AAB && app.aab_certificate.empty?
           updated_app = fad_api_client.get_app(app_id)

data/lib/fastlane/plugin/firebase_app_distribution/client/firebase_app_distribution_api_client.rb

@@ -127,10 +127,10 @@ module Fastlane
       #   app_id - Firebase app ID
       #   binary_path - Absolute path to your app's aab/apk/ipa file
       #
-      # Returns the release_id on a successful release, otherwise returns nil.
+      # Returns the release_id of the uploaded release.
       #
-      # Throws a UI error if the number of polling retries exceeds MAX_POLLING_RETRIES
-      # Crashes if not able to upload the binary
+      # Crashes if the number of polling retries exceeds MAX_POLLING_RETRIES or if the binary cannot
+      # be uploaded.
       def upload(project_number, app_id, binary_path, platform)
         binary_type = binary_type_from_path(binary_path)
 
@@ -159,8 +159,7 @@ module Fastlane
             end
           end
           unless upload_status_response.success?
-            UI.error("It took longer than expected to process your #{binary_type}, please try again.")
-            return nil
+            UI.crash!("It took longer than expected to process your #{binary_type}, please try again.")
           end
         end
         upload_status_response.release_id

data/lib/fastlane/plugin/firebase_app_distribution/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module FirebaseAppDistribution
-    VERSION = "0.2.7"
+    VERSION = "0.2.8"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-firebase_app_distribution
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.2.8
 platform: ruby
 authors:
 - Stefan Natchev
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-20 00:00:00.000000000 Z
+date: 2021-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry