fastlane-plugin-firebase_app_distribution 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 95ce0caafa7c11d0cb4796cbc744b6a1e1376c5edf3cdc38859960724bbb67a0
-  data.tar.gz: fc59439517a29b7cab67717a7c359a5f5d79b51ff342eccf5f660e98cb7343b9
+  metadata.gz: 839bb3358367db7178eed367005e3ede2a7b5073f25924ea71c96120afdfcbc2
+  data.tar.gz: 4f0316d47fe8c3d0027cb24cc6389448c6e2372dd8413d83c4d6d0f49e7ff3a0
 SHA512:
-  metadata.gz: d992a8074bff8b4c5c08b1bd1dae8bf498be2dc7b9b8e0562e76c2eb38e2ace7784d858c782f3df2d344c587ca29a39c798b7c07244df680ae64e82b3ed05d13
-  data.tar.gz: d65c13c342fda3ff0bae78f24388015a9220dfeb4d28e13c8d1c0e7c0f170461b6d3911e6b8e72b9cd0ecae6684596416c47f21f40aa03cef4e6e1ff6a858cf8
+  metadata.gz: 38eb5236916ab973cda79be4442dfcfe62faacf3915cf8875131bf4ae703085a30d65e17c3c765e6c53b6adfc66db14e2075d4538549dd68e74ed9342c1830e3
+  data.tar.gz: 5382e2ddbe0081c20435d009826be4a83256aa65c93e48c34b2047f0bd38d074f44360b8939a45daef75546a06a3003259d6f73453ad8ff7f694af2ee6b55290

data/README.md

@@ -1,26 +1,15 @@
-# firebase_app_distribution plugin
 
-[![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg)](https://rubygems.org/gems/fastlane-plugin-firebase_app_distribution)
-
-## Getting Started
 
-This project is a [_fastlane_](https://github.com/fastlane/fastlane) plugin. To get started with `fastlane-plugin-firebase_app_distribution`, add it to your project by running:
-
-```bash
-fastlane add_plugin firebase_app_distribution
-```
+# ![Firebase App Distribution](fad-icon.png) Firebase App Distribution
 
-## About firebase_app_distribution
-
-Release your beta builds to Firebase App Distro
-
-**Note to author:** Add a more detailed description about this plugin here. If your plugin contains multiple actions, make sure to mention them here.
+[![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg)](https://rubygems.org/gems/fastlane-plugin-firebase_app_distribution)
 
-## Example
+Firebase App Distribution makes distributing your apps to trusted testers painless. By getting your apps onto testers' devices quickly, you can get feedback early and often. To learn more about Firebase App Distribution, go [here](https://firebase.google.com/docs/app-distribution).
 
-Check out the [example `Fastfile`](fastlane/Fastfile) to see how to use this plugin. Try it by cloning the repo, running `fastlane install_plugins` and `bundle exec fastlane test`.
 
-**Note to author:** Please set up a sample project to make it easy for users to explore what your plugin does. Provide everything that is necessary to try out the plugin in this project (including a sample Xcode/Android project if necessary)
+## Getting Started
+ - [iOS](https://firebase.google.com/docs/app-distribution/ios/distribute-fastlane)
+ - [Android](https://firebase.google.com/docs/app-distribution/android/distribute-fastlane)
 
 ## Run tests for this plugin
 

data/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb

@@ -9,21 +9,22 @@ require_relative '../helper/firebase_app_distribution_helper'
 module Fastlane
   module Actions
     class FirebaseAppDistributionAction < Action
-      DEFAULT_FIREBASE_CLI_PATH = `which firebase`.chomp
+      DEFAULT_FIREBASE_CLI_PATH = `which firebase`
       FIREBASECMD_ACTION = "appdistribution:distribute".freeze
 
       extend Helper::FirebaseAppDistributionHelper
 
       def self.run(params)
         params.values # to validate all inputs before looking for the ipa/apk
-
-        cmd = [params[:firebase_cli_path], FIREBASECMD_ACTION]
+        cmd = [params[:firebase_cli_path].chomp, FIREBASECMD_ACTION]
         cmd << Shellwords.escape(params[:ipa_path] || params[:apk_path])
         cmd << "--app #{params[:app]}"
 
         cmd << groups_flag(params)
         cmd << testers_flag(params)
         cmd << release_notes_flag(params)
+        cmd << flag_value_if_supplied('--token', :firebase_cli_token, params)
+        cmd << flag_if_supplied('--debug', :debug, params)
 
         Actions.sh_control_output(
           cmd.compact.join(" "),
@@ -93,6 +94,7 @@ module Fastlane
                                        optional: false,
                                        type: String,
                                        verify_block: proc do |value|
+                                         value.chomp!
                                          if value.to_s == "" || !File.exist?(value)
                                            UI.user_error!("firebase_cli_path: missing path to firebase cli tool. Please install firebase in $PATH or specify path")
                                          end
@@ -132,7 +134,16 @@ module Fastlane
                                        env_name: "FIREBASEAPPDISTRO_RELEASE_NOTES_FILE",
                                        description: "Release notes file for this build",
                                        optional: true,
-                                       type: String)
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :firebase_cli_token,
+                                       description: "Auth token for firebase cli",
+                                       optional: true,
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :debug,
+                                       description: "Print verbose debug output",
+                                       optional: true,
+                                       default_value: false,
+                                       is_string: false)
         ]
       end
 

data/lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_helper.rb

@@ -26,6 +26,14 @@ module Fastlane
         end
       end
 
+      def flag_value_if_supplied(flag, param_name, params)
+        "#{flag} #{params[param_name]}" if params[param_name]
+      end
+
+      def flag_if_supplied(flag, param_name, params)
+        flag if params[param_name]
+      end
+
       ##
       # always return a file for a given content
       def file_for_contents(parameter_name, params)

data/lib/fastlane/plugin/firebase_app_distribution/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module FirebaseAppDistribution
-    VERSION = "0.1.2"
+    VERSION = "0.1.3"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-firebase_app_distribution
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Stefan Natchev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-28 00:00:00.000000000 Z
+date: 2019-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -137,7 +137,8 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 2.127.1
 description: 
-email: snatchev@google.com
+email:
+- snatchev@google.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -148,7 +149,7 @@ files:
 - lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb
 - lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_helper.rb
 - lib/fastlane/plugin/firebase_app_distribution/version.rb
-homepage: 
+homepage: https://github.com/fastlane-community/fastlane-plugin-firebase_app_distribution
 licenses:
 - MIT
 metadata: {}
@@ -167,8 +168,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
-summary: Release your beta builds to Firebase App Distro
+summary: Release your beta builds to Firebase App Distribution. https://firebase.google.com/docs/app-distribution
 test_files: []