fastlane-plugin-carthage_cache_ftps 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 802269f867a7261db7acaf714b3957b90edb53ff
-  data.tar.gz: 830e512786a52f1aaf7e242ea3bcbb3ebce0437e
+  metadata.gz: 8b2ce1a9eea0c1d6cbb8643f46b7ae032d7189f2
+  data.tar.gz: b86d2094773f68b5c49b0ff33dc8e257c48c2905
 SHA512:
-  metadata.gz: 7b3d162c2bc42afe0c9e48015ff9d366daafddd1ef089e27d260619a74cab3255b40e652b527e9a5b38ecf57b570d524d192695a7f549b28f5b6da59a6a0570e
-  data.tar.gz: edaf10b71585d08141acfec9e05f64a8b0bfabeddd24682159c2163a09b1466cc13aa1b38370d1462921765928420c8736dbc5dff5b1c903f4050a98281b1ed1
+  metadata.gz: fa70455940c78b708a3e7876d08972dee629b08beb956799dff919c66783527c3526fb2985b685e1080d7d58b4bb94fcb20ec1445199d62b306c0a56e035f93e
+  data.tar.gz: dabc74fbb8960b62247d31551b4d5ba58bfe378e0c836e4f4bdb6969e12d4346ce6b4f367c15955213d6423771f955b849cc3d2fc483b6072bf59d985060b52c

data/README.md

@@ -12,44 +12,7 @@ fastlane add_plugin carthage_cache_ftps
 
 ## About carthage_cache_ftps
 
-Allows to publish or install the carthage builds via FTPS or AWS to avoid recompilation.
-
-
-### AWS
-
-First, run
-
-```bash
-carthage_cache config
-```
-
-to create the `.carthage_cache.yml` file.
-
-Then, call the plugin from the Fastfile using
-
-```ruby
-carthage_cache (
-  command: "install" #This is the default and can be omitted
-)
-```
-
-to install from cache and use
-
-```ruby
-carthage_cache (
-  command: "publish"
-)
-```
-
-to push the current state to the remote.
-
-Run
-
-```bash
-bundle exec fastlane actions carthage_cache
-```
-
-for more information.
+Allows to publish or install the carthage builds via FTPS to avoid recompilation.
 
 ### FTPS
 
@@ -104,6 +67,13 @@ For any other issues and feedback about this plugin, please submit it to this re
 
 If you have trouble using plugins, check out the [Plugins Troubleshooting](https://docs.fastlane.tools/plugins/plugins-troubleshooting/) guide.
 
+### Keychain issues
+```
+SecKeychainAddInternetPassword <NULL>: The specified item already exists in the keychain.
+```
+If you have to login every time and see an error like this, got to Keychain and delete the carthage cache entry.
+
+
 ## Using _fastlane_ Plugins
 
 For more information about how the `fastlane` plugin system works, check out the [Plugins documentation](https://docs.fastlane.tools/plugins/create-plugin/).

data/lib/fastlane/plugin/carthage_cache_ftps/actions/carthage_cache_ftps_action.rb

@@ -23,7 +23,7 @@ module Fastlane
 
         project_directory = params.values[:project_directory]
         application = CarthageCache::Application.new(project_directory, true, config, repository: FTPRepository)
-        
+
         command = params.values[:command]
 
         case command.to_sym

data/lib/fastlane/plugin/carthage_cache_ftps/helper/ftp_repository.rb

@@ -1,6 +1,6 @@
-class FTPRepository
-  require 'double_bag_ftps'
+require 'net/ftp'
 
+class FTPRepository
   attr_reader :ftps_host
   attr_reader :ftps_remote_path
   attr_reader :ftps_username
@@ -13,35 +13,35 @@ class FTPRepository
     @ftps_password = config[:secret_access_key]
   end
 
-  def login
-    # Connect to a host using explicit FTPS and do not verify the host's cert
-    ftps = DoubleBagFTPS.new
-    ftps.ssl_context = DoubleBagFTPS.create_ssl_context(verify_mode: OpenSSL::SSL::VERIFY_NONE)
-    ftps.connect(@ftps_host)
-    ftps.login(@ftps_username, @ftps_password)
-    ftps
+  def connection
+    Net::FTP.new(@ftps_host, {
+      ssl:      { verify_mode: OpenSSL::SSL::VERIFY_NONE },
+      passive:  true,
+      username: @ftps_username,
+      password: @ftps_password
+    })
   end
 
   def archive_exist?(archive_filename)
-    ftps = login
+    ftps = connection
     begin
-      ftps.chdir(@ftps_remote_path) 
-    rescue
+      ftps.chdir(@ftps_remote_path)
+    rescue StandardError
       return false
     end
     files = ftps.list
     ftps.close
-    return !files.select { |f| f.include? "#{archive_filename}" }.empty?
+    return !files.select { |f| f.include? archive_filename.to_s }.empty?
   end
 
   def download(archive_filename, destination_path)
-    ftps = login
+    ftps = connection
     ftps.getbinaryfile("#{@ftps_remote_path}/#{archive_filename}", destination_path)
     ftps.close
   end
 
   def upload(archive_filename, archive_path)
-    ftps = login
+    ftps = connection
     files = ftps.list
     ftps.mkdir(@ftps_remote_path) if files.select { |f| f.include? @ftps_remote_path }.empty?
     ftps.putbinaryfile(archive_path, "#{@ftps_remote_path}/#{archive_filename}")

data/lib/fastlane/plugin/carthage_cache_ftps/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module CarthageCacheFtps
-    VERSION = "0.2.0"
+    VERSION = "0.3.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-carthage_cache_ftps
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Wolfgang Lutz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-14 00:00:00.000000000 Z
+date: 2018-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: carthage_cache
@@ -25,13 +25,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: double-bag-ftps
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -39,21 +39,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: fastlane
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.44.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.44.1
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -108,20 +108,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: fastlane
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.44.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.44.1
 description: 
 email: wlut@num42.de
 executables: []
@@ -148,7 +134,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -156,7 +142,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Allows to publish or install the carthage builds via ftps to avoid recompilation