fastlane-plugin-bugsnag 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a7020860789186a1fc8fb21cd6349d633a6f2a76
-  data.tar.gz: 758c188397d02a429660e287c6f35084fd409190
+  metadata.gz: ce569b7fba57418aa6216b66eafc6497d5b19ac2
+  data.tar.gz: 2cf21bbef1e8dc13ae3d6ab134671f7a36de8372
 SHA512:
-  metadata.gz: 7f0114205b5435acea7e400e292af32a941cd5f0ba9cac57216fa7a5ff12348a653e5708606409c55acd05e6c33efc4cfe254abb627e474c5b22face56a6e5cc
-  data.tar.gz: 1743c54c23cd198b7f4ed73787dd37d66bfb042c3e063acfae5936a4ea24af5ac7091a27275a17aa4706d3253d76bc828e1e0c15abae6553a4cb0d0d81e5dd92
+  metadata.gz: 93bbcc3cf75560bf4f9f0a8ba5dceaab4712cd039a371c9ea25fd283dd8f46c5b97e7b579264f0b605a0923c6daf1ee98bf9d4648ec0f15ea178f78fa1a32678
+  data.tar.gz: c034020abc2ea9112fcbdbf458391e3d05fb3c2503170583aa3f16b422695eaf81be48c57d67f49b49be79569a543fdfd15fec6890cf5022bc9872f9578289bf

data/bugsnag-dsym-upload

@@ -101,7 +101,7 @@ if [[ ! -d $dsym_dir ]]; then
         if [[ ! -x "$(command -v unzip 2>/dev/null)" ]]; then
             exit_with_usage "unzip command not found."
         fi
-        temp_dir=$(mktemp -dt "bugsnag-dsym-upload")
+        temp_dir=$(mktemp -dt "bugsnag-dsym-upload.XXX")
         unzip -qq $dsym_dir -d $temp_dir
         dsym_dir=$temp_dir
     else
@@ -157,4 +157,5 @@ fi
 
 if [ $fail_count -gt 0 ]; then
     log "$fail_count files failed to upload"
+    exit 1
 fi

data/lib/fastlane/plugin/bugsnag/actions/upload_symbols_to_bugsnag.rb

@@ -8,9 +8,13 @@ module Fastlane
       def self.run(params)
         parse_dsym_paths(params[:dsym_path]).each do |dsym_path|
           if dsym_path.end_with?(".zip") or File.directory?(dsym_path)
-            args = upload_args(dsym_path, params[:symbol_maps_path], params[:upload_url], params[:project_root])
+            args = upload_args(dsym_path, params[:symbol_maps_path], params[:upload_url], params[:project_root], params[:verbose])
             success = Kernel.system(UPLOAD_SCRIPT_PATH, *args)
-            UI.success("Uploaded dSYMs in #{dsym_path}") if success
+            if success
+              UI.success("Uploaded dSYMs in #{dsym_path}")
+            else
+              UI.user_error!("Failed uploading #{dsym_path}")
+            end
           else
             UI.user_error!("The specified symbol file path cannot be used: #{dsym_path}")
           end
@@ -78,14 +82,19 @@ module Fastlane
                                        env_name: "BUGSNAG_PROJECT_ROOT",
                                        description: "Root path of the project",
                                        default_value: Dir::pwd,
-                                       optional: true)
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :verbose,
+                                       env_name: "BUGSNAG_VERBOSE",
+                                       description: "Print helpful debug info",
+                                       skip_type_validation: true,
+                                       optional: true),
         ]
       end
 
       private
 
-      def self.upload_args dir, symbol_maps_dir, upload_url, project_root
-        args = ["--silent"]
+      def self.upload_args dir, symbol_maps_dir, upload_url, project_root, verbose
+        args = [verbose ? "--verbose" : "--silent"]
         args += ["--upload-server", upload_url] unless upload_url.nil?
         args += ["--symbol-maps", symbol_maps_dir] unless symbol_maps_dir.nil?
         args += ["--project-root", project_root] unless project_root.nil?

data/lib/fastlane/plugin/bugsnag/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module Bugsnag
-    VERSION = "1.3.1"
+    VERSION = "1.3.2"
   end
 end

data/spec/bugsnag_upload_dsym_action_spec.rb

@@ -11,7 +11,20 @@ describe Action do
   describe '#run' do
     it 'silences script output by default' do
       expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", FIXTURE_PATH)
+                                              "--silent", FIXTURE_PATH).and_return(true)
+      Action.run({dsym_path: FIXTURE_PATH})
+    end
+
+    it 'prints verbose if verbose flag set' do
+      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
+                                              "--verbose", FIXTURE_PATH).and_return(true)
+      Action.run({dsym_path: FIXTURE_PATH, verbose: true})
+    end
+
+    it 'UI.user_error when script fails' do
+      expect(Fastlane::UI).to receive(:user_error!).with("Failed uploading #{FIXTURE_PATH}")
+      expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
+        "--silent", FIXTURE_PATH).and_return(false)
       Action.run({dsym_path: FIXTURE_PATH})
     end
 
@@ -30,14 +43,14 @@ describe Action do
     it 'uploads a single .dSYM file' do
       directory = File.join(FIXTURE_PATH, 'dSYMs')
       expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", directory)
+                                              "--silent", directory).and_return(true)
       Action.run({dsym_path: File.join(FIXTURE_PATH, 'dSYMs/app.dSYM')})
     end
 
     it 'uploads a .zip of .dSYM files' do
       path = File.join(FIXTURE_PATH, 'files.zip')
       expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", path)
+                                              "--silent", path).and_return(true)
       Action.run({dsym_path: path})
     end
 
@@ -45,9 +58,9 @@ describe Action do
       zip1 = File.join(FIXTURE_PATH, 'files.zip')
       zip2 = File.join(FIXTURE_PATH, 'more_files.zip')
       expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", zip1)
+                                              "--silent", zip1).and_return(true)
       expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", zip2)
+                                              "--silent", zip2).and_return(true)
       Action.run({dsym_path: [zip1, zip2]})
     end
 
@@ -58,9 +71,9 @@ describe Action do
       dsym4 = File.join(FIXTURE_PATH, 'stuff/app2.dSYM')
       directories = [File.join(FIXTURE_PATH, 'dSYMs'), File.join(FIXTURE_PATH, 'stuff')]
       expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", directories[0])
+                                              "--silent", directories[0]).and_return(true)
       expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", directories[1])
+                                              "--silent", directories[1]).and_return(true)
       Action.run({dsym_path: [dsym1, dsym2, dsym3, dsym4]})
     end
 
@@ -69,7 +82,7 @@ describe Action do
       dsym2 = File.join(FIXTURE_PATH, 'dSYMs/app2.dSYM')
       directory = File.join(FIXTURE_PATH, 'dSYMs')
       expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
-                                              "--silent", directory)
+                                              "--silent", directory).and_return(true)
       Action.run({dsym_path: [dsym1, dsym2]})
     end
 
@@ -78,7 +91,7 @@ describe Action do
       expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
                                               "--silent",
                                               "--project-root", root_path,
-                                              FIXTURE_PATH)
+                                              FIXTURE_PATH).and_return(true)
       Action.run({dsym_path: FIXTURE_PATH, project_root: root_path})
     end
 
@@ -87,7 +100,7 @@ describe Action do
         expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
                                                 "--silent",
                                                 "--upload-server", "http://myserver.example.com",
-                                                FIXTURE_PATH)
+                                                FIXTURE_PATH).and_return(true)
         Action.run({dsym_path: FIXTURE_PATH,
                     upload_url: "http://myserver.example.com"})
       end
@@ -99,7 +112,7 @@ describe Action do
         expect(Kernel).to receive(:system).with(Action::UPLOAD_SCRIPT_PATH,
                                                 "--silent",
                                                 "--symbol-maps", path,
-                                                FIXTURE_PATH)
+                                                FIXTURE_PATH).and_return(true)
         Action.run({dsym_path: FIXTURE_PATH, symbol_maps_path: path})
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-bugsnag
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Delisa Mason
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-07 00:00:00.000000000 Z
+date: 2018-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xml-simple