fastlane-plugin-appcenter 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 172c940fc1d03ac4d3951cffc2c0f1c1d1b78ee25967f464d0a1058f12d7c7b9
-  data.tar.gz: f6835efe4d035061a6c8834e27c355817061835c9be067fe2090b2ae9dd3b65a
+SHA1:
+  metadata.gz: 0cf08880b9ba588e79b23dd385311f4d5a194246
+  data.tar.gz: fe26549362f32bbd22293bc8110e432a7a94118a
 SHA512:
-  metadata.gz: 9060632241323fe3a7cbc412b77cbbe457819277176e06a00fdbf155ef72c01aa19453a626214003b211bee5a9388fd4ce509b97a823489e0d9022674b14e908
-  data.tar.gz: 68fce7a6a0755c2fe71363e7f85d1f88d44f3303d7a94876c15d57d810033021ad410461fb399b91fee82aae4710fe1740a033967c2576245495f12360dd2a48
+  metadata.gz: 6ffd559816032b4c385ead27b89419541746a106e63713aeef51282d1a74950dd27eaff4d1daf59db58ccfd33a3d4efa9f3a1f9ffbefc836ed82af2d7579dcf4
+  data.tar.gz: 80b0cb6d8016fa35400e0ae7c1e7d1dfd9ac2e07cc3b6a96decb26917bf6c5988ab9a7f2fb407e4ee96e8303cd716dd6fc020785f6a2aa06f8167681f7d18e6f

data/README.md

@@ -91,6 +91,7 @@ Here is the list of all existing parameters:
 | `app_os` <br/> `APPCENTER_APP_OS` | App OS. Used for new app creation, if app 'app_name' was not found |
 | `app_platform` <br/> `APPCENTER_APP_PLATFORM` | App Platform. Used for new app creation, if app 'app_name' was not found |
 | `file` <br/> `APPCENTER_DISTRIBUTE_FILE` | File path to the release build to publish |
+| `upload_build_only` <br/> `APPCENTER_DISTRIBUTE_UPLOAD_BUILD_ONLY` | Flag to upload only the build to App Center. Skips uploading symbols or mapping (default: `false`) |
 | `dsym` <br/> `APPCENTER_DISTRIBUTE_DSYM` | Path to your symbols file. For iOS provide path to app.dSYM.zip |
 | `upload_dsym_only` <br/> `APPCENTER_DISTRIBUTE_UPLOAD_DSYM_ONLY` | Flag to upload only the dSYM file to App Center (default: `false`) |
 | `mapping` <br/> `APPCENTER_DISTRIBUTE_ANDROID_MAPPING` | Path to your Android mapping.txt |
@@ -155,6 +156,10 @@ _fastlane_ is the easiest way to automate beta deployments and releases for your
 
 This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.
 
+## Security
+
+Check out [SECURITY.md](SECURITY.md) for any security concern with this project.
+
 ## Contact
 
 We're on Twitter as [@vsappcenter](https://www.twitter.com/vsappcenter). Additionally you can reach out to us on the [App Center](https://appcenter.ms/apps) portal by using the blue Intercom button on the bottom right to start a conversation.

data/lib/fastlane/plugin/appcenter/actions/appcenter_upload_action.rb

@@ -28,7 +28,7 @@ module Fastlane
         api_token = params[:api_token]
         owner_name = params[:owner_name]
         app_name = params[:app_name]
-        file = params[:ipa]
+        file = params[:file] || params[:ipa]
         dsym = params[:dsym]
         build_number = params[:build_number]
         version = params[:version]
@@ -132,10 +132,10 @@ module Fastlane
         end
 
         file = [
+          params[:file],
           params[:ipa],
           params[:apk],
           params[:aab],
-          params[:file]
         ].detect { |e| !e.to_s.empty? }
 
         UI.user_error!("Couldn't find build file at path '#{file}'") unless file && File.exist?(file)
@@ -230,11 +230,17 @@ module Fastlane
         platforms = {
           Android: %w[Java React-Native Xamarin],
           iOS: %w[Objective-C-Swift React-Native Xamarin],
-          macOS: %w[Objective-C-Swift]
+          macOS: %w[Objective-C-Swift],
+          Windows: %w[UWP WPF WinForms Unity]
         }
 
-        if Helper::AppcenterHelper.get_app(api_token, owner_name, app_name)
-          return true
+        begin
+          if Helper::AppcenterHelper.get_app(api_token, owner_name, app_name)
+            return true
+          end
+        rescue URI::InvalidURIError
+          UI.user_error!("Provided app_name: '#{app_name}' is not in a valid format. Please ensure no special characters or spaces in the app_name.")
+          return false
         end
 
         should_create_app = !app_display_name.to_s.empty? || !app_os.to_s.empty? || !app_platform.to_s.empty?
@@ -242,9 +248,9 @@ module Fastlane
         if Helper.test? || should_create_app || UI.confirm("App with name #{app_name} not found, create one?")
           app_display_name = app_name if app_display_name.to_s.empty?
           os = app_os.to_s.empty? && (Helper.test? ? "Android" : UI.select("Select OS", platforms.keys)) || app_os.to_s
-          platform = app_platform.to_s.empty? && (Helper.test? ? "Java" : app_platform.to_s) || app_platform.to_s
+          platform = app_platform.to_s.empty? && (Helper.test? ? platforms[os.to_sym][0] : app_platform.to_s) || app_platform.to_s
           if platform.to_s.empty?
-            platform = platforms[os].length == 1 ? platforms[os][0] : UI.select("Select Platform", platforms[os])
+            platform = platforms[os.to_sym].length == 1 ? platforms[os.to_sym][0] : UI.select("Select Platform", platforms[os.to_sym])
           end
 
           Helper::AppcenterHelper.create_app(api_token, owner_type, owner_name, app_name, app_display_name, os, platform)
@@ -256,6 +262,7 @@ module Fastlane
 
       def self.run(params)
         values = params.values
+        upload_build_only = params[:upload_build_only]
         upload_dsym_only = params[:upload_dsym_only]
         upload_mapping_only = params[:upload_mapping_only]
 
@@ -267,8 +274,8 @@ module Fastlane
           params[:version] = release['short_version'] if release
           params[:build_number] = release['version'] if release
 
-          self.run_dsym_upload(params) unless upload_mapping_only
-          self.run_mapping_upload(params) unless upload_dsym_only
+          self.run_dsym_upload(params) unless upload_mapping_only || upload_build_only
+          self.run_mapping_upload(params) unless upload_dsym_only || upload_build_only
         end
 
         return values if Helper.test?
@@ -407,14 +414,27 @@ module Fastlane
                             end,
                               verify_block: proc do |value|
                                 platform = Actions.lane_context[SharedValues::PLATFORM_NAME]
-                                accepted_formats = Constants::SUPPORTED_EXTENSIONS[platform.to_sym] if platform
-                                unless accepted_formats
-                                  UI.important("Unknown platform '#{platform}', consider using one of: #{Constants::SUPPORTED_EXTENSIONS.keys}")
-                                  accepted_formats = Constants::ALL_SUPPORTED_EXTENSIONS
+                                if platform
+                                  accepted_formats = Constants::SUPPORTED_EXTENSIONS[platform.to_sym]
+                                  unless accepted_formats
+                                    UI.important("Unknown platform '#{platform}', Supported are #{Constants::SUPPORTED_EXTENSIONS.keys}")
+                                    accepted_formats = Constants::ALL_SUPPORTED_EXTENSIONS
+                                  end
+                                  file_ext = Helper::AppcenterHelper.file_extname_full(value)
+                                  self.optional_error("Extension not supported: '#{file_ext}'. Supported formats for platform '#{platform}': #{accepted_formats.join ' '}") unless accepted_formats.include? file_ext
                                 end
-                                file_ext = Helper::AppcenterHelper.file_extname_full(value)
-                                self.optional_error("Extension not supported: '#{file_ext}'. Supported formats for platform '#{platform}': #{accepted_formats.join ' '}") unless accepted_formats.include? file_ext
                               end),
+          
+          FastlaneCore::ConfigItem.new(key: :upload_build_only,
+                                  env_name: "APPCENTER_DISTRIBUTE_UPLOAD_BUILD_ONLY",
+                               description: "Flag to upload only the build to App Center. Skips uploading symbols or mapping",
+                                  optional: true,
+                                 is_string: false,
+                             default_value: false,
+                       conflicting_options: [:upload_dsym_only, :upload_mapping_only],
+                            conflict_block: proc do |value|
+                              UI.user_error!("You can't use 'upload_build_only' and '#{value.key}' options in one run")
+                            end),
 
           FastlaneCore::ConfigItem.new(key: :dsym,
                                   env_name: "APPCENTER_DISTRIBUTE_DSYM",

data/lib/fastlane/plugin/appcenter/helper/appcenter_helper.rb

@@ -6,13 +6,11 @@ module Fastlane
       # accounting for file types that can and should be zip-compressed
       # before they are uploaded
       def self.file_extname_full(path)
-        is_zip = File.extname(path) == ".zip"
-
-        # if file is not .zip'ed, these do not change basename and extname
-        unzip_basename = File.basename(path, ".zip")
-        unzip_extname = File.extname(unzip_basename)
+        %w(.app.zip .dSYM.zip).each do |suffix|
+          return suffix if path.to_s.downcase.end_with? suffix.downcase
+        end
 
-        is_zip ? unzip_extname + ".zip" : unzip_extname
+        File.extname path
       end
 
       # create request

data/lib/fastlane/plugin/appcenter/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module Appcenter
-    VERSION = "1.6.0"
+    VERSION = "1.7.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-appcenter
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Microsoft Corporation
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-01 00:00:00.000000000 Z
+date: 2019-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -140,7 +140,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
+rubyforge_project: 
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: Fastlane plugin for App Center