fastlane-plugin-appcenter 0.2.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ed345ffa12f5eb4ad5de4a627367908c22be9b9854e77f0a0149e708a4edc9a
-  data.tar.gz: 6574127a56bf36345e651a65d5ed69c406c4e7edaa68af8db9522afc81c45586
+  metadata.gz: 156b2b0f457a0ad05bd0abe5d232e4e960d36190002882545734f8a150e9284c
+  data.tar.gz: bff39320edca4e3337db294afb2d498aa249ec24320e1b77f170645af804f086
 SHA512:
-  metadata.gz: 0713dd1a8a2acbe4bbb30eab946cc148c1c5b101f09fc1992a9384ae438f5a252df7f07c6c756dea259fbfe6525dcc0eee60b403a5b583790cc5634643926a03
-  data.tar.gz: 4c18b39f4e3edd1b288dabfade13c3867b4223e50521f545746d5c27b1776782603fc8225de9c03869ba608e55a676a1c2f84c737e4c3a22f573edf62f8b836d
+  metadata.gz: 64cc092929a5189a4b5b610b329c2708aebbd4c7e586114d0a80be10d3b5267637d068713e8719a22a87fb8ff196ffd7ddc69aa09b8139d45f19fa410b4385d4
+  data.tar.gz: 6af5dbf4e3d3e44c8c0e1eddcda88779723f49eeda41f493eeed7ba6956864eef591bff5b1c35eaf1175efd4705907b8e28044d4a5ea07c34b88cf9b38c8dcff

data/README.md

@@ -2,7 +2,7 @@
 
 [![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg)](https://rubygems.org/gems/fastlane-plugin-appcenter)
 [![Gem Version](https://badge.fury.io/rb/fastlane-plugin-appcenter.svg)](https://badge.fury.io/rb/fastlane-plugin-appcenter)
-[![Build Status](https://travis-ci.org/Microsoft/fastlane-plugin-appcenter.svg?branch=master)](https://travis-ci.org/Microsoft/fastlane-plugin-appcenter)
+[![Build Status](https://travis-ci.org/microsoft/fastlane-plugin-appcenter.svg?branch=master)](https://travis-ci.org/microsoft/fastlane-plugin-appcenter)
 
 ## Getting Started
 
@@ -24,7 +24,8 @@ appcenter_upload(
   api_token: "<appcenter token>",
   owner_name: "<your appcenter account name>",
   app_name: "<your app name>",
-  apk: "<path to android build binary>"
+  apk: "<path to android build binary>",
+  notify_testers: true # Set to false if you don't want to notify testers of your new release (default: `false`)
 )
 ```
 
@@ -39,7 +40,7 @@ The action parameters `api_token` and `owner_name` can also be omitted when thei
 - `APPCENTER_DISTRIBUTE_UPLOAD_DSYM_ONLY` - Flag to upload only the dSYM file to App Center
 - `APPCENTER_DISTRIBUTE_GROUP` - Comma separated list of Distribution Group names
 - `APPCENTER_DISTRIBUTE_MANDATORY_UPDATE` - Require users to update to this release
-- `APPCENTER_DISTRIBUTE_NOTIFY_TESTERS` - Send email notification about release
+- `APPCENTER_DISTRIBUTE_NOTIFY_TESTERS` - Send email notification about release (default: `false`)
 - `APPCENTER_DISTRIBUTE_RELEASE_NOTES` - Release notes
 - `APPCENTER_DISTRIBUTE_RELEASE_NOTES_CLIPPING` - Clip release notes if its length is more then 5000, `true` by default
 - `APPCENTER_DISTRIBUTE_RELEASE_NOTES_LINK` - Additional release notes link
@@ -70,7 +71,7 @@ rubocop -a
 
 ## Issues and Feedback
 
-For any other issues and feedback about this plugin, please open a [GitHub issue](https://github.com/Microsoft/fastlane-plugin-appcenter/issues).
+For any other issues and feedback about this plugin, please open a [GitHub issue](https://github.com/microsoft/fastlane-plugin-appcenter/issues).
 
 ## Troubleshooting
 

data/lib/fastlane/plugin/appcenter/actions/appcenter_upload_action.rb

@@ -18,6 +18,8 @@ module Fastlane
         app_name = params[:app_name]
         file = params[:ipa]
         dsym = params[:dsym]
+        build_number = params[:build_number]
+        version = params[:version]
 
         dsym_path = nil
         if dsym
@@ -42,7 +44,13 @@ module Fastlane
           values[:dsym_path] = dsym_path
 
           UI.message("Starting dSYM upload...")
-          dsym_upload_details = Helper::AppcenterHelper.create_dsym_upload(api_token, owner_name, app_name)
+          
+          if File.extname(dsym_path) == ".txt"
+            file_name = File.basename(dsym_path)
+            dsym_upload_details = Helper::AppcenterHelper.create_mapping_upload(api_token, owner_name, app_name, file_name ,build_number, version)
+          else
+            dsym_upload_details = Helper::AppcenterHelper.create_dsym_upload(api_token, owner_name, app_name)
+          end
 
           if dsym_upload_details
             symbol_upload_id = dsym_upload_details['symbol_upload_id']
@@ -60,7 +68,8 @@ module Fastlane
         api_token = params[:api_token]
         owner_name = params[:owner_name]
         app_name = params[:app_name]
-        group = params[:group]
+        destinations = params[:destinations]
+        destination_type = params[:destination_type]
         mandatory_update = params[:mandatory_update]
         notify_testers = params[:notify_testers]
         release_notes = params[:release_notes]
@@ -85,7 +94,6 @@ module Fastlane
         ].detect { |e| !e.to_s.empty? }
 
         UI.user_error!("Couldn't find build file at path '#{file}'") unless file && File.exist?(file)
-        UI.user_error!("No Distribute Group given, pass using `group: 'group name'`") unless group && !group.empty?
 
         UI.message("Starting release upload...")
         upload_details = Helper::AppcenterHelper.create_release_upload(api_token, owner_name, app_name)
@@ -102,19 +110,19 @@ module Fastlane
 
             Helper::AppcenterHelper.update_release(api_token, owner_name, app_name, release_id, release_notes)
 
-            groups = group.split(',')
-            groups.each do |group_name|
-              group = Helper::AppcenterHelper.get_group(api_token, owner_name, app_name, group_name)
-              if group
-                group_id = group['id']
-                distributed_release = Helper::AppcenterHelper.add_to_group(api_token, owner_name, app_name, release_id, group_id, mandatory_update, notify_testers)
+            destinations_array = destinations.split(',')
+            destinations_array.each do |destination_name|
+              destination = Helper::AppcenterHelper.get_destination(api_token, owner_name, app_name, destination_type, destination_name)
+              if destination
+                destination_id = destination['id']
+                distributed_release = Helper::AppcenterHelper.add_to_destination(api_token, owner_name, app_name, release_id, destination_type, destination_id, mandatory_update, notify_testers)
                 if distributed_release
-                  UI.success("Release #{distributed_release['short_version']} was successfully distributed to group \"#{group_name}\"")
+                  UI.success("Release #{distributed_release['short_version']} was successfully distributed to #{destination_type} \"#{destination_name}\"")
                 else
                   UI.error("Release '#{release_id}' was not found")
                 end
               else
-                UI.error("Group '#{group_name}' was not found")
+                UI.error("#{destination_type} '#{destination_name}' was not found")
               end
             end
           end
@@ -253,20 +261,41 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :group,
                                   env_name: "APPCENTER_DISTRIBUTE_GROUP",
                                description: "Comma separated list of Distribution Group names",
+                                  optional: true,
+                                      type: String,
+                                deprecated: true,
+                              verify_block: proc do |value|
+                                UI.user_error!("Option `group` is deprecated. Use `destinations` and `destination_type`")
+                              end),
+
+          FastlaneCore::ConfigItem.new(key: :destinations,
+                                  env_name: "APPCENTER_DISTRIBUTE_DESTINATIONS",
+                               description: "Comma separated list of destination names. Both distribution groups and stores are supported. All names are required to be of the same destination type",
                              default_value: "Collaborators",
                                   optional: true,
                                       type: String),
 
+
+          FastlaneCore::ConfigItem.new(key: :destination_type,
+                                  env_name: "APPCENTER_DISTRIBUTE_DESTINATION_TYPE",
+                               description: "Destination type of distribution destination. 'group' and 'store' are supported",
+                             default_value: "group",
+                                  optional: true,
+                                      type: String,
+                              verify_block: proc do |value|
+                                UI.user_error!("No or incorrect destination type given. Use 'group' or 'store'") unless value && !value.empty? && ["group", "store"].include?(value)
+                              end),
+
           FastlaneCore::ConfigItem.new(key: :mandatory_update,
                                   env_name: "APPCENTER_DISTRIBUTE_MANDATORY_UPDATE",
-                               description: "Require users to update to this release",
+                               description: "Require users to update to this release. Ignored if destination type is 'store'",
                                   optional: true,
                                  is_string: false,
                              default_value: false),
 
           FastlaneCore::ConfigItem.new(key: :notify_testers,
                                   env_name: "APPCENTER_DISTRIBUTE_NOTIFY_TESTERS",
-                               description: "Send email notification about release",
+                               description: "Send email notification about release. Ignored if destination type is 'store'",
                                   optional: true,
                                  is_string: false,
                              default_value: false),
@@ -289,7 +318,19 @@ module Fastlane
                                   env_name: "APPCENTER_DISTRIBUTE_RELEASE_NOTES_LINK",
                                description: "Additional release notes link",
                                   optional: true,
-                                      type: String)
+                                      type: String),
+
+          FastlaneCore::ConfigItem.new(key: :build_number,
+                                       env_name: "APPCENTER_DISTRIBUTE_BUILD_NUMBER",
+                                       description: "The build number. Used (and required) for uploading Android ProGuard mapping file",
+                                       optional: true,
+                                       type: String),
+
+          FastlaneCore::ConfigItem.new(key: :version,
+                                       env_name: "APPCENTER_DISTRIBUTE_VERSION",
+                                       description: "The version number. Used (and required) for uploading Android ProGuard mapping file",
+                                       optional: true,
+                                       type: String),
         ]
       end
 
@@ -311,20 +352,24 @@ module Fastlane
             owner_name: "appcenter_owner",
             app_name: "testing_app",
             apk: "./app-release.apk",
-            group: "Testers",
-            release_notes: "release notes"
+            destinations: "Testers",
+            destination_type: "group",
+            release_notes: "release notes",
+            notify_testers: false
           )',
           'appcenter_upload(
             api_token: "...",
             owner_name: "appcenter_owner",
             app_name: "testing_app",
             apk: "./app-release.ipa",
-            group: "Testers,Alpha",
+            destinations: "Testers,Alpha",
+            destination_type: "group",
             dsym: "./app.dSYM.zip",
-            release_notes: "release notes"
+            release_notes: "release notes",
+            notify_testers: false
           )'
         ]
       end
     end
   end
-end
+end

data/lib/fastlane/plugin/appcenter/helper/appcenter_helper.rb

@@ -54,6 +54,42 @@ module Fastlane
         end
       end
 
+      # creates new mapping upload in appcenter
+      # returns:
+      # symbol_upload_id
+      # upload_url
+      # expiration_date
+      def self.create_mapping_upload(api_token, owner_name, app_name, file_name, build_number, version)
+        connection = self.connection
+
+        response = connection.post do |req|
+          req.url("/v0.1/apps/#{owner_name}/#{app_name}/symbol_uploads")
+          req.headers['X-API-Token'] = api_token
+          req.headers['internal-request-source'] = "fastlane"
+          req.body = {
+            symbol_type: "AndroidProguard",
+            file_name: file_name,
+            build: build_number,
+            version: version,
+          }
+        end
+
+        case response.status
+        when 200...300
+          UI.message("DEBUG: #{JSON.pretty_generate(response.body)}\n") if ENV['DEBUG']
+          response.body
+        when 401
+          UI.user_error!("Auth Error, provided invalid token")
+          false
+        when 404
+          UI.error("Not found, invalid owner or application name")
+          false
+        else
+          UI.error("Error #{response.status}: #{response.body}")
+          false
+        end
+      end
+
       # creates new dSYM upload in appcenter
       # returns:
       # symbol_upload_id
@@ -209,26 +245,26 @@ module Fastlane
         end
       end
 
-      # get distribution group
-      def self.get_group(api_token, owner_name, app_name, group_name)
+      # get distribution group or store
+      def self.get_destination(api_token, owner_name, app_name, destination_type, destination_name)
         connection = self.connection
 
         response = connection.get do |req|
-          req.url("/v0.1/apps/#{owner_name}/#{app_name}/distribution_groups/#{ERB::Util.url_encode(group_name)}")
+          req.url("/v0.1/apps/#{owner_name}/#{app_name}/distribution_#{destination_type}s/#{ERB::Util.url_encode(destination_name)}")
           req.headers['X-API-Token'] = api_token
           req.headers['internal-request-source'] = "fastlane"
         end
 
         case response.status
         when 200...300
-          group = response.body
-          UI.message("DEBUG: received group #{JSON.pretty_generate(group)}") if ENV['DEBUG']
-          group
+          destination = response.body
+          UI.message("DEBUG: received #{destination_type} #{JSON.pretty_generate(destination)}") if ENV['DEBUG']
+          destination
         when 404
-          UI.error("Not found, invalid distribution group name")
+          UI.error("Not found, invalid distribution #{destination_type} name")
           false
         else
-          UI.error("Error getting group #{response.status}: #{response.body}")
+          UI.error("Error getting #{destination_type} #{response.status}: #{response.body}")
           false
         end
       end
@@ -270,21 +306,23 @@ module Fastlane
         end
       end
 
-      # add release to distribution group
-      def self.add_to_group(api_token, owner_name, app_name, release_id, group_id, mandatory_update = false, notify_testers = false)
+      # add release to distribution group or store
+      def self.add_to_destination(api_token, owner_name, app_name, release_id, destination_type, destination_id, mandatory_update = false, notify_testers = false)
         connection = self.connection
 
         UI.message("DEBUG: getting #{release_id}") if ENV['DEBUG']
 
+        body = { "id" => destination_id }
+        if destination_type == "group"
+          body["mandatory_update"] = mandatory_update
+          body["notify_testers"] = notify_testers
+        end
+
         response = connection.post do |req|
-          req.url("/v0.1/apps/#{owner_name}/#{app_name}/releases/#{release_id}/groups")
+          req.url("/v0.1/apps/#{owner_name}/#{app_name}/releases/#{release_id}/#{destination_type}s")
           req.headers['X-API-Token'] = api_token
           req.headers['internal-request-source'] = "fastlane"
-          req.body = {
-            "id" => group_id,
-            "mandatory_update" => mandatory_update,
-            "notify_testers" => notify_testers
-          }
+          req.body = body
         end
 
         case response.status
@@ -303,10 +341,10 @@ module Fastlane
 
           release
         when 404
-          UI.error("Not found, invalid distribution group name")
+          UI.error("Not found, invalid distribution #{destination_type} name")
           false
         else
-          UI.error("Error adding to group #{response.status}: #{response.body}")
+          UI.error("Error adding to #{destination_type} #{response.status}: #{response.body}")
           false
         end
       end
@@ -363,4 +401,4 @@ module Fastlane
       end
     end
   end
-end
+end

data/lib/fastlane/plugin/appcenter/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module Appcenter
-    VERSION = "0.2.2"
+    VERSION = "1.0.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-appcenter
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Microsoft Corporation
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-25 00:00:00.000000000 Z
+date: 2019-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -106,7 +106,7 @@ files:
 - lib/fastlane/plugin/appcenter/actions/appcenter_upload_action.rb
 - lib/fastlane/plugin/appcenter/helper/appcenter_helper.rb
 - lib/fastlane/plugin/appcenter/version.rb
-homepage: https://github.com/Microsoft/fastlane-plugin-appcenter
+homepage: https://github.com/microsoft/fastlane-plugin-appcenter
 licenses:
 - MIT
 metadata: {}