fastest_server 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d73692c989e6f043a3b8d8d0a68597843684a2747cb0e71adf69731b2b239880
-  data.tar.gz: 4760926c9ca2767644b02d3c91163ac8ea1777b69fc6d70cd6f31840e7286990
+  metadata.gz: 5f2becc475d385131ac09de21030cecc44930564099c8d9726c12ff2bf260007
+  data.tar.gz: c745479bb721293f55404979dc974e47ec0ffd1e9288bbed77e47d48f243ff67
 SHA512:
-  metadata.gz: 4515eade6c6f41595ef446f5a8dcc3eb1688653eb1f72f3dfe6f673c53315ddfb3c986a1935ba1fd71b0eb39813055ac777c3f872a5f116151dac8649fa680b2
-  data.tar.gz: adf14907807ee4daf93c8b05c44ec36847182c2cba21b8fec87f21077efe6e316234435d3bd6166da1c553fa88551b0ccd85b1737eea207836af4b7452cb5be3
+  metadata.gz: 0ec4a0a1217a34503cd447ab470aaabfcf2ef73f0c2e618fca4f08500e870e1a6d80563660f4b362ca6090ac96b789d51840befb114112252c297f09d8e1b5bc
+  data.tar.gz: 9a3f862977314eaecf3c6d8742611b65db49d59883e20b778b1db8022dce794e0da91c5c9a14cd92899209a8aaa60a18c1f6b8c32d1bcc1b0c0a891f074fb75e

data/.gitignore

@@ -1,3 +1,5 @@
+.DS_Store
+
 /.bundle/
 /.yardoc
 /_yardoc/
@@ -7,6 +9,7 @@
 /spec/reports/
 /tmp/
 
+Gemfile.lock
 *.gem
 
 # rspec failure tracking

data/README.md

@@ -8,7 +8,7 @@ Find the fastest server via ping.
 
 ## Usage
 
-The most basic usage is very simple, you may type `fastest` with a sequence of servers:
+The most basic usage is very simple, you may type `fastest` with a sequence of servers[1]:
 
     $ fastest 5.153.63.162 159.8.223.72 169.38.84.49 169.46.49.132 23.246.195.8
     (after a while)
@@ -30,6 +30,11 @@ server will be displayed on the screen.
 
 Noticed that, you can also provide additional servers as parameters, even a `-f` or `--file` option has been set.
 
+## Disclaim
+
+[1] The ip address all come from [lifesize](https://www.lifesize.com/en/app-help/admin/get-started/ip-address-list) 
+for test purpose only.
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/DeathKing/fastest_server.

data/Rakefile

@@ -6,5 +6,5 @@ RSpec::Core::RakeTask.new(:spec)
 task :default => :spec
 
 task :console do
-  exec "irb -r mygem -I ./lib"
-end
+  exec "irb -r fastest_server -I ./lib"
+end

data/fastest_server.gemspec

@@ -22,5 +22,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.16"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "clamp", "~> 1.0"
+  spec.add_dependency "clamp", "~> 1.0"
 end

data/lib/fastest_server/fastest.rb

@@ -1,7 +1,7 @@
 module FastestServer
   class Fastest
     def initialize(targets, max, verbose)
-      @max = max
+      @max = [max, targets.size].min
       @jobs = targets
       @verbose = verbose
       @checkbook = {}

data/lib/fastest_server/formatter.rb

@@ -9,7 +9,7 @@ module FastestServer
 
     def formatted!
       return @formatted if @formatted
-      header = header_format % ["Site", "IP", "Average", "Stddev", "Loss"]
+      header = header_format % ["Site", "IP", "Average", "Stddev", "Loss", "Status"]
       rows = [header, "-" * header.length]
       rows += @stats.map {|stat| format_row(stat)}
       @formatted = rows.join("\n")
@@ -18,7 +18,7 @@ module FastestServer
     def display!(verbose)
       sort!
       puts formatted! if verbose
-      puts @stats.first[:target]
+      puts @stats.first[:server]
     end
 
     private
@@ -46,19 +46,16 @@ module FastestServer
     end
 
     def header_format
-      "%#{@site_max_width}s   %-16s%8s  %6s   %6s"
+      "%#{@site_max_width}s   %-16s%8s  %6s   %6s  %6s"
     end
 
     def row_format
-      "%#{@site_max_width}s  %16s %8.2f  %6.2f  %6.2f%s"
+      "%#{@site_max_width}s  %16s %8.2f  %6.2f  %6.2f%s  %6d"
     end
 
     def format_row stat
-      row_format % [stat[:site], format_ip(stat[:ip]), stat[:avg], stat[:stddev], stat[:loss], '%']
-    end
-
-    def format_ip ip
-      "%-3d.%-3d.%-3d.%-3d" % ip.split(".")
+      row_format % [stat[:site], stat[:ip], stat[:avg],
+                    stat[:stddev], stat[:loss], '%', stat[:status]]
     end
 
   end

data/lib/fastest_server/ping.rb

@@ -16,13 +16,11 @@ module FastestServer
       private
 
       def get_pinger
-        @pinger ||= if (/cygwin|mswin|mingw|bccwin|wince|emx/ =~ RUBY_PLATFORM)
-                      WindowsPing
-                    elsif (/darwin/ =~ RUBY_PLATFORM)
-                      UnixPing
-                    elsif
-                      LinuxPing
-                    end
+        if (/cygwin|mswin|mingw|bccwin|wince|emx/ =~ RUBY_PLATFORM)
+          WindowsPing
+        else
+          LinuxPing
+        end
       end
     end
 
@@ -30,53 +28,79 @@ module FastestServer
       @server = server
     end
 
+    def execute_ping_command
+      raise NotImplementedError, "Subclass must implement execute_ping_command method."
+    end
+
+    # ping and parse the result
     def perform
-      raise NotImplementedError
+      result, status = execute_ping_command
+
+      # we only process `successful` ping.
+      return parsed(status: status) unless status == 0
+
+      _, site, ip, _ = result.match(regex_ping)[0].split(" ")
+      ip.gsub!(regex_filter, "")
+      loss = result.match(regex_loss) ? $&.to_f : 100
+
+      if stat = result.match(regex_stat)
+        parsed(ip: ip, site: site, loss: loss,
+              max: stat["max"].to_f, min: stat["min"].to_f,
+              avg: stat["avg"].to_f, stddev: stat["stddev"]&.to_f || 0.0)
+      else
+        parsed(ip: ip, site: site, loss: loss, status: status)
+      end
+    end
+
+    def method_missing(name, *args)
+      if name =~ /regex_/
+        self.class.const_get(name.upcase)
+      else
+        super
+      end
     end
 
+    # From MacOX `ping` manual
+    #  
+    # EXIT STATUS
+    #      The `ping` utility exits with one of the following values:
+    #      0         At least one response was heard from the specified host
+    #
+    #      2         The transmission was successful but no responses were received.  
+    # 
+    #      any other value
+    #                An error occurred.  These values are defined in <sysexists.h>
+    #
+    def parsed(**arguments)
+      {ip: @server, server: @server, site: @server, status: 0,
+       loss: 100, max: 0.0, min: 0.0, avg: 0.0, stddev: 0.0}.merge(arguments)
+    end
   end
 
   class WindowsPing < Ping
+    REGEX_PING = /Pinging.*/
+    REGEX_FILTER = /\[|\]/
+    REGEX_LOSS = /\(\d*% loss\)/
+    REGEX_STAT = /Minimum = (?<min>\d+)ms, Maximum = (?<max>\d+)ms, Average = (?<avg>\d+)ms(?<stddev>)/
+
+    def execute_ping_command
+      result = `chcp 437 && ping -n #{Ping.get_count} #@server`
+      status = $?
+      [result, $?]
+    end
   end
 
-  class UnixPing < Ping
+  class LinuxPing < Ping
 
     REGEX_PING = /PING.*/
     REGEX_FILTER = /\(|\)|:/
-    REGEX_LOSS = /(\d*.\d*)% packet loss/
+    REGEX_LOSS = /(?<loss>\d*)% packet loss/
     REGEX_STAT = /(?<min>\d*.\d*)\/(?<avg>\d*.\d*)\/(?<max>\d*.\d*)\/(?<stddev>\d*.\d*) ms/
 
-    # ping and parse the result
-    def perform
-      #FIXME: may not thread safe
+    def execute_ping_command
       result = `ping -c #{Ping.get_count} -q #@server`
       status = $?
-
-      # if we cannot find a valid information line, just return nil
-      return useless_server unless result.match(REGEX_PING)
-      _, site, ip, _ = $&.split(" ")
-      ip.gsub!(REGEX_FILTER, "")
-
-      base = useless_server(status)
-
-      return base.merge(ip: ip) unless status == 0
-
-      stat = result.match(REGEX_STAT)
-      return base.merge({
-          ip: ip,
-          site: site,
-          loss: result.match(REGEX_LOSS)[0].to_f,
-          max: stat["max"].to_f,
-          min: stat["min"].to_f,
-          avg: stat["avg"].to_f,
-          stddev: stat["stddev"].to_f})
-    end
-
-    private
-
-    def useless_server(status=-1)
-      {site: @server, ip: @server, target: @server, status: status,
-       loss: 100, max: 0, min: 0, avg: 0, stddev: 0 }
+      [result, $?]
     end
   end
 end

data/lib/fastest_server/version.rb

@@ -1,3 +1,3 @@
 module FastestServer
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastest_server
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - DeathKing
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-22 00:00:00.000000000 Z
+date: 2019-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -59,7 +59,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -111,8 +111,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Find the fastest server via ping.