fasterer 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8497be57df6a101c8259f8909a2977b68727e0595de1c2b09bec0492b80d806
-  data.tar.gz: 7364812466aa12114dbada36fc6cb3865e4497478d60d8df0a4c4aad58f50d5d
+  metadata.gz: d9948b922544838685466166a577f49d09424d93b9d04337fb731198427f15bc
+  data.tar.gz: fad2c9125b232a13454d0bf168236713f59938ff01d85670597a2d8c7374e321
 SHA512:
-  metadata.gz: f8d177745b079e9b2608a698757165b595c0b9d25b4af28387194d8ecd308014487e19f228358fdcfdedfcfa3638846f23606b7b60c2bd9071a7f9a9b4946a50
-  data.tar.gz: a51a0dcc58688bb1bb2673543f9b2961381d9345e19f6e3c3fc0691eeea2c199792afeb6157303a45140962b4a9f034fd095c9bfc5fcd823725ba3611c1a7e80
+  metadata.gz: 4645193c53c5b78bda14a72b0368164673df1bf28ea726464c701d5f1e1d3f0a5f102089df55ae656ad090cc90aee0f8d8e488baefbb04d082cc4742479dc2f5
+  data.tar.gz: ce2e88f3d450299b42986cc9f3ee014a281aadf7f833d6413bfd0d5d80a7e43f4a21564060e7e440b664a93c99ff229ddd94d47282a0ee61970a43ffaccbcf35

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.7.0
+
+- More inclusive `check_symbol_to_proc` rule - don't only look at #each but any method that could leverage the symbol to proc rule. Merged through [#41](https://github.com/DamirSvrtan/fasterer/pull/41)
+
 ## 0.6.0
 
 - Enable placing the `.fasterer.yml` file not just in the current dir, but in any parent directory as well.

data/lib/fasterer/scanners/method_call_scanner.rb

@@ -44,6 +44,8 @@ module Fasterer
       when :include?
         check_range_include_offense
       end
+
+      check_symbol_to_proc
     end
 
     def check_module_eval_offense
@@ -98,8 +100,6 @@ module Fasterer
       when :keys
         add_offense(:keys_each_vs_each_key)
       end
-
-      check_symbol_to_proc
     end
 
     def check_flatten_offense

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.6.0'
+  VERSION = '0.7.0'
 end

data/spec/lib/fasterer/analyzer/18_block_vs_symbol_to_proc_spec.rb

@@ -3,9 +3,9 @@ require 'spec_helper'
 describe Fasterer::Analyzer do
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '18_block_vs_symbol_to_proc.rb') }
 
-  it 'should block that could be called with symbol 2 times' do
+  it 'should block that could be called with symbol 6 times' do
     analyzer = Fasterer::Analyzer.new(test_file_path)
     analyzer.scan
-    expect(analyzer.errors[:block_vs_symbol_to_proc].count).to eq(2)
+    expect(analyzer.errors[:block_vs_symbol_to_proc].count).to eq(6)
   end
 end

data/spec/support/analyzer/18_block_vs_symbol_to_proc.rb

@@ -28,3 +28,9 @@ route_sets.each do |routes|
 end
 
 route_sets.each { |routes| routes.finalize! }
+
+numbers = [1, 2, 3, 4, 5]
+numbers.each { |number| number.to_s }
+numbers.map { |number| number.to_s }
+numbers.any? { |number| number.even? }
+numbers.find { |number| number.even? }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Damir Svrtan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-05 00:00:00.000000000 Z
+date: 2019-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize