fasterer 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 440ad7aebc217baefb3e0c8f370af06c70b268c0
-  data.tar.gz: ba9338f1902827973c18dfaf7f00f34149aac042
+  metadata.gz: 4705338687a1a2cff20a0834e7ab76740f1ba62a
+  data.tar.gz: 0355a36451b7635e70b3f670d95b0a76b12bd036
 SHA512:
-  metadata.gz: 797d7f2a6d9cf016dc529bc2354683ef17c73cbeac91879b374913ff1762987fd01a7844fb4a486b73a6bd9640067792210a8d2a9ff810217138a1a2424f5975
-  data.tar.gz: 39df101b4b4e3693994e2a490f4c40ccba0b4ce067e0a6ed71a503aacbef061f746f56cf1efa5e4159aa36d775bfab4a491fcd1ed4c2451899239d6e9dad5672
+  metadata.gz: 6e54c755f4cb43d47d05a9a64a50fb95b592770c7b91d2e442b331a445e0a8089eda864ac604e34e7100f72e6385d6b2a16b46a9c35d32844220e3cb7b11250e
+  data.tar.gz: 32d38035fdeb87eac46f8b54e1fa398f69e37c819eb703cbf94050fe4520f3e0990a69bb7dc76c42455e605cab7678a2af67d603772c0606ff9e8974ead68962

data/lib/fasterer/analyzer.rb

@@ -92,6 +92,5 @@ module Fasterer
         errors.push(rescue_call_scanner.offense)
       end
     end
-
   end
 end

data/lib/fasterer/file_traverser.rb

@@ -1,5 +1,6 @@
 require 'pathname'
 require 'colorize'
+require 'English'
 
 require_relative 'analyzer'
 require_relative 'config'
@@ -12,11 +13,13 @@ module Fasterer
 
     attr_reader :config
     attr_reader :parse_error_paths
+    attr_accessor :offenses_total_count
 
     def initialize(path)
       @path = Pathname(path)
       @parse_error_paths = []
       @config = Config.new
+      @offenses_total_count = 0
     end
 
     def traverse
@@ -26,6 +29,7 @@ module Fasterer
         scan_file(@path)
       end
       output_parse_errors if parse_error_paths.any?
+      output_statistics
     end
 
     def config_file
@@ -36,6 +40,10 @@ module Fasterer
       !!offenses_found
     end
 
+    def scannable_files
+      all_files - ignored_files
+    end
+
     private
 
     attr_accessor :offenses_found
@@ -49,13 +57,10 @@ module Fasterer
       if offenses_grouped_by_type(analyzer).any?
         output(analyzer)
         self.offenses_found = true
+        self.offenses_total_count += analyzer.errors.count
       end
     end
 
-    def scannable_files
-      all_files - ignored_files
-    end
-
     def all_files
       Dir["#{@path}/**/*.rb"].map do |ruby_file_path|
         Pathname(ruby_file_path).relative_path_from(@path).to_s
@@ -85,6 +90,11 @@ module Fasterer
       puts 'has timed out. Unprocessable files were:'
       puts '-----------------------------------------------------'
       puts parse_error_paths
+      puts
+    end
+
+    def output_statistics
+      puts Statistics.new(self)
     end
 
     def ignored_speedups
@@ -105,4 +115,46 @@ module Fasterer
       "#{file_path} - #{error_class} - #{error_message}"
     end
   end
+
+  class Statistics
+    def initialize(traverser)
+      @files_inspected_count  = traverser.scannable_files.count
+      @offenses_found_count   = traverser.offenses_total_count
+      @unparsable_files_count = traverser.parse_error_paths.count
+    end
+
+    def to_s
+      [
+        inspected_files_output,
+        offenses_found_output,
+        unparsable_files_output
+      ].compact.join(', ')
+    end
+
+    def inspected_files_output
+      "#{@files_inspected_count} #{pluralize(@files_inspected_count, 'file')} inspected"
+        .colorize(:green)
+    end
+
+    def offenses_found_output
+      "#{@offenses_found_count} #{pluralize(@offenses_found_count, 'offense')} detected"
+        .colorize(:red)
+    end
+
+    def unparsable_files_output
+      return if @unparsable_files_count.zero?
+      "#{@unparsable_files_count} unparsable #{pluralize(@unparsable_files_count, 'file')} found"
+        .colorize(:red)
+    end
+
+    def pluralize(n, singular, plural = nil)
+      if n == 1
+        "#{singular}"
+      elsif plural
+        "#{plural}"
+      else
+        "#{singular}s"
+      end
+    end
+  end
 end

data/lib/fasterer/method_call.rb

@@ -64,14 +64,12 @@ module Fasterer
     end
 
     def set_block_body
-      if has_block?
-        @block_body = element[3]
-      end
+      @block_body = element[3] if has_block?
     end
 
     # TODO: write specs for lambdas and procs
     def set_block_argument_names
-      @block_argument_names = if has_block? && element[2].is_a?(Sexp) # hack for lambdas
+      @block_argument_names = if has_block? && element[2].is_a?(Sexp) # HACK: for lambdas
                                 element[2].drop(1).map { |argument| argument }
                               end || []
     end

data/lib/fasterer/method_definition.rb

@@ -56,7 +56,6 @@ module Fasterer
   end
 
   class MethodDefinitionArgument
-
     attr_reader :element, :name, :type
 
     def initialize(element)
@@ -85,13 +84,12 @@ module Fasterer
 
     def set_argument_type
       @type = if element.is_a?(Symbol)
-        :regular_argument
-      elsif element.is_a?(Sexp) && element.sexp_type == :lasgn
-        :default_argument
-      elsif element.is_a?(Sexp) && element.sexp_type == :kwarg
-        :keyword_argument
+                :regular_argument
+              elsif element.is_a?(Sexp) && element.sexp_type == :lasgn
+                :default_argument
+              elsif element.is_a?(Sexp) && element.sexp_type == :kwarg
+                :keyword_argument
       end
     end
   end
-
 end

data/lib/fasterer/offense_collector.rb

@@ -12,6 +12,6 @@ module Fasterer
       @offenses.select { |offense| offense.name == offense_name }
     end
 
-    def_delegators :@offenses, :push, :any?, :each, :group_by
+    def_delegators :@offenses, :push, :any?, :each, :group_by, :count
   end
 end

data/lib/fasterer/rescue_call.rb

@@ -15,11 +15,8 @@ module Fasterer
       return if element[1].sexp_type != :array
 
       @rescue_classes = element[1].drop(1).map do |rescue_reference|
-        if rescue_reference.sexp_type == :const
-          rescue_reference[1]
-        end
+        rescue_reference[1] if rescue_reference.sexp_type == :const
       end.compact
     end
-
   end
 end

data/lib/fasterer/scanners/method_call_scanner.rb

@@ -50,9 +50,7 @@ module Fasterer
       first_argument = method_call.arguments.first
       return unless first_argument && first_argument.value.is_a?(String)
 
-      if first_argument.value.include?("def")
-        add_offense(:module_eval)
-      end
+      add_offense(:module_eval) if first_argument.value.include?('def')
     end
 
     def check_gsub_offense
@@ -62,7 +60,7 @@ module Fasterer
       return if first_argument.nil? || second_argument.nil?
 
       if first_argument.value.is_a?(String) && first_argument.value.size == 1 &&
-           second_argument.value.is_a?(String) && second_argument.value.size == 1
+         second_argument.value.is_a?(String) && second_argument.value.size == 1
 
         add_offense(:gsub_vs_tr)
       end

data/lib/fasterer/scanners/method_definition_scanner.rb

@@ -31,8 +31,8 @@ module Fasterer
         method_call = MethodCall.new(element)
 
         if method_call.receiver.is_a?(Fasterer::VariableReference) &&
-          method_call.receiver.name == method_definition.block_argument_name &&
-          method_call.method_name == :call
+           method_call.receiver.name == method_definition.block_argument_name &&
+           method_call.method_name == :call
 
           add_offense(:proc_call_vs_yield) && return
         end
@@ -63,8 +63,8 @@ module Fasterer
       return if first_argument.type != :regular_argument
 
       if method_definition.body.first.sexp_type == :iasgn &&
-        method_definition.body.first[1].to_s == "@#{method_definition.name.to_s[0..-2]}" &&
-        method_definition.body.first[2][1] == first_argument.name
+         method_definition.body.first[1].to_s == "@#{method_definition.name.to_s[0..-2]}" &&
+         method_definition.body.first[2][1] == first_argument.name
 
         add_offense(:setter_vs_attr_writer)
       end
@@ -75,12 +75,10 @@ module Fasterer
       return if method_definition.body.size != 1
 
       if method_definition.body.first.sexp_type == :ivar &&
-        method_definition.body.first[1].to_s == "@#{method_definition.name}"
+         method_definition.body.first[1].to_s == "@#{method_definition.name}"
 
         add_offense(:getter_vs_attr_reader)
       end
     end
-
   end
-
 end

data/lib/fasterer/scanners/offensive.rb

@@ -2,7 +2,6 @@ require 'fasterer/offense'
 
 module Fasterer
   module Offensive
-
     attr_accessor :offense
 
     def offensive?
@@ -13,13 +12,12 @@ module Fasterer
 
     private
 
-      def add_offense(offense_name, element_line_number = element.line)
-        self.offense = Fasterer::Offense.new(offense_name, element_line_number)
-      end
-
-      def check_offense
-        raise NotImplementedError
-      end
+    def add_offense(offense_name, element_line_number = element.line)
+      self.offense = Fasterer::Offense.new(offense_name, element_line_number)
+    end
 
+    def check_offense
+      fail NotImplementedError
+    end
   end
 end

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

data/spec/lib/fasterer/analyzer/01_parallel_assignment_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '01_parallel_assignment.rb') }
 
   it 'should detect parallel assignment 2 times' do

data/spec/lib/fasterer/analyzer/02_rescue_vs_respond_to_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '02_rescue_vs_respond_to.rb') }
 
   it 'should detect rescue NoMethodError' do

data/spec/lib/fasterer/analyzer/03_module_eval_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '03_module_eval.rb') }
 
   it 'should detect module eval' do

data/spec/lib/fasterer/analyzer/06_shuffle_first_vs_sample_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '06_shuffle_first_vs_sample.rb') }
 
   it 'should detect a for loop' do

data/spec/lib/fasterer/analyzer/08_for_loop_vs_each_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '08_for_loop_vs_each.rb') }
 
   it 'should detect a for loop' do

data/spec/lib/fasterer/analyzer/09_each_with_index_vs_while_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '09_each_with_index_vs_while.rb') }
 
   it 'should detect a for loop' do

data/spec/lib/fasterer/analyzer/10_map_flatten_vs_flat_map_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '10_map_flatten_vs_flat_map.rb') }
 
   it 'should detect a map{}.flatten(1) ' do

data/spec/lib/fasterer/analyzer/11_reverse_each_vs_reverse_each_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '11_reverse_each_vs_reverse_each.rb') }
 
   it 'should detect a for loop' do

data/spec/lib/fasterer/analyzer/12_select_first_vs_detect_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '12_select_first_vs_detect.rb') }
 
   it 'should detect sort once' do

data/spec/lib/fasterer/analyzer/13_sort_vs_sort_by_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '13_sort_vs_sort_by.rb') }
 
   it 'should detect sort once' do

data/spec/lib/fasterer/analyzer/14_fetch_with_argument_vs_block_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '14_fetch_with_argument_vs_block.rb') }
 
   it 'should detect keys fetch with argument once' do

data/spec/lib/fasterer/analyzer/15_keys_each_vs_each_key_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '15_keys_each_vs_each_key.rb') }
 
   it 'should detect keys each 3 times' do

data/spec/lib/fasterer/analyzer/16_hash_merge_bang_vs_hash_brackets_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '16_hash_merge_bang_vs_hash_brackets.rb') }
 
   it 'should detect keys each 3 times' do

data/spec/lib/fasterer/analyzer/18_block_vs_symbol_to_proc_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '18_block_vs_symbol_to_proc.rb') }
 
   it 'should block that could be called with symbol 2 times' do

data/spec/lib/fasterer/analyzer/19_proc_call_vs_yield_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '19_proc_call_vs_yield.rb') }
 
   it 'should detect sort once' do

data/spec/lib/fasterer/analyzer/24_gsub_vs_tr_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '24_gsub_vs_tr.rb') }
 
   it 'should detect gsub 4 times' do

data/spec/lib/fasterer/analyzer/25_select_last_vs_reverse_detect_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '25_select_last_vs_reverse_detect.rb') }
 
   it 'should detect select last once' do

data/spec/lib/fasterer/analyzer/26_getter_vs_attr_reader_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '26_getter_vs_attr_reader.rb') }
 
   it 'should detect 2 getters' do

data/spec/lib/fasterer/analyzer/27_setter_vs_attr_writer_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '27_setter_vs_attr_writer.rb') }
 
   it 'should detect 2 setters' do

data/spec/lib/fasterer/analyzer/29_include_vs_cover_on_range_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) do
     RSpec.root.join('support', 'analyzer', '29_include_vs_cover_on_range.rb')
   end

data/spec/lib/fasterer/analyzer/98_misc_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '98_misc.rb') }
 
   it 'should detect gsub 4 times' do

data/spec/lib/fasterer/analyzer/99_exceptional_files_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::Analyzer do
-
   let(:test_file_path) { RSpec.root.join('support', 'analyzer', '99_exceptional_files.rb') }
 
   it 'diacritics should not raise an error' do

data/spec/lib/fasterer/cli_spec.rb

@@ -8,13 +8,13 @@ describe Fasterer::FileTraverser do
     context 'success' do
       it 'when no files exist' do
         `#{fasterer_bin}`
-        expect($?.exitstatus).to eq(0)
+        expect($CHILD_STATUS.exitstatus).to eq(0)
       end
 
       it 'when no files with offenses exist' do
         create_file('user.rb', '[].sample')
         `#{fasterer_bin}`
-        expect($?.exitstatus).to eq(0)
+        expect($CHILD_STATUS.exitstatus).to eq(0)
       end
     end
 
@@ -22,7 +22,7 @@ describe Fasterer::FileTraverser do
       it 'when file with offenses exists' do
         create_file('user.rb', '[].shuffle.first')
         `#{fasterer_bin}`
-        expect($?.exitstatus).to eq(1)
+        expect($CHILD_STATUS.exitstatus).to eq(1)
       end
     end
   end

data/spec/lib/fasterer/file_traverser_spec.rb

@@ -44,7 +44,7 @@ describe Fasterer::FileTraverser do
     context 'with speedups content but no exclude_paths' do
       let(:config_file_content) do
         "speedups:\n"\
-        "  keys_each_vs_each_key: true"
+        '  keys_each_vs_each_key: true'
       end
 
       before(:each) do

data/spec/lib/fasterer/method_call_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::MethodCall do
-
   let(:ripper) do
     Fasterer::Parser.parse(code)
   end
@@ -13,7 +12,6 @@ describe Fasterer::MethodCall do
   describe 'with explicit receiver' do
     describe 'without arguments, without block, called with parentheses' do
       describe 'method call on a constant' do
-
         let(:code) { 'User.hello()' }
 
         # This is where the :call token will be recognized.
@@ -23,11 +21,9 @@ describe Fasterer::MethodCall do
           expect(method_call.method_name).to eq(:hello)
           expect(method_call.arguments).to be_empty
         end
-
       end
 
       describe 'method call on a integer' do
-
         let(:code) { '1.hello()' }
 
         # This is where the :call token will be recognized.
@@ -37,11 +33,9 @@ describe Fasterer::MethodCall do
           expect(method_call.method_name).to eq(:hello)
           expect(method_call.arguments).to be_empty
         end
-
       end
 
       describe 'method call on a string' do
-
         let(:code) { "'hello'.hello()" }
 
         let(:call_element) { ripper }
@@ -50,11 +44,9 @@ describe Fasterer::MethodCall do
           expect(method_call.method_name).to eq(:hello)
           expect(method_call.arguments).to be_empty
         end
-
       end
 
       describe 'method call on a variable' do
-
         let(:code) do
           "number_one = 1\n"\
           'number_one.hello()'
@@ -68,11 +60,9 @@ describe Fasterer::MethodCall do
           expect(method_call.receiver).to be_a(Fasterer::VariableReference)
           expect(method_call.receiver.name).to eq(:number_one)
         end
-
       end
 
       describe 'method call on a method' do
-
         let(:code) { '1.hi(2).hello()' }
 
         let(:call_element) { ripper }
@@ -83,13 +73,11 @@ describe Fasterer::MethodCall do
           expect(method_call.receiver.name).to eq(:hi)
           expect(method_call.arguments).to be_empty
         end
-
       end
     end
 
     describe 'without arguments, without block, called without parentheses' do
       describe 'method call on a constant' do
-
         let(:code) { 'User.hello' }
 
         let(:call_element) { ripper }
@@ -98,11 +86,9 @@ describe Fasterer::MethodCall do
           expect(method_call.method_name).to eq(:hello)
           expect(method_call.arguments).to be_empty
         end
-
       end
 
       describe 'method call on a integer' do
-
         let(:code) { '1.hello' }
 
         # This is where the :call token will be recognized.
@@ -112,11 +98,9 @@ describe Fasterer::MethodCall do
           expect(method_call.method_name).to eq(:hello)
           expect(method_call.arguments).to be_empty
         end
-
       end
 
       describe 'method call on a string' do
-
         let(:code) { "'hello'.hello" }
 
         let(:call_element) { ripper }
@@ -125,11 +109,9 @@ describe Fasterer::MethodCall do
           expect(method_call.method_name).to eq(:hello)
           expect(method_call.arguments).to be_empty
         end
-
       end
 
       describe 'method call on a variable' do
-
         let(:code) do
           "number_one = 1\n"\
           'number_one.hello'
@@ -143,11 +125,9 @@ describe Fasterer::MethodCall do
           expect(method_call.receiver).to be_a(Fasterer::VariableReference)
           expect(method_call.receiver.name).to eq(:number_one)
         end
-
       end
 
       describe 'method call on a method' do
-
         let(:code) { '1.hi(2).hello' }
 
         let(:call_element) { ripper }
@@ -158,14 +138,11 @@ describe Fasterer::MethodCall do
           expect(method_call.receiver.name).to eq(:hi)
           expect(method_call.arguments).to be_empty
         end
-
       end
     end
 
     describe 'with do end block' do
-
       describe 'and no arguments, without block parameter' do
-
         let(:code) do
           <<-code
             number_one.fetch do
@@ -184,11 +161,9 @@ describe Fasterer::MethodCall do
           expect(method_call.block_argument_names.count).to be(0)
           expect(method_call.receiver).to be_a(Fasterer::MethodCall)
         end
-
       end
 
       describe 'and no arguments, with block parameter' do
-
         let(:code) do
           <<-code
             number_one.fetch do |el|
@@ -208,11 +183,9 @@ describe Fasterer::MethodCall do
           expect(method_call.block_argument_names.first).to be(:el)
           expect(method_call.receiver).to be_a(Fasterer::MethodCall)
         end
-
       end
 
       describe 'and no arguments, with block parameter' do
-
         let(:code) do
           <<-code
             number_one.fetch do |el, tip|
@@ -233,11 +206,9 @@ describe Fasterer::MethodCall do
           expect(method_call.block_argument_names.last).to be(:tip)
           expect(method_call.receiver).to be_a(Fasterer::MethodCall)
         end
-
       end
 
       describe 'and one argument within parentheses' do
-
         let(:code) do
           <<-code
             number_one = 1
@@ -256,13 +227,11 @@ describe Fasterer::MethodCall do
           expect(method_call.has_block?).to be
           expect(method_call.receiver).to be_a(Fasterer::VariableReference)
         end
-
       end
     end
 
     describe 'with curly block' do
       describe 'in one line' do
-
         let(:code) do
           <<-code
             number_one = 1
@@ -278,11 +247,9 @@ describe Fasterer::MethodCall do
           expect(method_call.has_block?).to be
           expect(method_call.receiver).to be_a(Fasterer::VariableReference)
         end
-
       end
 
       describe 'multi lined' do
-
         let(:code) do
           <<-code
             number_one = 1
@@ -301,14 +268,11 @@ describe Fasterer::MethodCall do
           expect(method_call.has_block?).to be
           expect(method_call.receiver).to be_a(Fasterer::VariableReference)
         end
-
       end
     end
 
     describe 'with arguments, without block, called with parentheses' do
-
       describe 'method call with an argument' do
-
         let(:code) { '{}.fetch(:writing)' }
 
         let(:call_element) { ripper }
@@ -318,13 +282,11 @@ describe Fasterer::MethodCall do
           expect(method_call.arguments.count).to eq(1)
           expect(method_call.arguments.first.type).to eq(:lit)
         end
-
       end
     end
 
     describe 'arguments without parenthesis' do
       describe 'method call with an argument' do
-
         let(:code) { '{}.fetch :writing, :listening' }
 
         let(:call_element) { ripper }
@@ -335,7 +297,6 @@ describe Fasterer::MethodCall do
           expect(method_call.arguments[0].type).to eq(:lit)
           expect(method_call.arguments[1].type).to eq(:lit)
         end
-
       end
     end
   end
@@ -344,7 +305,6 @@ describe Fasterer::MethodCall do
   end
 
   describe 'method call with an argument and a block' do
-
     let(:code) do
       <<-code
         number_one = 1
@@ -361,11 +321,9 @@ describe Fasterer::MethodCall do
       expect(method_call.has_block?).to be
       expect(method_call.receiver).to be_a(Fasterer::VariableReference)
     end
-
   end
 
   describe 'method call without an explicit receiver' do
-
     let(:code) { 'fetch(:writing, :listening)' }
 
     let(:call_element) { ripper }
@@ -377,11 +335,9 @@ describe Fasterer::MethodCall do
       expect(method_call.arguments[1].type).to eq(:lit)
       expect(method_call.receiver).to be_nil
     end
-
   end
 
   describe 'method call without an explicit receiver and without brackets' do
-
     let(:code) { 'fetch :writing, :listening' }
 
     let(:call_element) { ripper }
@@ -393,11 +349,9 @@ describe Fasterer::MethodCall do
       expect(method_call.arguments[1].type).to eq(:lit)
       expect(method_call.receiver).to be_nil
     end
-
   end
 
   describe 'method call without an explicit receiver and without brackets and do end' do
-
     let(:code) do
       <<-code
         "fetch :writing do\n"\
@@ -414,11 +368,9 @@ describe Fasterer::MethodCall do
       # expect(method_call.arguments[1].type).to eq(:symbol_literal)
       # expect(method_call.receiver).to be_nil
     end
-
   end
 
   describe 'method call with two arguments' do
-
     let(:code) do
       "number_one = 1\n"\
       'number_one.fetch(:writing, :zumba)'
@@ -433,11 +385,9 @@ describe Fasterer::MethodCall do
       expect(method_call.arguments[1].type).to eq(:lit)
       expect(method_call.receiver).to be_a(Fasterer::VariableReference)
     end
-
   end
 
   describe 'method call with a regex argument' do
-
     let(:code) { '{}.fetch(/.*/)' }
 
     let(:call_element) { ripper }
@@ -448,11 +398,9 @@ describe Fasterer::MethodCall do
       expect(method_call.arguments[0].type).to eq(:lit)
       expect(method_call.arguments[0].value).to be_a(Regexp)
     end
-
   end
 
   describe 'method call with a integer argument' do
-
     let(:code) { '[].flatten(1)' }
 
     let(:call_element) { ripper }
@@ -463,7 +411,6 @@ describe Fasterer::MethodCall do
       expect(method_call.arguments[0].type).to eq(:lit)
       expect(method_call.arguments[0].value).to eq(1)
     end
-
   end
 
   describe 'method call with symbol to proc argument' do
@@ -480,7 +427,6 @@ describe Fasterer::MethodCall do
   end
 
   describe 'method call with equals operator' do
-
     let(:code) { 'method_call_with_equals.rb' }
 
     let(:call_element) { ripper.drop(1).first.first[1] }
@@ -490,7 +436,5 @@ describe Fasterer::MethodCall do
       # expect(method_call.receiver).to be_a(Fasterer::MethodCall)
       # expect(method_call.receiver.name).to eq('hi')
     end
-
   end
-
 end

data/spec/lib/fasterer/method_definition_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::MethodDefinition do
-
   let(:def_element) do
     Fasterer::Parser.parse(File.read(RSpec.root.join('support', 'method_definition', file_name)))
   end
@@ -11,40 +10,33 @@ describe Fasterer::MethodDefinition do
   end
 
   describe 'method with no arguments' do
-
     let(:file_name) { 'simple_method.rb' }
 
     it 'should not detect block' do
       expect(method_definition.method_name).to eq(:hello)
       expect(method_definition.has_block?).to eq(false)
     end
-
   end
 
   describe 'method with no arguments and omitted parenthesis' do
-
     let(:file_name) { 'simple_method_omitted_parenthesis.rb' }
 
     it 'should not detect block' do
       expect(method_definition.method_name).to eq(:hello)
       expect(method_definition.has_block?).to eq(false)
     end
-
   end
 
   describe 'method with one argument' do
-
     let(:file_name) { 'simple_method_with_argument.rb' }
 
     it 'should not detect block' do
       expect(method_definition.method_name).to eq(:hello)
       expect(method_definition.has_block?).to eq(false)
     end
-
   end
 
   describe 'method with a block' do
-
     let(:file_name) { 'method_with_block.rb' }
 
     it 'should detect block' do
@@ -52,11 +44,9 @@ describe Fasterer::MethodDefinition do
       expect(method_definition.has_block?).to eq(true)
       expect(method_definition.block_argument_name).to eq(:block)
     end
-
   end
 
   describe 'method with an argument and a block' do
-
     let(:file_name) { 'method_with_argument_and_block.rb' }
 
     it 'should detect block' do
@@ -64,11 +54,9 @@ describe Fasterer::MethodDefinition do
       expect(method_definition.has_block?).to eq(true)
       expect(method_definition.block_argument_name).to eq(:block)
     end
-
   end
 
   describe 'method with an splat argument and a block' do
-
     let(:file_name) { 'method_with_splat_and_block.rb' }
 
     it 'should detect block' do
@@ -76,18 +64,14 @@ describe Fasterer::MethodDefinition do
       expect(method_definition.has_block?).to eq(true)
       expect(method_definition.block_argument_name).to eq(:block)
     end
-
   end
 
   describe 'method with an default argument' do
-
     let(:file_name) { 'method_with_default_argument.rb' }
 
     it 'should not detect block' do
       expect(method_definition.method_name).to eq(:hello)
       expect(method_definition.has_block?).to eq(false)
     end
-
   end
-
 end

data/spec/lib/fasterer/rescue_call_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Fasterer::RescueCall do
-
   let(:file_path) { RSpec.root.join('support', 'rescue_call', file_name) }
 
   let(:rescue_element) do
@@ -14,63 +13,50 @@ describe Fasterer::RescueCall do
   end
 
   describe 'plain rescue call' do
-
     let(:file_name) { 'plain_rescue.rb' }
 
     it 'should detect constant' do
       expect(rescue_call.rescue_classes).to eq([])
     end
-
   end
 
   describe 'rescue call with class' do
-
     let(:file_name) { 'rescue_with_class.rb' }
 
     it 'should detect integer' do
       expect(rescue_call.rescue_classes).to eq([:NoMethodError])
     end
-
   end
 
   describe 'rescue call with class and variable' do
-
     let(:file_name) { 'rescue_with_class_and_variable.rb' }
 
     it 'should detect string' do
       expect(rescue_call.rescue_classes).to eq([:NoMethodError])
     end
-
   end
 
   describe 'rescue call with variable' do
-
     let(:file_name) { 'rescue_with_variable.rb' }
 
     it 'should detect variable' do
       expect(rescue_call.rescue_classes).to eq([])
     end
-
   end
 
   describe 'rescue call with multiple classes' do
-
     let(:file_name) { 'rescue_with_multiple_classes.rb' }
 
     it 'should detect method' do
       expect(rescue_call.rescue_classes).to eq([:NoMethodError, :StandardError])
     end
-
   end
 
   describe 'rescue call with multiple classes and variable' do
-
     let(:file_name) { 'rescue_with_multiple_classes_and_variable.rb' }
 
     it 'should detect method' do
       expect(rescue_call.rescue_classes).to eq([:NoMethodError, :StandardError])
     end
-
   end
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Damir Svrtan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-21 00:00:00.000000000 Z
+date: 2015-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize