fasterer 0.1.12 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a3553ce8184fc77f1acf47f6853044df9e21f5dc
-  data.tar.gz: cc19c0ab4f3e1f57d865d8dd734da0e5edaddc0a
+  metadata.gz: 440ad7aebc217baefb3e0c8f370af06c70b268c0
+  data.tar.gz: ba9338f1902827973c18dfaf7f00f34149aac042
 SHA512:
-  metadata.gz: 81fdc75a473a31b92c754da7f7a71c93b3f632b03f3a3fb0a7b1e514e27c24429247de20298579663772e92ac447359b409ecad1d712ce4f77ac12ecd7caaa03
-  data.tar.gz: aa1a4e40b67a12654028fa0f2e2ec9e980436631f3437230a120f95349c608b209627d762e4b915cf88745f7e7b3e92e0be449814177ff1677729b67d18c1b91
+  metadata.gz: 797d7f2a6d9cf016dc529bc2354683ef17c73cbeac91879b374913ff1762987fd01a7844fb4a486b73a6bd9640067792210a8d2a9ff810217138a1a2424f5975
+  data.tar.gz: 39df101b4b4e3693994e2a490f4c40ccba0b4ce067e0a6ed71a503aacbef061f746f56cf1efa5e4159aa36d775bfab4a491fcd1ed4c2451899239d6e9dad5672

data/.gitignore

@@ -13,3 +13,4 @@
 *.a
 mkmf.log
 *.gem
+.ruby-version

data/.rubocop.yml

@@ -1,3 +1,5 @@
+LineLength:
+  Max: 100
 AllCops:
   Include:
     - '**/Rakefile'

data/README.md

@@ -2,6 +2,8 @@
 [![Code Climate](https://codeclimate.com/github/DamirSvrtan/fasterer/badges/gpa.svg)](https://codeclimate.com/github/DamirSvrtan/fasterer)
 [![Gem Version](https://badge.fury.io/rb/fasterer.svg)](http://badge.fury.io/rb/fasterer)
 [![Test Coverage](https://codeclimate.com/github/DamirSvrtan/fasterer/badges/coverage.svg)](https://codeclimate.com/github/DamirSvrtan/fasterer/coverage)
+[![Dependency Status](https://gemnasium.com/DamirSvrtan/fasterer.svg)](https://gemnasium.com/DamirSvrtan/fasterer)
+
 # Fasterer
 
 Make your Rubies go faster with this command line tool highly inspired by [fast-ruby](https://github.com/JuanitoFatas/fast-ruby) and [Sferik's talk at Baruco Conf](https://speakerdeck.com/sferik/writing-fast-ruby).

data/fasterer.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'colorize', '~> 0.7'
-  spec.add_dependency 'ruby_parser', '~> 3.6'
+  spec.add_dependency 'ruby_parser', '~> 3.7'
 
   spec.add_development_dependency 'bundler', '~> 1.6'
   spec.add_development_dependency 'rake',    '~> 10.0'

data/lib/fasterer/file_traverser.rb

@@ -11,6 +11,7 @@ module Fasterer
     EXCLUDE_PATHS_KEY = Config::EXCLUDE_PATHS_KEY
 
     attr_reader :config
+    attr_reader :parse_error_paths
 
     def initialize(path)
       @path = Pathname(path)
@@ -37,14 +38,13 @@ module Fasterer
 
     private
 
-    attr_reader :parse_error_paths
     attr_accessor :offenses_found
 
     def scan_file(path)
       analyzer = Analyzer.new(path)
       analyzer.scan
-    rescue RubyParser::SyntaxError, Racc::ParseError, Timeout::Error
-      parse_error_paths.push(path)
+    rescue RubyParser::SyntaxError, Racc::ParseError, Timeout::Error => e
+      parse_error_paths.push(ErrorData.new(path, e.class, e.message).to_s)
     else
       if offenses_grouped_by_type(analyzer).any?
         output(analyzer)
@@ -85,7 +85,6 @@ module Fasterer
       puts 'has timed out. Unprocessable files were:'
       puts '-----------------------------------------------------'
       puts parse_error_paths
-      puts
     end
 
     def ignored_speedups
@@ -100,4 +99,10 @@ module Fasterer
       config.nil_file
     end
   end
+
+  ErrorData = Struct.new(:file_path, :error_class, :error_message) do
+    def to_s
+      "#{file_path} - #{error_class} - #{error_message}"
+    end
+  end
 end

data/lib/fasterer/offense.rb

@@ -76,6 +76,5 @@ module Fasterer
       include_vs_cover_on_range:
         'Use #cover? instead of #include? on ranges'
     }
-
   end
 end

data/lib/fasterer/parser.rb

@@ -5,7 +5,7 @@ module Fasterer
     PARSER_CLASS = RubyParser
 
     def self.parse(ruby_code)
-      PARSER_CLASS.new.parse(ruby_code)
+      PARSER_CLASS.for_current_ruby.parse(ruby_code)
     end
   end
 end

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.1.12'
+  VERSION = '0.2.0'
 end

data/spec/lib/fasterer/file_traverser_spec.rb

@@ -186,8 +186,7 @@ describe Fasterer::FileTraverser do
       end
 
       before(:each) do
-        create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME,
-                    config_file_content)
+        create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
         create_file(file_name)
       end
 
@@ -197,5 +196,93 @@ describe Fasterer::FileTraverser do
         expect(file_traverser.send(:scannable_files)).to eq([file_name])
       end
     end
+
+    context 'nested ruby files' do
+      before(:each) do
+        create_file('something.rb')
+        create_file('nested/something.rb')
+      end
+
+      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+
+      it 'returns files properly' do
+        expect(file_traverser.send(:scannable_files))
+          .to match_array(['something.rb', 'nested/something.rb'])
+      end
+    end
+
+    context 'ruby files but nested ignored explicitly' do
+      let(:config_file_content) do
+        "exclude_paths:\n"\
+        "  - 'nested/something.rb'"
+      end
+
+      before(:each) do
+        create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
+        create_file('something.rb')
+        create_file('nested/something.rb')
+      end
+
+      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+
+      it 'returns unignored files' do
+        expect(file_traverser.send(:scannable_files))
+          .to match_array(['something.rb'])
+      end
+    end
+
+    context 'ruby files but nested ignored with *' do
+      let(:config_file_content) do
+        "exclude_paths:\n"\
+        "  - 'nested/*'"
+      end
+
+      before(:each) do
+        create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
+        create_file('something.rb')
+        create_file('nested/something.rb')
+      end
+
+      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+
+      it 'returns unignored files' do
+        expect(file_traverser.send(:scannable_files))
+          .to match_array(['something.rb'])
+      end
+    end
+
+    context 'ruby files but unnested ignored' do
+      let(:config_file_content) do
+        "exclude_paths:\n"\
+        "  - 'something.rb'"
+      end
+
+      before(:each) do
+        create_file(Fasterer::FileTraverser::CONFIG_FILE_NAME, config_file_content)
+        create_file('something.rb')
+        create_file('nested/something.rb')
+      end
+
+      let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+
+      it 'returns unignored files' do
+        expect(file_traverser.send(:scannable_files))
+          .to match_array(['nested/something.rb'])
+      end
+    end
+  end
+
+  describe 'parse errors' do
+    before do
+      create_file('user.rb', '[]*/sa*()')
+      file_traverser.traverse
+    end
+
+    let(:file_traverser) { Fasterer::FileTraverser.new('.') }
+
+    it 'should have errors' do
+      expect(file_traverser.parse_error_paths)
+        .to match_array(['user.rb - RubyParser::SyntaxError - unterminated string meets end of file. near line 1: ""'])
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.1.12
+  version: 0.2.0
 platform: ruby
 authors:
 - Damir Svrtan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-19 00:00:00.000000000 Z
+date: 2015-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '3.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '3.7'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement