fasterer 0.1.10 → 0.1.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 917099eee3733d73079d7cb3add928d81880351e
-  data.tar.gz: 8de26edcf41f8919a38dc34d16f16d796f57ca2c
+  metadata.gz: 5fc06a003ad7ef35818e525f60ef7bc3bbc7b015
+  data.tar.gz: c33294e5d4ae9d8f731cf018ff4f6e834731e230
 SHA512:
-  metadata.gz: 9db9bedccb3ffb027fdfce9dade3ca0ef33cd114e25c23f46491afb2bda5db1ef3af7b0e35655472a0219f4aef46acfd7545ff1270c22be23f189bc0d0662a34
-  data.tar.gz: a71ed2ece3272ec0c027b9fc2b1f625a7406073a99284b4ed2c940b96b7b9f7813b8157a65625657531bfc656f527453627c894040cb1d9c8bc0191e67b1e98f
+  metadata.gz: 13e41010ea909bc9990f61ac6423b91855ce9ea8d17323ed10ed1ca8d44613e22e9929895dbc8e9cf213ebb1acc1613e24e89d2ffab2840f3d06c769ea52f278
+  data.tar.gz: 654bd69d4a16bffab862c955e50aba3e9364118a23436f6aaf10a912ac65376a6bb9e9db1e8cfabeeae3b850eb0f6c9c6dcfa0466e50da2370b1d6889bd593d5

data/lib/fasterer/method_call.rb

@@ -88,6 +88,8 @@ module Fasterer
         return VariableReference.new(receiver_info)
       when :call, :iter
         return MethodCall.new(receiver_info)
+      when :array, :dot2, :dot3, :lit
+        return Primitive.new(receiver_info)
       end
     end
   end
@@ -116,4 +118,24 @@ module Fasterer
       @value ||= @element[1]
     end
   end
+
+  class Primitive
+    attr_reader :element
+
+    def initialize(element)
+      @element = element
+    end
+
+    def type
+      @type ||= @element[0]
+    end
+
+    def range?
+      [:dot2, :dot3, :lit].include?(type)
+    end
+
+    def array?
+      type == :array
+    end
+  end
 end

data/lib/fasterer/offense.rb

@@ -71,7 +71,10 @@ module Fasterer
         'Use attr_reader for reading ivars',
 
       setter_vs_attr_writer:
-        'Use attr_writer for writing to ivars'
+        'Use attr_writer for writing to ivars',
+
+      include_vs_cover_on_range:
+        'Use #cover? instead of #include? on ranges'
     }
 
   end

data/lib/fasterer/scanners/method_call_scanner.rb

@@ -41,6 +41,8 @@ module Fasterer
         check_merge_bang_offense
       when :last
         check_last_offense
+      when :include?
+        check_range_include_offense
       end
     end
 
@@ -155,5 +157,10 @@ module Fasterer
       end
     end
 
+    def check_range_include_offense
+      if method_call.receiver.is_a?(Primitive) && method_call.receiver.range?
+        add_offense(:include_vs_cover_on_range)
+      end
+    end
   end
 end

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.1.10'
+  VERSION = '0.1.11'
 end

data/spec/lib/fasterer/analyzer/29_include_vs_cover_on_range_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe Fasterer::Analyzer do
+
+  let(:test_file_path) do
+    RSpec.root.join('support', 'analyzer', '29_include_vs_cover_on_range.rb')
+  end
+
+  it 'should detect 3 include? method calls' do
+    analyzer = Fasterer::Analyzer.new(test_file_path)
+    analyzer.scan
+    expect(analyzer.errors[:include_vs_cover_on_range].count).to eq(3)
+  end
+end

data/spec/support/analyzer/29_include_vs_cover_on_range.rb

@@ -0,0 +1,17 @@
+[1,2,3].include? 2
+
+numbers = [1,2,3]
+
+numbers.include? 2
+
+def fast
+  (BEGIN_OF_JULY..END_OF_JULY).cover? DAY_IN_JULY
+end
+
+def slow
+  (BEGIN_OF_JULY..END_OF_JULY).include? DAY_IN_JULY
+end
+
+(10..1_000_000).include? 999
+
+(BEGIN_OF_JULY...END_OF_JULY).include? DAY_IN_JULY

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.1.10
+  version: 0.1.11
 platform: ruby
 authors:
 - Damir Svrtan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-04 00:00:00.000000000 Z
+date: 2015-08-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -163,6 +163,7 @@ files:
 - spec/lib/fasterer/analyzer/25_select_last_vs_reverse_detect_spec.rb
 - spec/lib/fasterer/analyzer/26_getter_vs_attr_reader_spec.rb
 - spec/lib/fasterer/analyzer/27_setter_vs_attr_writer_spec.rb
+- spec/lib/fasterer/analyzer/29_include_vs_cover_on_range_spec.rb
 - spec/lib/fasterer/analyzer/98_misc_spec.rb
 - spec/lib/fasterer/analyzer/99_exceptional_files_spec.rb
 - spec/lib/fasterer/method_call_spec.rb
@@ -188,6 +189,7 @@ files:
 - spec/support/analyzer/25_select_last_vs_reverse_detect.rb
 - spec/support/analyzer/26_getter_vs_attr_reader.rb
 - spec/support/analyzer/27_setter_vs_attr_writer.rb
+- spec/support/analyzer/29_include_vs_cover_on_range.rb
 - spec/support/analyzer/98_misc.rb
 - spec/support/analyzer/99_exceptional_files.rb
 - spec/support/binary_call/simple_comparison.rb
@@ -240,7 +242,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Run Ruby more than fast. Fasterer
@@ -264,6 +266,7 @@ test_files:
 - spec/lib/fasterer/analyzer/25_select_last_vs_reverse_detect_spec.rb
 - spec/lib/fasterer/analyzer/26_getter_vs_attr_reader_spec.rb
 - spec/lib/fasterer/analyzer/27_setter_vs_attr_writer_spec.rb
+- spec/lib/fasterer/analyzer/29_include_vs_cover_on_range_spec.rb
 - spec/lib/fasterer/analyzer/98_misc_spec.rb
 - spec/lib/fasterer/analyzer/99_exceptional_files_spec.rb
 - spec/lib/fasterer/method_call_spec.rb
@@ -289,6 +292,7 @@ test_files:
 - spec/support/analyzer/25_select_last_vs_reverse_detect.rb
 - spec/support/analyzer/26_getter_vs_attr_reader.rb
 - spec/support/analyzer/27_setter_vs_attr_writer.rb
+- spec/support/analyzer/29_include_vs_cover_on_range.rb
 - spec/support/analyzer/98_misc.rb
 - spec/support/analyzer/99_exceptional_files.rb
 - spec/support/binary_call/simple_comparison.rb
@@ -321,3 +325,4 @@ test_files:
 - spec/support/rescue_call/rescue_with_multiple_classes.rb
 - spec/support/rescue_call/rescue_with_multiple_classes_and_variable.rb
 - spec/support/rescue_call/rescue_with_variable.rb
+has_rdoc: