fasterer 0.1.9 → 0.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9166a1cbd984ee3e8af00277252f430d7efcc817
-  data.tar.gz: 35ec0f0a4953e38f0145106c3523622461e9467c
+  metadata.gz: 917099eee3733d73079d7cb3add928d81880351e
+  data.tar.gz: 8de26edcf41f8919a38dc34d16f16d796f57ca2c
 SHA512:
-  metadata.gz: 8f9774ae496a60c30b619155a53e1cf306ee1beed19e63fb601e4de2a40e3c435c0352daafeeb6d3de19ee7b9fde694d3493089cf36901197be939d80e376ca5
-  data.tar.gz: 0bac8bc68e9f4d5032d12d9dd29a8b4cc99efc59338aefe15a262590f955fb97f2af2ed4cb6b25b0502992f48cc1b4e983d54aee2879789c81b9a1c9442073e3
+  metadata.gz: 9db9bedccb3ffb027fdfce9dade3ca0ef33cd114e25c23f46491afb2bda5db1ef3af7b0e35655472a0219f4aef46acfd7545ff1270c22be23f189bc0d0662a34
+  data.tar.gz: a71ed2ece3272ec0c027b9fc2b1f625a7406073a99284b4ed2c940b96b7b9f7813b8157a65625657531bfc656f527453627c894040cb1d9c8bc0191e67b1e98f

data/lib/fasterer/method_call.rb

@@ -58,7 +58,7 @@ module Fasterer
     end
 
     def set_block_presence
-      if element.sexp_type == :iter
+      if element.sexp_type == :iter || (arguments.last && arguments.last.type == :block_pass)
         @block_present = true
       end
     end
@@ -71,9 +71,9 @@ module Fasterer
 
     # TODO: write specs for lambdas and procs
     def set_block_argument_names
-      @block_argument_names = if has_block? and element[2].is_a?(Sexp) # hack for lambdas
-        element[2].drop(1).map { |argument| argument }
-      end || []
+      @block_argument_names = if has_block? && element[2].is_a?(Sexp) # hack for lambdas
+                                element[2].drop(1).map { |argument| argument }
+                              end || []
     end
   end
 
@@ -102,7 +102,6 @@ module Fasterer
   end
 
   class Argument
-
     attr_reader :element
 
     def initialize(element)

data/lib/fasterer/scanners/method_call_scanner.rb

@@ -83,6 +83,8 @@ module Fasterer
       when :shuffle
         add_offense(:shuffle_first_vs_sample)
       when :select
+        return unless method_call.receiver.has_block?
+
         add_offense(:select_first_vs_detect)
       end
     end

data/lib/fasterer/version.rb

@@ -1,3 +1,3 @@
 module Fasterer
-  VERSION = '0.1.9'
+  VERSION = '0.1.10'
 end

data/spec/lib/fasterer/analyzer/12_select_first_vs_detect_spec.rb

@@ -7,6 +7,6 @@ describe Fasterer::Analyzer do
   it 'should detect sort once' do
     analyzer = Fasterer::Analyzer.new(test_file_path)
     analyzer.scan
-    expect(analyzer.errors[:select_first_vs_detect].count).to eq(2)
+    expect(analyzer.errors[:select_first_vs_detect].count).to eq(3)
   end
 end

data/spec/lib/fasterer/method_call_spec.rb

@@ -466,6 +466,19 @@ describe Fasterer::MethodCall do
 
   end
 
+  describe 'method call with symbol to proc argument' do
+    let(:code) { '[].select(&:zero?)' }
+
+    let(:call_element) { ripper }
+
+    it 'should detect block pass argument' do
+      expect(method_call.method_name).to eq(:select)
+      expect(method_call.arguments.count).to eq(1)
+      expect(method_call.arguments[0].type).to eq(:block_pass)
+      expect(method_call.has_block?).to be
+    end
+  end
+
   describe 'method call with equals operator' do
 
     let(:code) { 'method_call_with_equals.rb' }

data/spec/support/analyzer/12_select_first_vs_detect.rb

@@ -5,3 +5,7 @@ ARRAY.select { |x| x.eql?(15) }.first
 ARRAY.select do |x|
   x.eql?(15)
 end.first
+
+ARRAY.select(&:zero?).first
+
+ActiveRecordRelation.new.select('name').first

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fasterer
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.1.10
 platform: ruby
 authors:
 - Damir Svrtan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-09 00:00:00.000000000 Z
+date: 2015-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -321,4 +321,3 @@ test_files:
 - spec/support/rescue_call/rescue_with_multiple_classes.rb
 - spec/support/rescue_call/rescue_with_multiple_classes_and_variable.rb
 - spec/support/rescue_call/rescue_with_variable.rb
-has_rdoc: