fast_xlsx 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5115d5bf58c96ec3a87ab9168e954b77d2360cac3314c049efd8bed45feb634a
-  data.tar.gz: 6ecf4642347e56626a0508acd2784cd6773f4be9ab52f3c4ede1da48031e57e1
+  metadata.gz: f530f027eb2e902f4bed36fdfd75af2851ff93a9762915a56f9de3e966eab593
+  data.tar.gz: 794ddb87412acfa82840681a9caf32f85eb0d5b47fc0921c7091f3bbde020677
 SHA512:
-  metadata.gz: d95432cd98346cc8339c20f71c14839325e2236f43b05180960125764eb4dbff1fe434b1acf00919425b8be613e00b8fc318e548f5e4359450f9119f12cab205
-  data.tar.gz: 2e2563be474cd5613a713f680c433a8e35186423d367004b4c02afa02905859cc139fc1efd762da66b04d748f3b1c3404def56bedb3b5c86cc0c8c3ecc4f2041
+  metadata.gz: 915d233e6c422187d23853c1c521bdefbf3336d85af03574882dc14a8055b1f692e3044588281c33c94e451be5123f516c4b07e2596111782c2b2a1f68fa261a
+  data.tar.gz: 98aa0c5de0d29816828a8fe6215c5132b7bd88297ed13bf6db9df9ddd6f0221e27f7a804a082e4430daffbb235193f1c85ffb898f41f6fee94940625d0caabb2

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 ## [Unreleased]
 
+## [0.8.1] - 2026-10-03
+
+### Fixed
+
+- Rails' `ActiveSupport::TimeWithZone` (e.g. `created_at`) and other objects that act like a `Time` without being one were written as text; they are dates now.
+
+### Changed
+
+- Writing `Time` values is about 25% faster (read through Ruby's C API instead of method calls), and `Date` values a little faster.
+
 ## [0.8.0] - 2026-10-02
 
 ### Changed

data/README.md

@@ -370,7 +370,7 @@ Values are mapped by type:
 |---|---|
 | `Integer`, `Float`, any `Numeric` | number |
 | `String` | string |
-| `Time`, `DateTime` | date and time (`yyyy-mm-dd hh:mm:ss` unless formatted), in its own offset |
+| `Time`, `DateTime`, time-like objects such as Rails' `ActiveSupport::TimeWithZone` | date and time (`yyyy-mm-dd hh:mm:ss` unless formatted), in its own offset |
 | `Date` | date (`yyyy-mm-dd` unless formatted) |
 | `FastXlsx::Formula.new("SUM(A1:A9)")` | formula |
 | `FastXlsx::URL.new("https://…")`, `URL.new(url, text: "Title")` | hyperlink (optionally showing other text) |

data/bench/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    fast_xlsx (0.8.0)
+    fast_xlsx (0.8.1)
       rb_sys (~> 0.9.130)
 
 GEM
@@ -77,7 +77,7 @@ DEPENDENCIES
 CHECKSUMS
   caxlsx (4.5.0) sha256=e3d98d859f148df05d5462086b5079b523f29c1766b569535f1d68629ce743ff
   fast_excel (0.5.0) sha256=59c418bdcf586a6030798d4e3a9f575742badaceaf7bb90f38eee5feb5bdc478
-  fast_xlsx (0.8.0)
+  fast_xlsx (0.8.1)
   ffi (1.17.4-aarch64-linux-gnu) sha256=b208f06f91ffd8f5e1193da3cae3d2ccfc27fc36fba577baf698d26d91c080df
   ffi (1.17.4-aarch64-linux-musl) sha256=9286b7a615f2676245283aef0a0a3b475ae3aae2bb5448baace630bb77b91f39
   ffi (1.17.4-arm-linux-gnu) sha256=d6dbddf7cb77bf955411af5f187a65b8cd378cb003c15c05697f5feee1cb1564

data/ext/fast_xlsx/Cargo.toml

@@ -10,7 +10,7 @@ publish = false
 crate-type = ["cdylib"]
 
 [dependencies]
-magnus = "0.9"
+magnus = { version = "0.9", features = ["rb-sys"] }
 rb-sys = { version = "0.9", features = ["stable-api-compiled-fallback"] }
 # No "zlib" feature: without it zip compresses with zlib-rs, which saves
 # 20-30% faster than the system zlib (and needs no C library).

data/ext/fast_xlsx/src/lib.rs

@@ -328,7 +328,29 @@ fn excel_serial(days: f64) -> Result<f64, Error> {
 }
 
 // Time: seconds since 1970-01-01 (serial day 25569), in its own offset.
+// For a Time (checked by the caller): Ruby's C functions, with no method calls,
+// since this runs once per cell.
 fn excel_time(v: Value) -> Result<f64, Error> {
+    use magnus::rb_sys::{protect, AsRawValue, FromRawValue};
+    // Both can raise (a Time out of range or uninitialized, or a zone object
+    // whose Ruby code fails), so they run under protect: a raise becomes an
+    // Err instead of a longjmp over these Rust frames.
+    let mut spec = None;
+    protect(|| {
+        // SAFETY: protect catches anything this raises.
+        spec = Some(unsafe { rb_sys::rb_time_timespec(v.as_raw()) });
+        rb_sys::Qnil as rb_sys::VALUE
+    })?;
+    // SAFETY: as above.
+    let offset = protect(|| unsafe { rb_sys::rb_time_utc_offset(v.as_raw()) })?;
+    let (spec, offset) = (spec.unwrap(), unsafe { Value::from_raw(offset) });
+    let secs = spec.tv_sec as f64 + spec.tv_nsec as f64 / 1e9;
+    excel_serial((secs + i64::try_convert(offset)? as f64) / 86400.0 + 25569.0)
+}
+
+// Something that acts like a Time without being one at the C level, such as
+// Rails' ActiveSupport::TimeWithZone (it delegates to a Time).
+fn excel_time_like(v: Value) -> Result<f64, Error> {
     let secs: f64 = v.funcall("to_f", ())?;
     let offset: i64 = v.funcall("utc_offset", ())?;
     excel_serial((secs + offset as f64) / 86400.0 + 25569.0)
@@ -336,9 +358,14 @@ fn excel_time(v: Value) -> Result<f64, Error> {
 
 // Date / DateTime: Julian day and day fraction are both in the object's own
 // offset. JD 2415019 is 1899-12-30.
-fn excel_date(v: Value) -> Result<f64, Error> {
+// `time`: a DateTime, with a time of day; a Date's day fraction is always 0.
+fn excel_date(v: Value, time: bool) -> Result<f64, Error> {
     let jd: i64 = v.funcall("jd", ())?;
-    let fraction: f64 = f64::try_convert(v.funcall("day_fraction", ())?)?;
+    let fraction = if time {
+        f64::try_convert(v.funcall("day_fraction", ())?)?
+    } else {
+        0.0
+    };
     excel_serial((jd - 2_415_019) as f64 + fraction)
 }
 
@@ -413,7 +440,10 @@ impl CellValue {
             CellValue::Rich(parts)
         } else if v.respond_to("jd", false)? {
             // Date has no #hour; DateTime does.
-            CellValue::Date(excel_date(v)?, v.respond_to("hour", false)?)
+            let time = v.respond_to("hour", false)?;
+            CellValue::Date(excel_date(v, time)?, time)
+        } else if v.respond_to("utc_offset", false)? && v.respond_to("to_f", false)? {
+            CellValue::Date(excel_time_like(v)?, true)
         } else {
             CellValue::Text(v.funcall("to_s", ())?)
         };

data/lib/fast_xlsx/version.rb

@@ -2,5 +2,5 @@
 
 module FastXlsx
   # The gem version.
-  VERSION = "0.8.0"
+  VERSION = "0.8.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fast_xlsx
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Zac