fast_jsonapi 1.0.16 → 1.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b3264df8a99356f622a1ae64d3342b4053db4034
-  data.tar.gz: ff8f3b5f94425a792ea7e91ae71a03e37e329187
+  metadata.gz: c5fa6a70751601bec882ccec2e0e70b3b76fd084
+  data.tar.gz: 307516586bee4df357afb385ee89776bc118cd13
 SHA512:
-  metadata.gz: 2f360b1b12b52ea8655592613fbce505d8fe79c2458ee58d2ae1e6e17f30ece72f6c9781f3dd116b1e4ddbada91f2abb36bda960c8c09ff83ba54441b089a0db
-  data.tar.gz: 596aa63a06c578396193f55fbefaeb69c957632ad90efe270213c1fa345114fea0c2fddec419aa9b2459a09ea4ba93a03e87874995ebec5cf247b9747bd16a0c
+  metadata.gz: 982f868f471f0ad64e8d424ba3fe1313f0c14ee841b87ce8920d68816ef8d306f18b5b39be13eaffdf7c00ed888be3059195c7008f8541dfeefe2036ebd4c1ad
+  data.tar.gz: 27aef6f9b9e7fb5b94f881c190814dcc7d44d6919118cf732f42a77fe5bf941644bcfbef9986417926a68981d3c00bcfc35276504a0294b2dd2445968b4cab1e

data/Gemfile

@@ -1,23 +1,4 @@
-# Add gem dependencies here.
-gem "activesupport", "~> 5.0"
-gem "multi_json", "~> 1.12"
-gem "oj", "~> 3.3"
+source 'https://rubygems.org'
 
-# needed to send active support notifications to skylight
-gem "skylight", "~> 1.3"
-
-# needed because of the extension/has_one.rb
-gem "activerecord", "~> 5.0"
-
-# Add dependencies to develop and test the gem here
-group :development do
-  gem "rspec", "~> 3.5.0"
-  gem "rspec-benchmark", "~> 0.3.0"
-  gem "rdoc", "~> 3.12"
-  gem "bundler", "~> 1.0"
-  gem "juwelier", "~> 2.1.0"
-  gem "simplecov", ">= 0"
-  gem "byebug"
-  gem "active_model_serializers", "~> 0.10.4"
-  gem "sqlite3", "~> 1.3"
-end
+# Specify your gem's dependencies in fast_jsonapi.gemspec
+gemspec

data/Gemfile.lock

@@ -1,3 +1,12 @@
+PATH
+  remote: .
+  specs:
+    fast_jsonapi (1.0.16)
+      activerecord (~> 5.0)
+      activesupport (~> 5.0)
+      multi_json (~> 1.12)
+      oj (~> 3.3)
+
 GEM
   remote: https://rubygems.org/
   specs:
@@ -134,13 +143,10 @@ PLATFORMS
 
 DEPENDENCIES
   active_model_serializers (~> 0.10.4)
-  activerecord (~> 5.0)
-  activesupport (~> 5.0)
   bundler (~> 1.0)
   byebug
+  fast_jsonapi!
   juwelier (~> 2.1.0)
-  multi_json (~> 1.12)
-  oj (~> 3.3)
   rdoc (~> 3.12)
   rspec (~> 3.5.0)
   rspec-benchmark (~> 0.3.0)

data/README.md

@@ -4,16 +4,16 @@
 
 A lightning fast [JSON:API](http://jsonapi.org/) serializer for Ruby Objects.
 
-# Performance Comparision
+# Performance Comparison
 
 We compare serialization times with Active Model Serializer as part of RSpec performance tests included on this library. We want to ensure that with every change on this library, serialization time is at least `25 times` faster than Active Model Serializers on up to current benchmark of 1000 records.
 
 ## Benchmark times for 250 records
 
 ```bash
-  $ rspec
-  Active Model Serializer serialized 250 records in 138.71 ms
-  Fast JSON API serialized 250 records in 3.01 ms
+$ rspec
+Active Model Serializer serialized 250 records in 138.71 ms
+Fast JSON API serialized 250 records in 3.01 ms
 ```
 
 # Table of Contents
@@ -32,8 +32,8 @@ We compare serialization times with Active Model Serializer as part of RSpec per
 
 ## Features
 
-* Declaration syntax similar to Active Model serializer
-* Support for belongs_to, has_many and has_one
+* Declaration syntax similar to Active Model Serializer
+* Support for `belongs_to`, `has_many` and `has_one`
 * Support for compound documents (included)
 * Optimized serialization of compound documents
 * Caching
@@ -48,7 +48,7 @@ gem 'fast_jsonapi'
 
 Execute:
 
-```ruby
+```bash
 $ bundle install
 ```
 
@@ -78,13 +78,13 @@ end
 ### Sample Object
 
 ```ruby
-m = Movie.new
-m.id = 232
-m.name = 'test movie'
-m.actor_ids = [1, 2, 3]
-m.owner_id = 3
-m.movie_type_id = 1
-m
+movie = Movie.new
+movie.id = 232
+movie.name = 'test movie'
+movie.actor_ids = [1, 2, 3]
+movie.owner_id = 3
+movie.movie_type_id = 1
+movie
 ```
 
 ### Object Serialization
@@ -153,15 +153,13 @@ hash = MovieSerializer.new([movie, movie], options).serializable_hash
 json_string = MovieSerializer.new([movie, movie], options).serialized_json
 ```
 
-[Output String](https://github.com/Netflix/fast_jsonapi/blob/master/docs/collection_serializer_output.md)
-
 ### Caching
 
 ```ruby
 class MovieSerializer
   include FastJsonapi::ObjectSerializer
   set_type :movie  # optional
-  cache_options enabled: true cache_length: 12.hours
+  cache_options enabled: true, cache_length: 12.hours
   attributes :name, :year
 end
 ```
@@ -171,12 +169,11 @@ end
 Option | Purpose | Example
 ------------ | ------------- | -------------
 set_type | Type name of Object | ```set_type :movie ```
-cache_options | Hash to enable caching and set cache length | ```cache_options enabled: true cache_length: 12.hours```
+cache_options | Hash to enable caching and set cache length | ```cache_options enabled: true, cache_length: 12.hours```
 id_method_name | Set custom method name to get ID of an object | ```has_many :locations, id_method_name: :place_ids ```
 object_method_name | Set custom method name to get related objects | ```has_many :locations, object_method_name: :places ```
 record_type | Set custom Object Type for a relationship | ```belongs_to :owner, record_type: :user```
 serializer | Set custom Serializer for a relationship | ```has_many :actors, serializer: :custom_actor```
-cache_options | Hash to enable caching and set cache length | ```cache_options enabled: true cache_length: 12.hours ```
 
 
 ## Contributing
@@ -190,14 +187,14 @@ rake -T
 ```
 
 ### Updating Project information
-You can update the project information of the gem by updating the [Rakefile](Rakefile). Then you need to generate a new gemspec
+You can update the project information of the gem by updating the [Rakefile](Rakefile). Then you need to generate a new gemspec:
 
 ```bash
 rake gemspec
 ```
 
 ### Running Tests
-We use rspec for testing. We have unit tests, functional tests and performance tests. To run tests use the following rake task
+We use [RSpec](http://rspec.info/) for testing. We have unit tests, functional tests and performance tests. To run tests use the following rake task:
 
 ```bash
 rake spec
@@ -209,16 +206,16 @@ rake spec
 $ rake install
 ```
 
-The install rake task builds the gem installs it. You're all
+The install rake task builds the gem and then installs it. You're all
 set if you're using [RVM](http://rvm.beginrescueend.com/), but you may
-need to run it with sudo if you have a system-installed ruby:
+need to run it with sudo if you have a system-installed Ruby:
 
 ### Bumping Version
 
 It feels good to release code. Do it, do it often. But before that, bump
 the version. Then release it. There's a few ways to update the version:
 
-```ruby
+```bash
 # version:write like before
 $ rake version:write MAJOR=0 MINOR=3 PATCH=0
 
@@ -231,3 +228,12 @@ $ rake version:bump:minor
 # bump just patch, ie 0.1.0 -> 0.1.1
 $ rake version:bump:patch
 ```
+
+---
+
+### We're Hiring!
+
+Join the Netflix Studio Engineering team and help us build gems like this!
+
+* [Senior Ruby Engineer](https://jobs.netflix.com/jobs/864893)
+* [Senior Platform Engineer](https://jobs.netflix.com/jobs/865783)

data/README.rdoc

@@ -1,18 +1,231 @@
-= fast_jsonapi
+# Fast JSON API
 
-Description goes here.
+[![NetflixOSS Lifecycle](https://img.shields.io/osslifecycle/Netflix/osstracker.svg)]()
 
-== Contributing to fast_jsonapi
- 
-* Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet.
-* Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it.
-* Fork the project.
-* Start a feature/bugfix branch.
-* Commit and push until you are happy with your contribution.
-* Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
-* Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
+A lightning fast [JSON:API](http://jsonapi.org/) serializer for Ruby Objects.
 
-== Copyright
+# Performance Comparision
 
-Copyright (c) 2017 Shishir Kakaraddi. See LICENSE.txt for
-further details.
+We compare serialization times with Active Model Serializer as part of RSpec performance tests included on this library. We want to ensure that with every change on this library, serialization time is at least `25 times` faster than Active Model Serializers on up to current benchmark of 1000 records.
+
+## Benchmark times for 250 records
+
+```bash
+  $ rspec
+  Active Model Serializer serialized 250 records in 138.71 ms
+  Fast JSON API serialized 250 records in 3.01 ms
+```
+
+# Table of Contents
+
+* [Features](#features)
+* [Installation](#installation)
+* [Usage](#usage)
+  * [Model Definition](#model-definition)
+  * [Serializer Definition](#serializer-definition)
+  * [Object Serialization](#object-serialization)
+  * [Compound Document](#compound-document)
+  * [Collection Serialization](#collection-serialization)
+  * [Caching](#caching)
+* [Contributing](#contributing)
+
+
+## Features
+
+* Declaration syntax similar to Active Model serializer
+* Support for belongs_to, has_many and has_one
+* Support for compound documents (included)
+* Optimized serialization of compound documents
+* Caching
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'fast_jsonapi'
+```
+
+Execute:
+
+```ruby
+$ bundle install
+```
+
+## Usage
+
+### Model Definition
+
+```ruby
+class Movie
+  attr_accessor :id, :name, :year, :actor_ids, :owner_id
+end
+```
+
+### Serializer Definition
+
+```ruby
+class MovieSerializer
+  include FastJsonapi::ObjectSerializer
+  set_type :movie  # optional
+  attributes :name, :year
+  has_many :actors
+  belongs_to :owner, record_type: :user
+  belongs_to :movie_type
+end
+```
+
+### Sample Object
+
+```ruby
+m = Movie.new
+m.id = 232
+m.name = 'test movie'
+m.actor_ids = [1, 2, 3]
+m.owner_id = 3
+m.movie_type_id = 1
+m
+```
+
+### Object Serialization
+
+#### Return a hash
+```ruby
+hash = MovieSerializer.new(movie).serializable_hash
+```
+
+#### Return Serialized JSON
+```ruby
+json_string = MovieSerializer.new(movie).serialized_json
+```
+
+#### Serialized Output
+
+```json
+{
+  "data": {
+    "id": "232",
+    "type": "movie",
+    "attributes": {
+      "name": "test movie",
+      "year": null
+    },
+    "relationships": {
+      "actors": {
+        "data": [
+          {
+            "id": "1",
+            "type": "actor"
+          },
+          {
+            "id": "2",
+            "type": "actor"
+          }
+        ]
+      },
+      "owner": {
+        "data": {
+          "id": "3",
+          "type": "user"
+        }
+      }
+    }
+  }
+}
+
+```
+### Compound Document
+
+Support for top-level included member through ` options[:include] `.
+
+```ruby
+options = {}
+options[:meta] = { total: 2 }
+options[:include] = [:actors]
+MovieSerializer.new([movie, movie], options).serialized_json
+```
+
+### Collection Serialization
+
+```ruby
+options[:meta] = { total: 2 }
+hash = MovieSerializer.new([movie, movie], options).serializable_hash
+json_string = MovieSerializer.new([movie, movie], options).serialized_json
+```
+
+### Caching
+
+```ruby
+class MovieSerializer
+  include FastJsonapi::ObjectSerializer
+  set_type :movie  # optional
+  cache_options enabled: true cache_length: 12.hours
+  attributes :name, :year
+end
+```
+
+### Customizable Options
+
+Option | Purpose | Example
+------------ | ------------- | -------------
+set_type | Type name of Object | ```set_type :movie ```
+cache_options | Hash to enable caching and set cache length | ```cache_options enabled: true cache_length: 12.hours```
+id_method_name | Set custom method name to get ID of an object | ```has_many :locations, id_method_name: :place_ids ```
+object_method_name | Set custom method name to get related objects | ```has_many :locations, object_method_name: :places ```
+record_type | Set custom Object Type for a relationship | ```belongs_to :owner, record_type: :user```
+serializer | Set custom Serializer for a relationship | ```has_many :actors, serializer: :custom_actor```
+cache_options | Hash to enable caching and set cache length | ```cache_options enabled: true cache_length: 12.hours ```
+
+
+## Contributing
+
+This gem is built using a gem building gem called [juwelier](https://github.com/flajann2/juwelier).
+
+Beyond just editing source code, you’ll be interacting with the gem using rake a lot. To see all the tasks available with a brief description, you can run:
+
+```bash
+rake -T
+```
+
+### Updating Project information
+You can update the project information of the gem by updating the [Rakefile](Rakefile). Then you need to generate a new gemspec
+
+```bash
+rake gemspec
+```
+
+### Running Tests
+We use rspec for testing. We have unit tests, functional tests and performance tests. To run tests use the following rake task
+
+```bash
+rake spec
+```
+
+### Installation
+
+```bash
+$ rake install
+```
+
+The install rake task builds the gem installs it. You're all
+set if you're using [RVM](http://rvm.beginrescueend.com/), but you may
+need to run it with sudo if you have a system-installed ruby:
+
+### Bumping Version
+
+It feels good to release code. Do it, do it often. But before that, bump
+the version. Then release it. There's a few ways to update the version:
+
+```ruby
+# version:write like before
+$ rake version:write MAJOR=0 MINOR=3 PATCH=0
+
+# bump just major, ie 0.1.0 -> 1.0.0
+$ rake version:bump:major
+
+# bump just minor, ie 0.1.0 -> 0.2.0
+$ rake version:bump:minor
+
+# bump just patch, ie 0.1.0 -> 0.1.1
+$ rake version:bump:patch
+```

data/VERSION

@@ -1 +1 @@
-1.0.16
+1.0.17

data/fast_jsonapi.gemspec

@@ -6,7 +6,7 @@
 
 Gem::Specification.new do |s|
   s.name = "fast_jsonapi"
-  s.version = "1.0.16"
+  s.version = "1.0.17"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.metadata = { "allowed_push_host" => "https://rubygems.org" } if s.respond_to? :metadata=
@@ -61,8 +61,8 @@ Gem::Specification.new do |s|
       s.add_runtime_dependency(%q<activesupport>, ["~> 5.0"])
       s.add_runtime_dependency(%q<multi_json>, ["~> 1.12"])
       s.add_runtime_dependency(%q<oj>, ["~> 3.3"])
-      s.add_runtime_dependency(%q<skylight>, ["~> 1.3"])
       s.add_runtime_dependency(%q<activerecord>, ["~> 5.0"])
+      s.add_development_dependency(%q<skylight>, ["~> 1.3"])
       s.add_development_dependency(%q<rspec>, ["~> 3.5.0"])
       s.add_development_dependency(%q<rspec-benchmark>, ["~> 0.3.0"])
       s.add_development_dependency(%q<rdoc>, ["~> 3.12"])

data/lib/fast_jsonapi/object_serializer.rb

@@ -4,22 +4,30 @@ require 'active_support/inflector'
 require 'oj'
 require 'multi_json'
 require 'fast_jsonapi/serialization_core'
-require 'skylight'
+
+begin
+  require 'skylight'
+  SKYLIGHT_ENABLED = true
+rescue LoadError
+  SKYLIGHT_ENABLED = false
+end
 
 module FastJsonapi
   module ObjectSerializer
     extend ActiveSupport::Concern
     include SerializationCore
 
-    # Skylight integration
-    # To remove Skylight
-    # Remove the included do block
-    # Remove the Gemfile entry
     included do
-      include Skylight::Helpers
-
-      instrument_method :serializable_hash
-      instrument_method :to_json
+      # Skylight integration
+      # To remove Skylight
+      # Remove the included do block
+      # Remove the Gemfile entry
+      if SKYLIGHT_ENABLED
+        include Skylight::Helpers
+
+        instrument_method :serializable_hash
+        instrument_method :to_json
+      end
 
       # Set record_type based on the name of the serializer class
       set_type default_record_type if default_record_type

data/lib/fast_jsonapi/serialization_core.rb

@@ -13,7 +13,6 @@ module FastJsonapi
                       :record_type,
                       :cache_length,
                       :cached
-                      :record_type
       end
     end
 

data/spec/lib/extensions/active_record_spec.rb

@@ -62,6 +62,6 @@ describe 'active record' do
 
   # Clean up DB
   after(:all) do
-    File.delete(@db_file) if File.exists?(@db_file)
+    File.delete(@db_file) if File.exist?(@db_file)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fast_jsonapi
 version: !ruby/object:Gem::Version
-  version: 1.0.16
+  version: 1.0.17
 platform: ruby
 authors:
 - Shishir Kakaraddi
@@ -55,33 +55,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.3'
 - !ruby/object:Gem::Dependency
-  name: skylight
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: skylight
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
-  type: :runtime
+        version: '1.3'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement