fast_attributes 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4e11ae0723fe233d262a2072024c6a0c8a28eb85
-  data.tar.gz: 13ab026b7a65d4ca20222a76eea7efacdd74e096
+  metadata.gz: 9ba4ff16c6d56690494729bcb81f3af0b2ba1791
+  data.tar.gz: 04f39c4dd270fd4b89d5401ab09bd136d2a1829f
 SHA512:
-  metadata.gz: 425b0d00dbeb0f30d5de690f8a2caedd0940b8752b4028a3b88528591a807e683eee65620f6514ecefda59c468d01c6cbc57b80cdc5dac5d12a4779eae45220b
-  data.tar.gz: 20c0977d3c65e843a45749df83c9b197a9788519ec3eb0e703aa37a44c5c9bed22ee8ad43e3fe19ae6bc3da87a2e16d2a0fa2ce66c2a3aaac6b7b7fc433408e5
+  metadata.gz: 145edbabbec7ff5205bd2ffc554cd03764bcd869a87a4b201b55fd5788ff0b893faf5b0fd279657b65f57ff9d3b2acc9137226652c16ef2fe390fb479343671c
+  data.tar.gz: 6ad2af448a020de451358208ec55d9916e3d964837ac0db97afaceb5bc61029d717faba04dd33fc5e2aa3aaca0e7c40892e21224cb6286946ad12fd4c3cc7643

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+**0.4.0 (July 5, 2014)**
+* Allow to override generated methods
+
 **0.3.0 (July 4, 2014)**
 * Support `Float` data type
 

data/benchmarks/Gemfile

@@ -2,7 +2,7 @@ source 'https://rubygems.org'
 
 ruby '2.1.2'
 
-gem 'fast_attributes', '0.2.2'
+gem 'fast_attributes', path: '..'
 gem 'virtus',          '1.0.2'
 gem 'attrio',          '0.7.3'
 gem 'benchmark-ips',   '2.0.0'

data/benchmarks/comparison.rb

@@ -5,28 +5,26 @@ require 'attrio'
 
 ATTR_NAMES = [:attr0, :attr1, :attr2, :attr3, :attr4, :attr5, :attr6, :attr7, :attr8, :attr9]
 
-module Initializer
-  def initialize(attributes = {})
-    attributes.each do |attribute, value|
-      public_send("#{attribute}=", value)
-    end
-  end
-end
-
 class FastIntegers
   extend  FastAttributes
-  include Initializer
-  attribute *ATTR_NAMES, Integer
+  define_attributes initialize: true do
+    attribute *ATTR_NAMES, Integer
+  end
 end
 
 class AttrioIntegers
   include Attrio
-  include Initializer
   define_attributes do
     ATTR_NAMES.each do |name|
       attr name, Integer
     end
   end
+
+  def initialize(attributes = {})
+    attributes.each do |attribute, value|
+      public_send("#{attribute}=", value)
+    end
+  end
 end
 
 class VirtusIntegers

data/lib/fast_attributes/builder.rb

@@ -7,6 +7,7 @@ module FastAttributes
       @klass      = klass
       @options    = options
       @attributes = []
+      @methods    = Module.new
     end
 
     def attribute(*attributes, type)
@@ -18,23 +19,25 @@ module FastAttributes
     end
 
     def compile!
-      compile_getter!
-      compile_setter!
+      compile_getter
+      compile_setter
 
       if @options[:initialize]
-        compile_initialize!
+        compile_initialize
       end
 
       if @options[:attributes]
-        compile_attributes!
+        compile_attributes
       end
+
+      include_methods
     end
 
     private
 
-    def compile_getter!
+    def compile_getter
       each_attribute do |attribute, _|
-        @klass.class_eval <<-EOS, __FILE__, __LINE__ + 1
+        @methods.module_eval <<-EOS, __FILE__, __LINE__ + 1
           def #{attribute}  # def name
             @#{attribute}   #   @name
           end               # end
@@ -42,12 +45,12 @@ module FastAttributes
       end
     end
 
-    def compile_setter!
+    def compile_setter
       each_attribute do |attribute, type|
         type_matching  = "when #{type.name} then value"
         type_casting   = FastAttributes.get_type_casting(type) % 'value'
 
-        @klass.class_eval <<-EOS, __FILE__, __LINE__ + 1
+        @methods.module_eval <<-EOS, __FILE__, __LINE__ + 1
           def #{attribute}=(value)              # def name=(value)
             @#{attribute} = case value          #   @name = case value
                             when nil then nil   #           when nil    then nil
@@ -60,8 +63,8 @@ module FastAttributes
       end
     end
 
-    def compile_initialize!
-      @klass.class_eval <<-EOS, __FILE__, __LINE__ + 1
+    def compile_initialize
+      @methods.module_eval <<-EOS, __FILE__, __LINE__ + 1
         def initialize(attributes = {})
           attributes.each do |name, value|
             public_send("\#{name}=", value)
@@ -70,19 +73,28 @@ module FastAttributes
       EOS
     end
 
-    def compile_attributes!
+    def compile_attributes
       attributes = @attributes.flat_map(&:first)
       attributes = attributes.map do |attribute|
         "'#{attribute}' => @#{attribute}"
       end
 
-      @klass.class_eval <<-EOS, __FILE__, __LINE__ + 1
+      @methods.module_eval <<-EOS, __FILE__, __LINE__ + 1
         def attributes                # def attributes
           {#{attributes.join(', ')}}  #   {'name' => @name, ...}
         end                           # end
       EOS
     end
 
+    def include_methods
+      @methods.instance_eval <<-EOS, __FILE__, __LINE__ + 1
+        def inspect
+          'FastAttributes(#{@attributes.flat_map(&:first).join(', ')})'
+        end
+      EOS
+      @klass.send(:include, @methods)
+    end
+
     def each_attribute
       @attributes.each do |attributes, type|
         attributes.each do |attribute|

data/lib/fast_attributes/version.rb

@@ -1,3 +1,3 @@
 module FastAttributes
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/spec/fast_attributes_spec.rb

@@ -72,6 +72,13 @@ describe FastAttributes do
       expect(book.respond_to?(:finished)).to be(true)
     end
 
+    it 'is possible to override getter method' do
+      toy = Toy.new
+      expect(toy.name).to eq(' toy!')
+      toy.name = 'bear'
+      expect(toy.name).to eq('bear toy!')
+    end
+
     it 'generates setter methods' do
       book = Book.new
       expect(book.respond_to?(:title=)).to be(true)
@@ -84,6 +91,13 @@ describe FastAttributes do
       expect(book.respond_to?(:finished=)).to be(true)
     end
 
+    it 'is possible to override setter method' do
+      toy = Toy.new
+      expect(toy.price).to be(nil)
+      toy.price = 2
+      expect(toy.price).to eq(4)
+    end
+
     it 'setter methods convert values to correct datatype' do
       book = Book.new
       book.title     = 123
@@ -98,7 +112,7 @@ describe FastAttributes do
       expect(book.title).to eq('123')
       expect(book.name).to eq('456')
       expect(book.pages).to be(250)
-      expect(book.price).to be(2.55)
+      expect(book.price).to eq(2.55)
       expect(book.authors).to eq(%w[Jobs])
       expect(book.published).to eq(Date.new(2014, 6, 21))
       expect(book.sold).to eq(Time.new(2014, 6, 21, 20, 45, 15))
@@ -119,7 +133,7 @@ describe FastAttributes do
       expect(book.title).to be(title)
       expect(book.name).to be(name)
       expect(book.pages).to be(pages)
-      expect(book.price).to be(price)
+      expect(book.price).to eq(price)
       expect(book.authors).to be(authors)
       expect(book.published).to be(published)
       expect(book.sold).to be(sold)
@@ -176,6 +190,16 @@ describe FastAttributes do
         expect(reader.name).to eq('104')
         expect(reader.age).to be(23)
       end
+
+      it 'is possible to override initialize method' do
+        window = Window.new
+        expect(window.height).to be(200)
+        expect(window.width).to be(80)
+
+        window = Window.new(height: 210, width: 100)
+        expect(window.height).to be(210)
+        expect(window.width).to be(100)
+      end
     end
 
     describe 'option attributes: true' do
@@ -187,6 +211,11 @@ describe FastAttributes do
         expect(reader.attributes).to eq({'name' => nil, 'age' => nil})
       end
 
+      it 'is possible to override attributes method' do
+        window = Window.new(height: 220, width: 100)
+        expect(window.attributes).to eq({'height' => 220, 'width' => 100, 'color' => 'white'})
+      end
+
       it 'attributes method return all attributes with their values' do
         publisher = Publisher.new
         publisher.name  = 101

data/spec/fixtures/classes.rb

@@ -36,3 +36,38 @@ class Reader
     attribute :age,  Integer
   end
 end
+
+class Toy
+  extend FastAttributes
+
+  attribute :name,  String
+  attribute :price, Float
+
+  def name
+    "#{super} toy!"
+  end
+
+  def price=(value)
+    super((value.to_f + 2).to_s)
+  end
+end
+
+class Window
+  extend FastAttributes
+
+  define_attributes initialize: true, attributes: true do
+    attribute :height, Integer
+    attribute :width,  Integer
+  end
+
+  def initialize(attributes = {})
+    self.height = 200
+    self.width  = 80
+
+    super(attributes)
+  end
+
+  def attributes
+    super.merge('color' => 'white')
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fast_attributes
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Kostiantyn Stepaniuk