fashion_police 1.2.4 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a66ab079123035a99d3825847e8c4a1be7c1941e
-  data.tar.gz: 617d830178aedad41733f1161957cc1fcb43fa45
+  metadata.gz: e126b9b98346f31b6861fd50a08ddc4aa4456e0b
+  data.tar.gz: c9d9c6781d120d678a26a064d9ec9e90bcc923ad
 SHA512:
-  metadata.gz: a6a63f9927af6acd80b8a93970e87f507028c2e9c6dce4ca4797aaa69177d631a4479cefe7c2bd1c6d19fe3ab83400b86b5b0fadbacaabfefd0f4fc49f72e086
-  data.tar.gz: 4fdaee250291c225ad81f2b67d0241e668c6fa3b859d3720ede735df9e33cd272ae4acc99c565d0e343efdbaa996785ed2ee326ee4194d0e89bf8859cecf81d3
+  metadata.gz: aadd0501b0ef679dfec0b45564e4890e1ad10a355d81de5cdb51935e79682553ba2d75310a74af2937ba7d06448116919303aac3b795f6ab39d30b8e3a9c44a0
+  data.tar.gz: 8de3c35084a0ad3c7bd80fb5e252b6fe5bd5827307575fd1599606d7f72cf58f0e252584966390b53259033dc277f56c8a22b70acdb2be47a3d967e05b0313d0

data/.rubocop.yml

@@ -1,138 +1 @@
-require: rubocop-rspec
-
-AllCops:
-  TargetRubyVersion: 2.3
-  DisplayCopNames: true
-
-# Do not sort gems in Gemfile, since we are grouping them by functionality.
-Bundler/OrderedGems:
-  Enabled: false
-
-# Add a comment before each gem in Gemfile.
-Bundler/GemComment:
-  Enabled: true
-
-# Trailing commas are required on multiline method arguments.
-Style/TrailingCommaInArguments:
-  EnforcedStyleForMultiline: comma
-
-# Trailing commas are required in multiline arrays.
-Style/TrailingCommaInArrayLiteral:
-  EnforcedStyleForMultiline: comma
-
-# Trailing commas are required in multiline hashes.
-Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: comma
-
-# Allow indenting multiline chained operations.
-Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-
-# Allow empty lines around blocks in specs.
-Layout/EmptyLinesAroundBlockBody:
-  Exclude:
-    - spec/**/*
-
-# Allow not adding parentheses around blocks in DSLs.
-# E.g.:
-#     expect { … }.to change { … }
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - spec/**/*
-
-# Limit method length (default is 10).
-Metrics/MethodLength:
-  Max: 15
-
-# Limit class length (default is 100).
-Metrics/ClassLength:
-  Max: 200
-
-# Do not require `# frozen_string_literal: true` at the top of every file.
-FrozenStringLiteralComment:
-  Enabled: false
-
-# Allow ASCII comments (e.g "…").
-Style/AsciiComments:
-  Enabled: false
-
-# Do not comment the class we create, since the name should be self explanatory.
-Documentation:
-  Enabled: false
-
-# Do not verify the length of the blocks in DSLs.
-Metrics/BlockLength:
-  Exclude:
-    - "**/*/spec/**/*"
-    - lib/tasks/**/*
-    - app/admin/**/*
-    - config/routes.rb
-  ExcludedMethods:
-    - included
-
-# Allow any number of keyword arguments in methods.
-Metrics/ParameterLists:
-  CountKeywordArgs: false
-
-# Prefer `a_variable_1` to `a_variable1`.
-Naming/VariableNumber:
-  EnforcedStyle: snake_case
-
-# Prefer `== 0`, `< 0`, `> 0` to `zero?`, `negative?` or `positive?`,
-# since they don't exist before Ruby 2.3 or Rails 5 and can be ambiguous.
-Style/NumericPredicate:
-  EnforcedStyle: comparison
-
-# This cop by default assumes that `Rails.root.join('foo', 'bar')` works
-# better under Windows than `Rails.root.join('foo/bar')`.
-Rails/FilePath:
-  EnforcedStyle: slashes
-
-# Do not checks for the use of output safety calls like `html_safe` and `raw`,
-# we know what we are doing.
-Rails/OutputSafety:
-  Enabled: false
-
-# Allow `update_attribute`, we know when to use it.
-Rails/SkipsModelValidations:
-  Enabled: false
-
-# Allow creating tables without timestamps, whe know what we are doing.
-Rails/CreateTableWithTimestamps:
-  Enabled: false
-
-# Allow using `allow_any_instance_of` for stubbing.
-RSpec/AnyInstance:
-  Enabled: false
-
-# Allow `let!` to setup test data in specs.
-RSpec/LetSetup:
-  Enabled: false
-
-# Allow a nesting of up to 5 of describe/context blocks (default is 3).
-RSpec/NestedGroups:
-  Max: 5
-
-# Allow any number of expectations in an example, for performance.
-RSpec/MultipleExpectations:
-  Enabled: false
-
-# Allow using normal test doubles, since they are useful for mocking.
-RSpec/VerifiedDoubles:
-  Enabled: false
-
-# Limit example length (default is 5)
-RSpec/ExampleLength:
-  Max: 10
-
-# Prefer `change { User.count }` to `change(User, :count)`.
-RSpec/ExpectChange:
-  EnforcedStyle: block
-
-# Allow template token "%{foo}" since they are used in translation keys.
-Style/FormatStringToken:
-  EnforcedStyle: template
-
-# Prefer `->` to `lambda`.
-Style/Lambda:
-  EnforcedStyle: literal
+inherit_from: default.yml

data/CHANGELOG.md

@@ -1,8 +1,40 @@
-Rubocop Gem updates
+RuboCop Gem updates
 ===================
 
 ## Unreleased
 
+## v2.0.0
+
+Breaking change:
+- Can now inherit `Exclude` directives. For that you need to change your
+  `.rubocop.yml`:
+
+    Replace:
+
+    ```yml
+    inherit_gem:
+      fashion_police:
+        - .rubocop.yml
+    ```
+
+    By:
+
+    ```yml
+    inherit_gem:
+      fashion_police:
+        - default.yml
+
+    inherit_mode:
+      merge:
+        - Exclude
+    ```
+
+Features:
+- Update RuboCop dependency.
+
+Fixes:
+- Disable `Rails/Delegate`.
+
 ## v1.2.4
 
 Fixes:
@@ -33,7 +65,7 @@ Fixes:
 
 Features:
 - Prefer template style for "Style/FormatStringToken"
-- Add rubocop rules for RSpec
+- Add RuboCop rules for RSpec
 
 Fixes:
 - Remove excluded files for AllCops, since they are not inherited

data/README.md

@@ -25,7 +25,11 @@ Then, add to your `.rubocop.yml`:
 ```yml
 inherit_gem:
   fashion_police:
-    - .rubocop.yml
+    - default.yml
+
+inherit_mode:
+  merge:
+    - Exclude
 ```
 
 ### Release

data/default.yml

@@ -0,0 +1,143 @@
+require: rubocop-rspec
+
+AllCops:
+  TargetRubyVersion: 2.3
+  DisplayCopNames: true
+
+# Do not sort gems in Gemfile, since we are grouping them by functionality.
+Bundler/OrderedGems:
+  Enabled: false
+
+# Add a comment before each gem in Gemfile.
+Bundler/GemComment:
+  Enabled: true
+
+# Trailing commas are required on multiline method arguments.
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
+# Trailing commas are required in multiline arrays.
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+# Trailing commas are required in multiline hashes.
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma
+
+# Allow indenting multiline chained operations.
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+# Allow empty lines around blocks in specs.
+Layout/EmptyLinesAroundBlockBody:
+  Exclude:
+    - spec/**/*
+
+# Allow not adding parentheses around blocks in DSLs.
+# E.g.:
+#     expect { … }.to change { … }
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - spec/**/*
+
+# Limit method length (default is 10).
+Metrics/MethodLength:
+  Max: 15
+
+# Limit class length (default is 100).
+Metrics/ClassLength:
+  Max: 200
+
+# Do not require `# frozen_string_literal: true` at the top of every file.
+FrozenStringLiteralComment:
+  Enabled: false
+
+# Allow ASCII comments (e.g "…").
+Style/AsciiComments:
+  Enabled: false
+
+# Do not comment the class we create, since the name should be self explanatory.
+Documentation:
+  Enabled: false
+
+# Do not verify the length of the blocks in DSLs.
+Metrics/BlockLength:
+  Exclude:
+    - "**/*/spec/**/*"
+    - lib/tasks/**/*
+    - app/admin/**/*
+    - config/routes.rb
+  ExcludedMethods:
+    - included
+
+# Allow any number of keyword arguments in methods.
+Metrics/ParameterLists:
+  CountKeywordArgs: false
+
+# Prefer `a_variable_1` to `a_variable1`.
+Naming/VariableNumber:
+  EnforcedStyle: snake_case
+
+# Prefer `== 0`, `< 0`, `> 0` to `zero?`, `negative?` or `positive?`,
+# since they don't exist before Ruby 2.3 or Rails 5 and can be ambiguous.
+Style/NumericPredicate:
+  EnforcedStyle: comparison
+
+# This cop by default assumes that `Rails.root.join('foo', 'bar')` works
+# better under Windows than `Rails.root.join('foo/bar')`.
+Rails/FilePath:
+  EnforcedStyle: slashes
+
+# Do not checks for the use of output safety calls like `html_safe` and `raw`,
+# we know what we are doing.
+Rails/OutputSafety:
+  Enabled: false
+
+# Allow `update_attribute`, we know when to use it.
+Rails/SkipsModelValidations:
+  Enabled: false
+
+# Allow creating tables without timestamps, whe know what we are doing.
+Rails/CreateTableWithTimestamps:
+  Enabled: false
+
+# Do not enforce the use of `delegate`, since small methods are easier to
+# read.
+Rails/Delegate:
+  Enabled: false
+
+# Allow using `allow_any_instance_of` for stubbing.
+RSpec/AnyInstance:
+  Enabled: false
+
+# Allow `let!` to setup test data in specs.
+RSpec/LetSetup:
+  Enabled: false
+
+# Allow a nesting of up to 5 of describe/context blocks (default is 3).
+RSpec/NestedGroups:
+  Max: 5
+
+# Allow any number of expectations in an example, for performance.
+RSpec/MultipleExpectations:
+  Enabled: false
+
+# Allow using normal test doubles, since they are useful for mocking.
+RSpec/VerifiedDoubles:
+  Enabled: false
+
+# Limit example length (default is 5)
+RSpec/ExampleLength:
+  Max: 10
+
+# Prefer `change { User.count }` to `change(User, :count)`.
+RSpec/ExpectChange:
+  EnforcedStyle: block
+
+# Allow template token "%{foo}" since they are used in translation keys.
+Style/FormatStringToken:
+  EnforcedStyle: template
+
+# Prefer `->` to `lambda`.
+Style/Lambda:
+  EnforcedStyle: literal

data/fashion_police.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name = 'fashion_police'
-  spec.version = '1.2.4'
+  spec.version = '2.0.0'
   spec.authors = ['Sunny Ripert']
   spec.email = ['sunny.ripert@kisskissbankbank.com']
 
@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
 
   # Rubocop dependency to share the same version among our projects.
   # >= 0.59.0 for "Bundler/GemComment" cop.
-  spec.add_dependency 'rubocop', '>= 0.59'
+  spec.add_dependency 'rubocop', '>= 0.61.1'
 
   # RSpec rules
   spec.add_dependency 'rubocop-rspec'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fashion_police
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 2.0.0
 platform: ruby
 authors:
 - Sunny Ripert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-07 00:00:00.000000000 Z
+date: 2019-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.59'
+        version: 0.61.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.59'
+        version: 0.61.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -81,6 +81,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- default.yml
 - fashion_police.gemspec
 homepage: https://github.com/KissKissBankBank/fashion_police
 licenses: []