faraday-tracer 0.1.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5653805c639af977f9e4900d34fd90a1deee489d
-  data.tar.gz: 6ff3e871000bdc5dfdf2ac89f79cb4672c09ca04
+  metadata.gz: c62dc7fa9782e900ed0a8670f17a09d9fe6c72ff
+  data.tar.gz: b4deecc8fd5c8d17db0e553852a84457885f5ad3
 SHA512:
-  metadata.gz: 96d66a7f438c6c9b3a70ddd3ff59c3702f7cbae5324d1efaac2e270643b5ca1aee2afde3b1cbaa229467a130da55beec354c085fa735148975ff435c6c4439a8
-  data.tar.gz: 28f0f92cdb6e8d13df6d7ee2257ac5bef8c24027612d647edc79cf25690c262d49a18a1f87a96ddb98a5081e706747777acd2467345ae050be861bcce6139eb1
+  metadata.gz: 8eb062c0f11493e4ea7fcf8da004826ede0d552ee6f4ff1a859f8cc9a654d558bf3072520ee2ab340306b0c504d277782a9516f7bb3d5913d8c365f0b0002e7e
+  data.tar.gz: e8a902373253201fd282e9f06869f6dc567bf35fe5db8b440e0955ef29d6c07ae6196f8e8103aa1b2906c82ae2d1c9d30a57798df8460e2212616b2da8c536d7

data/README.md

@@ -40,7 +40,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/salemove/faraday-tracer.
+Bug reports and pull requests are welcome on GitHub at https://github.com/opentracing-contrib/ruby-faraday-tracer.
 
 
 ## License

data/faraday-tracer.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'faraday-tracer'
-  spec.version       = '0.1.3'
+  spec.version       = '0.2.0'
   spec.authors       = ['SaleMove TechMovers']
   spec.email         = ['techmovers@salemove.com']
 

data/lib/faraday/tracer.rb

@@ -3,15 +3,26 @@ require 'opentracing'
 
 module Faraday
   class Tracer < Faraday::Middleware
-    def initialize(app, span: nil, tracer: OpenTracing.global_tracer)
+    # Create a new Faraday Tracer middleware.
+    #
+    # @param app The faraday application/middlewares stack.
+    # @param span [Span, SpanContext, Proc, nil] SpanContext that acts as a parent to
+    #        the newly-started by the middleware Span. If a Proc is provided, its
+    #        evaluated during the call method invocation.
+    # @param tracer [OpenTracing::Tracer] A tracer to be used when start_span, and inject
+    #        is called.
+    # @param errors [Array<Class>] An array of error classes to be captured by the tracer
+    #        as errors. Errors are **not** muted by the middleware.
+    def initialize(app, span: nil, tracer: OpenTracing.global_tracer, errors: [StandardError])
       super(app)
       @tracer = tracer
       @parent_span = span
+      @errors = errors
     end
 
     def call(env)
       span = @tracer.start_span(env[:method].to_s.upcase,
-        child_of: @parent_span,
+        child_of: @parent_span.respond_to?(:call) ? @parent_span.call : @parent_span,
         tags: {
           'component' => 'faraday',
           'span.kind' => 'client',
@@ -22,8 +33,13 @@ module Faraday
       @tracer.inject(span.context, OpenTracing::FORMAT_RACK, env[:request_headers])
       @app.call(env).on_complete do |response|
         span.set_tag('http.status_code', response.status)
-        span.finish
       end
+    rescue *@errors => e
+      span.set_tag('error', true)
+      span.log(event: 'error', :'error.object' => e)
+      raise
+    ensure
+      span.finish
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faraday-tracer
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
 platform: ruby
 authors:
 - SaleMove TechMovers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-27 00:00:00.000000000 Z
+date: 2017-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opentracing