faraday-http-cache 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 591c5305967c1a77f52be280ad1c2b31f8b6c1d5
-  data.tar.gz: b7a40463bdffe22b23ad0a602b225f1df3041bd8
+  metadata.gz: 942379737f4eb3fb24ad2aee9663f11f0a9a0e6a
+  data.tar.gz: 26bea5cb199a05a64c86bc10db16439fd44351fe
 SHA512:
-  metadata.gz: 20567be380e251d4c16d9b3ba1a3f15feca47c1d3f2130f2f262c0e42c07180bd92179c71ae812dbedf44c779af4ade72c7a1fdaaccab706b876e917d4e477b5
-  data.tar.gz: 1d2c5ab40e991aa6acd2862d40f2fb44ca0741c4f0c708f7751805340bc941cbeda505d07be1d021b8375381fc952e9fbcbe4f507ad9719cfa311d5b7337139e
+  metadata.gz: e83a8ad2f7020b72a74e7932d343228648e50e68cc0c08ab18002de0fafcfff78598c34c4146ae2b2fd5fa1a1764897767f16b845bedd529886e5974b7279a61
+  data.tar.gz: 8d50e77a3a902a432f8bdafb559fc9a8f30f5904826893ea68c0bbf04b352ad4eb3620d5af228f544cb8938dc3863b4ad693a5ffc2f103d86723945e0dc7b01e

data/lib/faraday-http-cache.rb

@@ -1 +1 @@
-require 'faraday/http_cache' # rubocop:disable Style/FileName
+require 'faraday/http_cache'

data/lib/faraday/http_cache.rb

@@ -44,14 +44,14 @@ module Faraday
   #   end
   class HttpCache < Faraday::Middleware
     # Internal: valid options for the 'initialize' configuration Hash.
-    VALID_OPTIONS = [:store, :serializer, :logger, :shared_cache, :instrumenter, :instrument_name]
+    VALID_OPTIONS = [:store, :serializer, :logger, :shared_cache, :instrumenter, :instrument_name].freeze
 
-    UNSAFE_METHODS = [:post, :put, :delete, :patch]
+    UNSAFE_METHODS = [:post, :put, :delete, :patch].freeze
 
-    ERROR_STATUSES = 400..499
+    ERROR_STATUSES = (400..499).freeze
 
     # The name of the instrumentation event.
-    EVENT_NAME = 'http_cache.faraday'
+    EVENT_NAME = 'http_cache.faraday'.freeze
 
     CACHE_STATUSES = [
       # The request was not cacheable.
@@ -74,7 +74,7 @@ module Faraday
 
       # The request decided to ignore the cache.
       :bypass
-    ]
+    ].freeze
 
     # Public: Initializes a new HttpCache middleware.
     #

data/lib/faraday/http_cache/cache_control.rb

@@ -54,7 +54,7 @@ module Faraday
       def shared_max_age
         @directives['s-maxage'].to_i if @directives.key?('s-maxage')
       end
-      alias_method :s_maxage, :shared_max_age
+      alias s_maxage shared_max_age
 
       # Internal: Checks if the 'must-revalidate' directive is present.
       def must_revalidate?

data/lib/faraday/http_cache/response.rb

@@ -16,7 +16,7 @@ module Faraday
       # * 302 - 'Found'
       # * 404 - 'Not Found'
       # * 410 - 'Gone'
-      CACHEABLE_STATUS_CODES = [200, 203, 300, 301, 302, 307, 404, 410]
+      CACHEABLE_STATUS_CODES = [200, 203, 300, 301, 302, 307, 404, 410].freeze
 
       # Internal: Gets the actual response Hash (status, headers and body).
       attr_reader :payload
@@ -38,7 +38,7 @@ module Faraday
         @now = Time.now
         @payload = payload
         wrap_headers!
-        headers['Date'] ||= @now.httpdate
+        ensure_date_header!
 
         @last_modified = headers['Last-Modified']
         @etag = headers['ETag']
@@ -198,6 +198,15 @@ module Faraday
         @payload[:response_headers].update(headers) if headers
       end
 
+      # Internal: Try to parse the Date header, if it fails set it to @now.
+      #
+      # Returns nothing.
+      def ensure_date_header!
+        date
+      rescue
+        headers['Date'] = @now.httpdate
+      end
+
       # Internal: Gets the headers 'Hash' from the payload.
       def headers
         @payload[:response_headers]

data/spec/response_spec.rb

@@ -96,6 +96,14 @@ describe Faraday::HttpCache::Response do
     expect(response.date).to be
   end
 
+  it 'sets the "Date" header if is not a valid RFC 2616 compliant string' do
+    date = Time.now.httpdate
+    headers = { 'Date' => "#{date}, #{date}" }
+    response = Faraday::HttpCache::Response.new(response_headers: headers)
+
+    expect(response.date).to be
+  end
+
   it 'the response is not modified if the status code is 304' do
     response = Faraday::HttpCache::Response.new(status: 304)
     expect(response).to be_not_modified

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faraday-http-cache
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Lucas Mazza
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-24 00:00:00.000000000 Z
+date: 2016-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday