faraday-client_error_handling 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e41fa10ec11afe25ed9889c06b9bb2cd363bb94a
-  data.tar.gz: da41aad11e5618ef5aa929693a559a0b4c464c57
+  metadata.gz: d1498ad2458223369fdfe123da8c2b5725eff5aa
+  data.tar.gz: dc16f39b2544edac98e3229e0f5e335210a18a71
 SHA512:
-  metadata.gz: bbcd9197ad06dff73a721b73e850f3fbe81867ebea0e4cf92dc1575323c1210365ed2bced9466efb62cb3d3374f3bb33946f40ff626bbd955c63691901a5d88c
-  data.tar.gz: 65e1f89f20ac41155f6c5c6e78b24c106d04494a19f4a0941e28e8d3266152dbb4f58f8afaf88d01cd6bd34da04dbdde16cf66388e68018e14bee65bb8223ba7
+  metadata.gz: b19a0262b62a4243d2f7103befde1bcc0f44e224585d9727ad38b9ec0bb7390b62e70c312e51ec039ba822e93a4176d1c53ab1c81d71e0405380de8a80b790bc
+  data.tar.gz: 1d01464ceadba73d2965f05dc4dc4fc838b24eb071ac765283ce18fb7e9da4dd628cbe480cfa962a508ece2ae7b3b9471c75feab20d2faa7cdcebf1f71ab6a86

data/lib/faraday/client_error_handling/parser.rb

@@ -2,20 +2,28 @@ module Faraday
   module ClientErrorHandling
     class Parser < Faraday::Response::Middleware
       def on_complete(env)
-        json = MultiJson.load(env[:body], symbolize_keys: true)
+        if env[:body].size == 0
+          env[:body] = {
+            data: {},
+            errors: {},
+            metadata: {}
+          }
+        else
+          json = MultiJson.load(env[:body], symbolize_keys: true)
 
-        errors = json.delete(:errors) || {}
+          errors = json.delete(:errors) || {}
 
-        if defined?( Rails ) && !errors.empty?
-          Rails.logger.warn "SERVICE ERRORS: #{errors}"
-        end
+          if defined?( Rails ) && !errors.empty?
+            Rails.logger.warn "SERVICE ERRORS: #{errors}"
+          end
 
-        metadata = json.delete(:metadata) || {}
-        env[:body] = {
-          data: json,
-          errors: errors,
-          metadata: metadata
-        }
+          metadata = json.delete(:metadata) || {}
+          env[:body] = {
+            data: json,
+            errors: errors,
+            metadata: metadata
+          }
+        end
       end
     end
   end

data/lib/faraday/client_error_handling/version.rb

@@ -1,5 +1,5 @@
 module Faraday
   module ClientErrorHandling
-    VERSION = '0.0.2'
+    VERSION = '0.0.3'
   end
 end

data/spec/middleware/parser_spec.rb

@@ -4,9 +4,9 @@ class Rails
 end
 
 describe Faraday::ClientErrorHandling::Parser do
-  it 'logs errors in Rails land' do
-    parser = Faraday::ClientErrorHandling::Parser.new
+  let(:parser) { Faraday::ClientErrorHandling::Parser.new }
 
+  it 'logs errors in Rails land' do
     logger = double('Rails logger')
     expect(logger).to receive(:warn)
 
@@ -23,4 +23,17 @@ describe Faraday::ClientErrorHandling::Parser do
 
     parser.on_complete(env)
   end
+
+  it 'handles head responses' do
+    env = Hash.new
+    env[:body] = ''
+    parser.on_complete(env)
+
+    expect(env[:body]).to eq({
+                        data: {},
+                        errors: {},
+                        metadata: {}
+                      })
+
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faraday-client_error_handling
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Andy Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-25 00:00:00.000000000 Z
+date: 2014-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday