familia 2.0.0.pre21 → 2.0.0.pre22

data/try/features/external_identifier/external_identifier_try.rb

@@ -387,3 +387,137 @@ found_no_prefix&.id
 findable_custom.destroy! rescue nil
 findable_hyphen.destroy! rescue nil
 findable_no_prefix.destroy! rescue nil
+
+# ========================================
+# extid? Method Test Coverage
+# ========================================
+
+## extid? returns false for nil
+ExternalIdTest.extid?(nil)
+#=> false
+
+## extid? returns false for empty string
+ExternalIdTest.extid?('')
+#=> false
+
+## extid? returns false for whitespace-only string
+ExternalIdTest.extid?('   ')
+#=> false
+
+## extid? returns true for valid extid with default format
+# Valid format: ext_ prefix + exactly 25 alphanumeric characters
+ExternalIdTest.extid?('ext_0123456789abcdefghijklmno')
+#=> true
+
+## extid? returns true for valid extid with uppercase characters
+# The pattern allows [0-9a-zA-Z] for the ID part
+ExternalIdTest.extid?('ext_0123456789ABCDEFGHIJKLMNO')
+#=> true
+
+## extid? returns true for valid extid with mixed case
+ExternalIdTest.extid?('ext_0123456789AbCdEfGhIjKlMnO')
+#=> true
+
+## extid? returns true for generated extid
+obj = ExternalIdTest.new
+ExternalIdTest.extid?(obj.extid)
+#=> true
+
+## extid? returns false for wrong prefix
+ExternalIdTest.extid?('xxx_0123456789abcdefghijklmno')
+#=> false
+
+## extid? returns false for missing prefix
+ExternalIdTest.extid?('0123456789abcdefghijklmno')
+#=> false
+
+## extid? accepts ID part with 24 chars (within 20-32 range)
+ExternalIdTest.extid?('ext_0123456789abcdefghijklmn')
+#=> true
+
+## extid? accepts ID part with 26 chars (within 20-32 range)
+ExternalIdTest.extid?('ext_0123456789abcdefghijklmnop')
+#=> true
+
+## extid? returns false for ID part too short (19 chars, below minimum)
+ExternalIdTest.extid?('ext_0123456789abcdefghi')
+#=> false
+
+## extid? returns false for ID part too long (33 chars, above maximum)
+ExternalIdTest.extid?('ext_0123456789abcdefghijklmnopqrstuvw')
+#=> false
+
+## extid? returns false for invalid characters in ID (underscore)
+ExternalIdTest.extid?('ext_0123456789abcdefghij_lmno')
+#=> false
+
+## extid? returns false for invalid characters in ID (hyphen)
+ExternalIdTest.extid?('ext_0123456789abcdefghij-lmno')
+#=> false
+
+## extid? returns false for invalid characters in ID (special chars)
+ExternalIdTest.extid?('ext_0123456789abcdefghij!@#$%')
+#=> false
+
+## extid? with custom prefix format returns true for valid extid
+CustomPrefixTest.extid?('cust_0123456789abcdefghijklmno')
+#=> true
+
+## extid? with custom prefix format returns false for default prefix
+CustomPrefixTest.extid?('ext_0123456789abcdefghijklmno')
+#=> false
+
+## extid? with custom prefix format returns true for generated extid
+custom_obj = CustomPrefixTest.new
+CustomPrefixTest.extid?(custom_obj.extid)
+#=> true
+
+## extid? with hyphen format returns true for valid extid
+CustomFormatTest.extid?('ext-0123456789abcdefghijklmno')
+#=> true
+
+## extid? with hyphen format returns false for underscore format
+CustomFormatTest.extid?('ext_0123456789abcdefghijklmno')
+#=> false
+
+## extid? with hyphen format returns true for generated extid
+hyphen_obj = CustomFormatTest.new
+CustomFormatTest.extid?(hyphen_obj.extid)
+#=> true
+
+## extid? with no-prefix format returns true for valid extid
+NoPrefixFormatTest.extid?('api/0123456789abcdefghijklmno')
+#=> true
+
+## extid? with no-prefix format returns false for default format
+NoPrefixFormatTest.extid?('ext_0123456789abcdefghijklmno')
+#=> false
+
+## extid? with no-prefix format returns true for generated extid
+no_prefix_obj = NoPrefixFormatTest.new
+NoPrefixFormatTest.extid?(no_prefix_obj.extid)
+#=> true
+
+## extid? returns false for partial match at start
+ExternalIdTest.extid?('ext_0123456789abcdefghijklmno_extra')
+#=> false
+
+## extid? returns false for partial match with leading chars
+ExternalIdTest.extid?('prefix_ext_0123456789abcdefghijklmno')
+#=> false
+
+## extid? returns false for spaces in ID
+ExternalIdTest.extid?('ext_0123456789 bcdefghijklmno')
+#=> false
+
+## extid? returns false for just the prefix
+ExternalIdTest.extid?('ext_')
+#=> false
+
+## extid? with Symbol input (symbols support =~ matching)
+ExternalIdTest.extid?(:ext_0123456789abcdefghijklmno)
+#=> true
+
+## extid? with Symbol input returns false for invalid format
+ExternalIdTest.extid?(:invalid_symbol)
+#=> false

data/try/features/object_identifier/object_identifier_try.rb

@@ -201,3 +201,141 @@ race_obj.save                                # Save so find_by_objid can locate
 found = BasicObjectTest.find_by_objid(generated_objid)
 found && found.id == "race_test_123"
 #=> true
+
+# ========================================
+# objid? Method Test Coverage
+# ========================================
+
+## objid? returns false for nil
+BasicObjectTest.objid?(nil)
+#=> false
+
+## objid? returns false for empty string
+BasicObjectTest.objid?('')
+#=> false
+
+## objid? returns false for whitespace-only string
+BasicObjectTest.objid?('   ')
+#=> false
+
+## objid? returns true for valid UUID v7 format
+# UUID v7 format: xxxxxxxx-xxxx-7xxx-xxxx-xxxxxxxxxxxx (version char is '7')
+BasicObjectTest.objid?('01234567-89ab-7def-89ab-0123456789ab')
+#=> true
+
+## objid? returns true for generated UUID v7 objid
+obj = BasicObjectTest.new
+BasicObjectTest.objid?(obj.objid)
+#=> true
+
+## objid? returns false for UUID v4 in UUID v7 class
+# Version char is '4' instead of '7'
+BasicObjectTest.objid?('01234567-89ab-4def-89ab-0123456789ab')
+#=> false
+
+## objid? returns false for wrong version char
+BasicObjectTest.objid?('01234567-89ab-5def-89ab-0123456789ab')
+#=> false
+
+## objid? returns false for missing hyphens
+BasicObjectTest.objid?('0123456789ab7def89ab0123456789ab')
+#=> false
+
+## objid? returns false for wrong length (too short)
+BasicObjectTest.objid?('01234567-89ab-7def-89ab-012345678')
+#=> false
+
+## objid? returns false for wrong length (too long)
+BasicObjectTest.objid?('01234567-89ab-7def-89ab-0123456789abcd')
+#=> false
+
+## objid? returns false for hyphens in wrong positions
+BasicObjectTest.objid?('0123456-789ab-7def-89ab-0123456789ab')
+#=> false
+
+## objid? returns false for UUID with non-hex characters
+# Validates that all characters are valid hexadecimal digits
+BasicObjectTest.objid?('gggggggg-gggg-7ggg-gggg-gggggggggggg')
+#=> false
+
+## objid? with UUID v4 generator returns true for valid v4 format
+UuidV4Test.objid?('01234567-89ab-4def-89ab-0123456789ab')
+#=> true
+
+## objid? with UUID v4 generator returns true for generated objid
+v4_obj = UuidV4Test.new
+UuidV4Test.objid?(v4_obj.objid)
+#=> true
+
+## objid? with UUID v4 generator returns false for v7 format
+UuidV4Test.objid?('01234567-89ab-7def-89ab-0123456789ab')
+#=> false
+
+## objid? with hex generator returns true for valid hex string
+HexTest.objid?('0123456789abcdef')
+#=> true
+
+## objid? with hex generator returns true for generated hex objid
+hex_obj = HexTest.new
+HexTest.objid?(hex_obj.objid)
+#=> true
+
+## objid? with hex generator returns true for uppercase hex
+HexTest.objid?('0123456789ABCDEF')
+#=> true
+
+## objid? with hex generator returns true for mixed case hex
+HexTest.objid?('0123456789AbCdEf')
+#=> true
+
+## objid? with hex generator returns false for non-hex chars
+HexTest.objid?('0123456789ghijkl')
+#=> false
+
+## objid? with hex generator returns false for UUID format
+HexTest.objid?('01234567-89ab-7def-89ab-0123456789ab')
+#=> false
+
+## objid? with hex generator returns true for short hex
+HexTest.objid?('abc')
+#=> true
+
+## objid? with hex generator returns true for long hex
+HexTest.objid?('0123456789abcdef0123456789abcdef')
+#=> true
+
+## objid? with custom proc generator returns false (unsupported)
+CustomProcTest.objid?('custom_12345678')
+#=> false
+
+## objid? with custom proc generator returns false for any input
+CustomProcTest.objid?('anything')
+#=> false
+
+## objid? UUID validation checks position 8 for hyphen
+BasicObjectTest.objid?('01234567X89ab-7def-89ab-0123456789ab')
+#=> false
+
+## objid? UUID validation checks position 13 for hyphen
+BasicObjectTest.objid?('01234567-89abX7def-89ab-0123456789ab')
+#=> false
+
+## objid? UUID validation checks position 18 for hyphen
+BasicObjectTest.objid?('01234567-89ab-7defX89ab-0123456789ab')
+#=> false
+
+## objid? UUID validation checks position 23 for hyphen
+BasicObjectTest.objid?('01234567-89ab-7def-89abX0123456789ab')
+#=> false
+
+## objid? returns false for partial UUID match
+BasicObjectTest.objid?('01234567-89ab-7def')
+#=> false
+
+## objid? with Symbol input for UUID v7 (symbols support string comparison)
+BasicObjectTest.objid?(:'01234567-89ab-7def-89ab-0123456789ab')
+#=> true
+
+## objid? with Symbol input returns false for invalid format
+BasicObjectTest.objid?(:invalid_objid)
+#=> false

data/try/features/relationships/indexing_rebuild_try.rb

@@ -553,6 +553,9 @@ found3 = @company.find_by_badge_number("BADGE003")
 # The architecture prevents this via factory pattern, but guard provides explicit protection
 begin
   # Simulate calling rebuild_via_participation with multi-index cardinality
+  # Note: dept_index is a multi-index, so we need to use dept_index_for to get a DataType instance
+  # But for this test, we just need any HashKey-like object to pass for serialization
+  index_hashkey = @company.badge_index  # Use a valid HashKey index
   Familia::Features::Relationships::Indexing::RebuildStrategies.rebuild_via_participation(
     @company,
     RebuildTestEmployee,
@@ -560,6 +563,7 @@ begin
     :add_to_rebuild_test_company_dept_index,
     @company.employees,
     :multi,  # Wrong cardinality!
+    index_hashkey,  # Added required parameter
     batch_size: 100
   )
   "should have raised"
@@ -571,6 +575,7 @@ end
 ## Guard accepts correct cardinality (:unique)
 begin
   index_config = RebuildTestEmployee.indexing_relationships.find { |r| r.index_name == :badge_index }
+  index_hashkey = @company.badge_index  # Get the index HashKey for serialization
   Familia::Features::Relationships::Indexing::RebuildStrategies.rebuild_via_participation(
     @company,
     RebuildTestEmployee,
@@ -578,6 +583,7 @@ begin
     :add_to_rebuild_test_company_badge_index,
     @company.employees,
     :unique,  # Correct cardinality
+    index_hashkey,  # Added required parameter
     batch_size: 100
   )
   "no error"

data/try/integration/data_types/datatype_pipelines_try.rb

@@ -81,10 +81,12 @@ result = @user.scores.pipelined { |pipe| }
 #=> [true, true]
 
 ## Multiple DataType operations in single pipeline
+# Note: Raw Redis commands bypass Familia's JSON serialization.
+# Use serialize_value for values that will be looked up via Familia methods.
 result = @user.scores.pipelined do |pipe|
-  pipe.zadd(@user.scores.dbkey, 500, 'multi')
-  pipe.hset(@user.profile.dbkey, 'multi', 'pipeline')
-  pipe.sadd(@user.tags.dbkey, 'multi_tag')
+  pipe.zadd(@user.scores.dbkey, 500, @user.scores.serialize_value('multi'))
+  pipe.hset(@user.profile.dbkey, 'multi', @user.profile.serialize_value('pipeline'))
+  pipe.sadd(@user.tags.dbkey, @user.tags.serialize_value('multi_tag'))
 end
 [
   result.is_a?(MultiResult),

data/try/integration/data_types/datatype_transactions_try.rb

@@ -152,6 +152,8 @@ conn_class
 #=> "Redis::MultiConnection"
 
 ## Transaction with direct_access works correctly
+# Note: direct_access bypasses serialize_value, so raw 'true' string
+# gets parsed as JSON boolean true on retrieval (Issue #190 behavior)
 result = @user.profile.transaction do |trans_conn|
   trans_conn.hset(@user.profile.dbkey, 'status', 'active')
 
@@ -162,7 +164,7 @@ result = @user.profile.transaction do |trans_conn|
   end
 end
 [@user.profile['status'], @user.profile['verified']]
-#=> ["active", "true"]
+#=> ["active", true]
 
 ## Transaction atomicity - all commands succeed or none
 test_zset = Familia::SortedSet.new('atomic:test')
@@ -182,11 +184,13 @@ end
 #=> ["initial"]
 
 ## Nested transactions with parent-owned DataTypes work
+# Note: Raw Redis commands bypass Familia's JSON serialization.
+# Use serialize_value or check raw members for consistency.
 outer_result = @user.scores.transaction do |outer_conn|
-  outer_conn.zadd(@user.scores.dbkey, 999, 'outer_member')
+  outer_conn.zadd(@user.scores.dbkey, 999, @user.scores.serialize_value('outer_member'))
 
   inner_result = @user.tags.transaction do |inner_conn|
-    inner_conn.sadd(@user.tags.dbkey, 'nested_tag')
+    inner_conn.sadd(@user.tags.dbkey, @user.tags.serialize_value('nested_tag'))
   end
 
   inner_result.is_a?(MultiResult)
@@ -231,12 +235,14 @@ TransactionTestUser.logical_database
 #=> 2
 
 ## Multiple DataType types in single transaction
+# Note: Raw Redis commands bypass Familia's JSON serialization.
+# Use serialize_value for values that will be looked up via Familia methods.
 result = @user.scores.transaction do |conn|
   # Can operate on different DataTypes using same connection
-  conn.zadd(@user.scores.dbkey, 777, 'multi_test')
-  conn.hset(@user.profile.dbkey, 'multi', 'yes')
-  conn.sadd(@user.tags.dbkey, 'multi_tag')
-  conn.rpush(@user.activity.dbkey, 'multi_action')
+  conn.zadd(@user.scores.dbkey, 777, @user.scores.serialize_value('multi_test'))
+  conn.hset(@user.profile.dbkey, 'multi', @user.profile.serialize_value('yes'))
+  conn.sadd(@user.tags.dbkey, @user.tags.serialize_value('multi_tag'))
+  conn.rpush(@user.activity.dbkey, @user.activity.serialize_value('multi_action'))
 end
 [
   result.is_a?(MultiResult),

data/try/integration/models/customer_try.rb

@@ -73,7 +73,8 @@ Customer.find_by_id(ident).planid
 #=> true
 
 ## Customer can be added to class-level sorted set
-Customer.instances.add(@customer.identifier)
+# Note: Add the object directly so identifier extraction is consistent
+Customer.instances.add(@customer)
 Customer.instances.member?(@customer)
 #=> true
 
@@ -97,11 +98,10 @@ multi_result = @customer.destroy!
 cust = Customer.find_by_id('test@example.com')
 exists = Customer.exists?('test@example.com')
 [multi_result.results, cust.nil?, exists]
-#=> [[1, 0, 1, 1, 1, 1, 1], true, false]
+#=> [[1, 0, 1, 1, 1, 1, 1, true], true, false]
 
 ## Customer.destroy! can be called on an already destroyed object
 @customer.destroy!
-#=:> MultiResult
 #==> result.successful?
 #=*> result.results
 

data/try/unit/data_types/boolean_try.rb

@@ -3,6 +3,7 @@
 # frozen_string_literal: true
 
 # try/data_types/boolean_try.rb
+# Issue #190: Updated to reflect JSON serialization with type preservation
 
 require_relative '../../support/helpers/test_helpers'
 
@@ -10,37 +11,49 @@ Familia.debug = false
 
 @hashkey = Familia::HashKey.new 'key'
 
-## Boolean values are returned as strings, on assignment as string
+## String 'true' is stored and returned as string
 @hashkey['test'] = 'true'
 #=> "true"
 
-## Boolean values are returned as strings
+## String values are returned as strings
 @hashkey['test']
 #=> "true"
 
-## Trying to store a boolean value to a hash key raises an exception
-begin
-  @hashkey['test'] = true
-rescue Familia::NotDistinguishableError => e
-  e.message
-end
-#=> "Cannot represent true<TrueClass> as a string"
+## Boolean true is now stored with type preservation (Issue #190)
+@hashkey['bool_true'] = true
+#=> true
 
-## Boolean values are returned as strings
-@hashkey['test']
-#=> "true"
+## Boolean true is returned as TrueClass
+@hashkey['bool_true']
+#=> true
 
-## Trying to store a nil value to a hash key raises an exception
-begin
-  @hashkey['test'] = nil
-rescue Familia::NotDistinguishableError => e
-  e.message
-end
-#=> "Cannot represent <NilClass> as a string"
+## Boolean true has correct class
+@hashkey['bool_true'].class
+#=> TrueClass
 
-## The exceptions prevented the hash from being updated
-@hashkey['test']
-#=> "true"
+## Boolean false is stored with type preservation
+@hashkey['bool_false'] = false
+#=> false
+
+## Boolean false is returned as FalseClass
+@hashkey['bool_false']
+#=> false
+
+## Boolean false has correct class
+@hashkey['bool_false'].class
+#=> FalseClass
+
+## nil is stored with type preservation
+@hashkey['nil_value'] = nil
+#=> nil
+
+## nil is returned as nil
+@hashkey['nil_value']
+#=> nil
+
+## nil has correct class
+@hashkey['nil_value'].class
+#=> NilClass
 
 ## Clear the hash key
 @hashkey.delete!

data/try/unit/data_types/hash_try.rb

@@ -50,8 +50,8 @@ require_relative '../../support/helpers/test_helpers'
 @a.props.decrement 'counter', 60
 #=> 40
 
-## Familia::HashKey#values_at
+## Familia::HashKey#values_at (counter is integer from HINCRBY, others are strings)
 @a.props.values_at 'fieldA', 'counter', 'fieldC'
-#=> ['1', '40', '3']
+#=> ['1', 40, '3']
 
 @a.props.delete!