familia 2.0.0.pre19 → 2.0.0.pre22

data/try/features/external_identifier/external_identifier_try.rb

@@ -1,4 +1,6 @@
 # try/features/external_identifier/external_identifier_try.rb
+#
+# frozen_string_literal: true
 
 require_relative '../../support/helpers/test_helpers'
 
@@ -15,10 +17,28 @@ class ExternalIdTest < Familia::Horreum
   field :name
 end
 
-# Class with custom prefix
+# Class with custom format using different prefix
 class CustomPrefixTest < Familia::Horreum
   feature :object_identifier
-  feature :external_identifier, prefix: 'cust'
+  feature :external_identifier, format: 'cust_%{id}'
+  identifier_field :id
+  field :id
+  field :name
+end
+
+# Class with custom format template using hyphen separator
+class CustomFormatTest < Familia::Horreum
+  feature :object_identifier
+  feature :external_identifier, format: 'ext-%{id}'
+  identifier_field :id
+  field :id
+  field :name
+end
+
+# Class with format template without traditional prefix
+class NoPrefixFormatTest < Familia::Horreum
+  feature :object_identifier
+  feature :external_identifier, format: 'api/%{id}'
   identifier_field :id
   field :id
   field :name
@@ -77,6 +97,28 @@ custom_obj = CustomPrefixTest.new
 custom_obj.extid.start_with?('cust_')
 #==> true
 
+## Custom format with hyphen separator
+format_obj = CustomFormatTest.new
+format_obj.extid.start_with?('ext-')
+#==> true
+
+## Custom format uses hyphen not underscore
+format_obj = CustomFormatTest.new
+extid = format_obj.extid
+extid.include?('-') && !extid.include?('_')
+#==> true
+
+## Format without prefix placeholder uses literal format
+no_prefix_obj = NoPrefixFormatTest.new
+no_prefix_obj.extid.start_with?('api/')
+#==> true
+
+## Format without prefix does not include underscore
+no_prefix_obj = NoPrefixFormatTest.new
+extid = no_prefix_obj.extid
+!extid.include?('_') && !extid.include?('ext')
+#==> true
+
 ## External ID is URL-safe base-36 format
 obj = ExternalIdTest.new
 extid = obj.extid
@@ -154,13 +196,21 @@ obj1.extid != obj2.extid
 ExternalIdTest.field_types[:extid]
 #=:> Familia::Features::ExternalIdentifier::ExternalIdentifierFieldType
 
-## Feature options contain correct prefix
-ExternalIdTest.feature_options(:external_identifier)[:prefix]
-#=> "ext"
+## Feature options contain default format
+ExternalIdTest.feature_options(:external_identifier)[:format]
+#=> "ext_%{id}"
+
+## Custom prefix format options
+CustomPrefixTest.feature_options(:external_identifier)[:format]
+#=> "cust_%{id}"
 
-## Custom prefix feature options
-CustomPrefixTest.feature_options(:external_identifier)[:prefix]
-#=> "cust"
+## Custom format with hyphen options
+CustomFormatTest.feature_options(:external_identifier)[:format]
+#=> "ext-%{id}"
+
+## No traditional prefix format options
+NoPrefixFormatTest.feature_options(:external_identifier)[:format]
+#=> "api/%{id}"
 
 ## External ID is shorter than UUID objid
 obj = ExternalIdTest.new
@@ -224,3 +274,250 @@ destroy_test_obj.destroy!
 # Verify mapping was cleaned up
 ExternalIdTest.extid_lookup.key?(destroy_extid)
 #=> false
+
+# ========================================
+# Comprehensive Format Option Test Coverage
+# ========================================
+
+## Format option: default format produces ext_ prefix
+default_obj = ExternalIdTest.new
+default_obj.extid.start_with?('ext_')
+#==> true
+
+## Format option: custom format with different prefix works
+custom_prefix_obj = CustomPrefixTest.new
+custom_prefix_obj.extid.start_with?('cust_')
+#==> true
+
+## Format option: custom format with hyphen separator works
+hyphen_obj = CustomFormatTest.new
+hyphen_obj.extid.start_with?('ext-')
+#==> true
+
+## Format option: hyphen format does not contain underscore
+hyphen_obj = CustomFormatTest.new
+!hyphen_obj.extid.include?('_')
+#==> true
+
+## Format option: format without prefix works
+no_prefix_obj = NoPrefixFormatTest.new
+no_prefix_obj.extid.start_with?('api/')
+#==> true
+
+## Format option: no prefix format uses slash separator
+no_prefix_obj = NoPrefixFormatTest.new
+no_prefix_obj.extid.include?('/')
+#==> true
+
+## Format option: %{id} placeholder is properly interpolated
+obj = ExternalIdTest.new
+# The extid should not contain the literal string '%{id}'
+!obj.extid.include?('%{id}')
+#==> true
+
+## Format option: generated ID part is base36 alphanumeric
+obj = ExternalIdTest.new
+extid = obj.extid
+id_part = extid.gsub(/^ext_/, '')
+id_part.match?(/\A[0-9a-z]+\z/)
+#==> true
+
+## Format option: hyphen format ID part is base36 alphanumeric
+hyphen_obj = CustomFormatTest.new
+extid = hyphen_obj.extid
+id_part = extid.gsub(/^ext-/, '')
+id_part.match?(/\A[0-9a-z]+\z/)
+#==> true
+
+## Format option: no prefix format ID part is base36 alphanumeric
+no_prefix_obj = NoPrefixFormatTest.new
+extid = no_prefix_obj.extid
+id_part = extid.gsub(/^api\//, '')
+id_part.match?(/\A[0-9a-z]+\z/)
+#==> true
+
+## Format option: different formats produce different prefixes but same ID length
+default_obj = ExternalIdTest.new
+custom_obj = CustomPrefixTest.new
+hyphen_obj = CustomFormatTest.new
+# All should have similar length IDs (within a few characters due to prefix differences)
+default_id_len = default_obj.extid.length
+custom_id_len = custom_obj.extid.length
+hyphen_id_len = hyphen_obj.extid.length
+(default_id_len - custom_id_len).abs <= 5 && (default_id_len - hyphen_id_len).abs <= 5
+#==> true
+
+## Format option: custom formats maintain determinism
+obj = CustomPrefixTest.new
+first_extid = obj.extid
+second_extid = obj.extid
+first_extid == second_extid
+#==> true
+
+## Format option: formats work correctly with save/load cycle
+format_save_obj = CustomFormatTest.new(id: 'format_save_test', name: 'Format Save Test')
+original_extid = format_save_obj.extid
+format_save_obj.save
+loaded_obj = CustomFormatTest.new(id: 'format_save_test')
+loaded_obj.extid == original_extid
+#==> true
+
+## Format option: find_by_extid works with custom formats
+findable_custom = CustomPrefixTest.new(id: 'findable_custom', name: 'Findable Custom')
+findable_custom.save
+found_custom = CustomPrefixTest.find_by_extid(findable_custom.extid)
+found_custom&.id
+#=> "findable_custom"
+
+## Format option: find_by_extid works with hyphen format
+findable_hyphen = CustomFormatTest.new(id: 'findable_hyphen', name: 'Findable Hyphen')
+findable_hyphen.save
+found_hyphen = CustomFormatTest.find_by_extid(findable_hyphen.extid)
+found_hyphen&.id
+#=> "findable_hyphen"
+
+## Format option: find_by_extid works with no-prefix format
+findable_no_prefix = NoPrefixFormatTest.new(id: 'findable_no_prefix', name: 'Findable No Prefix')
+findable_no_prefix.save
+found_no_prefix = NoPrefixFormatTest.find_by_extid(findable_no_prefix.extid)
+found_no_prefix&.id
+#=> "findable_no_prefix"
+
+# Cleanup format test objects
+findable_custom.destroy! rescue nil
+findable_hyphen.destroy! rescue nil
+findable_no_prefix.destroy! rescue nil
+
+# ========================================
+# extid? Method Test Coverage
+# ========================================
+
+## extid? returns false for nil
+ExternalIdTest.extid?(nil)
+#=> false
+
+## extid? returns false for empty string
+ExternalIdTest.extid?('')
+#=> false
+
+## extid? returns false for whitespace-only string
+ExternalIdTest.extid?('   ')
+#=> false
+
+## extid? returns true for valid extid with default format
+# Valid format: ext_ prefix + exactly 25 alphanumeric characters
+ExternalIdTest.extid?('ext_0123456789abcdefghijklmno')
+#=> true
+
+## extid? returns true for valid extid with uppercase characters
+# The pattern allows [0-9a-zA-Z] for the ID part
+ExternalIdTest.extid?('ext_0123456789ABCDEFGHIJKLMNO')
+#=> true
+
+## extid? returns true for valid extid with mixed case
+ExternalIdTest.extid?('ext_0123456789AbCdEfGhIjKlMnO')
+#=> true
+
+## extid? returns true for generated extid
+obj = ExternalIdTest.new
+ExternalIdTest.extid?(obj.extid)
+#=> true
+
+## extid? returns false for wrong prefix
+ExternalIdTest.extid?('xxx_0123456789abcdefghijklmno')
+#=> false
+
+## extid? returns false for missing prefix
+ExternalIdTest.extid?('0123456789abcdefghijklmno')
+#=> false
+
+## extid? accepts ID part with 24 chars (within 20-32 range)
+ExternalIdTest.extid?('ext_0123456789abcdefghijklmn')
+#=> true
+
+## extid? accepts ID part with 26 chars (within 20-32 range)
+ExternalIdTest.extid?('ext_0123456789abcdefghijklmnop')
+#=> true
+
+## extid? returns false for ID part too short (19 chars, below minimum)
+ExternalIdTest.extid?('ext_0123456789abcdefghi')
+#=> false
+
+## extid? returns false for ID part too long (33 chars, above maximum)
+ExternalIdTest.extid?('ext_0123456789abcdefghijklmnopqrstuvw')
+#=> false
+
+## extid? returns false for invalid characters in ID (underscore)
+ExternalIdTest.extid?('ext_0123456789abcdefghij_lmno')
+#=> false
+
+## extid? returns false for invalid characters in ID (hyphen)
+ExternalIdTest.extid?('ext_0123456789abcdefghij-lmno')
+#=> false
+
+## extid? returns false for invalid characters in ID (special chars)
+ExternalIdTest.extid?('ext_0123456789abcdefghij!@#$%')
+#=> false
+
+## extid? with custom prefix format returns true for valid extid
+CustomPrefixTest.extid?('cust_0123456789abcdefghijklmno')
+#=> true
+
+## extid? with custom prefix format returns false for default prefix
+CustomPrefixTest.extid?('ext_0123456789abcdefghijklmno')
+#=> false
+
+## extid? with custom prefix format returns true for generated extid
+custom_obj = CustomPrefixTest.new
+CustomPrefixTest.extid?(custom_obj.extid)
+#=> true
+
+## extid? with hyphen format returns true for valid extid
+CustomFormatTest.extid?('ext-0123456789abcdefghijklmno')
+#=> true
+
+## extid? with hyphen format returns false for underscore format
+CustomFormatTest.extid?('ext_0123456789abcdefghijklmno')
+#=> false
+
+## extid? with hyphen format returns true for generated extid
+hyphen_obj = CustomFormatTest.new
+CustomFormatTest.extid?(hyphen_obj.extid)
+#=> true
+
+## extid? with no-prefix format returns true for valid extid
+NoPrefixFormatTest.extid?('api/0123456789abcdefghijklmno')
+#=> true
+
+## extid? with no-prefix format returns false for default format
+NoPrefixFormatTest.extid?('ext_0123456789abcdefghijklmno')
+#=> false
+
+## extid? with no-prefix format returns true for generated extid
+no_prefix_obj = NoPrefixFormatTest.new
+NoPrefixFormatTest.extid?(no_prefix_obj.extid)
+#=> true
+
+## extid? returns false for partial match at start
+ExternalIdTest.extid?('ext_0123456789abcdefghijklmno_extra')
+#=> false
+
+## extid? returns false for partial match with leading chars
+ExternalIdTest.extid?('prefix_ext_0123456789abcdefghijklmno')
+#=> false
+
+## extid? returns false for spaces in ID
+ExternalIdTest.extid?('ext_0123456789 bcdefghijklmno')
+#=> false
+
+## extid? returns false for just the prefix
+ExternalIdTest.extid?('ext_')
+#=> false
+
+## extid? with Symbol input (symbols support =~ matching)
+ExternalIdTest.extid?(:ext_0123456789abcdefghijklmno)
+#=> true
+
+## extid? with Symbol input returns false for invalid format
+ExternalIdTest.extid?(:invalid_symbol)
+#=> false

data/try/features/feature_dependencies_try.rb

@@ -1,4 +1,6 @@
 # try/features/feature_dependencies_try.rb
+#
+# frozen_string_literal: true
 
 require_relative '../support/helpers/test_helpers'
 

data/try/features/feature_improvements_try.rb

@@ -1,4 +1,6 @@
 # try/features/feature_improvements_try.rb
+#
+# frozen_string_literal: true
 
 require_relative '../support/helpers/test_helpers'
 

data/try/features/field_groups_try.rb

@@ -1,3 +1,5 @@
+# try/features/field_groups_try.rb
+#
 # frozen_string_literal: true
 
 # try/features/field_groups_try.rb

data/try/features/object_identifier/object_identifier_integration_try.rb

@@ -1,4 +1,6 @@
 # try/features/object_identifier/object_identifier_integration_try.rb
+#
+# frozen_string_literal: true
 
 require_relative '../../support/helpers/test_helpers'
 
@@ -19,7 +21,7 @@ end
 # Class with custom configurations for both features
 class ::CustomIntegrationTest < Familia::Horreum
   feature :object_identifier, generator: :hex
-  feature :external_identifier, prefix: 'custom'
+  feature :external_identifier, format: 'custom_%{id}'
   identifier_field :id
   field :id
   field :name
@@ -96,8 +98,9 @@ original_extid = persistence_obj.extid
 persistence_obj.save
 
 # Load from Valkey/Redis
-loaded_obj = PersistenceTest.load(id: 'persistence_test')
-#=> nil
+loaded_obj = PersistenceTest.load('persistence_test')
+loaded_obj.objid == original_objid && loaded_obj.extid == original_extid
+#==> true
 
 ## objid persists after save/load
 persistence_obj = PersistenceTest.new
@@ -169,17 +172,17 @@ opts.key?(:external_identifier)
 IntegrationTest.feature_options(:object_identifier)[:generator]
 #=> :uuid_v7
 
-## Prefix default configuration is applied correctly
-IntegrationTest.feature_options(:external_identifier)[:prefix]
-#=> "ext"
+## Format default configuration is applied correctly
+IntegrationTest.feature_options(:external_identifier)[:format]
+#=> "ext_%{id}"
 
 ## Custom generator configuration is applied correctly
 CustomIntegrationTest.feature_options(:object_identifier)[:generator]
 #=> :hex
 
-## Custom prefix configuration is applied correctly
-CustomIntegrationTest.feature_options(:external_identifier)[:prefix]
-#=> "custom"
+## Custom format configuration is applied correctly
+CustomIntegrationTest.feature_options(:external_identifier)[:format]
+#=> "custom_%{id}"
 
 ## objid is URL-safe (UUID format)
 obj = IntegrationTest.new

data/try/features/object_identifier/object_identifier_try.rb

@@ -1,4 +1,6 @@
 # try/features/object_identifier/object_identifier_try.rb
+#
+# frozen_string_literal: true
 
 require_relative '../../support/helpers/test_helpers'
 
@@ -199,3 +201,141 @@ race_obj.save                                # Save so find_by_objid can locate
 found = BasicObjectTest.find_by_objid(generated_objid)
 found && found.id == "race_test_123"
 #=> true
+
+# ========================================
+# objid? Method Test Coverage
+# ========================================
+
+## objid? returns false for nil
+BasicObjectTest.objid?(nil)
+#=> false
+
+## objid? returns false for empty string
+BasicObjectTest.objid?('')
+#=> false
+
+## objid? returns false for whitespace-only string
+BasicObjectTest.objid?('   ')
+#=> false
+
+## objid? returns true for valid UUID v7 format
+# UUID v7 format: xxxxxxxx-xxxx-7xxx-xxxx-xxxxxxxxxxxx (version char is '7')
+BasicObjectTest.objid?('01234567-89ab-7def-89ab-0123456789ab')
+#=> true
+
+## objid? returns true for generated UUID v7 objid
+obj = BasicObjectTest.new
+BasicObjectTest.objid?(obj.objid)
+#=> true
+
+## objid? returns false for UUID v4 in UUID v7 class
+# Version char is '4' instead of '7'
+BasicObjectTest.objid?('01234567-89ab-4def-89ab-0123456789ab')
+#=> false
+
+## objid? returns false for wrong version char
+BasicObjectTest.objid?('01234567-89ab-5def-89ab-0123456789ab')
+#=> false
+
+## objid? returns false for missing hyphens
+BasicObjectTest.objid?('0123456789ab7def89ab0123456789ab')
+#=> false
+
+## objid? returns false for wrong length (too short)
+BasicObjectTest.objid?('01234567-89ab-7def-89ab-012345678')
+#=> false
+
+## objid? returns false for wrong length (too long)
+BasicObjectTest.objid?('01234567-89ab-7def-89ab-0123456789abcd')
+#=> false
+
+## objid? returns false for hyphens in wrong positions
+BasicObjectTest.objid?('0123456-789ab-7def-89ab-0123456789ab')
+#=> false
+
+## objid? returns false for UUID with non-hex characters
+# Validates that all characters are valid hexadecimal digits
+BasicObjectTest.objid?('gggggggg-gggg-7ggg-gggg-gggggggggggg')
+#=> false
+
+## objid? with UUID v4 generator returns true for valid v4 format
+UuidV4Test.objid?('01234567-89ab-4def-89ab-0123456789ab')
+#=> true
+
+## objid? with UUID v4 generator returns true for generated objid
+v4_obj = UuidV4Test.new
+UuidV4Test.objid?(v4_obj.objid)
+#=> true
+
+## objid? with UUID v4 generator returns false for v7 format
+UuidV4Test.objid?('01234567-89ab-7def-89ab-0123456789ab')
+#=> false
+
+## objid? with hex generator returns true for valid hex string
+HexTest.objid?('0123456789abcdef')
+#=> true
+
+## objid? with hex generator returns true for generated hex objid
+hex_obj = HexTest.new
+HexTest.objid?(hex_obj.objid)
+#=> true
+
+## objid? with hex generator returns true for uppercase hex
+HexTest.objid?('0123456789ABCDEF')
+#=> true
+
+## objid? with hex generator returns true for mixed case hex
+HexTest.objid?('0123456789AbCdEf')
+#=> true
+
+## objid? with hex generator returns false for non-hex chars
+HexTest.objid?('0123456789ghijkl')
+#=> false
+
+## objid? with hex generator returns false for UUID format
+HexTest.objid?('01234567-89ab-7def-89ab-0123456789ab')
+#=> false
+
+## objid? with hex generator returns true for short hex
+HexTest.objid?('abc')
+#=> true
+
+## objid? with hex generator returns true for long hex
+HexTest.objid?('0123456789abcdef0123456789abcdef')
+#=> true
+
+## objid? with custom proc generator returns false (unsupported)
+CustomProcTest.objid?('custom_12345678')
+#=> false
+
+## objid? with custom proc generator returns false for any input
+CustomProcTest.objid?('anything')
+#=> false
+
+## objid? UUID validation checks position 8 for hyphen
+BasicObjectTest.objid?('01234567X89ab-7def-89ab-0123456789ab')
+#=> false
+
+## objid? UUID validation checks position 13 for hyphen
+BasicObjectTest.objid?('01234567-89abX7def-89ab-0123456789ab')
+#=> false
+
+## objid? UUID validation checks position 18 for hyphen
+BasicObjectTest.objid?('01234567-89ab-7defX89ab-0123456789ab')
+#=> false
+
+## objid? UUID validation checks position 23 for hyphen
+BasicObjectTest.objid?('01234567-89ab-7def-89abX0123456789ab')
+#=> false
+
+## objid? returns false for partial UUID match
+BasicObjectTest.objid?('01234567-89ab-7def')
+#=> false
+
+## objid? with Symbol input for UUID v7 (symbols support string comparison)
+BasicObjectTest.objid?(:'01234567-89ab-7def-89ab-0123456789ab')
+#=> true
+
+## objid? with Symbol input returns false for invalid format
+BasicObjectTest.objid?(:invalid_objid)
+#=> false

data/try/features/quantization/quantization_try.rb

@@ -1,3 +1,7 @@
+# try/features/quantization/quantization_try.rb
+#
+# frozen_string_literal: true
+
 # try/features/quantization_try.rb
 
 require_relative '../../support/helpers/test_helpers'

data/try/features/real_feature_integration_try.rb

@@ -1,4 +1,6 @@
 # try/features/real_feature_integration_try.rb
+#
+# frozen_string_literal: true
 
 require_relative '../support/helpers/test_helpers'
 

data/try/features/relationships/indexing_commands_verification_try.rb

@@ -1,5 +1,7 @@
 # try/features/relationships/indexing_commands_verification_try.rb
 #
+# frozen_string_literal: true
+
 # Verification of proper Redis command generation for indexing operations
 # This test ensures the indexing system uses proper DataType methods instead of direct Redis calls
 #