familia 2.0.0.pre19 → 2.0.0.pre22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4250fd7b94da275c6cfe9ebc7515e14fc6bead4bb25597aa5e433bf6c9368727
-  data.tar.gz: 50818f7fce2464d3a4349d4de6a1fd7992900e45d8774f6d6d40d047d71a1842
+  metadata.gz: cf37d5963fa9ae33323b70ad4eea48cfa45e91aa59ea46ecce2ac85644a9d0e2
+  data.tar.gz: 8880f7e2914b12db9a0cdcf2f741968c7c43731ef15833a921be72df19de70cd
 SHA512:
-  metadata.gz: bf19202fe2ae0176698fa3ed5b5bd5cb4c1536de2e091a0978d75d8d9964c05cf2285cbcbbdf2d8deb20500a00b83f4fc4d7091e80f08fcaa29840053788da4f
-  data.tar.gz: c7a5810d3c84cca3c8f51e7449d0049c13eae86300f4703b5af9a492329a1a1c6ff01142529351e705f527c4b4f1ad8d07b15e5280b956a3c5a4fa2971ff2b08
+  metadata.gz: 31b585405895213ee9857a66306ee2e7b60ce2f26568915571bc8c992e1169ff8589856c40253e2b8ef8081fd3805b0f32f0a769d85108a11528786621ac4440
+  data.tar.gz: 715766983ba9c44603bc8a94c240dc716130cc70cc182fd84dec1cc5b17333de32e52b1677610d62b6aba047aadada2cdf65b61867df1d3bffab08f94d8c4067

data/.github/workflows/claude-code-review.yml

@@ -2,13 +2,8 @@ name: Claude Code Review
 
 on:
   pull_request:
-    types: [opened, synchronize]
-    # Optional: Only run on specific file changes
-    # paths:
-    #   - "src/**/*.ts"
-    #   - "src/**/*.tsx"
-    #   - "src/**/*.js"
-    #   - "src/**/*.jsx"
+    types: [opened, synchronize, labeled]
+  workflow_dispatch:
 
 jobs:
   claude-review:
@@ -40,7 +35,7 @@ jobs:
           # Optional: Use sticky comments to make Claude reuse the same comment on subsequent pushes to the same PR
           use_sticky_comment: true
 
-          prompt: |
+          direct_prompt: |
             Please review this pull request and provide feedback on:
             - Code quality and best practices
             - Potential bugs or issues
@@ -54,4 +49,4 @@ jobs:
 
           # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
           # or https://docs.anthropic.com/en/docs/claude-code/sdk#command-line for available options
-          claude_args: '--allowed-tools "Bash(gh issue view:*),Bash(gh search:*),Bash(gh issue list:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"'
+          allowed_tools: "Bash(gh issue view:*),Bash(gh search:*),Bash(gh issue list:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"

data/.github/workflows/code-smells.yml

@@ -1,4 +1,4 @@
-# ..github/workflows/code-smells.yml
+# .github/workflows/code-smells.yml
 ---
 name: Code Smells
 
@@ -14,7 +14,7 @@ permissions:
   pull-requests: write # Needed to post comments on PRs
 
 jobs:
-  reek:
+  reek-analysis:
     name: Reek Code Analysis
     runs-on: ubuntu-24.04
     timeout-minutes: 5
@@ -52,7 +52,7 @@ jobs:
           echo "=== Reek analysis complete ==="
         continue-on-error: true # Don't fail the build on code smells
 
-      - name: Generate Reek report (if analysis available)
+      - name: Generate Reek report
         run: |
           echo "=== Generating detailed Reek report ==="
 
@@ -83,3 +83,64 @@ jobs:
             reek-report.html
           if-no-files-found: ignore
           retention-days: 30
+
+  additional-checks:
+    name: Additional Quality Checks
+    runs-on: ubuntu-24.04
+    timeout-minutes: 5
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.4
+          bundler-cache: true
+
+      - name: Configure Bundler for secure gem installation
+        run: |
+          bundle config set --local path 'vendor/bundle'
+          bundle config set --local deployment 'false'
+
+      - name: Install dependencies
+        run: bundle install --jobs 4 --retry 3
+
+      - name: Check for TODO/FIXME comments
+        run: |
+          echo "=== Scanning for TODO/FIXME comments ==="
+          echo "This helps track technical debt and action items."
+          echo ""
+
+          # Find TODO/FIXME comments (excluding vendor and tmp directories)
+          find . -name "*.rb" -not -path "./vendor/*" -not -path "./tmp/*" | \
+            xargs grep -Hn -i -E "(TODO|FIXME|HACK|XXX|NOTE):" 2>/dev/null | \
+            head -20 || echo "No TODO/FIXME comments found"
+        continue-on-error: true
+
+      - name: Check Ruby file syntax
+        run: |
+          echo "=== Checking Ruby syntax ==="
+          echo "Validates that all Ruby files have correct syntax."
+          echo ""
+
+          find . -name "*.rb" -not -path "./vendor/*" -not -path "./tmp/*" | \
+            while read -r file; do
+              if ! ruby -c "$file" > /dev/null 2>&1; then
+                echo "Syntax error in: $file"
+                ruby -c "$file"
+              fi
+            done
+        continue-on-error: true
+
+      - name: Check for long lines
+        run: |
+          echo "=== Checking for long lines (>120 characters) ==="
+          echo "Identifies potentially hard-to-read code lines."
+          echo ""
+
+          find . -name "*.rb" -not -path "./vendor/*" -not -path "./tmp/*" | \
+            xargs grep -Hn "^.\{121,\}$" | \
+            head -10 || echo "No overly long lines found"
+        continue-on-error: true

data/.pre-commit-config.yaml

@@ -65,13 +65,15 @@ repos:
         env:
           TALISMAN_SCAN_MODE: CI
 
-  - repo: https://github.com/avilaton/add-msg-issue-prefix-hook
-    rev: v0.0.11
+  # Commit message issue tracking integration
+  - repo: https://github.com/delano/add-msg-issue-prefix-hook
+    rev: v0.0.14-fork
     hooks:
       - id: add-msg-issue-prefix
         stages: [prepare-commit-msg]
-        name: Link commit to Github issue
+        description: Automatically prefix commits with issue numbers
         args:
-          - "--default="
-          - "--pattern=[a-zA-Z0-9]{0,10}-?[0-9]{1,5}"
-          - "--template=[#{}]"
+          - '--default='
+          - '--exclude-pattern=^(dependabot|renovate|claude)/'
+          - '--pattern=(i18n(?=/)|([a-zA-Z0-9]{0,10}-?[0-9]{1,5}))'
+          - '--template=[#{}]'

data/.reek.yml

@@ -1,10 +1,11 @@
 # .reek.yml
-# Reek configuration for Familia
+#
+# Reek configuration for Rhales
 #
 # Basic commands:
 #   bundle exec reek                           # Analyze all Ruby files
 #   bundle exec reek lib/                      # Analyze specific directory
-#   bundle exec reek lib/familia/horreum.rb    # Analyze specific file
+#   bundle exec reek lib/rhales.rb             # Analyze specific file
 #   bundle exec reek --help                    # Show all options
 #   bundle exec reek --docs                    # Open documentation
 #
@@ -60,16 +61,16 @@ detectors:
   UncommunicativeParameterName:
     enabled: true
     reject:
-      - '/^.$/' # Single letter names
-      - '/[0-9]$/' # Names ending in numbers
-      - '/^_/' # Names starting with underscore (common Ruby pattern)
+      - "/^.$/" # Single letter names
+      - "/[0-9]$/" # Names ending in numbers
+      - "/^_/" # Names starting with underscore (common Ruby pattern)
     accept: []
 
   UncommunicativeVariableName:
     enabled: true
     reject:
-      - '/^.$/' # Single letter names
-      - '/[0-9]$/' # Names ending in numbers
+      - "/^.$/" # Single letter names
+      - "/[0-9]$/" # Names ending in numbers
     accept:
       - e # Exception variable
       - id # Common identifier
@@ -80,8 +81,8 @@ detectors:
   UncommunicativeMethodName:
     enabled: true
     reject:
-      - '/^.$/' # Single letter method names
-      - '/[0-9]$/' # Methods ending in numbers
+      - "/^.$/" # Single letter method names
+      - "/[0-9]$/" # Methods ending in numbers
     accept:
       - "<<" # Common Ruby operator overload
 

data/.rubocop.yml

@@ -88,6 +88,10 @@ Layout/EndAlignment:
 Layout/FirstArgumentIndentation:
   EnforcedStyle: consistent
 
+Layout/ExtraSpacing:
+  Enabled: true
+  AllowBeforeTrailingComments: true
+
 Metrics/AbcSize:
   Enabled: false
   Max: 20

data/.talismanrc

@@ -5,5 +5,9 @@
 # https://thoughtworks.github.io/talisman/docs/configuring-talisman/severity-threshold/
 #
 threshold: medium
-fileignoreconfig: []
+fileignoreconfig:
+  - filename: try/features/external_identifier/external_identifier_try.rb
+    checksum: dcc0dd135cd8c569b096c922e6260e446d25b65b7b97b8a4cb4ccaac59325b38
+  - filename: try/features/object_identifier/object_identifier_try.rb
+    checksum: 10c94f802b2fa3a39fa33bf7dc34dac2ecaa2dd453ff97a19313f96a32fadeff
 version: ""