familia 2.0.0.pre19 → 2.0.0.pre21

data/try/features/relationships/participation_bidirectional_try.rb

@@ -0,0 +1,242 @@
+# try/features/relationships/participation_bidirectional_try.rb
+#
+# frozen_string_literal: true
+
+require_relative '../../../lib/familia'
+
+# Test demonstrating true bidirectional participation functionality
+# This shows the improvement from asymmetric to symmetric relationship access
+
+# Setup test classes
+class ::ProjectTeam < Familia::Horreum
+  feature :relationships
+
+  identifier_field :team_id
+  field :team_id
+  field :name
+  field :department
+
+  # Explicitly declare collections for participates_in
+  sorted_set :members
+  sorted_set :admins
+
+  def init
+    @team_id ||= "team_#{SecureRandom.hex(4)}"
+  end
+end
+
+class ::ProjectOrganization < Familia::Horreum
+  feature :relationships
+
+  identifier_field :org_id
+  field :org_id
+  field :name
+  field :type
+
+  # Explicitly declare collections for participates_in
+  sorted_set :employees
+  sorted_set :contractors
+
+  def init
+    @org_id ||= "org_#{SecureRandom.hex(4)}"
+  end
+end
+
+class ::ProjectUser < Familia::Horreum
+  feature :relationships
+
+  identifier_field :user_id
+  field :user_id
+  field :email
+  field :name
+  field :role
+
+  # Define bidirectional participation relationships
+  # These will auto-generate reverse collection methods with _instances suffix
+  participates_in ProjectTeam, :members          # Generates: user.project_team_instances
+  participates_in ProjectTeam, :admins           # Also adds to user.project_team_instances (union)
+  participates_in ProjectOrganization, :employees # Generates: user.project_organization_instances
+
+  # Custom reverse method name (user chooses the base name)
+  participates_in ProjectOrganization, :contractors, as: :contracting_orgs
+
+  def init
+    @user_id ||= "user_#{SecureRandom.hex(4)}"
+  end
+end
+
+# Create test data
+@user1 = ProjectUser.new(email: 'alice@example.com', name: 'Alice', role: 'developer')
+@user2 = ProjectUser.new(email: 'bob@example.com', name: 'Bob', role: 'manager')
+
+@team1 = ProjectTeam.new(name: 'Frontend Team', department: 'Engineering')
+@team2 = ProjectTeam.new(name: 'Backend Team', department: 'Engineering')
+@team3 = ProjectTeam.new(name: 'Design Team', department: 'Product')
+
+@org1 = ProjectOrganization.new(name: 'TechCorp Inc', type: 'employer')
+@org2 = ProjectOrganization.new(name: 'FreelanceCorp', type: 'contractor')
+
+# Save all objects
+[@user1, @user2, @team1, @team2, @team3, @org1, @org2].each(&:save)
+
+# Set up relationships using generated methods (automatic participation tracking)
+@team1.add_members_instance(@user1)
+@team2.add_members_instance(@user1)
+@team1.add_admins_instance(@user1)
+@org1.add_employees_instance(@user1)
+@org2.add_contractors_instance(@user1)
+
+# Set up user2 in fewer relationships
+@team3.add_members_instance(@user2)
+@org1.add_employees_instance(@user2)
+
+## Test the OLD way - difficult and verbose
+# Before: Getting teams for a user required manual parsing
+old_way_keys = @user1.participations.members.select { |k| k.start_with?("project_team:") && k.end_with?(":members") }
+old_way_ids = old_way_keys.map { |k| k.split(':')[1] }.uniq
+old_way_teams = ProjectTeam.load_multi(old_way_ids).compact
+old_way_teams.map(&:name).sort
+#=> ["Backend Team", "Frontend Team"]
+
+## Debug - Check if methods are defined
+@user1.respond_to?(:project_team_instances)
+#=> true
+
+## Debug - Check participations data
+@user1.participations.members
+#=> ["project_team:#{@team1.identifier}:members", "project_team:#{@team2.identifier}:members", "project_team:#{@team1.identifier}:admins", "project_organization:#{@org1.identifier}:employees", "project_organization:#{@org2.identifier}:contractors"]
+
+## Debug - Check if participating_ids_for_target works
+ids = @user1.participating_ids_for_target(ProjectTeam)
+ids
+#=> [@team1.identifier, @team2.identifier]
+
+## Debug - Test individual team loading
+ProjectTeam.load(@team1.identifier).name
+#=> "Frontend Team"
+
+## Debug - Test load_multi with actual IDs
+test_ids = [@team1.identifier, @team2.identifier]
+ProjectTeam.load_multi(test_ids).compact.map(&:name).sort
+#=> ["Backend Team", "Frontend Team"]
+
+## Debug - Check what project_teams method returns
+result = @user1.project_team_instances
+puts "project_teams method returns: #{result.inspect}"
+result.map(&:name).sort
+#=> ["Backend Team", "Frontend Team"]
+
+## Test NEW way - clean and intuitive reverse collection method
+user_teams = @user1.project_team_instances  # Auto-generated pluralized from ProjectTeam class name
+user_teams.map(&:name).sort
+#=> ["Backend Team", "Frontend Team"]
+
+## Test that both users and admins collections are included (union behavior)
+all_team_participations = @user1.project_team_instances  # Should include both members and admins
+all_team_participations.map(&:name).sort
+#=> ["Backend Team", "Frontend Team"]
+
+## Test IDs-only method (efficient, no object loading)
+user_team_ids = @user1.project_team_ids
+user_team_ids.sort
+#=> [@team1.identifier, @team2.identifier].sort
+
+## Test boolean check method
+@user1.project_team?
+#=> true
+
+## Test count method returns correct number
+@user1.project_team_count
+#=> 2
+
+## Test organizations (different target class)
+user_orgs = @user1.project_organization_instances
+user_orgs.map(&:name).sort
+#=> ["FreelanceCorp", "TechCorp Inc"]
+
+## Test custom reverse method name
+contracting_orgs_instances = @user1.contracting_orgs_instances
+contracting_orgs_instances.map(&:name)
+#=> ["FreelanceCorp"]
+
+## Test user with fewer relationships
+@user2.project_team_instances.map(&:name)
+#=> ["Design Team"]
+
+## Test user2 count
+@user2.project_team_count
+#=> 1
+
+## Test user2 organizations
+@user2.project_organization_instances.map(&:name)
+#=> ["TechCorp Inc"]
+
+## Test create empty user with no memberships
+@user3 = ProjectUser.new(email: 'charlie@example.com', name: 'Charlie')
+@user3.save
+@user3.project_team_instances
+#=> []
+
+## Test empty user with IDs, check and count
+@user3.project_team_ids
+#=> []
+
+## Test empty user boolean check
+@user3.project_team?
+#=> false
+
+## Test empty user count
+@user3.project_team_count
+#=> 0
+
+## Test that forward direction still works (backwards compatibility)
+@team1.members.to_a.sort
+#=> [@user1.identifier]
+
+## Test admin collection forward direction
+@team1.admins.to_a
+#=> [@user1.identifier]
+
+## Test bidirectional consistency - forward direction
+team1_member_ids = @team1.members.to_a
+team1_members = ProjectUser.load_multi(team1_member_ids).compact
+team1_members.map(&:name)
+#=> ["Alice"]
+
+## Test bidirectional consistency - reverse direction
+user1_teams = @user1.project_team_instances
+user1_team_ids = user1_teams.map(&:identifier)
+user1_team_ids.include?(@team1.identifier)
+#=> true
+
+## Test multiple users in same team - add user2
+@team1.add_members_instance(@user2)
+@team1.members.member?(@user2.identifier)
+#=> true
+
+## Test team1 now has two members
+team1_all_members = @team1.members.to_a.sort
+team1_all_members == [@user1.identifier, @user2.identifier].sort
+#=> true
+
+## Test both users show up in team1 - user1
+@user1.project_team_instances.map(&:name).include?("Frontend Team")
+#=> true
+
+## Test both users show up in team1 - user2
+@user2.project_team_instances.map(&:name).include?("Frontend Team")
+#=> true
+
+## Test cleanup - remove relationships using generated method
+@team1.remove_members_instance(@user1)
+
+## Test that removal from members is reflected (no caching)
+# User1 was removed from :members but is still in :admins
+# So they should STILL appear in project_team_instances (union behavior)
+updated_teams = @user1.project_team_instances.map(&:name).sort
+updated_teams.include?("Frontend Team")
+#=> true
+
+## Test still admin of team1 after member removal (confirms union behavior)
+@user1.project_team_instances.map(&:name).include?("Frontend Team")
+#=> true

data/try/features/relationships/participation_commands_verification_spec.rb

@@ -1,3 +1,7 @@
+# try/features/relationships/participation_commands_verification_spec.rb
+#
+# frozen_string_literal: true
+
 # Generated rspec code for /Users/d/Projects/opensource/d/familia/try/features/relationships/participation_commands_verification_try.rb
 # Updated: 2025-09-26 21:27:49 -0700
 

data/try/features/relationships/participation_commands_verification_try.rb

@@ -1,5 +1,7 @@
 # try/features/relationships/participation_commands_verification_try.rb
 #
+# frozen_string_literal: true
+
 # Based on participation reverse index functionality tests.
 # Validates participation functionality and command isolation
 #

data/try/features/relationships/participation_performance_improvements_try.rb

@@ -1,12 +1,14 @@
 # try/features/relationships/participation_performance_improvements_try.rb
 #
+# frozen_string_literal: true
+
 # Tests for performance improvements in participation functionality
 # Verifies reverse index functionality and robust type comparison
 
 require_relative '../../support/helpers/test_helpers'
 
 # Test classes for performance improvements
-class PerfTestCustomer < Familia::Horreum
+class ::PerfTestCustomer < Familia::Horreum
   feature :relationships
 
   identifier_field :customer_id
@@ -16,7 +18,7 @@ class PerfTestCustomer < Familia::Horreum
   sorted_set :domains
 end
 
-class PerfTestDomain < Familia::Horreum
+class ::PerfTestDomain < Familia::Horreum
   feature :relationships
 
   identifier_field :domain_id
@@ -51,7 +53,7 @@ end
 #=> true
 
 ## Test add domain creates reverse index tracking 1 of 2
-@customer.add_domain(@domain)
+@customer.add_domains_instance(@domain)
 @reverse_index_key = "#{@domain.dbkey}:participations"
 @tracked_collections = Familia.dbclient.smembers(@reverse_index_key) # TODO: Do not use keys directly
 @tracked_collections.length
@@ -64,13 +66,13 @@ end
 ##=> true
 
 ## Test remove domain cleans up reverse index tracking
-@customer.remove_domain(@domain)
+@customer.remove_domains_instance(@domain)
 @tracked_collections_after_remove = Familia.dbclient.smembers(@reverse_index_key) # TODO: Do not use keys directly
 @tracked_collections_after_remove.include?(@collection_key)
 ##=> false
 
 ## Test robust type comparison in score calculation works with Class
-@customer.add_domain(@domain)
+@customer.add_domains_instance(@domain)
 @score_with_class = @domain.calculate_participation_score(PerfTestCustomer, :domains)
 @score_with_class.is_a?(Numeric)
 #=> true
@@ -93,16 +95,16 @@ end
 ## Test membership contains expected target class
 @memberships = @domain.current_participations
 @membership = @memberships.first
-@membership[:target_class] == 'PerfTestCustomer'
+@membership.target_class == 'PerfTestCustomer'
 #=> true
 
 ## Test membership contains collection name
 @memberships = @domain.current_participations
-@membership[:collection_name] == :domains
+@membership.collection_name == :domains
 #=> true
 
 ## Test membership contains type information
-@membership[:type] == :sorted_set
+@membership.type == :sorted_set
 #=> true
 
 ## Test remove from all participation collections works efficiently
@@ -112,7 +114,7 @@ end
 ##=> true
 
 ## Test domain is removed from customer collection
-@customer.remove_domain(@domain)
+@customer.remove_domains_instance(@domain)
 @customer.domains.include?(@domain)
 #=> false
 

data/try/features/relationships/participation_reverse_index_try.rb

@@ -1,5 +1,7 @@
 # try/features/relationships/participation_reverse_index_try.rb
 #
+# frozen_string_literal: true
+
 # Tests for participation reverse index functionality
 # Verifies performance improvements and correct behavior
 
@@ -52,7 +54,7 @@ end
 @domain2.save
 
 ## Test reverse index tracking is created when adding to sorted set
-@customer.add_domain(@domain1)
+@customer.add_domains_instance(@domain1)
 @ri_members1 = @domain1.participations.members
 @ri_members1.is_a?(Array)
 #=> true
@@ -63,7 +65,7 @@ end
 #=> true
 
 ## Test adding to set collection also creates tracking
-@customer.add_preferred_domain(@domain1)
+@customer.add_preferred_domains_instance(@domain1)
 @ri_members1_updated = @domain1.participations.members
 @ri_members1_updated.length > 1
 #=> true
@@ -81,7 +83,7 @@ end
 #=> true
 
 ## Test multiple domains can be tracked
-@customer.add_domain(@domain2)
+@customer.add_domains_instance(@domain2)
 @ri_members2_updated = @domain2.participations.members
 @ri_members2_updated.length >= 1
 #=> true
@@ -94,8 +96,8 @@ end
 
 ## Test remove_from_all_participations uses reverse index
 # NOTE: This method was removed - cleanup happens via individual remove operations
-@customer.remove_domain(@domain1)
-@customer.remove_preferred_domain(@domain1)
+@customer.remove_domains_instance(@domain1)
+@customer.remove_preferred_domains_instance(@domain1)
 @domain1_collections_after = @domain1.participations.members
 @domain1_collections_after.empty?
 #=> true
@@ -106,7 +108,7 @@ end
 #=> false
 
 ## Test domain was removed from set
-@customer.remove_preferred_domain(@domain1)
+@customer.remove_preferred_domains_instance(@domain1)
 @customer.preferred_domains.include?(@domain1)
 #=> false
 
@@ -120,12 +122,12 @@ end
 #=> true
 
 ## Test membership includes target information
-@customer_membership = @domain2_memberships.find { |m| m[:target_id] == @customer.identifier }
-@customer_membership.is_a?(Hash) || @customer_membership.nil?
+@customer_membership = @domain2_memberships.find { |m| m.target_id == @customer.identifier }
+@customer_membership.is_a?(Familia::Features::Relationships::ParticipationMembership) || @customer_membership.nil?
 #=> true
 
 ## Test membership includes collection name
-@customer_membership && @customer_membership[:collection_name] == :domains || true
+@customer_membership && @customer_membership.collection_name == :domains || true
 #=> true
 
 ## Test score type comparison works with different types
@@ -151,7 +153,7 @@ puts "Before add_preferred_domain - domain2 participations: #{@domain2.participa
 puts "Before add_preferred_domain - domain2 in domains?: #{@customer.domains.member?(@domain2.identifier)}"
 
 # Add domain to multiple collections
-@customer.add_preferred_domain(@domain2)
+@customer.add_preferred_domains_instance(@domain2)
 
 # Debug: Check what participations we actually have after
 puts "After add_preferred_domain - domain2 participations: #{@domain2.participations.members.inspect}"
@@ -172,14 +174,14 @@ puts "Domain2 participations length: #{@domain2_final_memberships.length}"
 ## Test cleanup removes all participations
 # Manual cleanup since remove_from_all_participations was removed
 # Remove from all collections domain2 participates in
-@customer.remove_domain(@domain2)
-@customer.remove_preferred_domain(@domain2) if @customer.preferred_domains.member?(@domain2.identifier)
+@customer.remove_domains_instance(@domain2)
+@customer.remove_preferred_domains_instance(@domain2) if @customer.preferred_domains.member?(@domain2.identifier)
 @ri_members2_final = @domain2.participations.members
 @ri_members2_final.empty?
 ##=> true
 
 ## Test domain2 removed from all collections
-@customer.remove_domain(@domain2)
+@customer.remove_domains_instance(@domain2)
 @customer.domains.include?(@domain2)
 #=> false
 

data/try/features/relationships/participation_target_class_resolution_try.rb

@@ -0,0 +1,209 @@
+# try/features/relationships/participation_target_class_resolution_try.rb
+#
+# frozen_string_literal: true
+
+# Regression test for Symbol/String target class resolution in participates_in
+#
+# This test verifies the fix for the NoMethodError that occurred when
+# participates_in was called with a Symbol or String target class instead
+# of a Class object. The error was:
+#   "private method 'member_by_config_name' called for module Familia"
+#
+# See commit: Fix NoMethodError when calling private member_by_config_name
+
+require_relative '../../support/helpers/test_helpers'
+
+# Test classes for target class resolution
+# Define target class FIRST so it's registered in Familia.members
+class SymbolResolutionCustomer < Familia::Horreum
+  feature :relationships
+
+  identifier_field :customer_id
+  field :customer_id
+  field :name
+
+  sorted_set :domains
+  set :tags
+end
+
+# Participant classes using different target class formats
+class SymbolResolutionDomain < Familia::Horreum
+  feature :relationships
+
+  identifier_field :domain_id
+  field :domain_id
+  field :name
+  field :created_at
+
+  # TEST CASE 1: Symbol target class (most common case)
+  # This was causing: NoMethodError: private method 'member_by_config_name'
+  participates_in :SymbolResolutionCustomer, :domains, score: :created_at
+end
+
+class StringResolutionTag < Familia::Horreum
+  feature :relationships
+
+  identifier_field :tag_id
+  field :tag_id
+  field :name
+  field :created_at
+
+  # TEST CASE 2: String target class
+  # This was also causing the same NoMethodError
+  # Note: Customer's tags is a set (not sorted_set), so specify type: :set
+  participates_in 'SymbolResolutionCustomer', :tags, type: :set
+end
+
+class ClassResolutionItem < Familia::Horreum
+  feature :relationships
+
+  identifier_field :item_id
+  field :item_id
+  field :name
+  field :created_at
+
+  # TEST CASE 3: Class object (this always worked)
+  # Including for completeness
+  sorted_set :items
+end
+
+# Setup test data
+@customer = SymbolResolutionCustomer.new(
+  customer_id: 'symbol_res_cust_1',
+  name: 'Symbol Resolution Customer'
+)
+@domain = SymbolResolutionDomain.new(
+  domain_id: 'symbol_res_dom_1',
+  name: 'example.com',
+  created_at: Time.now.to_f
+)
+@tag = StringResolutionTag.new(
+  tag_id: 'string_res_tag_1',
+  name: 'important',
+  created_at: Time.now.to_f
+)
+
+# Ensure clean state
+[@customer, @domain, @tag].each do |obj|
+  obj.destroy if obj&.respond_to?(:destroy) && obj&.respond_to?(:exists?) && obj.exists?
+end
+
+@customer.save
+@domain.save
+@tag.save
+
+## Test Symbol target class resolution works
+# This is the primary regression test - it should not raise NoMethodError
+@customer.add_domains_instance(@domain)
+@customer.domains.member?(@domain.identifier)
+#=> true
+
+## Test domain bidirectional methods were created correctly
+@domain.respond_to?(:in_symbol_resolution_customer_domains?)
+#=> true
+
+## Test domain can check membership using generated method
+@domain.in_symbol_resolution_customer_domains?(@customer)
+#=> true
+
+## Test domain can add itself using generated method
+@customer.domains.remove(@domain)
+@domain.add_to_symbol_resolution_customer_domains(@customer)
+@customer.domains.member?(@domain.identifier)
+#=> true
+
+## Test domain score calculation works with Symbol target class
+@score = @domain.calculate_participation_score(:SymbolResolutionCustomer, :domains)
+@score.is_a?(Numeric)
+#=> true
+
+## Test domain score matches created_at field
+(@score - @domain.created_at).abs < 0.001
+#=> true
+
+## Test String target class resolution works
+# This is the secondary regression test
+@customer.add_tags_instance(@tag)
+@customer.tags.member?(@tag.identifier)
+#=> true
+
+## Test tag bidirectional methods were created correctly
+@tag.respond_to?(:in_symbol_resolution_customer_tags?)
+#=> true
+
+## Test tag can check membership using generated method
+@tag.in_symbol_resolution_customer_tags?(@customer)
+#=> true
+
+## Test tag can add itself using generated method
+@customer.tags.remove(@tag)
+@tag.add_to_symbol_resolution_customer_tags(@customer)
+@customer.tags.member?(@tag.identifier)
+#=> true
+
+## Test tag membership check works with String target class (sets don't have scores)
+@tag.in_symbol_resolution_customer_tags?(@customer)
+#=> true
+
+## Test reverse index tracking works with Symbol target class
+@domain.participations.members.length > 0
+#=> true
+
+## Test reverse index contains the correct collection key
+@domains_key = @customer.domains.dbkey
+@domain.participations.members.include?(@domains_key)
+#=> true
+
+## Test reverse index tracking works with String target class
+@tag.participations.members.length > 0
+#=> true
+
+## Test reverse index contains the correct collection key for tags
+@tags_key = @customer.tags.dbkey
+@tag.participations.members.include?(@tags_key)
+#=> true
+
+## Test current_participations works with Symbol target class
+@domain_participations = @domain.current_participations
+@domain_participations.is_a?(Array)
+#=> true
+
+## Test participation data includes correct target class
+@domain_participation = @domain_participations.first
+@domain_participation.target_class == 'SymbolResolutionCustomer'
+#=> true
+
+## Test current_participations works with String target class
+@tag_participations = @tag.current_participations
+@tag_participations.is_a?(Array)
+#=> true
+
+## Test participation data includes correct collection name
+@tag_participation = @tag_participations.first
+@tag_participation.collection_name == :tags
+#=> true
+
+## Test removal works correctly with Symbol target class
+@customer.remove_domains_instance(@domain)
+@customer.domains.member?(@domain.identifier)
+#=> false
+
+## Test reverse index cleanup with Symbol target class
+@domain.participations.members.empty?
+#=> true
+
+## Test removal works correctly with String target class
+@customer.remove_tags_instance(@tag)
+@customer.tags.member?(@tag.identifier)
+#=> false
+
+## Test reverse index cleanup with String target class
+@tag.participations.members.empty?
+#=> true
+
+## Cleanup
+[@customer, @domain, @tag].each do |obj|
+  obj.destroy if obj&.respond_to?(:destroy) && obj&.respond_to?(:exists?) && obj.exists?
+end
+true
+#=> true