familia 2.0.0.pre18 → 2.0.0.pre21

data/try/integration/persistence_operations_try.rb

@@ -1,3 +1,7 @@
+# try/integration/persistence_operations_try.rb
+#
+# frozen_string_literal: true
+
 # try/core/persistence_operations_try.rb
 #
 # Comprehensive test coverage for core persistence methods: exists?, save, save_if_not_exists, create
@@ -13,6 +17,27 @@ class PersistenceTestModel < Familia::Horreum
   field :value
 end
 
+# Create model with expiration feature for save_fields testing
+class ExpirationPersistenceTest < Familia::Horreum
+  feature :expiration
+  identifier_field :id
+  field :id
+  field :name
+  field :email
+  field :status
+  field :metadata
+
+  default_expiration 3600  # 1 hour
+end
+
+# Simple model without expiration feature
+class SimpleModel < Familia::Horreum
+  identifier_field :id
+  field :id
+  field :name
+  field :value
+end
+
 # Clean up any existing test data
 cleanup_keys = []
 begin
@@ -111,9 +136,9 @@ result = @sine_new.save_if_not_exists
 [result, @sine_new.exists?]
 #=> [true, true]
 
-## save_if_not_exists raises error for existing object
+## save_if_not_exists! raises error for existing object
 @sine_duplicate = PersistenceTestModel.new(id: @sine_new.identifier, name: 'Duplicate')
-@sine_duplicate.save_if_not_exists
+@sine_duplicate.save_if_not_exists!
 #=!> Familia::RecordExistsError
 
 ## save_if_not_exists with update_expiration: false
@@ -128,14 +153,10 @@ original_name = 'Original Name'
 @sine_fail_test.save_if_not_exists
 # Now create duplicate and verify state doesn't change on failure
 @sine_fail_duplicate = PersistenceTestModel.new(id: @sine_fail_test.identifier, name: 'Changed Name')
-begin
-  @sine_fail_duplicate.save_if_not_exists
-  false # Should not reach here
-rescue Familia::RecordExistsError
-  # State should be unchanged
-  @sine_fail_duplicate.name == 'Changed Name'
-end
-#=> true
+result = @sine_fail_duplicate.save_if_not_exists
+# save_if_not_exists returns false on failure, state should be unchanged
+[result == false, @sine_fail_duplicate.name == 'Changed Name']
+#=> [true, true]
 
 # =============================================
 # 4. create Method Coverage (MISSING from current tests)
@@ -291,7 +312,142 @@ actual_key = @key_obj.dbkey
 # Cleanup
 # =============================================
 
+# =============================================
+# 8. save_fields Method Coverage
+# =============================================
+
+## save_fields basic functionality with specified fields
+@save_fields_obj = ExpirationPersistenceTest.new(id: next_test_id, name: 'Original Name', email: 'test@example.com', status: 'active')
+@save_fields_obj.save
+# Modify fields locally
+@save_fields_obj.name = 'Updated Name'
+@save_fields_obj.status = 'inactive'
+@save_fields_obj.metadata = { updated: true }
+# Save only specific fields
+result = @save_fields_obj.save_fields(:name, :metadata)
+[result.class == ExpirationPersistenceTest, @save_fields_obj.exists?]
+#=> [true, true]
+
+## Verify only specified fields were saved
+@save_fields_obj.refresh!
+[@save_fields_obj.name, @save_fields_obj.status, @save_fields_obj.metadata]
+#=> ['Updated Name', 'active', { 'updated' => true }]
+
+## save_fields with update_expiration: true (default)
+@exp_obj = ExpirationPersistenceTest.new(id: next_test_id, name: 'Expiration Test')
+@exp_obj.save
+original_ttl = @exp_obj.ttl
+# Wait a moment to ensure TTL decreases
+sleep 0.1
+@exp_obj.name = 'Updated with TTL'
+@exp_obj.save_fields(:name)  # Should update expiration by default
+new_ttl = @exp_obj.ttl
+# TTL should be refreshed (closer to default_expiration)
+# Allow for small timing variations
+new_ttl >= (ExpirationPersistenceTest.default_expiration - 10)
+#=> true
+
+## save_fields with update_expiration: false
+@no_exp_obj = ExpirationPersistenceTest.new(id: next_test_id, name: 'No Exp Update')
+@no_exp_obj.save
+# Wait briefly and get TTL
+sleep 0.1
+original_ttl = @no_exp_obj.ttl
+@no_exp_obj.name = 'Updated without TTL'
+@no_exp_obj.save_fields(:name, update_expiration: false)
+new_ttl = @no_exp_obj.ttl
+# TTL should be approximately the same (slightly less due to time passing)
+(new_ttl - original_ttl).abs < 2
+#=> true
+
+## save_fields with multiple fields
+@multi_fields_obj = ExpirationPersistenceTest.new(id: next_test_id, name: 'Multi', email: 'multi@test.com')
+@multi_fields_obj.save
+@multi_fields_obj.name = 'Multi Updated'
+@multi_fields_obj.email = 'updated@test.com'
+@multi_fields_obj.status = 'new_status'
+result = @multi_fields_obj.save_fields(:name, :email, :status)
+@multi_fields_obj.refresh!
+[@multi_fields_obj.name, @multi_fields_obj.email, @multi_fields_obj.status]
+#=> ['Multi Updated', 'updated@test.com', 'new_status']
+
+## save_fields with string field names
+@string_fields_obj = ExpirationPersistenceTest.new(id: next_test_id, name: 'String Fields')
+@string_fields_obj.save
+@string_fields_obj.name = 'Updated via String'
+result = @string_fields_obj.save_fields('name')  # String instead of symbol
+@string_fields_obj.refresh!
+@string_fields_obj.name
+#=> 'Updated via String'
+
+## save_fields error handling - empty fields
+@empty_fields_obj = ExpirationPersistenceTest.new(id: next_test_id, name: 'Empty Test')
+@empty_fields_obj.save
+@empty_fields_obj.save_fields()
+#=!> ArgumentError
+
+## save_fields error handling - unknown field
+@unknown_field_obj = ExpirationPersistenceTest.new(id: next_test_id, name: 'Unknown Field')
+@unknown_field_obj.save
+@unknown_field_obj.save_fields(:nonexistent_field)
+#=!> ArgumentError
+
+## save_fields with nil values
+@nil_values_obj = ExpirationPersistenceTest.new(id: next_test_id, name: 'Nil Values', status: 'initial')
+@nil_values_obj.save
+@nil_values_obj.status = nil
+@nil_values_obj.save_fields(:status)
+@nil_values_obj.refresh!
+@nil_values_obj.status
+#=> nil
+
+## save_fields with complex data types (Hash, Array)
+@complex_obj = ExpirationPersistenceTest.new(id: next_test_id, name: 'Complex')
+@complex_obj.save
+@complex_obj.metadata = {
+  tags: ['ruby', 'redis'],
+  config: { timeout: 30, retries: 3 },
+  enabled: true
+}
+@complex_obj.save_fields(:metadata)
+@complex_obj.refresh!
+expected_metadata = {
+  'tags' => ['ruby', 'redis'],
+  'config' => { 'timeout' => 30, 'retries' => 3 },
+  'enabled' => true
+}
+@complex_obj.metadata == expected_metadata
+#=> true
+
+## save_fields transactional behavior
+@transaction_obj = ExpirationPersistenceTest.new(id: next_test_id, name: 'Transaction Test')
+@transaction_obj.save
+@transaction_obj.name = 'Updated in Transaction'
+@transaction_obj.email = 'transaction@test.com'
+# All fields should be saved atomically
+@transaction_obj.save_fields(:name, :email)
+@transaction_obj.refresh!
+[@transaction_obj.name, @transaction_obj.email]
+#=> ['Updated in Transaction', 'transaction@test.com']
+
+## save_fields performance with model without expiration feature
+
+@simple_obj = SimpleModel.new(id: next_test_id, name: 'Simple', value: 'test')
+@simple_obj.save
+@simple_obj.name = 'Simple Updated'
+# Should work without expiration feature (update_expiration param ignored)
+result = @simple_obj.save_fields(:name, update_expiration: true)
+@simple_obj.refresh!
+@simple_obj.name
+#=> 'Simple Updated'
+
+# =============================================
+# Cleanup
+# =============================================
+
 # Clean up test data
 test_keys = Familia.dbclient.keys('persistencetestmodel:*')
 test_keys.concat(Familia.dbclient.keys('encryptedpersistencetest:*')) if defined?(EncryptedPersistenceTest)
+test_keys.concat(Familia.dbclient.keys('expirationpersistencetest:*'))
+test_keys.concat(Familia.dbclient.keys('simplemodel:*'))
 Familia.dbclient.del(*test_keys) if test_keys.any?

data/try/integration/relationships_persistence_round_trip_try.rb

@@ -1,5 +1,7 @@
 # try/integration/relationships_persistence_round_trip_try.rb
 #
+# frozen_string_literal: true
+
 # CRITICAL PRIORITY: Full Persistence Round-Trip Testing for Relationships
 #
 # PURPOSE:
@@ -113,22 +115,23 @@ class ::RTPDomain < Familia::Horreum
 end
 
 # Setup - create test data with known values
-@test_user_id = "rtp_user_#{Familia.now.to_i}"
-@test_email = "roundtrip@example.com"
-@test_name = "Alice Roundtrip"
+@test_run_id = Familia.now.to_i
+@test_user_id = "rtp_user_#{@test_run_id}"
+@test_email = "roundtrip-#{@test_run_id}@example.com"
+@test_name = "Alice Roundtrip #{@test_run_id}"
 @test_age = 30
 
-@test_company_id = "rtp_comp_#{Familia.now.to_i}"
+@test_company_id = "rtp_comp_#{@test_run_id}"
 @test_company_name = "Acme Corp"
 @test_industry = "Technology"
 
-@test_emp_id = "rtp_emp_#{Familia.now.to_i}"
-@test_emp_email = "employee@acme.com"
+@test_emp_id = "rtp_emp_#{@test_run_id}"
+@test_emp_email = "employee-#{@test_run_id}@acme.com"
 @test_department = "engineering"
-@test_badge = "BADGE_RTP_001"
+@test_badge = "BADGE_RTP_#{@test_run_id}"
 @test_hire_date = Time.now.to_i
 
-@test_domain_id = "rtp_dom_#{Familia.now.to_i}"
+@test_domain_id = "rtp_dom_#{@test_run_id}"
 @test_domain_name = "example.com"
 @test_domain_created = Familia.now.to_i
 
@@ -291,10 +294,10 @@ RTPEmployee.exists?(@test_emp_id)
 
 ## Multiple employees in same department
 @emp2_id = "rtp_emp2_#{Familia.now.to_i}"
-@emp2_badge = "BADGE_RTP_002"
+@emp2_badge = "BADGE_RTP_002_#{@test_run_id}"
 @emp2 = RTPEmployee.new(
   emp_id: @emp2_id,
-  email: "emp2@acme.com",
+  email: "emp2-#{@test_run_id}@acme.com",
   department: @test_department,
   badge_number: @emp2_badge
 )
@@ -323,7 +326,7 @@ RTPDomain.exists?(@test_domain_id)
 #=> true
 
 ## Add domain to company participation collection
-@company.add_domain(@domain)
+@company.add_domains_instance(@domain)
 @company.domains.size
 #=> 1
 
@@ -377,7 +380,7 @@ RTPDomain.all_domains.size
 #=> @new_age
 
 ## Update email and verify index updates
-@new_email = "newemail@example.com"
+@new_email = "newemail-#{@test_run_id}@example.com"
 @old_email = @user.email
 @user.email = @new_email
 @user.save
@@ -396,8 +399,8 @@ RTPUser.find_by_email(@old_email)
 ## User with nil field saves correctly
 @user_nil_age = RTPUser.new(
   user_id: "rtp_nil_#{Familia.now.to_i}",
-  email: "nil@example.com",
-  name: "Nil Tester",
+  email: "nil-#{@test_run_id}@example.com",
+  name: "Nil Tester #{@test_run_id}",
   age: nil
 )
 @user_nil_age.save

data/try/integration/save_methods_consistency_try.rb

@@ -0,0 +1,241 @@
+# try/integration/save_methods_consistency_try.rb
+#
+# frozen_string_literal: true
+
+# Test coverage for save and save_if_not_exists consistency improvements
+#
+# This test verifies that both save and save_if_not_exists! produce identical
+# results when creating new objects, including:
+# - Timestamp updates (created/updated)
+# - Unique index validation
+# - Class-level index updates
+# - Instance collection tracking
+
+require_relative '../support/helpers/test_helpers'
+
+# Model with timestamps to verify timestamp handling
+class TimestampedModel < Familia::Horreum
+  identifier_field :id
+  field :id
+  field :name
+  field :created
+  field :updated
+
+  zset :instances
+end
+
+# Model with unique indexes to verify validation
+class UniqueIndexModel < Familia::Horreum
+  feature :relationships
+  include Familia::Features::Relationships::Indexing
+
+  identifier_field :id
+  field :id
+  field :email
+
+  unique_index :email, :email_lookup
+  zset :instances
+end
+
+# Clean up any existing test data
+cleanup_keys = Familia.dbclient.keys('timestampedmodel:*') +
+               Familia.dbclient.keys('uniqueindexmodel:*') +
+               Familia.dbclient.keys('*:email_lookup:*')
+Familia.dbclient.del(*cleanup_keys) if cleanup_keys.any?
+
+@test_counter = 0
+def next_id
+  @test_counter += 1
+  "test-#{Familia.now.to_i}-#{@test_counter}"
+end
+
+# =============================================
+# 1. Timestamp Consistency Tests
+# =============================================
+
+## save sets created and updated timestamps
+@save_model = TimestampedModel.new(id: next_id, name: 'Save Test')
+@save_model.save
+[@save_model.created.nil?, @save_model.updated.nil?]
+#=> [false, false]
+
+## save_if_not_exists! sets created and updated timestamps
+@sine_model = TimestampedModel.new(id: next_id, name: 'SINE Test')
+@sine_model.save_if_not_exists!
+[@sine_model.created.nil?, @sine_model.updated.nil?]
+#=> [false, false]
+
+## Both methods set timestamps to the same approximate time
+time_diff = (@save_model.created - @save_model.updated).abs
+time_diff < 1  # Should be within 1 second
+#=> true
+
+## save_if_not_exists! timestamps match save behavior
+sine_time_diff = (@sine_model.created - @sine_model.updated).abs
+sine_time_diff < 1
+#=> true
+
+# =============================================
+# 2. Instance Collection Consistency
+# =============================================
+
+## save adds object to instances collection
+@inst_save = TimestampedModel.new(id: next_id, name: 'Instance Save')
+@inst_save.save
+TimestampedModel.instances.members.include?(@inst_save.identifier)
+#=> true
+
+## save_if_not_exists! adds object to instances collection
+@inst_sine = TimestampedModel.new(id: next_id, name: 'Instance SINE')
+@inst_sine.save_if_not_exists!
+TimestampedModel.instances.members.include?(@inst_sine.identifier)
+#=> true
+
+## Both methods produce identical instance collection state
+[@inst_save, @inst_sine].all? { |obj| TimestampedModel.instances.members.include?(obj.identifier) }
+#=> true
+
+# =============================================
+# 3. Unique Index Validation Consistency
+# =============================================
+
+## save validates unique indexes
+@unique_email_1 = "save-#{next_id}@test.com"
+@unique_save = UniqueIndexModel.new(id: next_id, email: @unique_email_1)
+@unique_save.save
+@unique_save.exists?
+#=> true
+
+## save raises RecordExistsError for duplicate unique index
+@unique_dup_save = UniqueIndexModel.new(id: next_id, email: @unique_email_1)
+@unique_dup_save.save
+#=!> Familia::RecordExistsError
+
+## save_if_not_exists! validates unique indexes
+@unique_email_2 = "sine-#{next_id}@test.com"
+@unique_sine = UniqueIndexModel.new(id: next_id, email: @unique_email_2)
+@unique_sine.save_if_not_exists!
+@unique_sine.exists?
+#=> true
+
+## save_if_not_exists! raises RecordExistsError for duplicate unique index
+@unique_dup_sine = UniqueIndexModel.new(id: next_id, email: @unique_email_2)
+@unique_dup_sine.save_if_not_exists!
+#=!> Familia::RecordExistsError
+
+# =============================================
+# 4. Return Value Consistency
+# =============================================
+
+## save returns true for successful save
+@ret_save = TimestampedModel.new(id: next_id, name: 'Return Test Save')
+result_save = @ret_save.save
+result_save
+#=> true
+
+## save_if_not_exists! returns true for successful save
+@ret_sine = TimestampedModel.new(id: next_id, name: 'Return Test SINE')
+result_sine = @ret_sine.save_if_not_exists!
+result_sine
+#=> true
+
+## save_if_not_exists returns true for new object
+@ret_sine_safe = TimestampedModel.new(id: next_id, name: 'Return Safe SINE')
+result = @ret_sine_safe.save_if_not_exists
+result
+#=> true
+
+## save_if_not_exists returns false for existing object
+@ret_existing = TimestampedModel.new(id: next_id, name: 'Existing')
+@ret_existing.save
+@ret_dup = TimestampedModel.new(id: @ret_existing.identifier, name: 'Duplicate')
+result = @ret_dup.save_if_not_exists
+result
+#=> false
+
+# =============================================
+# 5. Data Persistence Consistency
+# =============================================
+
+## save persists all fields
+@data_save = TimestampedModel.new(id: next_id, name: 'Data Save Test')
+@data_save.save
+@data_save.refresh
+@data_save.name
+#=> 'Data Save Test'
+
+## save_if_not_exists! persists all fields
+@data_sine = TimestampedModel.new(id: next_id, name: 'Data SINE Test')
+@data_sine.save_if_not_exists!
+@data_sine.refresh
+@data_sine.name
+#=> 'Data SINE Test'
+
+## Both methods produce identical persistence
+[@data_save.name, @data_sine.name]
+#=> ['Data Save Test', 'Data SINE Test']
+
+# =============================================
+# 6. Expiration Handling Consistency
+# =============================================
+
+## save with update_expiration: true handles TTL
+@exp_save = TimestampedModel.new(id: next_id, name: 'Exp Save')
+@exp_save.save(update_expiration: true)
+# No default expiration set, so TTL is -1 (no expiration)
+@exp_save.ttl == -1
+#=> true
+
+## save_if_not_exists! with update_expiration: true handles TTL
+@exp_sine = TimestampedModel.new(id: next_id, name: 'Exp SINE')
+@exp_sine.save_if_not_exists!(update_expiration: true)
+# No default expiration set, so TTL is -1 (no expiration)
+@exp_sine.ttl == -1
+#=> true
+
+# =============================================
+# 7. OptimisticLockError Behavior
+# =============================================
+
+## save_if_not_exists allows OptimisticLockError to propagate
+# Note: This is difficult to test reliably without mocking, but we can
+# verify the method signature and rescue clause structure through the API
+
+## save_if_not_exists rescues only RecordExistsError
+@opt_test = TimestampedModel.new(id: next_id, name: 'Opt Test')
+@opt_test.save
+@opt_dup = TimestampedModel.new(id: @opt_test.identifier, name: 'Opt Dup')
+# This should return false, not raise
+result = @opt_dup.save_if_not_exists
+result
+#=> false
+
+# =============================================
+# 8. Edge Cases
+# =============================================
+
+## save works with nil field values
+@nil_save = TimestampedModel.new(id: next_id, name: nil)
+@nil_save.save
+@nil_save.exists?
+#=> true
+
+## save_if_not_exists! works with nil field values
+@nil_sine = TimestampedModel.new(id: next_id, name: nil)
+@nil_sine.save_if_not_exists!
+@nil_sine.exists?
+#=> true
+
+## Both methods handle empty strings
+@empty_save = TimestampedModel.new(id: next_id, name: '')
+@empty_save.save
+@empty_sine = TimestampedModel.new(id: next_id, name: '')
+@empty_sine.save_if_not_exists!
+[@empty_save.exists?, @empty_sine.exists?]
+#=> [true, true]
+
+# Cleanup
+cleanup_keys = Familia.dbclient.keys('timestampedmodel:*') +
+               Familia.dbclient.keys('uniqueindexmodel:*') +
+               Familia.dbclient.keys('*:email_lookup:*')
+Familia.dbclient.del(*cleanup_keys) if cleanup_keys.any?

data/try/integration/scenarios_try.rb

@@ -1,3 +1,7 @@
+# try/integration/scenarios_try.rb
+#
+# frozen_string_literal: true
+
 # Comprehensive configuration scenarios
 
 require_relative '../support/helpers/test_helpers'

data/try/integration/secure_identifier_try.rb

@@ -1,3 +1,7 @@
+# try/integration/secure_identifier_try.rb
+#
+# frozen_string_literal: true
+
 # try/core/secure_identifier_try.rb
 
 # Test Familia::SecureIdentifier methods