falcon 0.17.4 → 0.17.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bffdd8ea496ec7bdcac74b8c2c540f4d6da008d35d3d8f598764a2d17974b842
-  data.tar.gz: 4f993d6d77cebb76ca53141f2e92febba54d3db3eeddaeda130d5bce04d9f48c
+  metadata.gz: 5236b4f598c705ca3edc34fde0642c631db40667e3eff10f86421803282e4e0f
+  data.tar.gz: 0b368e6e54a9ca811d29a514c007d653140f9f0a6440c7f71be17729a66dec7d
 SHA512:
-  metadata.gz: 8c44c95675ce2e672a97048ca99070b83d773b7a840699f474b72744fe80f17fd8ba8a8d2061a0ab2659dc7622188b5238395b34871db2f17b424580ce0aa7e1
-  data.tar.gz: 752f925c54ff738d48cbc2cd81104bd2291d931a5cfe5f1b3893c18e98a599d4bf32f5b0f8e9a5b6db5f9a456357cd1ad88053d5169acc470fff7a1313381607
+  metadata.gz: 703c41487454bec117de57d6bdf30f8492133ac1b8d589d430fcffb8d436e075f97f5749d5acb50179aad3a104292d54fc963c58c5b0c2b973634435804ed154
+  data.tar.gz: 9c0be50a44d5f9bc19a99cbf8aadb5a61324b30195ed3ada6f096e13e25513a5c3a64b6fc213ec51639da5b793a92d1265a9b8de705778614e98f363c286af31

data/README.md

@@ -36,6 +36,10 @@ Falcon supports `rack.hijack` for HTTP/1.x connections. You can thus use [async-
 
 [async-websocket]: https://github.com/socketry/async-websocket
 
+#### ActionCable
+
+The `rack.hijack` functionality is compatible with ActionCable. If you use the `async` adapter, you should run falcon in threaded mode, or in forked mode with `--concurrency 1`. Otherwise, your messaging system will be distributed over several processes with no IPC mechanism.
+
 ### Integration with Guard
 
 Falcon can restart very quickly and is ideal for use with guard. See [guard-falcon] for more details.

data/lib/falcon/adapters/output.rb

@@ -27,20 +27,23 @@ module Falcon
 			CONTENT_LENGTH = 'content-length'.freeze
 			
 			# Wraps an array into a buffered body.
-			def self.wrap(headers, body)
+			def self.wrap(status, headers, body)
+				# In no circumstance do we want this propagating up:
+				content_length = headers.delete(CONTENT_LENGTH)
+				
 				if body.is_a?(Async::HTTP::Body::Readable)
 					return body
-				# This needs more testing:
-				elsif body.respond_to?(:to_path)
+				elsif status == 200 and body.respond_to?(:to_path)
+					# Don't mangle partial responsese (206)
 					return Async::HTTP::Body::File.open(body.to_path)
 				else
-					return self.new(headers, body)
+					return self.new(headers, body, (Integer(content_length) rescue nil))
 				end
 			end
 			
-			def initialize(headers, body)
+			def initialize(headers, body, length)
 				# We don't trust the user to provide the right length to the transport.
-				@length = headers.delete(CONTENT_LENGTH)
+				@length = length
 				
 				@body = body
 				@chunks = body.to_enum(:each)

data/lib/falcon/adapters/response.rb

@@ -27,7 +27,7 @@ module Falcon
 				# We normalize headers to be lower case:
 				headers = headers.map{|key, value| [key.downcase, value]}.to_h
 				
-				super(nil, status, nil, headers, Output.wrap(headers, body))
+				super(nil, status, nil, headers, Output.wrap(status, headers, body))
 			end
 		end
 	end

data/lib/falcon/version.rb

@@ -19,5 +19,5 @@
 # THE SOFTWARE.
 
 module Falcon
-	VERSION = "0.17.4"
+	VERSION = "0.17.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: falcon
 version: !ruby/object:Gem::Version
-  version: 0.17.4
+  version: 0.17.5
 platform: ruby
 authors:
 - Samuel Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-04 00:00:00.000000000 Z
+date: 2018-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: async-io