fakturan_nu 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 64fc9b74cfb95861e8b574f428566b6bfbd595c7
-  data.tar.gz: 06bf8ba9173850d5ea72d6b83480a547a978c5b6
+  metadata.gz: 02e35fa5a923f61075b3e317194962264c8ee81f
+  data.tar.gz: ae4c21387becc98cce2317202131450e7aa9feb4
 SHA512:
-  metadata.gz: f39f502582ebd9e7dd6afc6c1a860224fe7b0654bdf141bc9eb6efd6c09f859eb476e20420c53b9f27e026e3fa4104b553b958c29c239e0520e888fda35ab936
-  data.tar.gz: d15e1c04982734057338d0060de635f4281769d6ab160814678d85ddb36978389066af543b7d9f977a1cb6c4504ccd6c97625475e15f923ab36d2d7687a26f24
+  metadata.gz: b8f81b2e68400977172e5dfd33d32e81d55c41a7211985836c26a8a8937603a0a229d03de9f96df4c10520254c85a27fe839a86b394dfd1dbb18224d431a9617
+  data.tar.gz: b56c5ae954df126117441917ad54303e3dde7cac5457556c4b395e07f82f31dedfc4f62ada4f02a979384d76932bd91ce62405355d71818e56a65db156b8e52a

data/README.md

@@ -1,7 +1,7 @@
 Ruby client for the fakturan.nu API
 ==============================
 
-API client in ruby for the Swedish web based invoicing software [fakturan.nu](https://www.fakturan.nu). The API is currently in Beta and may be subject to change without notice until final release.
+API client in ruby for the Swedish web based invoicing software [fakturan.nu](https://www.fakturan.nu). 
 
 ---
 
@@ -30,7 +30,7 @@ If you're not using Rails, just ``` require 'fakturan_nu'``` and run setup where
 
 ### General
 
-The client attempts to provide an interface similar to ActiveRecord.
+The api client attempts to provide an interface similar to ActiveRecord.
 
 ```ruby
 Fakturan::Product.all
@@ -56,7 +56,7 @@ product.save
 
 ### Invoices
 
-For creating invoices, a client is required. It can be an existing client (by using ```client_id```), or a new one (by using ```client```):
+For creating invoices, a client/customer is required. It can be an existing client (by using ```client_id```), or a new one (by using ```client```):
 
 ```ruby
 invoice = Fakturan::Invoice.create(client: { company: "Acme Inc" })
@@ -72,6 +72,15 @@ invoice = Fakturan::Invoice.create(client_id: 1, rows: [{ product_name: "Shoes",
 # POST "https://fakturan.nu/api/v2/invoices" # Will create a new invoice for client with id: 1
 ```
 
+### Finding specific resources
+
+Some resources can be found by other attributes than their id. Any attribute that can be used for *filtering* on the list action, (see [client/list](https://sandbox.fakturan.nu/apidocs/2/clients/index.en.html) for example) can be used to find a single resource as well. This is done through the same find_by-interface that ActiveRecord uses:
+
+```ruby
+Client.find_by(number: 123)
+# GET "https://fakturan.nu/api/v2/clients?number=123" # Find a client by number or return nil if not found
+```
+
 ### Available resources and properties
 
 For a full list of resources and the properties of each type of resource, see the [api reference](https://sandbox.fakturan.nu/apidocs). 

data/fakturan_nu.gemspec

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |s|
   s.name        = 'fakturan_nu'
-  s.version     = '1.2.0'
+  s.version     = '1.2.1'
   s.date        = '2015-05-11'
   s.summary     = 'A ruby client for the Fakturan.nu - API'
   s.description = 'A ruby client for the Fakturan.nu - API. Fakturan.nu is a webbapp for billing.'

data/lib/fakturan_nu.rb

@@ -14,6 +14,9 @@ require 'fakturan_nu/product'
 require 'fakturan_nu/client'
 require 'fakturan_nu/row'
 require 'fakturan_nu/invoice'
+require 'fakturan_nu/account'
+require 'fakturan_nu/setting'
+require 'fakturan_nu/user'
 
 I18n.load_path += Dir.glob( File.dirname(__FILE__) + "lib/locales/*.{rb,yml}" )
 

data/lib/fakturan_nu/account.rb

@@ -0,0 +1,27 @@
+module Fakturan
+  class Account < Base
+    uri 'accounts/(:id)'
+    has_many :users, uri: nil
+    belongs_to :setting, uri: nil
+
+    attributes :api_token
+
+    accepts_nested_attributes_for :users, :setting
+
+    def users=(attrs_or_obj_array)
+      if attrs_or_obj_array.first.respond_to?(:each)
+        send(:users_attributes=, attrs_or_obj_array)
+      else
+        super
+      end
+    end
+
+    def setting=(attrs_or_obj)
+      if attrs_or_obj.respond_to?(:each)
+        send(:setting_attributes=, attrs_or_obj)
+      else
+        super
+      end
+    end
+  end
+end

data/lib/fakturan_nu/base.rb

@@ -41,7 +41,7 @@ module Fakturan
 
         # The errors are for an associated object, and there is an associated object to put them on
         if (association = self.class.reflect_on_association(ass_name)) && !self.send(ass_name).blank?
-          if association.type == Spyke::Associations::HasMany
+          if association.type == Spyke::Associations::HasMany && self.respond_to?(field_name.to_sym)
             # We need to add one error to our "base" object so that it's not valid
             self.add_to_errors(field_name.to_sym, [{error: :invalid}])
             field_errors.each do |new_error_hash_with_index| # new_error_hash_OR_error_type ("blank") on presence of has_many
@@ -63,14 +63,16 @@ module Fakturan
               association_target_parent = path_sub_parts[0..-2].inject(self, :send)
 
               # We add the error to the associated object
-              association_target.add_to_errors(field_name, field_errors)
-              # and then we get the errors (with generated messages) and add them to
-              # the parent (but without details, like nested_attributes works)
-              # This only makes sense on belongs_to and has_one, since it's impossible
-              # to know which object is refered to on has_many
-              association_target.errors.each do |attribute, message|
-                association_target_parent.errors[full_field_path] << message
-                association_target_parent.errors[full_field_path].uniq!
+              if association_target.respond_to?(field_name)
+                association_target.add_to_errors(field_name, field_errors)
+                # and then we get the errors (with generated messages) and add them to
+                # the parent (but without details, like nested_attributes works)
+                # This only makes sense on belongs_to and has_one, since it's impossible
+                # to know which object is refered to on has_many
+                association_target.errors.each do |attribute, message|
+                  association_target_parent.errors[full_field_path] << message
+                  association_target_parent.errors[full_field_path].uniq!
+                end
               end
             end
           end

data/lib/fakturan_nu/middleware/parse_json.rb

@@ -19,7 +19,7 @@ module Fakturan
           else # If we get 204 = request fine, but no content returned
             env.body = { data: {}, metadata: {}, errors: {} }
           end
-        rescue MultiJson::ParseError => exception
+        rescue MultiJson::ParseError
           raise Fakturan::Error::ParseError, {:status => env.status, :headers => env.response_headers, :body => env.body}
         end
       end

data/lib/fakturan_nu/setting.rb

@@ -0,0 +1,5 @@
+module Fakturan
+  class Setting < Base
+    attributes :company_email
+  end
+end

data/lib/fakturan_nu/user.rb

@@ -0,0 +1,8 @@
+module Fakturan
+  class User < Base
+    attributes :login, :name
+
+    validates :login, presence: true
+    validates :name, presence: true
+  end
+end

data/test/exceptions_test.rb

@@ -114,6 +114,13 @@ module Fakturan
       assert_equal ({:company=>[{:error=>:blank}]}), invoice.client.errors.details
     end
 
+    def test_ignores_errors_for_nonexistant_attributes
+      stub_api_request(:post, '/accounts').to_return(body: {errors: { "users.email" => [{ error: "taken", value: "palle@kuling.net"}], "users.login" => [{error:"taken",value:"palle@kuling.net"}], users: [{"0" => { "users.email" => [{error: "taken", value: "palle@kuling.net"}], "users.login" => [{ error: "taken", value: "palle@kuling.net"}]}}]}}.to_json, status: 422)
+
+      account = Fakturan::Account.new( setting: { company_email: "palle@kuling.net" }, users: [{ email: "palle@kuling.net", password: "asdfasdf", firstname: "asdfasdf", lastname: "asdfasdf"}])
+      assert !account.save # Should just return false without raising errors
+    end
+
     def test_validation_errors_on_nested_associated_objects
       stub_api_request(:post, '/invoices').to_return(body: {errors: {date: [{error: :blank},{error: :invalid}], :"client.address.country" => [{ error: :blank}]}}.to_json, status: 422)
       invoice = Fakturan::Invoice.new(client: { address: { street_address: 'Some street' } })

data/test/models_test.rb

@@ -28,19 +28,12 @@ module Fakturan
       assert_equal nil, client
     end
 
-    def get_good_invoice
-      return if @invoice # We won't change this instance so we really only need to do this once.
-      @invoice = Fakturan::Invoice.find(5)
-    end
-
-    def test_find_one_and_access_attribute
-      client = Fakturan::Client.find(1)
-      assert client.name.is_a? String
+    def good_invoice
+      @invoice ||= Fakturan::Invoice.find(5)
     end
 
     def test_should_create_associated_objects
-      get_good_invoice
-      assert_equal @invoice.address.name, 'A simple client'
+      assert_equal good_invoice.address.name, 'A simple client'
     end
 
     def test_should_be_able_to_fetch_and_update_invoice
@@ -51,11 +44,10 @@ module Fakturan
     end
 
     def test_should_fetch_associated_record
-      get_good_invoice
       client = Fakturan::Client.find(11)
       assert_equal Fakturan::Client, client.class
       assert_equal 'A simple client', client.name
-      assert_equal client.name, @invoice.client.name
+      assert_equal client.name, good_invoice.client.name
     end
 
     def test_find_one_and_access_attribute
@@ -116,8 +108,7 @@ module Fakturan
     end
 
     def test_date_fields_should_not_be_typecast
-      get_good_invoice
-      assert_equal String, @invoice.date.class
+      assert_equal String, good_invoice.date.class
     end
 
     def test_getting_attribute_on_new_instance

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fakturan_nu
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Jonathan Bourque Olivegren
@@ -203,6 +203,7 @@ files:
 - config/locales/en.yml
 - fakturan_nu.gemspec
 - lib/fakturan_nu.rb
+- lib/fakturan_nu/account.rb
 - lib/fakturan_nu/address.rb
 - lib/fakturan_nu/base.rb
 - lib/fakturan_nu/client.rb
@@ -213,7 +214,9 @@ files:
 - lib/fakturan_nu/middleware/raise_error.rb
 - lib/fakturan_nu/product.rb
 - lib/fakturan_nu/row.rb
+- lib/fakturan_nu/setting.rb
 - lib/fakturan_nu/spyke_extensions.rb
+- lib/fakturan_nu/user.rb
 - test/basics_test.rb
 - test/exceptions_test.rb
 - test/fixtures.rb
@@ -240,7 +243,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: A ruby client for the Fakturan.nu - API