fake_password_field 1.1 → 1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4f522d8c3abe3cb5917c5389bbbbbd93996ff79b
-  data.tar.gz: 15b4cb332717b8143100eb7f1c99513ef751adb1
+  metadata.gz: 1f0e7ed13d10911f2f14a31138b793471ae163df
+  data.tar.gz: 8583916fb7ae6cf62acb051b24c809573ec00a69
 SHA512:
-  metadata.gz: 193d2226ddca4262369530ef3f75999d77a942a985bb58ad572ed5284735834a5159214d71910bb90d61f13618d9f536a152f73214eeadb324ae7985828f3a19
-  data.tar.gz: 90f542030942c95709b35cc9f0cf54cce38bbfe8fcfe0ba3a466a21f9794b6e14a0915887f727f4fe8c9d9506ba7a597d559c2b2fce8c89a9bed149016f1c616
+  metadata.gz: b96fa92fcbf425d42e16a9cdfb49f39570a116b5ea1caf11b19736acf097744247bce792ad4214a2dd480bba943909440ece2e3239f163fbff17fa69c9b9f6b0
+  data.tar.gz: dd0fc7d8598c60cdf8a799fbce4cd1839df5b3b075a849f2db0856fbfbb798aeca38a9b6a86768b700ff358aad65d1aa936104d1607e7efe505b0d215e003bc1

data/README.md

@@ -22,24 +22,16 @@ Available on RubyGems: https://rubygems.org/gems/fake_password_field
 
 ### Usage
 
-In your views, replace `password_field_tag` with `fake_password_field_tag`. Or if you're using a FormBuilder (`form_for(@object)...`), replace `f.password_field` with `f.fake_password_field`.
-
-All other parameters should be the same - you shouldn't need to change anything else in your view code. Please create an issue if that isn't the case.
+Add a `fake_password_field_tag` to the top of your page. Or if you're using a FormBuilder (`form_for(@object)...`), add a `f.fake_password_field`.
 
 ### How it works
 
-The gem will render a text field (`<input type=text>`) with the same markup as your password field. Directly below, it inserts a snippet of Javascript that will convert this text field to a password field after the page has loaded and Safari's autofiller has finished running.
-
-The snippet looks like this:
+This inserts a dummy HTML password element, which is hidden from view and will not be posted. But it will trick Safari into not autofilling your actual password field.
 
-````javascript
-<script>
-// http://stackoverflow.com/q/22817801/641293
-var i = document.getElementsByTagName('input'), e = i[i.length - 1]
-setTimeout(function() { e.type = 'password' }, 500)
-</script>
-````
+You should experiment with the best place in the form to add this element. Usually adding it to the top works well, but some form layouts work best if it's added to the bottom.
 
-### Shortfalls
+The HTML looks like this:
 
-If you have a default value in the password field, that value will flash briefly before being replaced by the password field dots. Generally it's not considered a good practice to include the user's password (or indeed, any password) in your HTML. But if you really need to, you should try one of the other workarounds suggested at http://stackoverflow.com/questions/22817801/how-to-disable-auto-fill-in-safari-7 or elsewhere, instead of this gem.
+````html
+<div class="break_safari_autofill" style="left: -9999px; position: fixed; width: 1px;"><input type="password"></div> <!-- http://stackoverflow.com/a/24471266/641293 -->
+````

data/lib/fake_password_field/helpers.rb

@@ -1,16 +1,11 @@
 module ActionView
 module Helpers
 class FormBuilder
-  def fake_password_field(method, options = {})
-    text_field_output = text_field(method, options)
-    javascript = <<-STR
-<script>
-// http://stackoverflow.com/q/22817801/641293
-var i = document.getElementsByTagName('input'), e = i[i.length - 1]
-setTimeout(function() { e.type = 'password' }, 500)
-</script>
+  def fake_password_field
+    html = <<-STR
+<div class="break_safari_autofill" style="left: -9999px; position: fixed; width: 1px;"><input type="password"></div> <!-- http://stackoverflow.com/a/24471266/641293 -->
     STR
-    "#{text_field_output} #{javascript}".html_safe
+    html.html_safe
   end
 end
 end
@@ -19,16 +14,11 @@ end
 module ActionView
 module Helpers
 module FormTagHelper
-  def fake_password_field_tag(name = "password", value = nil, options = {})
-    text_field_output = text_field_tag(name, value, options)
-    javascript = <<-STR
-<script>
-// http://stackoverflow.com/q/22817801/641293
-var i = document.getElementsByTagName('input'), e = i[i.length - 1]
-setTimeout(function() { e.type = 'password' }, 500)
-</script>
+  def fake_password_field_tag
+    html = <<-STR
+<div class="break_safari_autofill" style="left: -9999px; position: fixed; width: 1px;"><input type="password"></div> <!-- http://stackoverflow.com/a/24471266/641293 -->
     STR
-    "#{text_field_output} #{javascript}".html_safe
+    html.html_safe
   end
 end
 end

data/lib/fake_password_field/version.rb

@@ -1,3 +1,3 @@
 module FakePasswordField
-  VERSION = 1.1
+  VERSION = 1.2
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fake_password_field
 version: !ruby/object:Gem::Version
-  version: '1.1'
+  version: '1.2'
 platform: ruby
 authors:
 - Alex Ghiculescu