fake_fb_marketing_api 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c9e916084f69d4c775a025c3bb6948843c85e121
-  data.tar.gz: f99a3b4b67c3f6209a82e26fb45903e4f85388f7
+  metadata.gz: 66764ff94b5fc44d7089157cd9853e53ea31b9ca
+  data.tar.gz: 78231722916c4547e803edfe4f54f94efc45cb19
 SHA512:
-  metadata.gz: 7e2bad6aae8e22ac811433dbaf252447b8b3529cdaa5406d26092db792e867ab1ce4150615d068e1450d7a6e04e6066f23e7ffe225a416ea98d31d92d04d17b4
-  data.tar.gz: d57770fdd7181beed6a70d317330c9af955f0be75ef9c4ee8cb95078922757600a3836b0c1d53ea79c53f038e2182b378e2987a55d77c7c3cae7e64c4c06871c
+  metadata.gz: d555f5efe1a591939df94af860ceb2391000a726416d7b864b34c409307989d91c59ced034e9fdf92e504e5ff2802b6da3012ee79175a779ee5f2ab540d4de1b
+  data.tar.gz: e0cfdabf5cf4f263a30c9fba1c50a3a3c8382269f4f83db8c8458b07f4e11bd33323e77550c53979168854733ef8e2848722a1e2c5820c38550aadd363555692

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    fake_fb_marketing_api (0.0.1)
+    fake_fb_marketing_api (0.0.2)
       sinatra (~> 2.0)
       we-call (~> 0.9)
 

data/lib/fake_fb_marketing_api/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FakeFbMarketingApi
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/lib/fake_fb_marketing_api/versions/v3_2.rb

@@ -13,7 +13,7 @@ module FakeFbMarketingApi
         FakeFacebook.owned_ad_accounts.to_json
       end
 
-      post '/:business_id/adaccounts' do
+      post '/:business_id/adaccount' do
         content_type :json
         FakeFacebook.add_owned_ad_account(
           {
@@ -21,18 +21,19 @@ module FakeFbMarketingApi
             'id' => ENV.fetch('FACEBOOK_AD_ACCOUNT_ID')
           }
         )
-        if params.key?('adaccount_id')
-          proxy_post_to_fb(request, response)
-        else
-          {
-            end_advertiser_id: params[:end_advertiser_id],
-            media_agency_id: params[:media_agency_id],
-            business_id: params[:business_id],
-            account_id: ENV['FACEBOOK_AD_ACCOUNT_ID'],
-            id: "act_%{ENV['FACEBOOK_AD_ACCOUNT_ID']}",
-            partner_id: 'NONE'
-          }.to_json
-        end
+        {
+          end_advertiser_id: params[:end_advertiser_id],
+          media_agency_id: params[:media_agency_id],
+          business_id: params[:business_id],
+          account_id: ENV['FACEBOOK_AD_ACCOUNT_ID'],
+          id: "act_#{ENV['FACEBOOK_AD_ACCOUNT_ID']}",
+          partner_id: 'NONE'
+        }.to_json
+      end
+
+      post '/:project_id/adaccounts' do
+        content_type :json
+        proxy_post_to_fb(request, response)
       end
 
       post '/:ad_account_id/assigned_users' do

data/spec/fake_fb_marketing_api_spec.rb

@@ -45,7 +45,7 @@ RSpec.describe FakeFbMarketingApi::Application do
       end_advertiser_id = Faker::Number.number(10)
       media_agency_id = Faker::Number.number(10)
       name = Faker::Seinfeld.character
-      response = graph.put_connections "#{ENV['BUSINESS_ID']}", 'adaccounts',
+      response = graph.put_connections "#{ENV['BUSINESS_ID']}", 'adaccount',
         name: name,
         currency: 'USD', timezone_id: 6, end_advertiser_id: end_advertiser_id,
         media_agency_id: media_agency_id, partner: 'NONE'
@@ -62,12 +62,12 @@ RSpec.describe FakeFbMarketingApi::Application do
     end
   end
 
-  describe 'POST /:business_id/adaccounts' do
+  describe 'POST /:business_id/adaccount' do
     context 'when creating an ad account' do
       it 'works' do
         end_advertiser_id = Faker::Number.number(10)
         media_agency_id = Faker::Number.number(10)
-        response = graph.put_connections (ENV['BUSINESS_ID']).to_s, 'adaccounts',
+        response = graph.put_connections (ENV['BUSINESS_ID']).to_s, 'adaccount',
                                          name: 'Test Ad Account',
                                          currency: 'USD', timezone_id: 6, end_advertiser_id: end_advertiser_id,
                                          media_agency_id: media_agency_id, partner: 'NONE'
@@ -76,14 +76,16 @@ RSpec.describe FakeFbMarketingApi::Application do
         {
           'business_id' => ENV['BUSINESS_ID'],
           'account_id' => ENV['FACEBOOK_AD_ACCOUNT_ID'],
-          'id' => "act_%{ENV['FACEBOOK_AD_ACCOUNT_ID']}",
+          'id' => "act_#{ENV['FACEBOOK_AD_ACCOUNT_ID']}",
           'end_advertiser_id' => end_advertiser_id,
           'media_agency_id' => media_agency_id,
           'partner_id' => 'NONE'
         }
       end
     end
+  end
 
+  describe 'POST /:project_id/adaccounts' do
     context 'when adding a user to an ad account' do
       it 'calls out to facebook' do
         project_id = Faker::Number.number(15).to_s

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fake_fb_marketing_api
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Mike Menne
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-08 00:00:00.000000000 Z
+date: 2019-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler