fake_braintree 0.4.3 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: add7e06e8924fb857057b26cf5b666c3e4c26e46
-  data.tar.gz: e29ab9a2d7f8cd055f50136b8665a2ba59a13840
+  metadata.gz: 3e1f728169a3ebbadce2b17ce18b02573c62bebb
+  data.tar.gz: ae270d791ae918780fc6d73876d1262b767b2d9c
 SHA512:
-  metadata.gz: 17bb6bf3ee490082c5a776fb8d8a80f9a076098fe8debeb1eec4ea7dfeff9f942d8eccf3ad4d888bb91fadd2cc4776da7b1e3b937588be8496aa87a928e92301
-  data.tar.gz: 6bfd5dbfd0bf373283c90a23f05a7269cd0b545a655aa9ab60041e4a0c6ec8d1672b79670cae5fe97a93048642ef1200abd8fd671d12842762c12f073917db4f
+  metadata.gz: 8760ad110627da619df7e9d01886f106d43c0e79b820185dce901aabf38c1ca563fc81f9449af1dee11bad69fcc125c3f6cc262314aefd0a24140eab68b1876d
+  data.tar.gz: e436d08996cb0b17ef1ab0cd8668dbeb3cd44ef60717b4f69b68fe2f46dddb3d470722b7698b73f6fd7ed25bddef9c17a00312417195272fdcf8edfdba12f87f

data/.travis.yml

@@ -4,6 +4,7 @@ rvm:
   - 2.0.0
   - 2.1.0
   - 2.1.1
+  - 2.1.2
 before_install:
   - gem update --system
 branches:

data/Gemfile

@@ -1,7 +1,6 @@
 source 'http://rubygems.org'
 
 # Web servers for different platforms
-
 platform :jruby do
   gem 'puma'
 end
@@ -10,12 +9,11 @@ platform :mri do
   gem 'thin'
 end
 
-# Specify your gem's dependencies in fake_braintree.gemspec
 gemspec
 
-# Capybara 2.1.0 requires 1.9.3+ so we install a version that works with
-# every Ruby version we test against. This can be removed if we stop testing
-# against 1.9.2.
+# Capybara 2.1.0 requires 1.9.3+ so we install a version that works with every
+# Ruby version we test against. This can be removed if we stop testing against
+# 1.9.2.
 gem 'capybara', '~> 2.0.3'
 
 if RUBY_VERSION == '1.9.2'

data/LICENSE

@@ -2,7 +2,7 @@ LICENSE
 
 The MIT License
 
-Copyright (c) 2011-2013 thoughtbot, inc.
+Copyright (c) 2011-2014 thoughtbot, inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/NEWS.md

@@ -1,3 +1,12 @@
+# HEAD
+
+* Remove unused `i18n` gem dependency (#56).
+* Set `credit_card.card_type`, `credit_card.last_4`, and
+  `credit_card.unique_number_identifier`. Ensure `credit_card.bin` is always
+  set (#47).
+* Support new Braintree credit card API URLs
+* Requires Braintree ~> 2.32 instead of Braintree ~> 2.5.
+
 # 0.4.3
 
 * Add missing quote.

data/README.md

@@ -41,6 +41,7 @@ of them (yet).
 * `Braintree::Transaction.refund`
 * `Braintree::Transaction.sale`
 * `Braintree::Transaction.void`
+* `Braintree::Transaction.submit_for_settlement`
 
 ### TransparentRedirect
 * `Braintree::TransparentRedirect.confirm` (only for creating customers)
@@ -74,29 +75,14 @@ If you're using Cucumber, add this too:
       FakeBraintree.clear!
     end
 
-## Spork
+It is advised to run your tests with `js: true` (RSpec) or `@javascript`
+(Cucumber), so that the requests correctly go through `FakeBraintree`. You might
+want to give a look at
+[capybara-webkit](https://github.com/thoughtbot/capybara-webkit).
 
-To use fake\_braintree with Spork, do this:
-
-    # Gemfile
-    group :test do
-      gem 'fake_braintree', require: false
-    end
-
-    # spec/spec_helper.rb
-    Spork.each_run do
-      require 'fake_braintree'
-      # ...other FakeBraintree configuration, for example:
-      # FakeBraintree.verify_all_cards!
-    end
-
-    # features/support/env.rb
-    Spork.each_run do
-      require 'fake_braintree'
-      # ...other FakeBraintree configuration, for example:
-      # FakeBraintree.verify_all_cards!
-    end
+# Credit Cards
 
+* `credit_card.card_type` will always be `"FakeBraintree"`.
 
 ## Verifying credit cards
 
@@ -150,10 +136,13 @@ call it with no arguments.
 
 Full example:
 
-    transaction = FakeBraintree.generate_transaction(amount: '20.00',
-                                                     status: Braintree::Transaction::Status::Settled,
-                                                     subscription_id: 'foobar',
-                                                     created_at: Time.now + 60)
+    transaction = FakeBraintree.generate_transaction(
+      amount: '20.00',
+      status: Braintree::Transaction::Status::Settled,
+      subscription_id: 'foobar',
+      created_at: Time.now + 60
+    )
+
     p transaction
     # {
     #   "status_history" =>
@@ -166,6 +155,11 @@ Full example:
     #   "subscription_id" => "foobar"
     # }
 
+## Running the tests
+
+During tests, debug-level logs will be sent to `tmp/braintree_log`. This is
+useful for seeing which URLs Braintree is actually hitting.
+
 Credits
 -------
 

data/Rakefile

@@ -5,4 +5,4 @@ require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
 
 desc 'Run specs'
-task :default => [:spec]
+task default: [:spec]

data/fake_braintree.gemspec

@@ -17,14 +17,12 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
   s.required_ruby_version = Gem::Requirement.new(">= 1.9.2")
 
-  s.add_dependency 'capybara'
   s.add_dependency 'activesupport'
-  s.add_dependency 'i18n'
+  s.add_dependency 'braintree', '~> 2.32'
+  s.add_dependency 'capybara'
   s.add_dependency 'sinatra'
-  s.add_dependency 'braintree', '~> 2.5'
 
-  s.add_development_dependency 'rspec', '~> 2.12.0'
-  s.add_development_dependency 'bourne', '~> 1.3'
-  s.add_development_dependency 'timecop', '~> 0.6'
   s.add_development_dependency 'rake'
+  s.add_development_dependency 'rspec', '~> 2.14'
+  s.add_development_dependency 'timecop', '~> 0.6'
 end

data/lib/fake_braintree/address.rb

@@ -7,33 +7,33 @@ module FakeBraintree
     end
 
     def create
-      @hash['id'] = generate_id
-      FakeBraintree.registry.addresses[id] = @hash
-      customer['addresses'] << @hash
+      @address['id'] = generate_id
+      FakeBraintree.registry.addresses[id] = @address
+      customer['addresses'] << @address
       response_for_updated_address
     end
 
     def customer
-      FakeBraintree.registry.customers[@hash['customer_id']]
+      FakeBraintree.registry.customers[@address['customer_id']]
     end
 
     def response_for_updated_address
-      gzipped_response(200, @hash.to_xml(root: 'address'))
+      gzipped_response(200, @address.to_xml(root: 'address'))
     end
 
     def set_up_address(address_hash_from_params, options)
-      @hash = {
+      @address = {
         "merchant_id" => options[:merchant_id],
         "customer_id" => options[:customer_id],
       }.merge(address_hash_from_params)
     end
 
     def generate_id
-      "#{@hash['customer_id']}_#{customer['addresses'].size}"
+      "#{@address['customer_id']}_#{customer['addresses'].size}"
     end
 
     def id
-      @hash['id']
+      @address['id']
     end
   end
 end

data/lib/fake_braintree/credit_card.rb

@@ -5,17 +5,21 @@ module FakeBraintree
     def initialize(credit_card_hash_from_params, options)
       set_up_credit_card(credit_card_hash_from_params, options)
       set_billing_address
+      set_bin
+      set_card_type
       set_expiration_month_and_year
+      set_last_4
+      set_unique_number_identifier
     end
 
     def create
       if valid_number?
         if token.nil?
-          @hash['token'] = generate_token
+          @credit_card['token'] = generate_token
         end
-        FakeBraintree.registry.credit_cards[token] = @hash
-        if customer = FakeBraintree.registry.customers[@hash['customer_id']]
-          customer['credit_cards'] << @hash
+        FakeBraintree.registry.credit_cards[token] = @credit_card
+        if customer = FakeBraintree.registry.customers[@credit_card['customer_id']]
+          customer['credit_cards'] << @credit_card
           update_default_card
         end
         response_for_updated_card
@@ -34,14 +38,14 @@ module FakeBraintree
     end
 
     def to_xml
-      @hash.to_xml(root: 'credit_card')
+      @credit_card.to_xml(root: 'credit_card')
     end
 
     def valid_number?
       if FakeBraintree.decline_all_cards?
         false
       elsif FakeBraintree.verify_all_cards
-        FakeBraintree::VALID_CREDIT_CARDS.include?(@hash['number'])
+        FakeBraintree::VALID_CREDIT_CARDS.include?(@credit_card['number'])
       else
         true
       end
@@ -50,23 +54,23 @@ module FakeBraintree
     private
 
     def update_existing_credit_card
-      @hash = credit_card_from_registry.merge!(@hash)
+      @credit_card = credit_card_from_registry.merge!(@credit_card)
       update_default_card
     end
 
-    # When updating a card that has 'default' set to true, make sure
-    # only one card has the flag.
+    # When updating a card that has 'default' set to true, make sure only one
+    # card has the flag.
     def update_default_card
-      if @hash['default']
-        FakeBraintree.registry.customers[@hash['customer_id']]['credit_cards'].each do |card|
+      if @credit_card['default']
+        FakeBraintree.registry.customers[@credit_card['customer_id']]['credit_cards'].each do |card|
           card['default'] = false
         end
-        @hash['default'] = true
+        @credit_card['default'] = true
       end
     end
 
     def response_for_updated_card
-      gzipped_response(200, @hash.to_xml(root: 'credit_card'))
+      gzipped_response(200, @credit_card.to_xml(root: 'credit_card'))
     end
 
     def credit_card_exists_in_registry?
@@ -82,10 +86,11 @@ module FakeBraintree
     end
 
     def response_for_invalid_card
-      gzipped_response(422, FakeBraintree.failure_response.merge(
-          'params' => {credit_card: @hash}
-        ).
-        to_xml(root: 'api_error_response'))
+      body = FakeBraintree.failure_response.merge(
+        'params' => {credit_card: @credit_card}
+      ).to_xml(root: 'api_error_response')
+
+      gzipped_response(422, body)
     end
 
     def expiration_month
@@ -97,7 +102,7 @@ module FakeBraintree
     end
 
     def set_up_credit_card(credit_card_hash_from_params, options)
-      @hash = {
+      @credit_card = {
         'token' => options[:token],
         'merchant_id' => options[:merchant_id],
         'customer_id' => options[:customer_id],
@@ -106,32 +111,52 @@ module FakeBraintree
     end
 
     def set_billing_address
-      if @hash["billing_address_id"]
-        @hash["billing_address"] = FakeBraintree.registry.addresses[@hash['billing_address_id']]
+      if @credit_card["billing_address_id"]
+        @credit_card["billing_address"] = FakeBraintree.registry.addresses[@credit_card['billing_address_id']]
       end
     end
 
+    def set_bin
+      @credit_card['bin'] = number[0, 6]
+    end
+
+    def set_card_type
+      @credit_card['card_type'] = 'FakeBraintree'
+    end
+
     def set_expiration_month_and_year
       if expiration_month
-        @hash['expiration_month'] = expiration_month
+        @credit_card['expiration_month'] = expiration_month
       end
 
       if expiration_year
-        @hash['expiration_year'] = expiration_year
+        @credit_card['expiration_year'] = expiration_year
       end
     end
 
+    def set_last_4
+      @credit_card['last_4'] = number[-4, 4]
+    end
+
+    def number
+      @credit_card['number'].to_s
+    end
+
+    def set_unique_number_identifier
+      @credit_card["unique_number_identifier"] = number
+    end
+
     def generate_token
-      md5("#{@hash['number']}#{@hash['merchant_id']}")
+      md5("#{@credit_card['number']}#{@credit_card['merchant_id']}")
     end
 
     def token
-      @hash['token']
+      @credit_card['token']
     end
 
     def expiration_date_parts
-      if @hash.key?('expiration_date')
-        @hash['expiration_date'].split('/')
+      if @credit_card.key?('expiration_date')
+        @credit_card['expiration_date'].split('/')
       else
         []
       end

data/lib/fake_braintree/helpers.rb

@@ -8,8 +8,8 @@ module FakeBraintree
       ActiveSupport::Gzip.compress(content)
     end
 
-    def gzipped_response(status_code, uncompressed_content)
-      [status_code, { 'Content-Encoding' => 'gzip' }, gzip(uncompressed_content)]
+    def gzipped_response(status_code, uncompressed_body)
+      [status_code, { 'Content-Encoding' => 'gzip' }, gzip(uncompressed_body)]
     end
 
     def md5(content)

data/lib/fake_braintree/sinatra_app.rb

@@ -90,7 +90,7 @@ module FakeBraintree
     end
 
     # Braintree::CreditCard.find
-    get '/merchants/:merchant_id/payment_methods/:credit_card_token' do
+    get '/merchants/:merchant_id/payment_methods/credit_card/:credit_card_token' do
       credit_card = FakeBraintree.registry.credit_cards[params[:credit_card_token]]
       if credit_card
         gzipped_response(200, credit_card.to_xml(root: 'credit_card'))
@@ -100,10 +100,11 @@ module FakeBraintree
     end
 
     # Braintree::CreditCard.update
-    put '/merchants/:merchant_id/payment_methods/:credit_card_token' do
+    put '/merchants/:merchant_id/payment_methods/credit_card/:credit_card_token' do
       credit_card = FakeBraintree.registry.credit_cards[params[:credit_card_token]]
       updates     = hash_from_request_body_with_key('credit_card')
       options     = {token: params[:credit_card_token], merchant_id: params[:merchant_id]}
+
       CreditCard.new(updates, options).update
     end
 
@@ -157,7 +158,7 @@ module FakeBraintree
       gzipped_response(200, transaction_response.to_xml(root: 'transaction'))
     end
 
-
+    # Braintree:Transaction.submit_for_settlement
     put '/merchants/:merchant_id/transactions/:transaction_id/submit_for_settlement' do
       transaction = FakeBraintree.registry.transactions[params[:transaction_id]]
       transaction_response = {'id' => transaction['id'],

data/lib/fake_braintree/version.rb

@@ -1,3 +1,3 @@
 module FakeBraintree
-  VERSION = '0.4.3'
+  VERSION = '0.5.0'
 end

data/spec/fake_braintree/address_spec.rb

@@ -2,8 +2,13 @@ require 'spec_helper'
 
 describe "Braintree::Address.create" do
   it "successfully creates address with valid data" do
-    result = create_customer
-    result = Braintree::Address.create(customer_id: result.customer.id, postal_code: 30339)
-    result.should be_success
+    customer_response = create_customer
+
+    address_response = Braintree::Address.create(
+      customer_id: customer_response.customer.id,
+      postal_code: 30339
+    )
+
+    expect(address_response).to be_success
   end
 end

data/spec/fake_braintree/credit_card_spec.rb

@@ -6,9 +6,12 @@ describe 'Braintree::CreditCard.find' do
     year = '2016'
     credit_card = Braintree::CreditCard.find(token_for(month, year))
 
-    credit_card.last_4.should == TEST_CC_NUMBER[-4,4]
-    credit_card.expiration_month.should == month
-    credit_card.expiration_year.should ==  year
+    expect(credit_card.bin).to eq TEST_CC_NUMBER[0, 6]
+    expect(credit_card.card_type).to eq "FakeBraintree"
+    expect(credit_card.last_4).to eq TEST_CC_NUMBER[-4,4]
+    expect(credit_card.expiration_month).to eq month
+    expect(credit_card.expiration_year).to eq  year
+    expect(credit_card.unique_number_identifier).to eq TEST_CC_NUMBER
   end
 
   def token_for(month, year)
@@ -19,17 +22,18 @@ end
 describe 'Braintree::CreditCard.sale' do
   it 'successfully creates a sale' do
     result = Braintree::CreditCard.sale(cc_token, amount: 10.00)
-    result.should be_success
-    Braintree::Transaction.find(result.transaction.id).should be
+
+    expect(result).to be_success
+    expect(Braintree::Transaction.find(result.transaction.id)).to be
   end
 end
 
-
 describe 'Braintree::CreditCard.create' do
   it 'allows creating a credit card without a customer' do
     result = Braintree::CreditCard.create(build_credit_card_hash)
-    result.should be_success
-    Braintree::CreditCard.find('token').should_not be_nil
+
+    expect(result).to be_success
+    expect(Braintree::CreditCard.find('token')).to_not be_nil
   end
 
   context 'with a customer' do
@@ -39,37 +43,37 @@ describe 'Braintree::CreditCard.create' do
 
     it 'fails to create a credit card if decline_all_cards is set' do
       FakeBraintree.decline_all_cards!
+
       result = Braintree::CreditCard.create(build_credit_card_hash)
-      result.should_not be_success
+
+      expect(result).to_not be_success
       expect { Braintree::CreditCard.find('token') }.to raise_error Braintree::NotFoundError
-      FakeBraintree.clear!
     end
 
     it 'fails to create a credit card if verify_all_cards is set and card is invalid' do
       FakeBraintree.verify_all_cards!
       result = Braintree::CreditCard.create(build_credit_card_hash.merge(number: '12345'))
-      result.should_not be_success
+      expect(result).to_not be_success
       expect { Braintree::CreditCard.find('token') }.to raise_error Braintree::NotFoundError
-      FakeBraintree.verify_all_cards = false
     end
 
     it 'successfully creates a credit card' do
       result = Braintree::CreditCard.create(build_credit_card_hash)
-      result.should be_success
-      Braintree::Customer.find(@customer.id).credit_cards.last.token.should == 'token'
-      Braintree::Customer.find(@customer.id).credit_cards.last.should be_default
-      Braintree::Customer.find(@customer.id).credit_cards.last.billing_address.postal_code.should == "94110"
+      expect(result).to be_success
+      expect(Braintree::Customer.find(@customer.id).credit_cards.last.token).to eq 'token'
+      expect(Braintree::Customer.find(@customer.id).credit_cards.last).to be_default
+      expect(Braintree::Customer.find(@customer.id).credit_cards.last.billing_address.postal_code).to eq "94110"
     end
 
     it 'only allows one credit card to be default' do
       result = Braintree::CreditCard.create(build_credit_card_hash)
-      result.should be_success
+      expect(result).to be_success
       result = Braintree::CreditCard.create(build_credit_card_hash)
-      result.should be_success
+      expect(result).to be_success
       # Reload the customer
       @customer = Braintree::Customer.find(@customer.id)
-      @customer.credit_cards.select(&:default?).length.should == 1
-      @customer.credit_cards.length.should == 2
+      expect(@customer.credit_cards.select(&:default?).length).to eq 1
+      expect(@customer.credit_cards.length).to eq 2
     end
   end
 
@@ -96,8 +100,8 @@ describe 'Braintree::CreditCard.update' do
     token = cc_token
 
     result = Braintree::CreditCard.update(token, expiration_date: new_expiration_date)
-    result.should be_success
-    Braintree::CreditCard.find(token).expiration_date.should == new_expiration_date
+    expect(result).to be_success
+    expect(Braintree::CreditCard.find(token).expiration_date).to eq new_expiration_date
   end
 
   it 'raises an error for a nonexistent credit card' do