fail_fast 0.5.0 → 0.5.1

data/CHANGELOG.txt

@@ -1,6 +1,9 @@
-0.5
+0.5.1
+  - fixed .failed? bug
+  - fixed key prefixes (broken in 0.5.0)
+0.5.0
   - all checkers methods accept a ':message => "CUSTOM MSG"'
-0.4
+0.4.0
   - added `is_on_path`
 0.3.0
   - added value_of()

data/README.markdown

@@ -37,9 +37,11 @@ Early in your project boot sequence insert this code :
 
 	require 'fail_fast'
 	FailFast("path/to/database.yml").check do
-	  has_active_record_db_for  'production'
+	  has_active_record_db_for  'production', :message => 'The main DB cannot be reached :'
 	end
 
+remark : the :message part is always optional.
+
 
 If the DB connection fails,   
 * the application will exit immediately and    
@@ -53,6 +55,7 @@ If the DB connection fails,
     +------------------------------------------------------------------------------------------
     |      error                                   key                                value
     +------------------------------------------------------------------------------------------
+    |  The main DB cannot be reached :
     |  * active_record_db_connection_error      production                          Unknown database 'a_db'
     +------------------------------------------------------------------------------------------
 
@@ -79,7 +82,7 @@ If you want to collect and report all the errors before exiting, use `check_now.
 	    has_url_for       'bug_tracker/url', :reachable => true
 	  end
 	
-	  directory_exists_for  '/tmp'
+	  directory_exists_for  '/tmp', :message => 'the log '
 	  file_exists_for       'public/nda.pdf'
 	
 	  skip_if Rails.env.development? do

data/VERSION

@@ -1 +1 @@
-0.5.0
+0.5.1

data/fail_fast.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{fail_fast}
-  s.version = "0.5.0"
+  s.version = "0.5.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Alain Ravet"]
-  s.date = %q{2010-07-28}
+  s.date = %q{2010-07-29}
   s.description = %q{raises an error if the yaml contents of a config file does not pass a test script.}
   s.email = %q{alainravet@gmail.com}
   s.extra_rdoc_files = [
@@ -59,6 +59,7 @@ Gem::Specification.new do |s|
      "spec/extensions/check_mongo_db_spec.rb",
      "spec/extensions/check_url_spec.rb",
      "spec/extensions/check_value_spec.rb",
+     "spec/extensions/key_prefix_spec.rb",
      "spec/fixtures/empty.yml",
      "spec/fixtures/simple.yml",
      "spec/how_to_use_spec.rb",
@@ -86,6 +87,7 @@ Gem::Specification.new do |s|
      "spec/extensions/check_mongo_db_spec.rb",
      "spec/extensions/check_url_spec.rb",
      "spec/extensions/check_value_spec.rb",
+     "spec/extensions/key_prefix_spec.rb",
      "spec/how_to_use_spec.rb",
      "spec/spec_helper.rb"
   ]

data/lib/fail_fast/extensions/check_active_record_db.rb

@@ -30,12 +30,12 @@ class FailFast
     #   has_active_record_db_for  'production/database'
     #   has_active_record_db_for  'production/database', :message => 'custom message'
     #
-    def has_active_record_db_for(key, *params)
-      p = key_value_regexp_options(key, params)
+    def has_active_record_db_for(raw_key, *params)
+      p = key_value_regexp_options(raw_key, params)
       key, options = p.key, p.options
-      return unless has_value_for key              , :message => options[:message]
-      return unless has_value_for "#{key}/adapter" , :message => options[:message]
-      return unless has_value_for "#{key}/database", :message => options[:message]
+      return unless has_value_for raw_key              , :message => options[:message]
+      return unless has_value_for "#{raw_key}/adapter" , :message => options[:message]
+      return unless has_value_for "#{raw_key}/database", :message => options[:message]
 
       begin
         connection_options = p.value

data/lib/fail_fast/extensions/check_email.rb

@@ -4,11 +4,11 @@ class FailFast
     # Usage
     #  has_email_for 'test/admin_email'
     #
-    def has_email_for(key, *params)
-      p = key_value_regexp_options(key, params)
+    def has_email_for(raw_key, *params)
+      p = key_value_regexp_options(raw_key, params)
       key, options = p.key, p.options
 
-      return unless has_value_for key, :message =>  options[:message]
+      return unless has_value_for raw_key, :message =>  options[:message]
 
       value = value_for_deep_key(key)
       if EmailValidator.invalid_email_address?(value)

data/lib/fail_fast/extensions/check_file_system.rb

@@ -31,11 +31,11 @@ class FailFast
     #   directory_exists_for 'foo/config'
     #   directory_exists_for 'foo/config', :message => 'custom message'
     #
-    def directory_exists_for(key, *params)
-      p = key_value_regexp_options(key, params)
+    def directory_exists_for(raw_key, *params)
+      p = key_value_regexp_options(raw_key, params)
       key, options = p.key, p.options
 
-      return unless has_value_for key, :message => options[:message]
+      return unless has_value_for raw_key, :message => options[:message]
 
       path = value_for_deep_key(key)
       unless File.exists?(path) && File.directory?(path)
@@ -49,11 +49,11 @@ class FailFast
     #   file_exists_for 'foo/config/app.yml'
     #   file_exists_for 'foo/config/app.yml', :message => 'custom message'
     #
-    def file_exists_for(key, *params)
-      p = key_value_regexp_options(key, params)
+    def file_exists_for(raw_key, *params)
+      p = key_value_regexp_options(raw_key, params)
       key, options = p.key, p.options
 
-      return unless has_value_for key, :message => options[:message]
+      return unless has_value_for raw_key, :message => options[:message]
 
       path = value_for_deep_key(key)
       unless File.exists?(path) && File.file?(path)

data/lib/fail_fast/extensions/check_url.rb

@@ -10,10 +10,10 @@ class FailFast
     #   (ex: http://example.com  + http://example.com/)
     #     has_url_for 'test/server_url', :reachable => true, :may_add_trailing_slash => true
     #
-    def has_url_for(key, *params)
-      p = key_value_regexp_options(key, params)
+    def has_url_for(raw_key, *params)
+      p = key_value_regexp_options(raw_key, params)
       key, options = p.key, p.options
-      return unless has_value_for key, :message =>  options[:message]
+      return unless has_value_for raw_key, :message =>  options[:message]
 
       value = value_for_deep_key(key)
       if UrlValidator.invalid_url?(value)

data/lib/fail_fast/support/z_only_for_tests.rb

@@ -1,6 +1,6 @@
 # ONLY USED BY TESTS !!
 class FailFast::ErrorDb
   def global_data
-    errors_for(@@hash.keys.first)
+    @@hash.keys.collect {|key|errors_for(key)}.flatten
   end
 end

data/show_all_errors.rb

@@ -1,4 +1,5 @@
 require 'rubygems'
+gem 'mongo', '1.0'
 require 'mongo'
 
 def fake_http_server

data/spec/base/base_commands_spec.rb

@@ -47,3 +47,21 @@ describe "skip_if" do
     end
   }
 end
+
+describe 'failed?' do
+  example "is false when there are no errors" do
+    FailFast(SIMPLE_FILE_PATH ).check_now.but_fail_later {}
+    FailFast.failed?.should be_false
+  end
+
+  example "is true when there is 1 block and 1 error" do
+    FailFast(UNKNOWN_FILE_PATH).check_now.but_fail_later {} # <-- 1 error here
+    FailFast.failed?.should be_true
+  end
+
+  example "is true when the error block is followed by and error-free empty file block (BUG FIX)" do
+    FailFast(UNKNOWN_FILE_PATH).check_now.but_fail_later {} # <-- 1 error here
+    FailFast(EMPTY_FILE_PATH  ).check_now.but_fail_later {} #no errors in the last block
+    FailFast.failed?.should be_true
+  end
+end

data/spec/extensions/check_url_spec.rb

@@ -4,8 +4,9 @@ describe 'has_url_for()' do
 before(:all) do
     FakeWeb.register_uri(:get, "http://example.com/index.html", :body => "I'm reachable!")
     FakeWeb.register_uri(:get, "http://localhost/index.html"  , :body => "I'm reachable!")
-    FakeWeb.register_uri(:get, "http://example.com"           , :body => "I'm reachable!")
-  end
+    FakeWeb.register_uri(:get, "http://localhost/index.html"  , :body => "I'm reachable!")
+    FakeWeb.register_uri(:get, "http://localhost:3200"        , :body => "I'm reachable!")
+end
 
   it_should_not_raise_an_error('when the value is an url') { has_url_for 'test/url' }
   it_should_not_raise_an_error("when the domain is 'localhost'") { has_url_for 'test/url_localhost' }

data/spec/extensions/key_prefix_spec.rb

@@ -0,0 +1,27 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe 'the key prefix' do
+
+  example 'works fine in all the checkers' do
+    FakeWeb.register_uri(:get, "http://localhost:3200"        , :body => "I'm reachable!")
+
+    conn = Mongo::Connection.new
+    conn.should_receive(:database_names).any_number_of_times.and_return %w(sample_mongoDB)
+    Mongo::Connection.should_receive(:new).and_return(conn)
+
+    arconn = Object.new
+    arconn.should_receive(:active?).and_return(true)
+    ActiveRecord::Base.should_receive(:connection).and_return(arconn)
+
+    FailFast(SIMPLE_FILE_PATH, 'test').check do
+      has_value_for             'email'
+      has_email_for             'email'
+      has_url_for               'url'
+      directory_exists_for      'a_directory'
+      file_exists_for           'a_file'
+      has_mongoDB               'mongoDB'
+      has_active_record_db_for  'db_connection'
+      is_on_path_for            'app_on_path'
+    end
+  end
+end

data/spec/fixtures/simple.yml

@@ -4,12 +4,16 @@ last_key: dernier
 app_on_path: ls
 app_not_on_path: ls0123
 test:
+  app_on_path: ls
   host: localhost
   url: http://example.com/index.html
   url_localhost: http://localhost/index.html
   email: test@example.com
   url_reachable: http://example.com
   url_not_reachable: http://xxx.zzz
+  db_connection:
+    adapter: mysql
+    database: a_db
   mongoDB:
     host: localhost
     database: sample_mongoDB
@@ -32,4 +36,7 @@ db_connection:
 
 number_six: 6
 letter_x: x
-nda_file: <%= SPEC_DIR + '/fixtures/simple.yml' %>
+nda_file: <%= SPEC_DIR + '/fixtures/simple.yml' %>
+development:
+  t_url: 'http://localhost:3200'
+  t_email: t_email@test.com

data/spec/spec_helper.rb

@@ -3,6 +3,7 @@ require 'fail_fast'
 require 'spec'
 require 'spec/autorun'
 require 'fakeweb'
+gem 'mongo', '1.0'
 require 'mongo'
 
 SPEC_DIR = File.dirname(File.expand_path(__FILE__))

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: fail_fast
 version: !ruby/object:Gem::Version 
-  hash: 11
+  hash: 9
   prerelease: false
   segments: 
   - 0
   - 5
-  - 0
-  version: 0.5.0
+  - 1
+  version: 0.5.1
 platform: ruby
 authors: 
 - Alain Ravet
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-07-28 00:00:00 +02:00
+date: 2010-07-29 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -114,6 +114,7 @@ files:
 - spec/extensions/check_mongo_db_spec.rb
 - spec/extensions/check_url_spec.rb
 - spec/extensions/check_value_spec.rb
+- spec/extensions/key_prefix_spec.rb
 - spec/fixtures/empty.yml
 - spec/fixtures/simple.yml
 - spec/how_to_use_spec.rb
@@ -169,5 +170,6 @@ test_files:
 - spec/extensions/check_mongo_db_spec.rb
 - spec/extensions/check_url_spec.rb
 - spec/extensions/check_value_spec.rb
+- spec/extensions/key_prefix_spec.rb
 - spec/how_to_use_spec.rb
 - spec/spec_helper.rb