facturacr 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: c8bf5eb68e70263abef81cfdd2749fe4b94ad7f6
-  data.tar.gz: 2302cca660e93c2d1d4dd2f2072e5a60fafcd129
+SHA256:
+  metadata.gz: 5a8fe4de4d95d4c43eadb53200c1ce6b847554a1970fb9cb803ffdd9b3a5ea93
+  data.tar.gz: a4ba9d8357de2b21305f5c32577e25433d0c477c4996cfdfdc8b42e1f5665935
 SHA512:
-  metadata.gz: 6b718daa726dc9d1171d896e9028891a30500bd683fa6c03c822757fc340e168b5afbb96be365ff3e736538414a17f47d027566cad51aa9e9281c49fdce2cb79
-  data.tar.gz: aee6da72dac27f6ed88ae05e95b84d0dc3052b45b16099e402ca3e6a6180a2d3b4a03f4a41c220a71fa8c32d456831ed851e3d6e6ad9cb07ab605350b340a037
+  metadata.gz: c339e27c622a15a04f9d55924b40bd78529fc31c284517e6dfa6b42473f1fa99993b8667e1a3b3960872c65cef8f674951a5f820564ed3754e159013ac2d0bd6
+  data.tar.gz: 3640e8f8d11d531ad16e801820c9eeb1c3671988338d5cc029548839338ade8ca4b99e467864647940a2851441d1c1a8ade3711d19b92b1bbff9011cc154f4a3

data/facturacr.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.10"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", ">= 12.3.3"
   spec.add_development_dependency "minitest", '~> 5.11'
   spec.add_development_dependency "minitest-colorize", '~> 0.0'
 

data/lib/facturacr.rb

@@ -1,24 +1,25 @@
 require 'awesome_print'
 
-require 'facturacr'
-require 'facturacr/configuration'
-require 'facturacr/element'
-require 'facturacr/document'
-require 'facturacr/invoice'
-require 'facturacr/credit_note'
-require 'facturacr/export_invoice'
-require 'facturacr/purchase_invoice'
-require 'facturacr/debit_note'
-require 'facturacr/ticket'
-require 'facturacr/signed_document'
-require 'facturacr/xml_document'
-require 'facturacr/api'
-require 'facturacr/builder'
-require 'facturacr/version'
-require 'facturacr/data_provider'
-require 'facturacr/signer/signer'
-require 'facturacr/reception_message'
-require 'facturacr/error'
+#require 'facturacr'
+require_relative 'facturacr/configuration'
+require_relative 'facturacr/element'
+require_relative 'facturacr/invoice'
+require_relative 'facturacr/credit_note'
+require_relative 'facturacr/export_invoice'
+require_relative 'facturacr/purchase_invoice'
+require_relative 'facturacr/debit_note'
+require_relative 'facturacr/ticket'
+require_relative 'facturacr/document'
+require_relative 'facturacr/signed_document'
+require_relative 'facturacr/xml_document'
+require_relative 'facturacr/api'
+require_relative 'facturacr/builder'
+require_relative 'facturacr/version'
+require_relative 'facturacr/data_provider'
+require_relative 'facturacr/signer/signer'
+require_relative 'facturacr/reception_message'
+require_relative 'facturacr/error'
+require_relative 'facturacr/data'
 
 module FE
   class << self

data/lib/facturacr/api.rb

@@ -42,7 +42,7 @@ module FE
       else
         url += "/logout"
       end
-      response = RestClient.post url, logout_data
+      RestClient.post url, logout_data
     rescue => e
       puts "LOGOUT ERROR: #{e.message}".red
     end

data/lib/facturacr/builder.rb

@@ -134,7 +134,7 @@ module FE
       else
         summary = args[:summary]
       end
-      FE::Invoice.new date: args[:date], issuer: issuer, receiver: receiver, number: args[:number], items: items, condition: args[:condition], credit_term: args[:credit_term], summary: summary, security_code: args[:security_code], document_situation: args[:document_situation]
+      FE::Invoice.new date: args[:date], issuer: issuer, receiver: receiver, number: args[:number], items: items, condition: args[:condition], credit_term: args[:credit_term], summary: summary, security_code: args[:security_code], document_situation: args[:document_situation], version: args[:version], economic_activity: args[:economic_activity]
     end
     
     def ticket(args = {})
@@ -165,7 +165,7 @@ module FE
       else
         summary = args[:summary]
       end
-      FE::Ticket.new date: args[:date], issuer: issuer, receiver: receiver, number: args[:number], items: items, condition: args[:condition], credit_term: args[:credit_term], summary: summary, security_code: args[:security_code], document_situation: args[:document_situation]
+      FE::Ticket.new date: args[:date], issuer: issuer, receiver: receiver, number: args[:number], items: items, condition: args[:condition], credit_term: args[:credit_term], summary: summary, security_code: args[:security_code], document_situation: args[:document_situation], version: args[:version], economic_activity: args[:economic_activity]
     end
     
     
@@ -207,7 +207,7 @@ module FE
         references = args[:references]
       end
       
-      FE::CreditNote.new date: args[:date], issuer: issuer, receiver: receiver, number: args[:number], items: items, condition: args[:condition], credit_term: args[:credit_term], summary: summary, security_code: args[:security_code], document_situation: args[:document_situation], references: references
+      FE::CreditNote.new date: args[:date], issuer: issuer, receiver: receiver, number: args[:number], items: items, condition: args[:condition], credit_term: args[:credit_term], summary: summary, security_code: args[:security_code], document_situation: args[:document_situation], references: references, version: args[:version], economic_activity: args[:economic_activity]
     end
     
     def debit_note(args = {})
@@ -248,7 +248,7 @@ module FE
         references = args[:references]
       end
       
-      FE::DebitNote.new date: args[:date], issuer: issuer, receiver: receiver, number: args[:number], items: items, condition: args[:condition], credit_term: args[:credit_term], summary: summary, security_code: args[:security_code], document_situation: args[:document_situation], references: references
+      FE::DebitNote.new date: args[:date], issuer: issuer, receiver: receiver, number: args[:number], items: items, condition: args[:condition], credit_term: args[:credit_term], summary: summary, security_code: args[:security_code], document_situation: args[:document_situation], references: references, version: args[:version], economic_activity: args[:economic_activity]
     end
     
     def reception_message(args={})

data/lib/facturacr/configuration.rb

@@ -29,7 +29,7 @@ module FE
     end
 
     def read_config_file
-      if file? && @file_path && File.exists?(@file_path)
+      if file? && @file_path && File.exist?(@file_path)
         template = ERB.new(File.read(@file_path))
         result = YAML.load(template.result(binding))
         result[@environment].each do |k,v|

data/lib/facturacr/credit_note.rb

@@ -32,6 +32,7 @@ module FE
       @security_code = args[:security_code]
       @document_situation = args[:document_situation]
       @references = args[:references]
+      @other_charges = args[:other_charges]
       @namespaces = NAMESPACES[@version]
       @others = args[:others] || []
     end

data/lib/facturacr/data.rb

@@ -0,0 +1,41 @@
+require 'json'
+require 'rest-client'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module FE
+  class Data
+    
+    ENDPOINT = "https://api.hacienda.go.cr"
+    
+    def self.contributor(id_number)
+      response = RestClient.get "#{ENDPOINT}/fe/ae?identificacion=#{id_number}"
+      return JSON.parse(response.body).with_indifferent_access
+    rescue => e
+      puts "FE::Data.contributor(#{id_number}) #{e.message}"
+      return nil
+    end
+    
+    def self.exchange_rate(currency = "USD")
+      if currency.eql?("USD")
+        path = "tc/dolar"
+      elsif currency.eql?("EUR")
+        path = "tc/euro"
+      else
+        raise "#{currency} is not a valid argument"
+      end
+      response = RestClient.get "#{ENDPOINT}/indicadores/#{path}"
+      return JSON.parse(response.body).with_indifferent_access
+    rescue => e
+      puts "FE::Data.exchange_rate(#{currency}) #{e.message}"
+      return nil
+    end
+    
+    def self.exonerations(id_number)
+      response = RestClient.get "#{ENDPOINT}/fe/ex?identificacion=#{id_number}"
+      return JSON.parse(response.body).with_indifferent_access
+    rescue => e
+      puts "FE::Data.exonerations(#{id_number}) #{e.message}"
+      return nil
+    end
+  end
+end

data/lib/facturacr/data_provider.rb

@@ -8,7 +8,7 @@ module FE
     def initialize(source, data)
       source = source.to_s.to_sym
       raise ArgumentError, "source (#{source}) is not valid" if !SOURCES.include?(source)
-      raise ArgumentError, "#{data} does not exist" if source.eql?(:file) && !File.exists?(data)
+      raise ArgumentError, "#{data} does not exist" if source.eql?(:file) && !File.exist?(data)
       
       if source.eql?(:string)
         @contents = data

data/lib/facturacr/debit_note.rb

@@ -33,6 +33,7 @@ module FE
       @security_code = args[:security_code]
       @document_situation = args[:document_situation]
       @references = args[:references]
+      @other_charges = args[:other_charges]
       @namespaces = NAMESPACES[@version]
       @others = args[:others] || []
     end

data/lib/facturacr/document.rb

@@ -41,12 +41,12 @@ module FE
       "3" => "Sin Internet"
     }.freeze
 
+    attr_writer :headquarters, :terminal, :key
     attr_accessor :serial, :date, :issuer, :receiver, :condition, :credit_term,
                   :payment_type, :service_type, :reference_information,
                   :regulation, :number, :document_type, :security_code,
                   :items, :references, :namespaces, :summary, :document_situation,
                   :headquarters, :terminal, :others, :key, :economic_activity, :other_charges, :version
-    
     validates :version, presence: true
     validates :economic_activity, presence: true, if: ->{ version.eql?("4.3") }
     validates :date, presence: true
@@ -63,7 +63,8 @@ module FE
     validates :references, presence: true, if: -> {document_type.eql?("02") || document_type.eql?("03")}
     validates :items, presence:true
     validate :payment_types_ok?
-    
+    validate :other_charges_ok?, if: -> {@other_charges.present?}
+
     def initialize
       raise FE::Error "Subclasses must implement this method"
     end
@@ -103,17 +104,17 @@ module FE
       cons = ("%010d" % @number)
       "#{headquarters}#{terminal}#{@document_type}#{cons}"
     end
-    
+
     def version_42?
       @version.eql?("4.2")
     end
-    
+
     def version_43?
       @version.eql?("4.3")
     end
 
     def build_xml
-      raise FE::Error.new "Documento inválido", class: self.class, messages: errors.messages unless valid?
+      raise FE::Error.new "Documento inválido #{errors.messages}", class: self.class, messages: errors.messages unless valid?
       builder  = Nokogiri::XML::Builder.new(encoding: 'UTF-8')
 
       builder.send(document_tag, @namespaces) do |xml|
@@ -138,8 +139,13 @@ module FE
           end
         end
 
+        if other_charges.present?
+          @other_charges.each do |other_charge|
+            other_charge.build_xml(xml, self)
+          end
+        end
 
-        other_charges.build_xml(xml,self) if other_charges.present? && version_43? # see this
+        #other_charges.build_xml(xml,self) if other_charges.present? && version_43? # see this
 
         summary.build_xml(xml, self)
 
@@ -187,6 +193,15 @@ module FE
 
     private
 
+    def other_charges_ok?
+      if @other_charges.is_a?(Array)
+        errors.add :other_charges, "invalid other_charges: the length can't be greater than 15" if @other_charges.length > 15
+        errors.add :other_charges, "invalid other_charges: not included" unless @other_charges.all? {|i| FE::Document::OtherCharges::OTHER_DOCUMENT_TYPES.include?(i.document_type)}
+      else
+        errors.add :other_charges, "invalid other_charges: not array"
+      end
+    end
+
     def payment_types_ok?
       errors.add :payment_type, "missing payment type" if @payment_type.nil?
       if @payment_type.is_a?(Array)
@@ -198,25 +213,23 @@ module FE
     end
 
   end
-
-
-
 end
 
-require 'facturacr/document/code'
-require 'facturacr/document/exoneration'
-require 'facturacr/document/fax'
-require 'facturacr/document/identification_document'
-require 'facturacr/document/issuer'
-require 'facturacr/document/item'
-require 'facturacr/document/location'
-require 'facturacr/document/phone_type'
-require 'facturacr/document/phone'
-require 'facturacr/document/receiver'
-require 'facturacr/document/reference'
-require 'facturacr/document/regulation'
-require 'facturacr/document/summary'
-require 'facturacr/document/tax'
-require 'facturacr/document/other_text'
-require 'facturacr/document/other_content'
-require 'facturacr/document/other_charges'
+require_relative 'document/code'
+require_relative 'document/exoneration'
+require_relative 'document/fax'
+require_relative 'document/identification_document'
+require_relative 'document/issuer'
+require_relative 'document/item'
+require_relative 'document/location'
+require_relative 'document/phone_type'
+require_relative 'document/phone'
+require_relative 'document/fax'
+require_relative 'document/receiver'
+require_relative 'document/reference'
+require_relative 'document/regulation'
+require_relative 'document/summary'
+require_relative 'document/tax'
+require_relative 'document/other_text'
+require_relative 'document/other_content'
+require_relative 'document/other_charges'

data/lib/facturacr/document/exoneration.rb

@@ -21,6 +21,7 @@ module FE
       validates :institution, presence: true, length: { maximum: 160 }
       validates :date, presence: true
       validates :total_tax,presence: true
+      validates :percentage, presence: true, numericality: {greater_than_or_equal_to: 0, less_than_or_equal_to: 100, only_integer: true}
       
 
       def initialize(args={})

data/lib/facturacr/document/fax.rb

@@ -1,7 +1,4 @@
-require "facturacr/document"
-require 'facturacr/document/phone_type'
-require 'active_model'
-require 'nokogiri'
+require_relative 'phone_type'
 
 module FE
   class Document

data/lib/facturacr/document/identification_document.rb

@@ -1,7 +1,3 @@
-require "facturacr/document"
-require 'active_model'
-require 'nokogiri'
-
 module FE
   class Document
     

data/lib/facturacr/document/issuer.rb

@@ -1,6 +1,3 @@
-require 'active_model'
-require 'nokogiri'
-
 module FE
   class Document
 

data/lib/facturacr/document/item.rb

@@ -6,7 +6,7 @@ module FE
       UNITS = %w[ Al Alc Cm I Os Spe St Sp m kg s A K mol cd m² m³ m/s m/s² 1/m kg/m³ A/m² A/m mol/m³ cd/m² 1 rad sr Hz N Pa J W C V F Ω S Wb T H °C lm
                  lx Bq Gy Sv kat Pa·s N·m N/m rad/s rad/s² W/m² J/K J/(kg·K) J/kg W/(m·K) J/m³ V/m C/m³ C/m² F/m H/m J/mol J/(mol·K)
                  C/kg Gy/s W/sr W/(m²·sr) kat/m³ min h d º ´ ´´ L t Np B eV u ua Unid Gal g Km ln cm mL mm Oz Otros].freeze
-      SERVICE_UNITS = %w[Al Alc Os Spe Sp St]
+      SERVICE_UNITS = %w[Al Alc Os Spe Sp St min h I Cm]
       CODE_TYPES = {
         '01' => 'Código del producto del vendedor',
         '02' => 'Código del producto del comprador',
@@ -30,12 +30,12 @@ module FE
       validates :discount_reason, presence: true, if: -> { discount.present? }
       validates :subtotal, presence: true
       validates :taxable_base, presence: true, if: ->{ taxes.map{ |t| t.code.eql?("07")}.include?(true) && document.version_43? }
-      validates :net_tax,presence:true, if: ->{ exoneration.present? }
+      validates :net_tax,presence:true, if: ->{ taxes.map{ |t| t.exoneration.present? }.include?(true) }
       validates :net_total, presence: true
       validates :comercial_code_type, inclusion: CODE_TYPES.keys, if: -> { comercial_code.present? }
       validates :comercial_code, presence: true, length: {maximum: 20}
-      validates :code, length: {maximum: 13} #TODO this will be mandatory after 2020-01-01
-      
+      validates :code, presence: true, length: {maximum: 13}, if: :code_is_mandatory?
+
       validate :calculations_ok?
 
       def initialize(args = {})
@@ -57,21 +57,21 @@ module FE
         @exoneration = args[:exoneration]
         @net_tax = args[:net_tax]
         @tariff_item = args[:tariff_item]
-        
+        @taxable_base = args[:taxable_base]
 
       end
 
       def build_xml(node, document)
         @document = document
         @document_type = document.document_type
-        raise FE::Error.new("item invalid",class: self.class, messages: errors.messages) unless valid?
+        raise FE::Error.new("item invalid: #{ errors.messages.map{|k,v| "#{k}=#{v.join(". ")}"}.join("; ")}",class: self.class, messages: errors.messages) unless valid?
 
         node = Nokogiri::XML::Builder.new if node.nil?
         node.LineaDetalle do |x|
           x.NumeroLinea @line_number
 
           x.PartidaArancelaria @tariff_item if @tariff_item.present? && document.version_43?
-          
+
           if document.version_43?
             x.Codigo @code if @code.present?
           end
@@ -94,7 +94,7 @@ module FE
           x.Detalle @description
           x.PrecioUnitario @unit_price
           x.MontoTotal @total
-          
+
           if document.version_42?
             x.MontoDescuento @discount if @discount.present?
             x.NaturalezaDescuento @discount_reason if @discount_reason.present?
@@ -113,19 +113,25 @@ module FE
             tax.build_xml(x,document)
           end
 
-          x.ImpuestoNeto @net_tax if @net_tax.present? && @exoneration.present?
+          x.ImpuestoNeto @net_tax if @net_tax.present?
           x.MontoTotalLinea @net_total
         end
 
       end
-      
-      
-      
+
+
+
       def calculations_ok?
         errors.add :total, :invalid_amount, message: 'invalid amount' if (@total - (@quantity * @unit_price).round(5)).abs > 1
       end
 
-
+      def code_is_mandatory?
+        if Time.zone.now >= Time.zone.parse("2020-12-01").beginning_of_day
+          true
+        else
+          false
+        end
+      end
     end
   end
 end

data/lib/facturacr/document/location.rb

@@ -1,7 +1,3 @@
-require "facturacr/document"
-require 'active_model'
-require 'nokogiri'
-
 module FE
   class Document
 

data/lib/facturacr/document/other_text.rb

@@ -17,11 +17,7 @@ module FE
         node.OtroTexto(@xml_attributes) do |xml|
           xml.text(@content)
         end
-      end
-      
-      
-      
-      
+      end  
     end
   end
 end

data/lib/facturacr/document/phone.rb

@@ -1,6 +1,4 @@
-require "facturacr/document"
-require 'facturacr/document/phone_type'
-require 'active_model'
+require_relative 'phone_type'
 
 module FE
   class Document

data/lib/facturacr/document/phone_type.rb

@@ -1,7 +1,3 @@
-require "facturacr/document"
-require 'active_model'
-require 'nokogiri'
-
 module FE
   class Document
     class PhoneType < Element

data/lib/facturacr/document/receiver.rb

@@ -1,4 +1,3 @@
-require "facturacr/document"
 require 'active_model'
 require 'nokogiri'
 

data/lib/facturacr/document/reference.rb

@@ -1,5 +1,3 @@
-require 'facturacr/document'
-
 module FE
   class Document
     class Reference < Element
@@ -36,10 +34,11 @@ module FE
       
 
       validates :document_type, presence: true, inclusion: DOCUMENT_TYPES.keys
-      validates :number, presence: true, length: {maximum: 50}, if: ->{ document_type.present? }
       validates :date, presence: true
-      validates :code, presence: true, length: {is: 2}, inclusion: REFERENCE_CODES.keys, if: ->{ document_type.present? }
-      validates :reason, presence: true, length: {maximum: 180}, if: ->{ document_type.present? }
+
+      validates :number, presence: true, length: {maximum: 50}, if: ->{ document_type.present? && document_type != "13"}
+      validates :code, presence: true, length: {is: 2}, inclusion: REFERENCE_CODES.keys, if: ->{ document_type.present? && document_type != "13" }
+      validates :reason, presence: true, length: {maximum: 180}, if: ->{ document_type.present? && document_type != "13" }
 
       def initialize(args={})
         @document_type = args[:document_type]
@@ -54,10 +53,10 @@ module FE
         node = Nokogiri::XML::Builder.new if node.nil?
         node.InformacionReferencia do |xml|
           xml.TipoDoc @document_type
-          xml.Numero @number
+          xml.Numero @number if @number.present?
           xml.FechaEmision @date.xmlschema
-          xml.Codigo @code
-          xml.Razon @reason
+          xml.Codigo @code if @code.present?
+          xml.Razon @reason if @reason.present?
         end
       end
     end

data/lib/facturacr/document/summary.rb

@@ -5,7 +5,7 @@ module FE
 
       attr_accessor :currency, :exchange_rate, :services_taxable_total, :services_exent_total, :services_exonerate_total,
                     :goods_taxable_total,:goods_exent_total,:goods_exonerate_total, :taxable_total, :exent_total,:exonerate_total,
-                    :subtotal, :discount_total, :gross_total, :tax_total,:total_iva_returned,:total_others_charges, :net_total,
+                    :subtotal, :discount_total, :gross_total, :tax_total,:total_iva_returned,:total_other_charges, :net_total,
                     :with_credit_card, :document_type, :has_exoneration, :medical_services_condition
 
       validates :currency, presence: true
@@ -35,7 +35,7 @@ module FE
         @gross_total = args[:gross_total].to_f
         @tax_total = args[:tax_total].to_f
         @total_iva_returned = args[:total_iva_returned].to_f
-        @total_others_charges =args[:total_others_charges].to_f
+        @total_other_charges = args[:total_other_charges].to_f
         @net_total = args[:net_total].to_f
         @has_exoneration = args[:has_exoneration] || false
         @medical_services_condition = args[:medical_services_condition] || false
@@ -44,17 +44,17 @@ module FE
       def build_xml(node, document)
         @document = document
         @document_type = document.document_type
-        raise FE::Error.new("summary invalid",class: self.class, messages: errors.messages) unless valid?
+        raise FE::Error.new("summary invalid: #{ errors.messages.map{|k,v| "#{k}=#{v.join(". ")}"}.join("; ")}",class: self.class, messages: errors.messages) unless valid?
         node = Nokogiri::XML::Builder.new if node.nil?
 
         node.ResumenFactura do |xml|
           if document.version_42?
             xml.CodigoMoneda @currency if @currency.present?
             xml.TipoCambio @exchange_rate if @exchange_rate.present?
-          elsif document.version_43? && @currency.present? && @currency != "CRC"
+          elsif document.version_43? && @currency.present? #&& @currency != "CRC"
             xml.CodigoTipoMoneda do |x|
               x.CodigoMoneda @currency
-              x.TipoCambio @exchange_rate
+              x.TipoCambio @exchange_rate || 1
             end
           end
 
@@ -73,7 +73,7 @@ module FE
           xml.TotalImpuesto @tax_total
           if document.version_43?
             xml.TotalIVADevuelto @total_iva_returned if @medical_services_condition && !document_type.eql?(FE::ExportInvoice::DOCUMENT_TYPE) && !document_type.eql?(FE::PurchaseInvoice::DOCUMENT_TYPE)
-            xml.TotalOtrosCargos @total_others_charges
+            xml.TotalOtrosCargos @total_other_charges if @total_other_charges > 0
           end
           xml.TotalComprobante @net_total
         end
@@ -87,9 +87,9 @@ module FE
         if document.version_43?
           errors.add :exonerate_total, :invalid_amount, message: 'invalid amount' if (@exonerate_total - (@services_exonerate_total + @goods_exonerate_total).round(5)).abs > 0.0005
         end
-        errors.add :subtotal, :invalid_amount, message: 'invalid amount' if (@subtotal - (@taxable_total + @exent_total + @exonerate_total).round(5)).abs > 0.0005
+        errors.add :subtotal, :invalid_amount, message: 'invalid amount' if (@subtotal - (@taxable_total + @exent_total + @exonerate_total ).round(5)).abs > 0.0005
         errors.add :gross_total, :invalid_amount, message: 'invalid amount' if (@gross_total - (@subtotal - @discount_total).round(5)).abs > 0.0005
-        errors.add :net_total, :invalid_amount, message: "invalid amount" if (@net_total - (@gross_total + @tax_total + @total_others_charges - @total_iva_returned).round(5)).abs > 0.0005
+        errors.add :net_total, :invalid_amount, message: "invalid amount" if (@net_total - (@gross_total + @tax_total + @total_other_charges - @total_iva_returned).round(5)).abs > 0.0005
       end
     end
   end

data/lib/facturacr/document/tax.rb

@@ -35,7 +35,7 @@ module FE
       # It is a mandatory field when a tax is added, it is obtained from the multiplication of the "subtotal" field by "tax rate"
       # And is a decimal number that can be composed of 13 integers and 5 decimals
       validates :total, presence: true, format: { with: /\A\d{1,13}(\.\d{0,5})?\z/ }
-      validates :exoneration, presence:false, if: ->{:document_type.eql?("09")}
+      #validates :exoneration, presence:false, if: ->{:document_type.eql?("09")}
     #  validates :iva_factor, presence: true, if: ->{  }
 
       def initialize(args={})

data/lib/facturacr/invoice.rb

@@ -1,4 +1,4 @@
-require 'facturacr/document'
+require_relative 'document'
 
 module FE
 

data/lib/facturacr/reception_message.rb

@@ -30,18 +30,18 @@ module FE
         "xmlns"=>"https://cdn.comprobanteselectronicos.go.cr/xml-schemas/v4.3/mensajeReceptor"
       }
     }
-
+    attr_writer :headquarters, :terminal, :key
     attr_accessor :key, :date, :issuer_id_number, :receiver_id_number, :message, :details, :economic_activity,
     :tax_condition,:creditable_tax, :applicable_expense,:tax, :total, :number, :receiver_id_type, :security_code,
     :document_situation, :issuer_id_type, :original_version, :version
-    
+
     validates :version, presence: true
     validates :original_version, presence: true, if: -> { version_43? }
     validates :date, presence: true
     validates :issuer_id_number, presence: true, length: {is: 12}
     validates :receiver_id_number, presence: true, length: {is: 12}
     validates :message, presence: true, inclusion: MESSAGE_TYPES.keys
-    validates :tax_condition, inclusion: TAX_CONDITION.keys, presence:true, if: ->{ version_43? && original_version.eql?("4.3")}
+    validates :tax_condition, inclusion: TAX_CONDITION.keys, presence:true, if: ->{ version_43? && original_version.eql?("4.3") && !tax_condition.blank?}
     validates :tax, numericality: true, if: -> { tax.present? }
     validates :total, presence: true, numericality: true
     validates :number, presence: true
@@ -99,14 +99,14 @@ module FE
     def version_42?
       @version.eql?("4.2")
     end
-    
+
     def version_43?
       @version.eql?("4.3")
     end
-    
+
 
     def build_xml
-      raise FE::Error.new "Documento inválido", class: self.class, messages: errors.messages unless valid?
+      raise FE::Error.new "Documento inválido #{errors.messages}", class: self.class, messages: errors.messages unless valid?
       builder  = Nokogiri::XML::Builder.new
 
       builder.MensajeReceptor(@namespaces) do |xml|
@@ -118,11 +118,11 @@ module FE
         xml.MontoTotalImpuesto @tax.to_f if @tax
         if version_43? && @original_version.eql?("4.3")
           xml.CodigoActividad @economic_activity if @economic_activity.present?
-          xml.CondicionImpuesto @tax_condition
+          xml.CondicionImpuesto @tax_condition if @tax_condition.present?
           xml.MontoImpuestoAcreditar @creditable_tax.to_f if @creditable_tax.present?
           xml.MontoTotalDeGastoAplicable @applicable_expense.to_f if @applicable_expense.present?
         end
-        
+
         xml.TotalFactura @total
         xml.NumeroCedulaReceptor @receiver_id_number
         xml.NumeroConsecutivoReceptor sequence

data/lib/facturacr/signed_document.rb

@@ -7,7 +7,7 @@ module FE
     def initialize(document, xml_provider)
       # Backwards compatibility with v0.1.4
       if xml_provider.is_a?(String)
-        raise ArgumentError, "File: #{xml_provider} does not exist" unless File.exists?(xml_provider)
+        raise ArgumentError, "File: #{xml_provider} does not exist" unless File.exist?(xml_provider)
         xml_provider = FE::DataProvider.new(:file, xml_provider)
       end
       raise ArgumentError, "Invalid Argument" unless xml_provider.is_a?(FE::DataProvider)

data/lib/facturacr/signer/signer.rb

@@ -132,7 +132,6 @@ module FE
     
     def build_signed_properties_element
       cert_digest = compute_digest(@x509.to_der,algorithm(SHA256))
-      policy_digest = compute_digest(@x509.to_der,algorithm(SHA256))
       signing_time = DateTime.now.rfc3339
       builder  = Nokogiri::XML::Builder.new
       attributes = {
@@ -153,7 +152,7 @@ module FE
                 xcd.send("ds:DigestValue", cert_digest)
               end
               c.send("xades:IssuerSerial") do |is|
-                is.send("ds:X509IssuerName", @x509.issuer.to_a.reverse.map{|c| c[0..1].join("=")}.join(", "))
+                is.send("ds:X509IssuerName", @x509.issuer.to_a.reverse.map{|x| x[0..1].join("=")}.join(", "))
                 is.send("ds:X509SerialNumber", @x509.serial.to_s)
               end
             end

data/lib/facturacr/version.rb

@@ -1,3 +1,3 @@
 module FE
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/lib/facturacr/xml_document.rb

@@ -2,15 +2,15 @@ require 'nokogiri'
 
 require 'facturacr/document'
 
-module FE  
+module FE
   class XmlDocument
-    
+
     attr_accessor :document, :root_tag, :doc, :xml
-    
+
     def initialize(xml_provider)
       # Backwards compatibility with v0.1.4
       if xml_provider.is_a?(String)
-        raise ArgumentError, "File: #{xml_provider} does not exist" unless File.exists?(xml_provider)
+        raise ArgumentError, "File: #{xml_provider} does not exist" unless File.exist?(xml_provider)
         xml_provider = FE::DataProvider.new(:file, xml_provider)
       end
       raise ArgumentError, "Invalid Argument" unless xml_provider.is_a?(FE::DataProvider)
@@ -19,7 +19,7 @@ module FE
         config.options = Nokogiri::XML::ParseOptions::NOBLANKS | Nokogiri::XML::ParseOptions::NOENT
       end
       root_tag = @doc.elements.first.name
-      
+
       if root_tag.eql?('FacturaElectronica')
         @document = FE::Invoice.new
       elsif root_tag.eql?("NotaCreditoElectronica")
@@ -30,8 +30,10 @@ module FE
         @document = FE::Ticket.new
       elsif root_tag.eql?("MensajeReceptor")
         @document = FE::ReceptionMessage.new
+      else
+        @document = nil
       end
-      
+
       if @document.is_a?(FE::Document)
         @document.version = @doc.elements.first.namespace.href.scan(/v4\..{1}/).first[1..-1]
         @document.date = DateTime.parse(@doc.css("#{root_tag} FechaEmision").first&.text)
@@ -58,7 +60,7 @@ module FE
         location.district = @doc.css("#{root_tag} Emisor Ubicacion Distrito").text
         location.others = @doc.css("#{root_tag} Emisor Ubicacion OtrasSenas").text
         @issuer.location = location
-      
+
         if !@doc.css("#{root_tag} Emisor Telefono").empty?
           @issuer.phone = FE::Document::Phone.new country_code: @doc.css("#{root_tag} Emisor Telefono CodigoPais").text, number: @doc.css("#{root_tag} Emisor Telefono CodigoPais").text
         end
@@ -66,19 +68,19 @@ module FE
           @issuer.fax = FE::Document::Phone.new country_code: @doc.css("#{root_tag} Emisor Telefono CodigoPais").text, number: @doc.css("#{root_tag} Emisor Telefono CodigoPais").text
         end
         @issuer.email = @doc.css("#{root_tag} Emisor CorreoElectronico").text
-      
+
         unless @doc.css("#{root_tag} Receptor").empty?
           @receiver = FE::Document::Receiver.new
           @receiver.name = @doc.css("#{root_tag} Receptor Nombre").text
           unless @doc.css("#{root_tag} Receptor Identificacion").empty?
             @receiver.identification_document = FE::Document::IdentificationDocument.new type: @doc.css("#{root_tag} Receptor Identificacion Tipo").text, number: @doc.css("#{root_tag} Receptor Identificacion Numero").text.to_i
           end
-        
+
           unless @doc.css("#{root_tag} Receptor IdentificacionExtranjero").empty?
             @receiver.foreign_id_number = @doc.css("#{root_tag} Receptor IdentificacionExtranjero").text
           end
           @receiver.comercial_name = @doc.css("#{root_tag} Receptor NombreComercial").text unless @doc.css("#{root_tag} Receptor NombreComercial").empty?
-        
+
           unless @doc.css("#{root_tag} Receptor Ubicacion").empty?
             location = FE::Document::Location.new
             location.province = @doc.css("#{root_tag} Receptor Ubicacion Provincia").text
@@ -87,7 +89,7 @@ module FE
             location.others = @doc.css("#{root_tag} Receptor Ubicacion OtrasSenas").text
             @receiver.location = location
           end
-        
+
           if !@doc.css("#{root_tag} Receptor Telefono").empty?
             @issuer.phone = FE::Document::Phone.new country_code: @doc.css("#{root_tag} Receptor Telefono CodigoPais").text, number: @doc.css("#{root_tag} Receptor Telefono CodigoPais").text
           end
@@ -103,7 +105,9 @@ module FE
           if @document.version_42?
             item.code = line.css("Codigo Codigo").text
           elsif @document.version_43?
-            item.code = line.css("CodigoComercial Codigo").text
+            code = line > "Codigo"
+            item.code = code.text
+            item.comercial_code = line.css("CodigoComercial Codigo").text
           end
           item.quantity = line.css("Cantidad").text
           item.unit = line.css("UnidadMedida").text
@@ -128,13 +132,13 @@ module FE
               exo.percentage = line.css("Exoneracion PorcentajeCompra").text.to_i
               t_args[:exoneration] = exo
             end
-            
+
             item.taxes << FE::Document::Tax.new(t_args)
           end
           @items << item
         end
 
-      
+
         @summary = FE::Document::Summary.new
         sum = @doc.css("#{root_tag} ResumenFactura")
         if @document.version_42?
@@ -155,7 +159,7 @@ module FE
         @summary.gross_total = sum.css("TotalVentaNeta").text.to_f
         @summary.tax_total = sum.css("TotalImpuesto").text.to_f
         @summary.net_total = sum.css("TotalComprobante").text.to_f
-      
+
         refs = @doc.css("#{root_tag} InformacionReferencia")
         @references = []
         unless refs.empty?
@@ -169,20 +173,20 @@ module FE
             @references << reference
           end
         end
-      
+
         reg = @doc.css("#{root_tag} Normativa")
         @regulation = FE::Document::Regulation.new
         @regulation.number = reg.css("NumeroResolucion").text
         @regulation.date = reg.css("FechaResolucion").text
-      
-      
+
+
         @document.issuer = @issuer
         @document.receiver = @receiver
         @document.items = @items
         @document.summary = @summary
         @document.references = @references
-        @document.regulation = @regulation  
-      else
+        @document.regulation = @regulation
+      elsif @document.present?
         @document.date = DateTime.parse(@doc.css("#{root_tag} FechaEmisionDoc").text)
         @key = @doc.css("#{root_tag} Clave").text
         @document.key = @key
@@ -195,11 +199,11 @@ module FE
         @document.security_code = @key[42..-1]
         @document.total = @doc.css("#{root_tag} TotalFactura").text
         @document.tax = @doc.css("#{root_tag} MontoTotalImpuesto").text
-      end      
+      end
     end
-    
+
     def has_tax_node?
       @doc.css("#{root_tag} ResumenFactura TotalImpuesto").any?
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: facturacr
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Josef Sauter
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-09-05 00:00:00.000000000 Z
+date: 2020-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,16 +28,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -178,6 +178,7 @@ files:
 - lib/facturacr/cli/generate.rb
 - lib/facturacr/configuration.rb
 - lib/facturacr/credit_note.rb
+- lib/facturacr/data.rb
 - lib/facturacr/data_provider.rb
 - lib/facturacr/debit_note.rb
 - lib/facturacr/document.rb
@@ -240,10 +241,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Facturación Electrónica de Costa Rica
 test_files: []
-has_rdoc: