factory_json 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1fdcd55cfe7a41a601a71bde443711f27310bc4d
-  data.tar.gz: b456e844dc4cbe95b3d976757672d57cd6e85785
+  metadata.gz: c1f961754dad7697c6a16ddcd68a90873cd86d5a
+  data.tar.gz: e5d402e38bf49d9e3788f823e686e57fb0a2d5bc
 SHA512:
-  metadata.gz: ec268ccc71b6ed66ad2c6f199f32d3f624a50153e1529bc05e7c121ae1a989efd3ab7ee53f75346b0134c01728f9af6a5fd67c7677e3ad3818121b4514b10851
-  data.tar.gz: 72123089a8efd9c9720509dc4b8c4030a7d116851bb707de998c883984a9ec12a1ea89f55c3fa788acfbfad1fe28edcb68c9d08326b6da30fac805ae0ac90a36
+  metadata.gz: 2263468e77128fa5330fd160bf0bb29224dce606fca2f92d75f4ba9608c276731e19af27be92963b9a1c31fcb444e06ad5aad3448cf9b30b042137d6ff3a7960
+  data.tar.gz: 1e4411dbe3fd8ab39f7eb087384b04b5f45ad9d3e1739c17bc55ad684529a2b6e6500169a294dfc858fe72312d344a0fd1dd0259cb88b5b24a7b904bbf13d2e4

data/Gemfile

@@ -8,5 +8,6 @@ gem 'jdbc-sqlite3', platforms: :jruby
 
 gem 'sqlite3', '~> 1.3.10', platforms: :ruby
 
-gem "pry"
-gem "pry-byebug"
+# gem "pry"
+# gem "pry-byebug"
+# gem "pry-stack_explorer"

data/README.md

@@ -126,6 +126,20 @@ user_hash = FactoryGirl.as_json(:user, :with_profile) # to return data as a Ruby
 user_json = FactoryGirl.json(:user, :with_profile) # to return string, that contains valid JSON
 ```
 
+## Testing
+
+Testing is pretty much standard
+
+```bash
+rspec spec
+```
+
+Testing compatibility with FactoryGirl
+
+```bash
+rspec `bundle show factory_girl`/spec
+```
+
 ## Contributing
 
 1. Fork it ( https://github.com/[my-github-username]/factory_json/fork )

data/factory_json.gemspec

@@ -22,11 +22,18 @@ Gem::Specification.new do |spec|
   
   spec.add_dependency "factory_girl"
 
-  spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "mocha", "~> 0.14.0"
+  spec.add_development_dependency "bundler", "~> 1.6"
+  spec.add_development_dependency "rspec", "~> 2.12.0"
+  spec.add_development_dependency "cucumber", "~> 1.3.15"
+  spec.add_development_dependency "aruba"
+  spec.add_development_dependency "mocha", ">= 0.12.8"
   spec.add_development_dependency "bourne"
-
+  spec.add_development_dependency "appraisal", "~> 1.0.0"
+  spec.add_development_dependency "timecop"
   spec.add_development_dependency "activerecord", ">= 3.0.0"
+
+  # Compatibility test
+  spec.add_development_dependency "factory_girl_rails"
+
 end

data/lib/factory_girl/attribute_assigner_with_hash_support.rb

@@ -7,7 +7,7 @@ module FactoryGirl
         attributes_to_set_on_instance.each do |attribute|
           if instance.respond_to?("#{attribute}=")
             instance.public_send("#{attribute}=", get(attribute))
-          elsif instance.respond_to?("[]=")
+          elsif instance.kind_of?(Hash)
             instance[attribute] = get(attribute)
           else
             raise NoMethodError.new("undefined method `#{attribute}=' for #{instance}")

data/lib/factory_json/version.rb

@@ -1,3 +1,3 @@
 module FactoryJson
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/factory_girl/strategy/as_json_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe FactoryGirl::Strategy::AsJSON do
   it_should_behave_like "strategy with association support", :build
-  it_should_behave_like "strategy with callbacks", {}, :after_build, :before_json
+  it_should_behave_like "json strategy with callbacks", {}, :after_build, :before_json
   it_should_behave_like "strategy with strategy: :build", :build
 
   context "Object source" do

data/spec/factory_girl/strategy/json_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe FactoryGirl::Strategy::JSON do
   it_should_behave_like "strategy with association support", :build
-  it_should_behave_like "strategy with callbacks", "{}", :after_build, :before_json
+  it_should_behave_like "json strategy with callbacks", "{}", :after_build, :before_json
   it_should_behave_like "strategy with strategy: :build", :build
 
   context "Object source" do

data/spec/spec_helper.rb

@@ -4,31 +4,31 @@ $LOAD_PATH << File.join(File.dirname(__FILE__))
 require 'rubygems'
 require 'rspec'
 require 'rspec/autorun'
+
 require 'mocha/api'
 require 'bourne'
+require 'timecop'
 
 require 'factory_girl'
 require 'factory_json'
 
-spec = Gem::Specification.find_by_name('factory_girl')
+source_path = Gem::Specification.find_by_name('factory_girl').gem_dir
 
-files = File.join(spec.gem_dir, 'spec', 'support', 'macros', '**', '*.rb')
+files = File.join(source_path, 'spec', 'support', 'macros', '**', '*.rb')
 Dir[files].each { |f| require File.expand_path(f) }
 
-files = File.join(spec.gem_dir, 'spec', 'support', 'matchers', '**', '*.rb')
+files = File.join(source_path, 'spec', 'support', 'matchers', '**', '*.rb')
 Dir[files].each { |f| require File.expand_path(f) }
 
 require "support/shared_examples/strategy"
 
 RSpec.configure do |config|
-  config.expect_with :rspec do |expectations|
-    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
-  end
 
   config.mock_framework = :mocha
   config.include DeclarationMatchers
 
   config.after do
+    Timecop.return
     FactoryGirl.reload
   end
-end
+end

data/spec/support/shared_examples/strategy.rb

@@ -1,3 +1,23 @@
+shared_examples_for "strategy without association support" do
+  let(:factory)   { stub("associate_factory") }
+  let(:attribute) { FactoryGirl::Attribute::Association.new(:user, :user, {}) }
+
+  def association_named(name, overrides)
+    runner = FactoryGirl::FactoryRunner.new(name, :build, [overrides])
+    subject.association(runner)
+  end
+
+  before do
+    FactoryGirl.stubs(factory_by_name: factory)
+    factory.stubs(:compile)
+    factory.stubs(:run)
+  end
+
+  it "returns nil when accessing an association" do
+    expect(association_named(:user, {})).to be_nil
+  end
+end
+
 shared_examples_for "strategy with association support" do |factory_girl_strategy_name|
   let(:factory) { stub("associate_factory") }
 
@@ -48,7 +68,28 @@ shared_examples_for "strategy with strategy: :build" do |factory_girl_strategy_n
   end
 end
 
-shared_examples_for "strategy with callbacks" do |result_instance, *callback_names|
+shared_examples_for "strategy with callbacks" do |*callback_names|
+  let(:result_instance) do
+    define_class("ResultInstance") do
+      attr_accessor :id
+    end.new
+  end
+
+  let(:evaluation) { stub("evaluation", object: result_instance, notify: true, create: nil) }
+
+  it "runs the callbacks #{callback_names} with the evaluation's object" do
+    subject.result(evaluation)
+    callback_names.each do |name|
+      expect(evaluation).to have_received(:notify).with(name, evaluation.object)
+    end
+  end
+
+  it "returns the object from the evaluation" do
+    expect(subject.result(evaluation)).to eq evaluation.object
+  end
+end
+
+shared_examples_for "json strategy with callbacks" do |result_instance, *callback_names|
   let(:object) {{}}
   let(:evaluation) { stub("evaluation", object: object, notify: true, create: nil) }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: factory_json
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - E-Max
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-15 00:00:00.000000000 Z
+date: 2015-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: factory_girl
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -39,7 +53,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.12.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.12.0
+- !ruby/object:Gem::Dependency
+  name: cucumber
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.15
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.15
+- !ruby/object:Gem::Dependency
+  name: aruba
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,7 +95,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.12.8
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.12.8
+- !ruby/object:Gem::Dependency
+  name: bourne
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,21 +123,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: mocha
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: 1.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
-  name: bourne
+  name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -108,6 +164,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
+- !ruby/object:Gem::Dependency
+  name: factory_girl_rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: FactoryGirl can now handle JSON representation for an object.
 email:
 - max.zab87@gmail.com