factory_json 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 46bd43eb84be63ce213d2aa07324182523b194c0
-  data.tar.gz: 0ebcafa553e503bb5bb140426e7e95ef55e721b0
+  metadata.gz: 1fdcd55cfe7a41a601a71bde443711f27310bc4d
+  data.tar.gz: b456e844dc4cbe95b3d976757672d57cd6e85785
 SHA512:
-  metadata.gz: 21478e944982ce49bf27bb74d1a9d48aa914ea60693bf05f13cc2708090ae2c3a68f36eec295bee2e13691f00e251f1efaa8007b0d15c215fc697b9fb5db4ab0
-  data.tar.gz: f41687a7e44449836e34aa69924098f23743cf33db5d00ac74972c98de6dd946f8cd0086ec97625dd8e8c3a7fdadc416d2605d46baf63379adf0de9fef13c3a4
+  metadata.gz: ec268ccc71b6ed66ad2c6f199f32d3f624a50153e1529bc05e7c121ae1a989efd3ab7ee53f75346b0134c01728f9af6a5fd67c7677e3ad3818121b4514b10851
+  data.tar.gz: 72123089a8efd9c9720509dc4b8c4030a7d116851bb707de998c883984a9ec12a1ea89f55c3fa788acfbfad1fe28edcb68c9d08326b6da30fac805ae0ac90a36

data/Gemfile

@@ -2,3 +2,11 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in factory_json.gemspec
 gemspec
+
+gem 'activerecord-jdbcsqlite3-adapter', platforms: :jruby
+gem 'jdbc-sqlite3', platforms: :jruby
+
+gem 'sqlite3', '~> 1.3.10', platforms: :ruby
+
+gem "pry"
+gem "pry-byebug"

data/README.md

@@ -28,7 +28,16 @@ Tired of creating json fixtures somewhere in your app and keeping them up to dat
 ```ruby
 # spec/factories/data_structures.rb
 FactoryGirl.define do
-  factory :entry_relation, class: 'Hash' do
+  factory :entry, class: Hash do
+    name "This one is special"
+    location "The place where you can always see a Sunrise"
+
+    after(:build) do |entry|
+      entry[:relations] = FactoryGirl.build_list(entry_relation, 3, :with_address)
+    end
+  end
+
+  factory :entry_relation, class: Hash do
     type "RELATED"
     label "Apartment:"
     name_summary "Mr Darth Vader"
@@ -54,9 +63,45 @@ entry_relation = FactoryGirl.json(:entry_relation, :with_address) # to return st
 You have a factory that you'd also like to use as a JSON fixture? Use common usage patterns (to_json) with our fixtures now! Not only can you get JSON from your factories, but of course also Hashes. All you need to do is to define to_json or to_hash (since to_json is based on to_hash) on your model.
 
 ```ruby
-# spec/factories/users.rb
+# app/models.rb
+class User
+
+  has_one :profile
+
+  def to_hash
+    {
+      name: self.name,
+      email: self.email,
+      profile: profile.to_hash
+    }.to_json
+  end
+
+  def to_json(*args)
+    to_hash.to_json(*args)
+  end
+end
+
+class Profile
+
+  belongs_to :user
+
+  def to_hash
+    {
+      age: self.age,
+      hair_color: self.hair_color,
+      child_dream: self.child_dream,
+      i_will_start_running: "tomorrow"
+    }
+  end
+
+  def to_json(*args)
+    to_hash.to_json(*args)
+  end
+end
+
+# spec/factories.rb
 FactoryGirl.define do
-  factory :user, class: 'User' do
+  factory :user do
     name "User 1"
     email "test@example.com"
 
@@ -64,17 +109,11 @@ FactoryGirl.define do
       association :profile
     end
   end
-end
-
-# app/models/user.rb
-class User
 
-  def to_json
-    {
-      name: self.name,
-      email: self.email,
-      profile: profile.to_hash
-    }.to_json
+  factory :profile do
+    age "18 years"
+    hair_color "blue"
+    child_dream "To become a Jedi Knight"
   end
 end
 ```

data/factory_json.gemspec

@@ -18,10 +18,15 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.required_ruby_version = '~> 2.0'
+  
   spec.add_dependency "factory_girl"
 
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
-  spec.add_development_dependency "mocha", ">= 0.12.8"
+  spec.add_development_dependency "mocha", "~> 0.14.0"
+  spec.add_development_dependency "bourne"
+
+  spec.add_development_dependency "activerecord", ">= 3.0.0"
 end

data/lib/factory_girl/attribute_assigner_with_hash_support.rb

@@ -0,0 +1,20 @@
+module FactoryGirl
+  module AttributeAssignerWithHashSupport
+
+    def object
+      @evaluator.instance = build_class_instance
+      build_class_instance.tap do |instance|
+        attributes_to_set_on_instance.each do |attribute|
+          if instance.respond_to?("#{attribute}=")
+            instance.public_send("#{attribute}=", get(attribute))
+          elsif instance.respond_to?("[]=")
+            instance[attribute] = get(attribute)
+          else
+            raise NoMethodError.new("undefined method `#{attribute}=' for #{instance}")
+          end
+          @attribute_names_assigned << attribute
+        end
+      end
+    end
+  end
+end

data/lib/factory_girl/strategy/as_json.rb

@@ -1,21 +1,20 @@
 module FactoryGirl
   module Strategy
     class AsJSON
-      def association(runner)
-        runner.run(:null)
+      def initialize
+        @strategy = FactoryGirl.strategy_by_name(:build).new
       end
 
-      def result(evaluation)
-        source = 
-          build_class_is_hash?(evaluation) ? evaluation.hash : evaluation.object
-
-        ::JSON.parse source.to_json
+      def association(runner)
+        runner.instance_variable_set :@strategy, :build
+        runner.run
       end
 
-      private
+      def result(evaluation)
+        result = @strategy.result(evaluation)
+        evaluation.notify(:before_json, result)
 
-      def build_class_is_hash?(evaluation)
-        evaluation.instance_variable_get(:@attribute_assigner).instance_variable_get(:@build_class) == Hash
+        ::JSON.parse result.to_json
       end
     end
   end

data/lib/factory_girl/strategy/json.rb

@@ -1,21 +1,20 @@
 module FactoryGirl
   module Strategy
     class JSON
+      def initialize
+        @strategy = FactoryGirl.strategy_by_name(:build).new
+      end
+      
       def association(runner)
-        runner.run(:null)
+        runner.instance_variable_set :@strategy, :build
+        runner.run
       end
 
       def result(evaluation)
-        source = 
-          build_class_is_hash?(evaluation) ? evaluation.hash : evaluation.object
-
-        source.to_json
-      end
-
-      private
+        result = @strategy.result(evaluation)
+        evaluation.notify(:before_json, result)
 
-      def build_class_is_hash?(evaluation)
-        evaluation.instance_variable_get(:@attribute_assigner).instance_variable_get(:@build_class) == Hash
+        result.to_json
       end
     end
   end

data/lib/factory_json.rb

@@ -1,7 +1,13 @@
+require 'json'
+require "factory_girl"
+
 require "factory_json/version"
 
 require "factory_girl/strategy/json"
 require "factory_girl/strategy/as_json"
+require "factory_girl/attribute_assigner_with_hash_support"
 
 FactoryGirl.register_strategy(:json,  FactoryGirl::Strategy::JSON)
 FactoryGirl.register_strategy(:as_json,  FactoryGirl::Strategy::AsJSON)
+
+FactoryGirl::AttributeAssigner.prepend FactoryGirl::AttributeAssignerWithHashSupport

data/lib/factory_json/version.rb

@@ -1,3 +1,3 @@
 module FactoryJson
-  VERSION = "0.0.1"
+  VERSION = "0.1.0"
 end

data/spec/factory_girl/strategy/as_json_spec.rb

@@ -1,17 +1,14 @@
-
 require 'spec_helper'
 
 describe FactoryGirl::Strategy::AsJSON do
-  it_should_behave_like "strategy without association support"
+  it_should_behave_like "strategy with association support", :build
+  it_should_behave_like "strategy with callbacks", {}, :after_build, :before_json
+  it_should_behave_like "strategy with strategy: :build", :build
 
   context "Object source" do
     let(:result)     { { "name" => "John Doe", "gender" => "Male", "admin" => false } }
     let(:object)     { stub("user", to_json: result.to_json, ) }
-    let(:evaluation) { stub("evaluation", object: object) }
-
-    before(:each) do
-      subject.stubs(:build_class_is_hash?).returns(false)
-    end
+    let(:evaluation) { stub("evaluation", object: object, notify: true) }
 
     it "pipes hash through JSON lib" do
       JSON.expects(:parse).with(kind_of(String))
@@ -32,12 +29,8 @@ describe FactoryGirl::Strategy::AsJSON do
 
   context "Hash source" do
     let(:result)     { { "name" => "John Doe", "gender" => "Male", "admin" => false } }
-    let(:hash)     { { name: "John Doe", gender: "Male", admin: false } }
-    let(:evaluation) { stub("evaluation", hash: hash) }
-
-    before(:each) do
-      subject.stubs(:build_class_is_hash?).returns(true)
-    end
+    let(:hash)       { { name: "John Doe", gender: "Male", admin: false } }
+    let(:evaluation) { stub("evaluation", object: hash, notify: true) }
 
     it "pipes hash through JSON lib" do
       JSON.expects(:parse).with(kind_of(String))

data/spec/factory_girl/strategy/json_spec.rb

@@ -1,17 +1,14 @@
-
 require 'spec_helper'
 
 describe FactoryGirl::Strategy::JSON do
-  it_should_behave_like "strategy without association support"
+  it_should_behave_like "strategy with association support", :build
+  it_should_behave_like "strategy with callbacks", "{}", :after_build, :before_json
+  it_should_behave_like "strategy with strategy: :build", :build
 
   context "Object source" do
     let(:result)     { { "name" => "John Doe", "gender" => "Male", "admin" => false }.to_json }
     let(:object)     { stub("user", to_json: result) }
-    let(:evaluation) { stub("evaluation", object: object) }
-
-    before(:each) do
-      subject.stubs(:build_class_is_hash?).returns(false)
-    end
+    let(:evaluation) { stub("evaluation", object: object, notify: true) }
 
     it "returns to_hash from the evaluation for an object" do
       expect(subject.result(evaluation)).to eq(result)
@@ -27,11 +24,7 @@ describe FactoryGirl::Strategy::JSON do
   context "Hash source" do
     let(:result)     { { "name" => "John Doe", "gender" => "Male", "admin" => false }.to_json }
     let(:hash)       { { name: "John Doe", gender: "Male", admin: false } }
-    let(:evaluation) { stub("evaluation", hash: hash) }
-
-    before(:each) do
-      subject.stubs(:build_class_is_hash?).returns(true)
-    end
+    let(:evaluation) { stub("evaluation", object: hash, notify: true) }
 
     it "returns the hash from the evaluation" do
       expect(subject.result(evaluation)).to eq result

data/spec/spec_helper.rb

@@ -3,14 +3,22 @@ $LOAD_PATH << File.join(File.dirname(__FILE__))
 
 require 'rubygems'
 require 'rspec'
-require 'json'
+require 'rspec/autorun'
 require 'mocha/api'
+require 'bourne'
 
 require 'factory_girl'
 require 'factory_json'
 
 spec = Gem::Specification.find_by_name('factory_girl')
-require File.join(spec.gem_dir, 'spec', 'support', 'shared_examples', 'strategy')
+
+files = File.join(spec.gem_dir, 'spec', 'support', 'macros', '**', '*.rb')
+Dir[files].each { |f| require File.expand_path(f) }
+
+files = File.join(spec.gem_dir, 'spec', 'support', 'matchers', '**', '*.rb')
+Dir[files].each { |f| require File.expand_path(f) }
+
+require "support/shared_examples/strategy"
 
 RSpec.configure do |config|
   config.expect_with :rspec do |expectations|
@@ -18,6 +26,7 @@ RSpec.configure do |config|
   end
 
   config.mock_framework = :mocha
+  config.include DeclarationMatchers
 
   config.after do
     FactoryGirl.reload

data/spec/support/shared_examples/strategy.rb

@@ -0,0 +1,65 @@
+shared_examples_for "strategy with association support" do |factory_girl_strategy_name|
+  let(:factory) { stub("associate_factory") }
+
+  def association_named(name, strategy, overrides)
+    runner = FactoryGirl::FactoryRunner.new(name, strategy, [overrides])
+    subject.association(runner)
+  end
+
+  before do
+    FactoryGirl.stubs(factory_by_name: factory)
+    factory.stubs(:compile)
+    factory.stubs(:run)
+  end
+
+  it "runs the factory with the correct overrides" do
+    association_named(:author, factory_girl_strategy_name, great: "value")
+    expect(factory).to have_received(:run).with(factory_girl_strategy_name, great: "value")
+  end
+
+  it "finds the factory with the correct factory name" do
+    association_named(:author, factory_girl_strategy_name, great: "value")
+    expect(FactoryGirl).to have_received(:factory_by_name).with(:author)
+  end
+end
+
+shared_examples_for "strategy with strategy: :build" do |factory_girl_strategy_name|
+  let(:factory) { stub("associate_factory") }
+
+  def association_named(name, overrides)
+    runner = FactoryGirl::FactoryRunner.new(name, overrides[:strategy], [overrides.except(:strategy)])
+    subject.association(runner)
+  end
+
+  before do
+    FactoryGirl.stubs(factory_by_name: factory)
+    factory.stubs(:compile)
+    factory.stubs(:run)
+  end
+
+  it "runs the factory with the correct overrides" do
+    association_named(:author, strategy: :build, great: "value")
+    expect(factory).to have_received(:run).with(factory_girl_strategy_name, { great: "value" })
+  end
+
+  it "finds the factory with the correct factory name" do
+    association_named(:author, strategy: :build, great: "value")
+    expect(FactoryGirl).to have_received(:factory_by_name).with(:author)
+  end
+end
+
+shared_examples_for "strategy with callbacks" do |result_instance, *callback_names|
+  let(:object) {{}}
+  let(:evaluation) { stub("evaluation", object: object, notify: true, create: nil) }
+
+  it "runs the callbacks #{callback_names} with the evaluation's object" do
+    subject.result(evaluation)
+    callback_names.each do |name|
+      expect(evaluation).to have_received(:notify).with(name, evaluation.object)
+    end
+  end
+
+  it "returns the object from the evaluation" do
+    expect(subject.result(evaluation)).to eq result_instance
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: factory_json
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - E-Max
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-13 00:00:00.000000000 Z
+date: 2015-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: factory_girl
@@ -69,17 +69,45 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.14.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.14.0
+- !ruby/object:Gem::Dependency
+  name: bourne
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.12.8
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.12.8
+        version: 3.0.0
 description: FactoryGirl can now handle JSON representation for an object.
 email:
 - max.zab87@gmail.com
@@ -94,6 +122,7 @@ files:
 - README.md
 - Rakefile
 - factory_json.gemspec
+- lib/factory_girl/attribute_assigner_with_hash_support.rb
 - lib/factory_girl/strategy/as_json.rb
 - lib/factory_girl/strategy/json.rb
 - lib/factory_json.rb
@@ -101,6 +130,7 @@ files:
 - spec/factory_girl/strategy/as_json_spec.rb
 - spec/factory_girl/strategy/json_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_examples/strategy.rb
 homepage: https://github.com/local-ch/factory_json
 licenses:
 - MIT
@@ -111,9 +141,9 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -129,3 +159,4 @@ test_files:
 - spec/factory_girl/strategy/as_json_spec.rb
 - spec/factory_girl/strategy/json_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_examples/strategy.rb