factory_girl_remote_strategy 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1bd2d2572ab0367269268716ba1a455f7a2fd60d
-  data.tar.gz: f9331007bf708479bbc1d105e3828003097c055a
+  metadata.gz: 21f90569049c4f8d008001aa7c40efafd2b39a02
+  data.tar.gz: 725032e1c2b679209979bb677c692cdb63343f83
 SHA512:
-  metadata.gz: 49f8a43abee55530a7b84c1f3182e9818d0bb66d253ea47e611f34917e38dc27a1dcc4b10a4dd3dd2831ff5c50ed95d151aae2b356eb6e596edf813feff0e634
-  data.tar.gz: fac74153c6c9f41b5f8ee14ecaa557ea88e21d6f31255bb1b037a8699e7457af55a75bda907db92301f3655e56ca5f858f6e7dde882dc2e98b6f033d9c0a8785
+  metadata.gz: 830e4ca93da006123847430bb2660c11eeab35ff68f2d377c0aca772a30d5847219d6a101c140b1881ea3038562d5820b74a4a4c58a87aaa2ca0ddf20fb3cbe2
+  data.tar.gz: 0818258efe070db446ab90cf99797351c3863075bcecc3a63f8c842e091d3589ad27c3eb36c836be5943951930b9f559f0b00068e480a81560be2ac43d24b344

data/README.md

@@ -1,6 +1,7 @@
 # factory_girl_remote_strategy
 
 FactoryGirl strategy for ActiveResource models.
+Stubs remote HTTP requests with [WebMock](https://github.com/bblimke/webmock) or [FakeWeb](https://github.com/chrisk/fakeweb)
 
 ## Installation
 
@@ -16,9 +17,27 @@ Or install it yourself as:
 
     $ gem install factory_girl_remote_strategy
 
-## Usage
+## Usage with WebMock and RSpec
 
-TODO: Write usage instructions here
+Add this in `spec/spec_helper.rb`
+
+```ruby
+require 'webmock/rspec'
+WebMock.disable_net_connect!(allow_localhost: true)
+FactoryGirl::RemoteStrategy.stub_requests_with :webmock
+```
+
+If you do not use RSpec for more info please see [WebMock README](https://github.com/bblimke/webmock)
+
+## Usage with FakeWeb
+
+Add this in the helper method for your tests suite (for RSpec `spec/spec_helper.rb`)
+
+```ruby
+require 'fakeweb'
+FakeWeb.allow_net_connect = false
+FactoryGirl::RemoteStrategy.stub_requests_with :fakeweb
+```
 
 ## Contributing
 
@@ -27,3 +46,10 @@ TODO: Write usage instructions here
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+## Testing
+
+```ruby
+LIBRARY=webmock rspec
+LIBRARY=fakeweb rspec
+```

data/factory_girl_remote_strategy.gemspec

@@ -21,8 +21,9 @@ Gem::Specification.new do |spec|
   spec.add_dependency "activesupport", '>= 3.2'
   spec.add_dependency "activeresource", '>= 3.2'
   spec.add_dependency "factory_girl"
-  spec.add_dependency "fakeweb"
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "webmock"
+  spec.add_development_dependency "fakeweb"
 end

data/lib/factory_girl_remote_strategy.rb

@@ -23,8 +23,8 @@ module FactoryGirl
 
     def result(evaluation)
       @strategy.result(evaluation).tap do |e|
-        FakeWeb.register_uri(:get, self.class.entity_url(e), body: self.class.entity_hash(e).to_json)
-        FakeWeb.register_uri(:put, self.class.entity_url(e), body: self.class.entity_hash(e).to_json)
+        self.class.register_request(:get, self.class.entity_url(e), body: self.class.entity_hash(e).to_json)
+        self.class.register_request(:put, self.class.entity_url(e), body: self.class.entity_hash(e).to_json)
         remote_search(e, search: { :"#{e.class.primary_key}_eq" => e.public_send(e.class.primary_key) })
         remote_search(e, search: { :"#{e.class.primary_key}_in" => [e.public_send(e.class.primary_key)] })
         evaluation.notify(:after_remote, e) # runs after(:remote) callback
@@ -66,6 +66,23 @@ module FactoryGirl
       def collection_url(collection, params = {})
         (collection.first.is_a?(Class) ? collection.first : collection.first.class).instance_eval { "#{site}#{prefix}#{collection_name}.json#{'?' if params.any?}#{params.to_query}" }
       end
+
+      def stub_requests_with(library)
+        library = library.to_s
+        raise ArgumentError, "Unknown library '#{library}', please try :webmock or :fakeweb" unless %w(webmock fakeweb).include?(library)
+        require library
+        @@library = library.to_sym
+      rescue LoadError
+        worn "WARNING: gem '#{library}' is not installed"
+      end
+
+      def register_request(http_method, uri, options)
+        if @@library == :fakeweb
+          FakeWeb.register_uri(http_method, uri, options)
+        else
+          WebMock.stub_request(http_method, uri).to_return(options)
+        end
+      end
     end
   end
 
@@ -74,7 +91,7 @@ module FactoryGirl
       @strategy.result(evaluation).tap do |e|
         body = { errors: [{ code: 'resource_not_found',
           message: "Couldn't find #{e.class} with #{e.class.primary_key}=#{e.public_send(e.class.primary_key)}" } ] }.to_json
-        FakeWeb.register_uri(:get, self.class.entity_url(e), body: body, status: 404)
+        self.class.register_request(:get, self.class.entity_url(e), body: body, status: 404)
         remote_search(e.class, search: { :"#{e.class.primary_key}_eq" => e.public_send(e.class.primary_key) }) # empty search
         remote_search(e.class, search: { :"#{e.class.primary_key}_in" => [e.public_send(e.class.primary_key)] }) # empty search
       end
@@ -91,6 +108,6 @@ FactoryGirl.register_strategy(:remote_not_found, FactoryGirl::RemoteNotFoundStra
 def remote_search(*args)
   params = args.extract_options!
   collection = args.flatten
-  FakeWeb.register_uri(:get, FactoryGirl::RemoteStrategy.collection_url(collection, params),
+  ::FactoryGirl::RemoteStrategy.register_request(:get, FactoryGirl::RemoteStrategy.collection_url(collection, params),
     body: (collection.first.is_a?(Class) ? "[]" : collection.map { |e| FactoryGirl::RemoteStrategy.entity_hash(e, params) }.to_json))
 end

data/lib/factory_girl_remote_strategy/version.rb

@@ -1,3 +1,3 @@
 module FactoryGirlRemoteStrategy
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/spec/factory_girl_remote_strategy_spec.rb

@@ -14,7 +14,7 @@ describe FactoryGirl::RemoteStrategy do
       FactoryGirl.remote(:incident, id: 1)
       expect { Incident.find(1) }.not_to raise_error
       incident = Incident.find(1)
-      incident.should be_kind_of Incident
+      expect(incident).to be_kind_of Incident
     end
   end
 
@@ -25,24 +25,24 @@ describe FactoryGirl::RemoteStrategy do
     it "remote associations are added to response json" do
       FactoryGirl.remote(:incident, id: 3, victims: victims)
       incident = Incident.find(3)
-      incident.victims.should be_kind_of Array
-      incident.victims.first.should be_kind_of Victim
+      expect(incident.victims).to be_kind_of Array
+      expect(incident.victims.first).to be_kind_of Victim
     end
 
     it "allows to create has_many association with <assotiation(s)>_ids option" do
       FactoryGirl.remote(:incident, id: 4, victim_ids: [2, 3])
       incident = Incident.find(4)
-      incident.victims.should be_kind_of Array
-      incident.victims.first.should be_kind_of Victim
+      expect(incident.victims).to be_kind_of Array
+      expect(incident.victims.first).to be_kind_of Victim
 
       expect { Victim.find(2) }.not_to raise_error
       victim = Victim.find(2)
-      victim.should eq incident.victims.first
+      expect(victim).to eq incident.victims.first
     end
 
     it "belongs_to association id is added to response json" do
       membership = FactoryGirl.remote(:membership, group: group)
-      membership.group_id.should == group.id
+      expect(membership.group_id).to eq(group.id)
     end
   end
 
@@ -51,7 +51,7 @@ describe FactoryGirl::RemoteStrategy do
       incident = FactoryGirl.remote(:incident, reported_by: 4)
       expect { User.find(4) }.not_to raise_error
       user = User.find(4)
-      user.should be_kind_of User
+      expect(user).to be_kind_of User
     end
   end
 
@@ -60,15 +60,15 @@ describe FactoryGirl::RemoteStrategy do
       remote_search FactoryGirl.remote_list(:membership, 2), search: { premises_id_in: [4] }
       expect { Membership.find(:all, params: { search: { premises_id_in: [4] } }) }.not_to raise_error
       memberships = Membership.find(:all, params: { search: { premises_id_in: [4] } }).to_a
-      memberships.should be_kind_of Array
-      memberships.first.should be_kind_of Membership
+      expect(memberships).to be_kind_of Array
+      expect(memberships.first).to be_kind_of Membership
     end
 
     it "registers search url of empty collection if provided model class (no first element)" do
       remote_search Membership, search: { premises_id_in: [4] }
       expect { Membership.find(:all, params: { search: { premises_id_in: [4] } }) }.not_to raise_error
       memberships = Membership.find(:all, params: { search: { premises_id_in: [4] } }).to_a
-      memberships.should eq []
+      expect(memberships).to eq []
     end
 
     context "standard ActiveResource JSON formatter with included root" do
@@ -90,13 +90,13 @@ describe FactoryGirl::RemoteStrategy do
       it "registers search url for equality <primary_key>_eq = <value>" do
         expect { User.find(:first, params: { search: { id_eq: 4 } }) }.not_to raise_error
         user = User.find(:first, params: { search: { id_eq: 4 } })
-        user.id.should == 4
+        expect(user.id).to eq(4)
       end
 
       it "registers search url for inclusion <primary_key>_in [<value>]" do
         expect { User.find(:first, params: { search: { id_in: [4] } }) }.not_to raise_error
         user = User.find(:first, params: { search: { id_in: [4] } })
-        user.id.should == 4
+        expect(user.id).to eq(4)
       end
     end
 
@@ -106,13 +106,13 @@ describe FactoryGirl::RemoteStrategy do
       it "registers search url for equality <primary_key>_eq = <value>" do
         expect { Postcode.find(:first, params: { search: { code_eq: 'ABCD' } }) }.not_to raise_error
         postcode = Postcode.find(:first, params: { search: { code_eq: 'ABCD' } })
-        postcode.code.should == 'ABCD'
+        expect(postcode.code).to eq('ABCD')
       end
 
       it "registers search url for inclusion <primary_key>_in [<value>]" do
         expect { Postcode.find(:first, params: { search: { code_in: ['ABCD'] } }) }.not_to raise_error
         postcode = Postcode.find(:first, params: { search: { code_in: ['ABCD'] } })
-        postcode.code.should == 'ABCD'
+        expect(postcode.code).to eq('ABCD')
       end
     end
   end
@@ -122,8 +122,8 @@ describe FactoryGirl::RemoteStrategy do
       FactoryGirl.remote(:postcode, code: 'FGH')
       expect { Postcode.find('FGH') }.not_to raise_error
       postcode = Postcode.find('FGH')
-      postcode.should be_kind_of Postcode
-      postcode.code.should == 'FGH'
+      expect(postcode).to be_kind_of Postcode
+      expect(postcode.code).to eq('FGH')
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,7 +1,13 @@
-require "factory_girl_remote_strategy"
-require "fakeweb"
-
-FakeWeb.allow_net_connect = false
+require 'factory_girl_remote_strategy'
+ENV['LIBRARY'] ||= 'webmock'
+puts "HTTP requests are stabbed with library #{ENV['LIBRARY']}"
+FactoryGirl::RemoteStrategy.stub_requests_with ENV['LIBRARY']
+if ENV['LIBRARY'] == 'webmock'
+  require 'webmock/rspec'
+  WebMock.disable_net_connect!(allow_localhost: true)
+else
+  FakeWeb.allow_net_connect = false
+end
 
 FactoryGirl.find_definitions
 

metadata

@@ -1,111 +1,125 @@
 --- !ruby/object:Gem::Specification
 name: factory_girl_remote_strategy
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Alex Avoyants
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-08 00:00:00.000000000 Z
+date: 2016-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
   name: activeresource
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
   name: factory_girl
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: fakeweb
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: fakeweb
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: FactoryGirl strategy for ActiveResource models.
@@ -115,8 +129,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".gitignore"
+- ".rspec"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -152,17 +166,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: FactoryGirl strategy for ActiveResource models.