factory_girl 4.4.0 → 4.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b01f71363317939e019ac18363d51ce2b2caa9f0
-  data.tar.gz: cb128a3c6ade6aa7d1222fb4f86e6a81504dbc8a
+  metadata.gz: 4b66b3ff9ce2ea6a436ba4beb95761498dd26152
+  data.tar.gz: ce844f3fb80089bf0f88fed59de2b5a00aef949d
 SHA512:
-  metadata.gz: 3468641fa299f92b03cf869d2b3bfe9f75dce4de90f94b8cc2ebc86e9240177f8e514bfcf5ad44f99e17042112f1eb587dd2256df3c8606e8791d6580a818a2b
-  data.tar.gz: ffc2c949b1e3e344ad56a0a6609203d33c2464c20888a1aca53ca95530dcab8d74dc4d712a3b54fee55d94682422081782b8638c47a62e8f4c18a9238c43d999
+  metadata.gz: 4ae8b04a6f0c57e39b6361e48d098b5f91f8f12f01f8ad78e82467f7c6d664fb075ec8f3002ca42815d5d9a3460a70ac7c168dd9afc654d7385d4a705b6a4ae0
+  data.tar.gz: 8dd8a73ad04e9fbc5725959108366f6e9970204f24f0f81e66c65387a09a32c22a094ffde3ff75504c62ca2a9f8efb327d84f81cf954afa75a3026750a6cb10e

data/.travis.yml

@@ -13,6 +13,7 @@ gemfile:
   - gemfiles/3.1.gemfile
   - gemfiles/3.2.gemfile
   - gemfiles/4.0.gemfile
+  - gemfiles/4.1.gemfile
 branches:
   only:
     - master

data/.yardopts

@@ -1,5 +1,5 @@
 lib/**/*.rb
 -
 GETTING_STARTED.md
-CONTRIBUTION_GUIDELINES.md
+CONTRIBUTING.md
 LICENSE

data/Appraisals

@@ -9,3 +9,7 @@ end
 appraise '4.0' do
   gem 'activerecord', "~> 4.0.1"
 end
+
+appraise '4.1' do
+  gem 'activerecord', "~> 4.1.1"
+end

data/GETTING_STARTED.md

@@ -29,7 +29,8 @@ Configure your test suite
 -------------------------
 
 ```ruby
-# rspec
+# RSpec
+# spec/support/factory_girl.rb
 RSpec.configure do |config|
   config.include FactoryGirl::Syntax::Methods
 end
@@ -88,11 +89,33 @@ RSpec.configure do |config|
   # additional factory_girl configuration
 
   config.before(:suite) do
-    FactoryGirl.lint
+    begin
+      DatabaseCleaner.start
+      FactoryGirl.lint
+    ensure
+      DatabaseCleaner.clean
+    end
   end
 end
 ```
 
+After calling `FactoryGirl.lint`, you'll likely want to clear out the
+database, as built factories will create associated records. The provided
+example above uses the database_cleaner gem to clear out the database; be sure
+to add the gem to your Gemfile under the appropriate groups.
+
+You can lint factories selectively by passing only factories you want linted:
+
+```ruby
+factories_to_lint = FactoryGirl.factories.reject do |factory|
+  factory.name =~ /^old_/
+end
+
+FactoryGirl.lint factories_to_lint
+```
+
+This would lint all factories that aren't prefixed with `old_`.
+
 Defining factories
 ------------------
 
@@ -229,7 +252,7 @@ There may be times where your code can be DRYed up by passing in transient attri
 
 ```ruby
 factory :user do
-  ignore do
+  transient do
     rockstar true
     upcased  false
   end
@@ -246,14 +269,14 @@ create(:user, upcased: true).name
 #=> "JOHN DOE - ROCKSTAR"
 ```
 
-Static and dynamic attributes can be ignored. Ignored attributes will be ignored
-within attributes\_for and won't be set on the model, even if the attribute
-exists or you attempt to override it.
+Static and dynamic attributes can be created as transient attributes. Transient
+attributes will be ignored within attributes\_for and won't be set on the model,
+even if the attribute exists or you attempt to override it.
 
-Within factory_girl's dynamic attributes, you can access ignored attributes as
+Within factory_girl's dynamic attributes, you can access transient attributes as
 you would expect. If you need to access the evaluator in a factory_girl callback,
 you'll need to declare a second block argument (for the evaluator) and access
-ignored attributes from there.
+transient attributes from there.
 
 Associations
 ------------
@@ -332,14 +355,14 @@ FactoryGirl.define do
 
     # user_with_posts will create post data after the user has been created
     factory :user_with_posts do
-      # posts_count is declared as an ignored attribute and available in
+      # posts_count is declared as a transient attribute and available in
       # attributes on the factory, as well as the callback via the evaluator
-      ignore do
+      transient do
         posts_count 5
       end
 
       # the after(:create) yields two values; the user instance itself and the
-      # evaluator, which stores all values from the factory, including ignored
+      # evaluator, which stores all values from the factory, including transient
       # attributes; `create_list`'s second argument is the number of records
       # to create and we make sure the user is associated properly to the post
       after(:create) do |user, evaluator|
@@ -398,7 +421,7 @@ Sequences
 ---------
 
 Unique values in a specific format (for example, e-mail addresses) can be
-generated using sequences. Sequences are defined by calling sequence in a
+generated using sequences. Sequences are defined by calling `sequence` in a
 definition block, and values in a sequence are generated by calling
 `generate`:
 
@@ -865,23 +888,18 @@ end
 sequence(:email) { |n| "person#{n}@example.com" }
 
 factory :user do
-  ignore do
-    name "Jane Doe"
-  end
-
+  name "Jane Doe"
   email
+
   initialize_with { new(name) }
 end
 
 build(:user).name # Jane Doe
 ```
 
-Notice that I ignored the `name` attribute. If you don't want attributes
-reassigned after your object has been instantiated, you'll want to `ignore` them.
-
 Although factory_girl is written to work with ActiveRecord out of the box, it
-can also work with any Ruby class. For maximum compatibiltiy with ActiveRecord,
-the default initializer builds all instances by calling new on your build class
+can also work with any Ruby class. For maximum compatibility with ActiveRecord,
+the default initializer builds all instances by calling `new` on your build class
 without any arguments. It then calls attribute writer methods to assign all the
 attribute values. While that works fine for ActiveRecord, it actually doesn't
 work for almost any other Ruby class.
@@ -900,9 +918,7 @@ For example:
 
 ```ruby
 factory :user do
-  ignore do
-    name "John Doe"
-  end
+  name "John Doe"
 
   initialize_with { User.build_with_name(name) }
 end
@@ -913,7 +929,7 @@ by calling `attributes`:
 
 ```ruby
 factory :user do
-  ignore do
+  transient do
     comments_count 5
   end
 
@@ -924,7 +940,7 @@ end
 ```
 
 This will build a hash of all attributes to be passed to `new`. It won't
-include ignored attributes, but everything else defined in the factory will be
+include transient attributes, but everything else defined in the factory will be
 passed (associations, evalued sequences, etc.)
 
 You can define `initialize_with` for all factories by including it in the
@@ -1115,19 +1131,19 @@ throughout your test suite. If you're using RSpec, it's as simple as adding a
 `before(:suite)` and `after(:suite)`:
 
 ```ruby
+factory_girl_results = {}
 config.before(:suite) do
-  @factory_girl_results = {}
   ActiveSupport::Notifications.subscribe("factory_girl.run_factory") do |name, start, finish, id, payload|
     factory_name = payload[:name]
     strategy_name = payload[:strategy]
-    @factory_girl_results[factory_name] ||= {}
-    @factory_girl_results[factory_name][strategy_name] ||= 0
-    @factory_girl_results[factory_name][strategy_name] += 1
+    factory_girl_results[factory_name] ||= {}
+    factory_girl_results[factory_name][strategy_name] ||= 0
+    factory_girl_results[factory_name][strategy_name] += 1
   end
 end
 
 config.after(:suite) do
-  puts @factory_girl_results
+  puts factory_girl_results
 end
 ```
 

data/Gemfile

@@ -1,5 +1,3 @@
-source "http://rubygems.org"
-
-gem "activerecord", ">= 3.0.0", :require => false
+source 'https://rubygems.org'
 
 gemspec

data/Gemfile.lock

@@ -1,11 +1,11 @@
 PATH
   remote: .
   specs:
-    factory_girl (4.4.0)
+    factory_girl (4.5.0)
       activesupport (>= 3.0.0)
 
 GEM
-  remote: http://rubygems.org/
+  remote: https://rubygems.org/
   specs:
     activemodel (4.0.0)
       activesupport (= 4.0.0)
@@ -22,10 +22,11 @@ GEM
       multi_json (~> 1.3)
       thread_safe (~> 0.1)
       tzinfo (~> 0.3.37)
-    appraisal (0.5.2)
+    appraisal (1.0.0)
       bundler
       rake
-    arel (4.0.0)
+      thor (>= 0.14.0)
+    arel (4.0.2)
     aruba (0.5.3)
       childprocess (>= 0.3.6)
       cucumber (>= 1.1.1)
@@ -37,25 +38,27 @@ GEM
     builder (3.1.4)
     childprocess (0.3.9)
       ffi (~> 1.0, >= 1.0.11)
-    cucumber (1.2.5)
+    cucumber (1.3.15)
       builder (>= 2.1.2)
       diff-lcs (>= 1.1.3)
-      gherkin (~> 2.11.7)
-      multi_json (~> 1.3)
+      gherkin (~> 2.12)
+      multi_json (>= 1.7.5, < 2.0)
+      multi_test (>= 0.1.1)
     diff-lcs (1.1.3)
     ffi (1.9.0)
     ffi (1.9.0-java)
-    gherkin (2.11.8)
+    gherkin (2.12.2)
       multi_json (~> 1.3)
-    gherkin (2.11.8-java)
+    gherkin (2.12.2-java)
       multi_json (~> 1.3)
     i18n (0.6.4)
     metaclass (0.0.1)
     minitest (4.7.5)
     mocha (0.14.0)
       metaclass (~> 0.0.1)
-    multi_json (1.7.7)
-    rake (10.1.0)
+    multi_json (1.10.1)
+    multi_test (0.1.1)
+    rake (10.3.2)
     rspec (2.12.0)
       rspec-core (~> 2.12.0)
       rspec-expectations (~> 2.12.0)
@@ -69,6 +72,7 @@ GEM
       simplecov-html (~> 0.7.1)
     simplecov-html (0.7.1)
     sqlite3 (1.3.8)
+    thor (0.19.1)
     thread_safe (0.1.2)
       atomic
     thread_safe (0.1.2-java)
@@ -83,10 +87,10 @@ PLATFORMS
 
 DEPENDENCIES
   activerecord (>= 3.0.0)
-  appraisal (~> 0.5.1)
+  appraisal (~> 1.0.0)
   aruba
   bourne
-  cucumber (~> 1.2.1)
+  cucumber (~> 1.3.15)
   factory_girl!
   mocha (>= 0.12.8)
   rspec (~> 2.12.0)

data/NEWS

@@ -1,3 +1,10 @@
+4.5.0 (October 17, 2014)
+  Improve FactoryGirl.lint by including exception and message in output
+  Allow selective linting
+  Use more explicit #public_send when doing attribute assignment
+  Improve documentation around FactoryGirl.lint and initialize_with
+  Deprecate #ignore in favor of #transient
+
 4.4.0 (February 10, 2014)
   Add FactoryGirl.lint
   Fix memory leak in duplicate traits

data/README.md

@@ -10,7 +10,7 @@ Documentation
 
 You should find the documentation for your version of factory_girl on [Rubygems](https://rubygems.org/gems/factory_girl).
 
-See [GETTING_STARTED](https://github.com/thoughtbot/factory_girl/blob/master/GETTING_STARTED.md) for information on defining and using factories.
+See [GETTING_STARTED] for information on defining and using factories.
 
 Install
 --------
@@ -29,8 +29,7 @@ Supported Ruby versions
 -----------------------
 
 The factory_girl 3.x+ series supports MRI Ruby 1.9. Additionally, factory_girl
-3.6+ supports JRuby 1.6.7.2+ while running in 1.9 mode. See
-[GETTING_STARTED](https://github.com/thoughtbot/factory_girl/blob/master/GETTING_STARTED.md)
+3.6+ supports JRuby 1.6.7.2+ while running in 1.9 mode. See [GETTING_STARTED]
 for more information on configuring the JRuby environment.
 
 For versions of Ruby prior to 1.9, please use factory_girl 2.x.
@@ -43,10 +42,12 @@ More Information
 * [Issues](https://github.com/thoughtbot/factory_girl/issues)
 * [GIANT ROBOTS SMASHING INTO OTHER GIANT ROBOTS](http://robots.thoughtbot.com/)
 
+[GETTING_STARTED]: http://rubydoc.info/gems/factory_girl/file/GETTING_STARTED.md
+
 Contributing
 ------------
 
-Please see the [contribution guidelines](https://github.com/thoughtbot/factory_girl/blob/master/CONTRIBUTION_GUIDELINES.md).
+Please see [CONTRIBUTING.md](https://github.com/thoughtbot/factory_girl/blob/master/CONTRIBUTING.md).
 
 Credits
 -------

data/factory_girl.gemspec

@@ -24,13 +24,14 @@ Gem::Specification.new do |s|
   s.add_dependency("activesupport", ">= 3.0.0")
 
   s.add_development_dependency("rspec",    "~> 2.12.0")
-  s.add_development_dependency("cucumber", "~> 1.2.1")
+  s.add_development_dependency("cucumber", "~> 1.3.15")
   s.add_development_dependency("timecop")
   s.add_development_dependency("simplecov")
   s.add_development_dependency("aruba")
   s.add_development_dependency("mocha", ">= 0.12.8")
   s.add_development_dependency("bourne")
-  s.add_development_dependency("appraisal", "~> 0.5.1")
+  s.add_development_dependency("appraisal", "~> 1.0.0")
+  s.add_development_dependency("activerecord", ">= 3.0.0")
 
   if RUBY_PLATFORM == "java"
     s.add_development_dependency("activerecord-jdbcsqlite3-adapter")

data/gemfiles/3.1.gemfile

@@ -1,7 +1,7 @@
 # This file was generated by Appraisal
 
-source "http://rubygems.org"
+source "https://rubygems.org"
 
 gem "activerecord", "~> 3.1.12"
 
-gemspec :path=>"../"
+gemspec :path => "../"

data/gemfiles/3.1.gemfile.lock

@@ -1,11 +1,11 @@
 PATH
   remote: ../
   specs:
-    factory_girl (4.4.0)
+    factory_girl (4.5.0)
       activesupport (>= 3.0.0)
 
 GEM
-  remote: http://rubygems.org/
+  remote: https://rubygems.org/
   specs:
     activemodel (3.1.12)
       activesupport (= 3.1.12)
@@ -18,37 +18,41 @@ GEM
       tzinfo (~> 0.3.29)
     activesupport (3.1.12)
       multi_json (~> 1.0)
-    appraisal (0.5.2)
+    appraisal (1.0.0)
       bundler
       rake
+      thor (>= 0.14.0)
     arel (2.2.3)
     aruba (0.5.3)
       childprocess (>= 0.3.6)
       cucumber (>= 1.1.1)
       rspec-expectations (>= 2.7.0)
-    bourne (1.4.0)
-      mocha (~> 0.13.2)
+    bourne (1.5.0)
+      mocha (>= 0.13.2, < 0.15)
     builder (3.0.4)
     childprocess (0.3.9)
       ffi (~> 1.0, >= 1.0.11)
-    cucumber (1.2.5)
+    cucumber (1.3.15)
       builder (>= 2.1.2)
       diff-lcs (>= 1.1.3)
-      gherkin (~> 2.11.7)
-      multi_json (~> 1.3)
+      gherkin (~> 2.12)
+      multi_json (>= 1.7.5, < 2.0)
+      multi_test (>= 0.1.1)
     diff-lcs (1.1.3)
-    ffi (1.9.0)
-    ffi (1.9.0-java)
-    gherkin (2.11.8)
+    docile (1.1.3)
+    ffi (1.9.3)
+    ffi (1.9.3-java)
+    gherkin (2.12.2)
       multi_json (~> 1.3)
-    gherkin (2.11.8-java)
+    gherkin (2.12.2-java)
       multi_json (~> 1.3)
-    i18n (0.6.4)
-    metaclass (0.0.1)
-    mocha (0.13.3)
+    i18n (0.6.9)
+    metaclass (0.0.4)
+    mocha (0.14.0)
       metaclass (~> 0.0.1)
-    multi_json (1.7.7)
-    rake (10.1.0)
+    multi_json (1.10.1)
+    multi_test (0.1.1)
+    rake (10.3.2)
     rspec (2.12.0)
       rspec-core (~> 2.12.0)
       rspec-expectations (~> 2.12.0)
@@ -57,14 +61,16 @@ GEM
     rspec-expectations (2.12.1)
       diff-lcs (~> 1.1.3)
     rspec-mocks (2.12.2)
-    simplecov (0.7.1)
-      multi_json (~> 1.0)
-      simplecov-html (~> 0.7.1)
-    simplecov-html (0.7.1)
+    simplecov (0.8.2)
+      docile (~> 1.1.0)
+      multi_json
+      simplecov-html (~> 0.8.0)
+    simplecov-html (0.8.0)
     sqlite3 (1.3.8)
-    timecop (0.6.1)
-    tzinfo (0.3.37)
-    yard (0.8.6.1)
+    thor (0.19.1)
+    timecop (0.7.1)
+    tzinfo (0.3.39)
+    yard (0.8.7.3)
 
 PLATFORMS
   java
@@ -72,10 +78,10 @@ PLATFORMS
 
 DEPENDENCIES
   activerecord (~> 3.1.12)
-  appraisal (~> 0.5.1)
+  appraisal (~> 1.0.0)
   aruba
   bourne
-  cucumber (~> 1.2.1)
+  cucumber (~> 1.3.15)
   factory_girl!
   mocha (>= 0.12.8)
   rspec (~> 2.12.0)