factory_girl 3.4.1 → 3.4.2

data/GETTING_STARTED.md

@@ -18,6 +18,44 @@ gem "factory_girl", "~> 3.0"
 
 Once your Gemfile is updated, you'll want to update your bundle.
 
+Using Without Bundler
+---------------------
+
+If you're not using Bundler, be sure to have the gem installed and call:
+
+```
+require 'factory_girl'
+```
+
+Once required, assuming you have a directory structure of `spec/factories` or
+`test/factories`, all you'll need to do is run
+
+```ruby
+FactoryGirl.find_definitions
+```
+
+If you're using a separate directory structure for your factories, you can
+change the definition file paths before trying to find definitions:
+
+```ruby
+FactoryGirl.definition_file_paths = %w(custom_factories_directory)
+FactoryGirl.find_definitions
+```
+
+If you don't have a separate directory of factories and would like to define
+them inline, that's possible as well:
+
+```ruby
+require 'factory_girl'
+
+FactoryGirl.define do
+  factory :user do
+    name 'John Doe'
+    date_of_birth { 21.years.ago }
+  end
+end
+```
+
 Defining factories
 ------------------
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    factory_girl (3.4.1)
+    factory_girl (3.4.2)
       activesupport (>= 3.0.0)
 
 GEM

data/NEWS

@@ -1,3 +1,7 @@
+3.4.2 (June 12, 2012)
+  Fix bug in traits with callbacks called implicitly in factories whose
+    callbacks trigger multiple times
+
 3.4.1 (June 18, 2012)
   Fix traits so they can be nested and referred to from other traits
 

data/gemfiles/3.0.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/joshuaclayton/dev/gems/factory_girl
   specs:
-    factory_girl (3.4.1)
+    factory_girl (3.4.2)
       activesupport (>= 3.0.0)
 
 GEM

data/gemfiles/3.1.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/joshuaclayton/dev/gems/factory_girl
   specs:
-    factory_girl (3.4.1)
+    factory_girl (3.4.2)
       activesupport (>= 3.0.0)
 
 GEM

data/gemfiles/3.2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/joshuaclayton/dev/gems/factory_girl
   specs:
-    factory_girl (3.4.1)
+    factory_girl (3.4.2)
       activesupport (>= 3.0.0)
 
 GEM

data/lib/factory_girl/declaration_list.rb

@@ -21,7 +21,7 @@ module FactoryGirl
     end
 
     def attributes
-      AttributeList.new(@name).tap do |list|
+      @attributes ||= AttributeList.new(@name).tap do |list|
         to_attributes.each do |attribute|
           list.define_attribute(attribute)
         end

data/lib/factory_girl/version.rb

@@ -1,3 +1,3 @@
 module FactoryGirl
-  VERSION = '3.4.1'
+  VERSION = '3.4.2'
 end

data/spec/acceptance/traits_spec.rb

@@ -645,3 +645,27 @@ describe "nested implicit traits" do
     it_should_behave_like "assigning data from traits"
   end
 end
+
+describe "implicit traits containing callbacks" do
+  before do
+    define_model("User", value: :integer)
+
+    FactoryGirl.define do
+      factory :user do
+        value 0
+
+        trait :trait_with_callback do
+          after(:build) {|user| user.value += 1 }
+        end
+
+        factory :user_with_trait_with_callback do
+          trait_with_callback
+        end
+      end
+    end
+  end
+
+  it "only runs the callback once" do
+    FactoryGirl.build(:user_with_trait_with_callback).value.should == 1
+  end
+end

data/spec/factory_girl/declaration_list_spec.rb

@@ -25,10 +25,6 @@ describe FactoryGirl::DeclarationList, "#attributes" do
     attribute_list.should have_received(:define_attribute).with(static_attribute_2)
     attribute_list.should have_received(:define_attribute).with(dynamic_attribute_1)
   end
-
-  it "creates a new attribute list upon every invocation" do
-    subject.attributes.should_not == subject.attributes
-  end
 end
 
 describe FactoryGirl::DeclarationList, "#declare_attribute" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: factory_girl
 version: !ruby/object:Gem::Version
-  version: 3.4.1
+  version: 3.4.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-18 00:00:00.000000000 Z
+date: 2012-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport