factory_bot_rails 6.4.2 → 6.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b4a9a114b3d5f63d0083ef6990ac113e593ff67c19866fce133ecfc0423dd653
-  data.tar.gz: 3e8a9c7450996d67fa4f45b7ee949348c261319c7195e01a3a08aaa9ae3bcdfa
+  metadata.gz: 70ac3e65ecb946bde74a107d453206896d96a0bdd02d52f6e9d99cc4b11ace65
+  data.tar.gz: c5478bf4191651ac02e944af9d118f2243b10fd508073b0911c9b165ad6afd1e
 SHA512:
-  metadata.gz: 3c0a4cfe2745a02a9b2b1f8192286db492fc6e0bf850478c456f0b3863cdaecc9901dafc200201e75bc5dbb9bab429fdf3f9705ceb0d4ed7bd5a6758b4805f3f
-  data.tar.gz: 957f01135a351596d8221148bca75b61500518fc71f734454cf3051933ccd1f08f1b361de768bc73dd77105e09b747283617bc02f04e33944e02c97415f7beb3
+  metadata.gz: 4ff19ee6c07babb79676b2ecea45b5abc8dcc6af75042409a3a4e373e9db91787b0f0506d626700303414fc9b2e50f355c2757e1ec9289fccdcf14b6239f30e8
+  data.tar.gz: d1a7e2c0c2966eff606e58addc63fe1dba533934fcb45ff1c7399ce5afd5604f1efab1d755e133bcd54f6b12850c76df88108b74df0da19917864e0c94ad8b92

data/NEWS.md

@@ -3,6 +3,17 @@ there might not be any notable changes in new versions of this project.
 
 # NEWS
 
+## 6.4.3 (December 29, 2023)
+
+* Changed: allow sequence definitions for ActiveRecord primary keys (Mike
+  Burns).
+* Changed: Support Ruby 3.0+, Rails 6.1+ (Mike Burns)
+* Documentation improvements (obregonia1).
+* Internal: GitHub Actions improvements (Lorenzo Zabot, ydah).
+* Internal: RubyGems points to changelog (Tilo Sloboda).
+* Internal: Bump standard, rake, activerecord, appraisal, rspec-rails (Mike
+  Burns).
+
 ## 6.4.2 (November 23, 2023)
 * Fixed: Fix Rails 7.1.2 + monkey-patched ActiveRecord compatibility (Adif
   Sgaid, Benoit Tigeot)

data/README.md

@@ -152,22 +152,6 @@ rails generate factory_bot:model NAME [field:type field:type] [options]
 
 [default factory template]: https://github.com/thoughtbot/factory_bot_rails/tree/main/lib/generators/factory_bot/model/templates/factories.erb
 
-### Active Record Configuration
-
-By default, FactoryBot will refuse to generate Active Record primary key
-columns. Without additional configuration, an Active Record model treats a
-column named `id` as its primary key.
-
-For example, defining an `id` attribute with `add_attribute(:id)`, `id { ... }`,
-or `sequence(:id)` will raise a `FactoryBot::AttributeDefinitionError`.
-
-You can disable this behavior by adding the following to `config/application.rb`
-or the appropriate environment configuration in `config/environments`:
-
-```ruby
-config.factory_bot.reject_primary_key_attributes = false
-```
-
 ## Contributing
 
 Please see [CONTRIBUTING.md](CONTRIBUTING.md).

data/lib/factory_bot_rails/factory_validator.rb

@@ -15,25 +15,9 @@ module FactoryBotRails
     private
 
     def validate_compiled_factory
-      if Rails.version >= "6.0"
-        rails_6_0_support
-      else
-        rails_5_2_support
-      end
-    end
-
-    def rails_6_0_support
       proc do |event|
         @validators.each { |validator| validator.validate!(event.payload) }
       end
     end
-
-    def rails_5_2_support
-      proc do |*notification_event_arguments|
-        event = ActiveSupport::Notifications::Event.new(*notification_event_arguments)
-
-        rails_6_0_support.call(event)
-      end
-    end
   end
 end

data/lib/factory_bot_rails/railtie.rb

@@ -10,7 +10,6 @@ module FactoryBotRails
   class Railtie < Rails::Railtie
     config.factory_bot = ActiveSupport::OrderedOptions.new
     config.factory_bot.definition_file_paths = FactoryBot.definition_file_paths
-    config.factory_bot.reject_primary_key_attributes = true
     config.factory_bot.validator = FactoryBotRails::FactoryValidator.new
 
     initializer "factory_bot.set_fixture_replacement" do
@@ -21,18 +20,6 @@ module FactoryBotRails
       FactoryBot.definition_file_paths = definition_file_paths
     end
 
-    initializer "factory_bot.reject_primary_key_attributes" do
-      ActiveSupport.on_load :active_record do
-        config = Rails.configuration.factory_bot
-
-        if config.reject_primary_key_attributes
-          require "factory_bot_rails/factory_validator/active_record_validator"
-
-          config.validator.add_validator FactoryValidator::ActiveRecordValidator.new
-        end
-      end
-    end
-
     config.after_initialize do |app|
       FactoryBot.find_definitions
       Reloader.new(app).run

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: factory_bot_rails
 version: !ruby/object:Gem::Version
-  version: 6.4.2
+  version: 6.4.3
 platform: ruby
 authors:
 - Joe Ferris
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-23 00:00:00.000000000 Z
+date: 2023-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: factory_bot
@@ -80,7 +80,6 @@ files:
 - lib/factory_bot_rails.rb
 - lib/factory_bot_rails/definition_file_paths.rb
 - lib/factory_bot_rails/factory_validator.rb
-- lib/factory_bot_rails/factory_validator/active_record_validator.rb
 - lib/factory_bot_rails/generator.rb
 - lib/factory_bot_rails/generators/non_rspec_generator.rb
 - lib/factory_bot_rails/generators/null_generator.rb
@@ -94,7 +93,8 @@ files:
 homepage: https://github.com/thoughtbot/factory_bot_rails
 licenses:
 - MIT
-metadata: {}
+metadata:
+  changelog_uri: https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -110,7 +110,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.13
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: factory_bot_rails provides integration between factory_bot and rails 5.0

data/lib/factory_bot_rails/factory_validator/active_record_validator.rb

@@ -1,18 +0,0 @@
-module FactoryBotRails
-  class FactoryValidator
-    class ActiveRecordValidator
-      def validate!(payload)
-        attributes, for_class = payload.values_at(:attributes, :class)
-        attributes.each do |attribute|
-          if for_class < ActiveRecord::Base && for_class.primary_key == attribute.name.to_s
-            raise FactoryBot::AttributeDefinitionError, <<~ERROR
-              Attribute generates #{for_class.primary_key.inspect} primary key for #{for_class.name}"
-
-              Do not define #{for_class.primary_key.inspect}. Instead, rely on the database to generate it.
-            ERROR
-          end
-        end
-      end
-    end
-  end
-end