factory_bot_instrumentation 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8fad506387bc8c52339b3868ba4026a436bb3b4602747eabd30dcf3f41ecd855
-  data.tar.gz: a6c8adffc73924cbea80296c721ed264ba9378bba8f7bee7a1ec296871f17b79
+  metadata.gz: 106c1aa5ca524b01dbff80a366493e8e921d2b65aba880d156da6481f6798d74
+  data.tar.gz: 538be239cc2016d21996c85d96730c8501dfca703f5d7a1d259dc198aa0da880
 SHA512:
-  metadata.gz: 24790a2a645d22cc50edefb2ee19c3215cfd173ac88bf3bced467a1b71ec73a984ae28e88e57d09f6ff938266c38d89262dfec1596a55516b74449e6e6de0437
-  data.tar.gz: 741ac435c5ed84bcc622ac327598be7b37e1b98757772ee189eb5f01446ae766ee8b443380dbc97767d240b6ba329416d988f6d8dd1e1a8420b7ea83345a598f
+  metadata.gz: 423b35d7c9c7e590a1b312206f5f05a93407fa1fe3f5dff3790ae0ba9d263f782e7a3e8cbd24ae48307e422dd4806e15284b378b71f35792384d0fbf1739e449
+  data.tar.gz: 6f2211b069039602f7e74bfa6a5d737acf2a651953ce81e6c758fed27625719f4128abb419dd5a66accfa5614c89e7663e65e9944bca09674e58f05244158b28

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+### 1.0.1
+
+* Added a retry logic to the FactoryBot reloading on the POST/create endpoint
+  in order to handle parallel requests properly (#13)
+
 ### 1.0.0
 
 * Bundler >= 2.3 is from now on required as minimal version (#12)

data/app/controllers/factory_bot/instrumentation/root_controller.rb

@@ -37,8 +37,11 @@ module FactoryBot
       #
       # The result is the API v1 representation of the created entity.
       def create
-        # Reload the factories to improve the test development experience
-        FactoryBot.reload
+        # Reload the factories to improve the test development experience.
+        # In parallel request conditions this may lead to +Factory already
+        # registered+ errors as this call is not thread safe as it seems,
+        # so we retry it multiple times.
+        with_retries(max_tries: 15) { FactoryBot.reload }
         # Call the factory construction with the user given parameters
         entity = FactoryBot.create(*factory_params)
         # Render the resulting entity with the configured rendering block

data/factory_bot_instrumentation.gemspec

@@ -35,6 +35,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'factory_bot', '~> 6.2'
   spec.add_runtime_dependency 'rails', '>= 5.2'
+  spec.add_runtime_dependency 'retries', '>= 0.0.5'
 
   spec.add_development_dependency 'appraisal', '~> 2.4'
   spec.add_development_dependency 'bundler', '~> 2.3'

data/lib/factory_bot/instrumentation/version.rb

@@ -4,7 +4,7 @@ module FactoryBot
   # The gem version details.
   module Instrumentation
     # The version of the +factory_bot_instrumentation+ gem
-    VERSION = '1.0.0'
+    VERSION = '1.0.1'
 
     class << self
       # Returns the version of gem as a string.

data/lib/factory_bot_instrumentation.rb

@@ -7,6 +7,7 @@ require 'active_support/cache'
 require 'active_support/core_ext/hash'
 require 'active_support/time'
 require 'active_support/time_with_zone'
+require 'retries'
 
 require 'factory_bot'
 require 'factory_bot/instrumentation/configuration'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: factory_bot_instrumentation
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Hermann Mayer
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-01-18 00:00:00.000000000 Z
+date: 2023-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: factory_bot
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '5.2'
+- !ruby/object:Gem::Dependency
+  name: retries
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.0.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.0.5
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement