factorix 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f93238fc1b419e6adf7ec45ac04331f84aba675b94cf4d4e57fd7c8555687678
-  data.tar.gz: 2e7d4ed3b5c0b4be85fd5f1012eb4a73b84b160d5f31c1ed326a5830cba41c42
+  metadata.gz: ff57824d3ac0e73ae53844437c03f98bd10537f724a0285986b473b5136559f7
+  data.tar.gz: ed520b42e6f293f4e8021a71515f58348882093b634285d96c6d04164550d633
 SHA512:
-  metadata.gz: 254733ebd3ad1b896a84c341d35a49a2d8943114d4fe0f90d0b83efae5399d9f862aedaeb0f7a68d42cdfedad9ab0dae9a4d77625646540de111e77567b74ab6
-  data.tar.gz: 733b7da2d624bbf225e9bcbd586a0aa394c593d79743456c2a9b1a8ef06daf05603f1f4091da657038f7bacfdb766061a48026084a1d72290cc3350df2e8e694
+  metadata.gz: 36b43e73b76ec6e769ffaa7ec98dbcef83329490a01d6980518786fbb5699661db5e804fc3a0475455196aa0a1f50db2fd42ae233616a17dfef94b4578f71a31
+  data.tar.gz: d4f869b4cf329d391d59af1db92082e7acd18c0b6603334949f6fd7ffa22e11cc4536f16f3d0fdfefc1c3eeefa0653a8d0b207dd9eedaac201ad20ffca763fc6

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 ## [Unreleased]
 
+## [0.11.1] - 2026-03-03
+
+### Fixed
+
+- Fix `mod sync` incorrectly saving `mod-list.json` and `mod-settings.dat` when nothing changed (#74)
+- Include startup settings changes in the `mod sync` plan and confirmation flow (#74)
+
 ## [0.11.0] - 2026-03-03
 
 ### Added

data/lib/factorix/cli/commands/mod/sync.rb

@@ -61,12 +61,17 @@ module Factorix
             conflict_mods = find_conflict_mods(mod_list, save_data.mods, graph)
             changes = plan_mod_list_changes(mod_list, save_data.mods)
             unlisted_mods = keep_unlisted ? [] : find_unlisted_mods(mod_list, save_data.mods, conflict_mods)
+            mod_list_changed = needs_confirmation?(install_targets, conflict_mods, changes, unlisted_mods)
+            settings_changed = startup_settings_changed?(save_data.startup_settings)
 
             # Show combined plan and ask once
-            show_sync_plan(install_targets, conflict_mods, changes, unlisted_mods)
+            unless mod_list_changed || settings_changed
+              say "Nothing to change", prefix: :info
+              return
+            end
 
-            return if needs_confirmation?(install_targets, conflict_mods, changes, unlisted_mods) &&
-                      !confirm?("Do you want to apply these changes?")
+            show_sync_plan(install_targets, conflict_mods, changes, unlisted_mods, settings_changed)
+            return unless confirm?("Do you want to apply these changes?")
 
             # Execute phase
             if install_targets.any?
@@ -74,13 +79,17 @@ module Factorix
               say "Installed #{install_targets.size} MOD(s)", prefix: :success
             end
 
-            apply_mod_list_changes(mod_list, conflict_mods, changes, unlisted_mods)
-            backup_if_exists(runtime.mod_list_path)
-            mod_list.save
-            say "Updated mod-list.json", prefix: :success
+            if mod_list_changed
+              apply_mod_list_changes(mod_list, conflict_mods, changes, unlisted_mods)
+              backup_if_exists(runtime.mod_list_path)
+              mod_list.save
+              say "Updated mod-list.json", prefix: :success
+            end
 
-            update_mod_settings(save_data.startup_settings, save_data.version)
-            say "Updated mod-settings.dat", prefix: :success
+            if settings_changed
+              update_mod_settings(save_data.startup_settings, save_data.version)
+              say "Updated mod-settings.dat", prefix: :success
+            end
 
             say "Sync completed successfully", prefix: :success
           end
@@ -289,13 +298,9 @@ module Factorix
           # @param conflict_mods [Array<Hash>] MODs to disable due to conflicts
           # @param changes [Array<Hash>] MOD list changes from save file
           # @param unlisted_mods [Array<MOD>] MODs to disable as unlisted
+          # @param settings_changed [Boolean] Whether startup settings will be updated
           # @return [void]
-          private def show_sync_plan(install_targets, conflict_mods, changes, unlisted_mods)
-            unless needs_confirmation?(install_targets, conflict_mods, changes, unlisted_mods)
-              say "Nothing to change", prefix: :info
-              return
-            end
-
+          private def show_sync_plan(install_targets, conflict_mods, changes, unlisted_mods, settings_changed)
             say "Planning to sync MOD(s):", prefix: :info
 
             if install_targets.any?
@@ -319,10 +324,12 @@ module Factorix
             end
 
             update_changes = changes.select {|c| c[:action] == :update }
-            return if update_changes.none?
+            if update_changes.any?
+              say "  Update:"
+              update_changes.each {|c| say "    - #{c[:mod]} (#{c[:from_version]} \u2192 #{c[:to_version]})" }
+            end
 
-            say "  Update:"
-            update_changes.each {|c| say "    - #{c[:mod]} (#{c[:from_version]} \u2192 #{c[:to_version]})" }
+            say "  Update startup settings" if settings_changed
           end
 
           # Apply all mod-list.json changes
@@ -427,6 +434,20 @@ module Factorix
               changes.any? {|c| c[:action] != :add || c[:to_enabled] } ||
               unlisted_mods.any?
           end
+
+          # Check whether startup settings from the save file differ from the current mod-settings.dat
+          #
+          # @param startup_settings [MODSettings::Section] Startup settings from save file
+          # @return [Boolean]
+          private def startup_settings_changed?(startup_settings)
+            return true unless runtime.mod_settings_path.exist?
+
+            mod_settings = MODSettings.load(runtime.mod_settings_path)
+            startup_section = mod_settings["startup"]
+            startup_settings.any? do |key, value|
+              startup_section[key] != value
+            end
+          end
         end
       end
     end

data/lib/factorix/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Factorix
-  VERSION = "0.11.0"
+  VERSION = "0.11.1"
   public_constant :VERSION
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: factorix
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - OZAWA Sakuro