facter 4.0.20 → 4.0.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: baceb04e072102e0f18534a903fc7e0ead2f76d2d4f81dd49a64e325a22a0f7d
-  data.tar.gz: b63826bac2fef312e1745b2b2591e77a3d8a1e4b7fd019d3f77019660161d48c
+  metadata.gz: 0f98a392ad6a05f9c7ad8d5ea4b1f95792ccd133c4d4069b737710cb40d5f4bc
+  data.tar.gz: 61d8fb70c31865da5ea20b4e96e8331756cb1babca66dfcb89a369aa7d684326
 SHA512:
-  metadata.gz: 205b507dab7c7253b8d58f8e76ba664ac10545bfb3fca3b5d7649248546edf5f31fccd52c654d2d38691b48f8a30bf70b7731008b747260ba0a258775fdf231a
-  data.tar.gz: 5ca2bf79afe491abe2b8ace592ab269eedb9ff97e041cd39ea145c7d4da055863076432acb0eecd64a367b326c1d06621aab6545d9109093f99783c409e06945
+  metadata.gz: 03a6701d831ba8442ef9680a059781eb1b86f5b8ebd93ec7487b1b556345674d13cf37905fcad3da7f4aede956d82a69c4f3abd8facc0eea9961652e325c6a24
+  data.tar.gz: 7c04baac0acfe2b148e7a0a12adf935e5bc06770f7711f22aa35078c901f18ed0cd5096b403a16071c5150954db8175b521d254c170fc215327e11cb435db6fa

data/.github/actions/presuite.rb

@@ -0,0 +1,109 @@
+require 'open3'
+
+def install_bundler
+  message('INSTALL BUNDLER')
+  run('gem install bundler')
+end
+
+def install_facter_3_dependecies
+  message('INSTALL FACTER 3 ACCEPTANCE DEPENDENCIES')
+  run('bundle install')
+end
+
+def install_custom_beaker
+  message('BUILD CUSTOM BEAKER GEM')
+  run('gem build beaker.gemspec')
+
+  message('INSTALL CUSTOM BEAKER GEM')
+  run('gem install beaker-*.gem')
+end
+
+def initialize_beaker
+  beaker_options = "#{get_beaker_platform(ENV['ImageOS'].to_sym)}{hypervisor=none\\,hostname=localhost}"
+
+  message('BEAKER INITIALIZE')
+  run("beaker init -h #{beaker_options} -o config/aio/options.rb")
+
+  message('BEAKER PROVISION')
+  run('beaker provision')
+end
+
+def get_beaker_platform(host_platform)
+  beaker_platforms = {
+      ubuntu18: 'ubuntu1804-64a',
+      ubuntu16: 'ubuntu1604-64a',
+      macos1015: 'osx1015-64a'
+  }
+
+  beaker_platforms[host_platform]
+end
+
+def install_puppet_agent
+  beaker_puppet_root, _ = run('bundle info beaker-puppet --path')
+  install_puppet_file_path = File.join(beaker_puppet_root.chomp, 'setup', 'aio', '010_Install_Puppet_Agent.rb')
+
+  message('INSTALL PUPPET AGENT')
+  run("beaker exec pre-suite --pre-suite #{install_puppet_file_path}")
+end
+
+def replace_facter_3_with_facter_4
+  linux_puppet_bin_dir = '/opt/puppetlabs/puppet/bin'
+  gem_command = File.join(linux_puppet_bin_dir, 'gem')
+  puppet_command = File.join(linux_puppet_bin_dir, 'puppet')
+
+  message('SET FACTER 4 FLAG TO TRUE')
+  run("#{puppet_command} config set facterng true")
+
+  message('BUILD FACTER 4 LATEST AGENT GEM')
+  run("#{gem_command} build agent/facter-ng.gemspec", ENV['FACTER_4_ROOT'])
+
+  message('UNINSTALL DEFAULT FACTER 4 AGENT GEM')
+  run("#{gem_command} uninstall facter-ng")
+
+  message('INSTALL FACTER 4 GEM')
+  run("#{gem_command} install -f facter-ng-*.gem", ENV['FACTER_4_ROOT'])
+
+  message('CHANGE FACTER 3 WITH FACTER 4')
+  run('mv facter-ng facter', linux_puppet_bin_dir)
+end
+
+def run_acceptance_tests
+  message('RUN ACCEPTANCE TESTS')
+  run('beaker exec tests --test-tag-exclude=server,facter_3 --test-tag-or=risk:high,audit:high')
+end
+
+def message(message)
+  message_length = message.length
+  total_length = 130
+  lines_length = (total_length - message_length) / 2
+  result = ('-' * lines_length + ' ' + message + ' ' + '-' * lines_length)[0, total_length]
+  puts "\n\n#{result}\n\n"
+end
+
+def run(command, dir = './')
+  puts command
+  output, status = Open3.capture2(command, chdir: dir)
+  puts output
+  [output, status]
+end
+
+ENV['DEBIAN_DISABLE_RUBYGEMS_INTEGRATION'] = 'no_wornings'
+FACTER_3_ACCEPTANCE_PATH = File.join(ENV['FACTER_3_ROOT'], 'acceptance')
+
+install_bundler
+
+Dir.chdir(FACTER_3_ACCEPTANCE_PATH) { install_facter_3_dependecies }
+
+Dir.chdir(ENV['BEAKER_ROOT']) { install_custom_beaker }
+
+Dir.chdir(FACTER_3_ACCEPTANCE_PATH) do
+  initialize_beaker
+  install_puppet_agent
+end
+
+replace_facter_3_with_facter_4
+
+Dir.chdir(FACTER_3_ACCEPTANCE_PATH) do
+  _, status = run_acceptance_tests
+  exit(status.exitstatus)
+end

data/.github/workflows/acceptance_tests.yml

@@ -0,0 +1,61 @@
+---
+name: Acceptance tests
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  acceptance_tests:
+    name: Platform
+    strategy:
+      matrix:
+        os: [ubuntu-18.04, ubuntu-16.04, macos-10.15]
+    runs-on: ${{ matrix.os }}
+    env:
+      FACTER_3_ROOT: facter_3
+      FACTER_4_ROOT: facter_4
+      BEAKER_ROOT: beaker
+      SHA: latest
+      BEAKER_VERSION: 4.21.0
+
+    steps:
+      - name: Checkout current PR
+        uses: actions/checkout@v2
+        with:
+          path: facter_4
+
+      - name: Clone facter 3 repo
+        uses: actions/checkout@v2
+        with:
+          repository: puppetlabs/facter
+          ref: skip_failures_on_ng
+          path: facter_3
+
+      - name: Clone custom beaker fork
+        uses: actions/checkout@v2
+        with:
+          repository: mihaibuzgau/beaker
+          ref: master
+          path: beaker
+
+      - name: Install Ruby 2.6
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '2.6'
+
+      - name: Fix common permissions
+        run: sudo chmod a-w /opt
+
+      - name: Fix Linux permissions
+        if: runner.os == 'Linux'
+        run: |
+          sudo chmod a-w /home/runner /usr/share &&
+          sudo chmod -R a-w /usr/share/rust /home/runner/.config /home/linuxbrew
+
+      - name: Run acceptance tests
+        run: sudo -E "PATH=$PATH" ruby facter_4/.github/actions/presuite.rb

data/.github/workflows/checks.yaml

@@ -0,0 +1,71 @@
+---
+name: Checks
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  rubocop_checks:
+    runs-on: ubuntu-18.04
+    name: RuboCop
+    steps:
+      - name: Checkout current PR
+        uses: actions/checkout@v2
+
+      - name: Rubocop checks
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.6
+      - run: bundle install --jobs 3 --retry 3
+      - run: bundle exec rubocop --parallel
+
+  rtc:
+    runs-on: ubuntu-latest
+    name: RuboCop TODO
+    steps:
+      - uses: actions/checkout@v1
+      - uses: gimmyxd/rtc-action@0.0.5
+
+  commit_checks:
+    runs-on: ubuntu-18.04
+    name: commit message
+    steps:
+      - name: Checkout current PR
+        uses: actions/checkout@v2
+
+      - name: Commit message checks
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.6
+      - run: bundle install --jobs 3 --retry 3
+      - run: bundle exec rake commits
+
+  coverage_checks:
+    runs-on: ubuntu-18.04
+    name: coverage
+    steps:
+      - name: Checkout current PR
+        uses: actions/checkout@v2
+
+      - name: Setup Code Climate test-reporter
+        run: |
+          curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+          chmod +x ./cc-test-reporter
+          ./cc-test-reporter before-build
+
+      - name: Commit message checks
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.6
+      - run: bundle install --jobs 3 --retry 3
+      - run: bundle exec rake spec
+
+      - name: Publish code coverage
+        run: |
+          export GIT_BRANCH="${GITHUB_REF/refs\/heads\//}"
+          ./cc-test-reporter after-build -r ${{secrets.CC_TEST_REPORTER_ID}}

data/.github/workflows/unit_tests.yaml

@@ -0,0 +1,41 @@
+---
+name: Unit tests
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  linux_unit_tests:
+    name: Ruby version
+    strategy:
+      matrix:
+        ruby: [ 2.3, 2.7, jruby ]
+    runs-on: ubuntu-18.04
+    steps:
+      - name: Checkout current PR
+        uses: actions/checkout@v2
+
+      - name: Rspec checks
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - run: bundle install --jobs 3 --retry 3
+      - run: bundle exec rake spec
+
+  windows_unit_tests:
+    runs-on: windows-2019
+    steps:
+      - name: Checkout current PR
+        uses: actions/checkout@v2
+
+      - name: Rspec checks
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7
+      - run: bundle install --jobs 3 --retry 3
+      - run: bundle exec rake spec

data/.rubocop.yml

@@ -1,18 +1,25 @@
 ---
 inherit_from: .rubocop_todo.yml
 
+AllCops:
+  TargetRubyVersion: 2.3
+
 require:
   - rubocop-performance
   - rubocop-rspec
 
-Documentation:
-  Enabled: false
+Layout/LineLength:
+  Max: 120
 
-Style/TrivialAccessors:
-  AllowDSLWriters: true
+Lint/RescueException:
+  Exclude:
+    - 'lib/custom_facts/util/parser.rb'
 
-Metrics/LineLength:
-  Max: 120
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
 
 Metrics/MethodLength:
   Max: 20
@@ -33,10 +40,6 @@ Metrics/BlockLength:
   Exclude:
     - !ruby/regexp /(?:(?!.+_spec.rb).)*$/
 
-Style/ClassVars:
-  Exclude:
-    - !ruby/regexp /(?:(?!.+_resolver.rb).)*$/
-
 Naming/ClassAndModuleCamelCase:
   Exclude:
     - 'spec/mocks/**/*'
@@ -54,21 +57,6 @@ Metrics/AbcSize:
     - 'lib/custom_facts/core/execution/base.rb'
     - 'lib/custom_facts/core/resolvable.rb'
 
-Style/FrozenStringLiteralComment:
-  Exclude:
-    - 'spec/custom_facts/util/normalization_spec.rb'
-    - 'spec/custom_facts/shared_contexts/platform.rb'
-    - 'spec/custom_facts/core/execution/windows_spec.rb'
-    - 'spec/custom_facts/core/execution/posix_spec.rb'
-    - 'lib/custom_facts/util/resolution.rb'
-    - 'lib/custom_facts/core/execution/windows.rb'
-    - 'lib/custom_facts/core/execution/posix.rb'
-
-Style/CaseEquality:
-  Exclude:
-    - 'spec/custom_facts/util/confine_spec.rb'
-    - 'lib/custom_facts/util/confine.rb'
-
 Metrics/PerceivedComplexity:
   Exclude:
     - 'lib/custom_facts/util/values.rb'
@@ -84,10 +72,6 @@ Metrics/CyclomaticComplexity:
     - 'lib/custom_facts/core/execution/posix.rb'
     - 'lib/framework/detector/os_detector.rb'
 
-Lint/RescueException:
-  Exclude:
-    - 'lib/custom_facts/util/parser.rb'
-
 Metrics/ClassLength:
   Exclude:
     - 'lib/custom_facts/util/fact.rb'
@@ -95,26 +79,12 @@ Metrics/ClassLength:
     - 'lib/custom_facts/util/collection.rb'
     - 'lib/framework/core/options/option_store.rb'
     - 'lib/framework/cli/cli.rb'
-
-Style/DoubleNegation:
-  Exclude:
-    - 'lib/custom_facts/util/confine.rb'
-    - 'lib/custom_facts/util/confine.rb'
-    - 'lib/custom_facts/core/execution/windows.rb'
-    - 'lib/custom_facts/core/execution/posix.rb'
+    - 'lib/resolvers/networking_linux_resolver.rb'
 
 Naming/AccessorMethodName:
   Exclude:
     - 'lib/custom_facts/core/suitable.rb'
 
-Style/StderrPuts:
-  Exclude:
-    - 'lib/custom_facts/core/logging.rb'
-
-Style/ModuleFunction:
-  Exclude:
-    - 'lib/custom_facts/core/logging.rb'
-
 Naming/MethodName:
   Exclude:
     - 'spec/mocks/**/*'
@@ -123,14 +93,6 @@ Naming/PredicateName:
   Exclude:
     - 'lib/custom_facts/core/suitable.rb'
 
-Style/MethodMissingSuper:
-  Exclude:
-    - 'lib/facter.rb'
-
-Style/MissingRespondToMissing:
-  Exclude:
-    - 'lib/facter.rb'
-
 Naming/FileName:
   Exclude:
     - 'lib/facter.rb'
@@ -144,3 +106,60 @@ RSpec/DescribedClass:
 
 RSpec/NestedGroups:
   Max: 5
+
+Style/Documentation:
+  Enabled: false
+
+Style/ClassVars:
+  Exclude:
+    - !ruby/regexp /(?:(?!.+_resolver.rb).)*$/
+
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'spec/custom_facts/util/normalization_spec.rb'
+    - 'spec/custom_facts/shared_contexts/platform.rb'
+    - 'spec/custom_facts/core/execution/windows_spec.rb'
+    - 'spec/custom_facts/core/execution/posix_spec.rb'
+    - 'lib/custom_facts/util/resolution.rb'
+    - 'lib/custom_facts/core/execution/windows.rb'
+    - 'lib/custom_facts/core/execution/posix.rb'
+
+Style/TrivialAccessors:
+  AllowDSLWriters: true
+
+Style/CaseEquality:
+  Exclude:
+    - 'spec/custom_facts/util/confine_spec.rb'
+    - 'lib/custom_facts/util/confine.rb'
+
+Style/DoubleNegation:
+  Exclude:
+    - 'lib/custom_facts/util/confine.rb'
+    - 'lib/custom_facts/util/confine.rb'
+    - 'lib/custom_facts/core/execution/windows.rb'
+    - 'lib/custom_facts/core/execution/posix.rb'
+
+Style/MethodMissingSuper:
+  Exclude:
+    - 'lib/facter.rb'
+
+Style/MissingRespondToMissing:
+  Exclude:
+    - 'lib/facter.rb'
+
+Style/StderrPuts:
+  Exclude:
+    - 'lib/custom_facts/core/logging.rb'
+
+Style/ModuleFunction:
+  Exclude:
+    - 'lib/custom_facts/core/logging.rb'
+
+Style/HashEachMethods:
+  Enabled: false  # not implemted in ruby 2.3
+
+Style/HashTransformKeys:
+  Enabled: false  # not implemted in ruby 2.3
+
+Style/HashTransformValues:
+  Enabled: false  # not implemted in ruby 2.3