factbase 0.19.11 → 0.19.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 712cd682bc9457b563afc7a855e56cad191d2a302406e0e4e9f886ce7fa83af3
-  data.tar.gz: cd3a312b78a152b7c9631777473e7465648e6b57d31d713d37d93c63834048ed
+  metadata.gz: f97152f34dd9eb3ba72cc5380a87d321bbec59c316078108b38c2c078c23a0fd
+  data.tar.gz: 0f678a254dc256d1983965742771c37d0956a89f93ec91e098f63b4d2957117a
 SHA512:
-  metadata.gz: 013ff487bbd8d2379224361b7794d5219d3235c9c66f645ebe1d6dd928d2298f1a411240328839ea48e08f7dd4c1161cde173530c52f5f8a5afdab52c66cce98
-  data.tar.gz: cf57ff6a8f881224a2124306871d245cab380331905fd0ec1acecd381a46d636a7877867a8f1ef27611f1dafe4f1e777c1a01aa57f08b35eb3486682aef22ad3
+  metadata.gz: a8ebb9cd303ab0a6b34842ec06fa2d5f4ed1ec1d2c8fff89e1068531782386c1c6da2bba4f2d116635ca37532d314c25626fe0fdcac03a10ead6b57871483485
+  data.tar.gz: 1f2be490a544b5417059853ed135011c85215bbea7fb9b96551bcd67badc32e20a9384acf97d6a3b4908e63332937bb4502df168c79aa19ed95afc1a364ee4bd

data/Gemfile

@@ -10,16 +10,17 @@ gem 'benchmark', '~>0.5', require: false
 gem 'minitest', '~>6.0', require: false
 gem 'minitest-reporters', '~>1.7', require: false
 gem 'os', '~>1.1', require: false
-gem 'psych', '5.3.1', require: false # GPL
+gem 'psych', '5.3.1', require: false
 gem 'qbash', '~>0.4', require: false
 gem 'rake', '~>13.2', require: false
-gem 'rdoc', '7.1.0', require: false # GPL
+gem 'rdoc', '7.1.0', require: false
 gem 'rubocop', '~>1.74', require: false
+gem 'rubocop-elegant', '~>0.5', require: false
 gem 'rubocop-minitest', '~>0.38', require: false
 gem 'rubocop-performance', '~>1.25', require: false
 gem 'rubocop-rake', '~>0.7', require: false
 gem 'simplecov', '~>0.22', require: false
 gem 'simplecov-cobertura', '~>3.0', require: false
-gem 'stackprof', '0.2.27', require: false, platforms: [:ruby] # GPL
+gem 'stackprof', '0.2.27', require: false, platforms: [:ruby]
 gem 'threads', '~>0.4', require: false
-gem 'yard', '0.9.38', require: false # GPL
+gem 'yard', '0.9.38', require: false

data/Gemfile.lock

@@ -30,8 +30,8 @@ GEM
       loog (~> 0.6)
       tago (~> 0.1)
     ellipsized (0.3.0)
-    erb (6.0.1)
-    json (2.18.1)
+    erb (6.0.4)
+    json (2.19.5)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     logger (1.7.0)
@@ -46,18 +46,18 @@ GEM
       builder
       minitest (>= 5.0, < 7)
       ruby-progressbar
-    nokogiri (1.19.0-arm64-darwin)
+    nokogiri (1.19.3-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.19.0-x64-mingw-ucrt)
+    nokogiri (1.19.3-x64-mingw-ucrt)
       racc (~> 1.4)
-    nokogiri (1.19.0-x86_64-darwin)
+    nokogiri (1.19.3-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.19.0-x86_64-linux-gnu)
+    nokogiri (1.19.3-x86_64-linux-gnu)
       racc (~> 1.4)
     os (1.1.4)
     others (0.1.1)
-    parallel (1.27.0)
-    parser (3.3.10.2)
+    parallel (2.1.0)
+    parser (3.3.11.1)
       ast (~> 2.4.1)
       racc
     prism (1.9.0)
@@ -76,22 +76,25 @@ GEM
       erb
       psych (>= 4.0.0)
       tsort
-    regexp_parser (2.11.3)
+    regexp_parser (2.12.0)
     rexml (3.4.4)
-    rubocop (1.84.2)
+    rubocop (1.86.2)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
-      parallel (~> 1.10)
+      parallel (>= 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
       rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.49.0)
+    rubocop-ast (1.49.1)
       parser (>= 3.3.7.2)
       prism (~> 1.7)
+    rubocop-elegant (0.5.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.75)
     rubocop-minitest (0.39.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.75.0, < 2.0)
@@ -148,6 +151,7 @@ DEPENDENCIES
   rake (~> 13.2)
   rdoc (= 7.1.0)
   rubocop (~> 1.74)
+  rubocop-elegant (~> 0.5)
   rubocop-minitest (~> 0.38)
   rubocop-performance (~> 1.25)
   rubocop-rake (~> 0.7)

data/README.md

@@ -11,7 +11,10 @@
 [![Yard Docs](https://img.shields.io/badge/yard-docs-blue.svg)](https://rubydoc.info/github/yegor256/factbase/master/frames)
 [![Hits-of-Code](https://hitsofcode.com/github/yegor256/factbase)](https://hitsofcode.com/view/github/yegor256/factbase)
 [![License](https://img.shields.io/badge/license-MIT-green.svg)](https://github.com/yegor256/factbase/blob/master/LICENSE.txt)
-[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Fyegor256%2Ffactbase.svg?type=shield&issueType=license)](https://app.fossa.com/projects/git%2Bgithub.com%2Fyegor256%2Ffactbase?ref=badge_shield&issueType=license)
+[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Fyegor256%2Ffactbase.svg?type=shield&issueType=license)](https://app.fossa.com/projects/git%2Bgithub%2Fyegor256%2Ffactbase?ref=badge_shield&issueType=license)
+
+> **WARNING:** `Factbase` is **NOT** thread-safe. Use `Factbase::SyncFactbase`
+> for concurrent access from multiple threads.
 
 This Ruby gem manages an in-memory database of facts.
 A fact is simply an associative array of properties and their values.
@@ -19,7 +22,8 @@ The values are either atomic literals or non-empty sets of literals.
 It is possible to delete a fact, but impossible to delete a property
 from a fact.
 
-Here is how you use it (it's thread-safe, by the way):
+Here is how you use it (wrap it with `Factbase::SyncFactbase`
+for thread-safe access):
 
 ```ruby
 fb = Factbase.new
@@ -119,6 +123,27 @@ end
 assert(0 == fb.size)
 ```
 
+## Query Parameters
+
+You can use `$name` variables in queries and pass values at runtime:
+
+```ruby
+fb = Factbase.new
+fb.insert.foo = 42
+fb.insert.foo = 99
+fb.query('(eq foo $bar)').each(Factbase.new, bar: [42]).to_a
+# Returns the fact with foo = 42
+```
+
+Variables are passed as keyword arguments to `each` or `one`. The value must
+be an array (even for a single value). This works with any term:
+
+```ruby
+fb.query(
+  '(eq salary (agg (eq dept $dept) (avg salary)))'
+).each(Factbase.new, dept: ['eng']).to_a
+```
+
 ## Terms
 
 There are some boolean terms available in a query
@@ -293,7 +318,13 @@ Persistence uses Ruby's
   platforms, unlike [JSON](https://www.json.org/json-en.html) or
   [Protocol Buffers](https://protobuf.dev/). Output-only decorators
   `Factbase::ToJSON`, `Factbase::ToXML`, and `Factbase::ToYAML` exist but
-  do not support round-trip import.
+  do not support round-trip import. Because `import` calls `Marshal.load`
+  on the incoming bytes, the input must come from a source the caller
+  trusts; a `Marshal` stream crafted by an attacker can execute arbitrary
+  code in the calling process, so factbase blobs received over the
+  network or read from a user-supplied path should be authenticated
+  out-of-band before being imported, as described in the
+  [Ruby security notes](https://docs.ruby-lang.org/en/3.3/security_rdoc.html#label-Marshal.load).
 
 `Factbase::IndexedFactbase` lazily builds a hash-based inverted index for
   equality queries, keyed by array `object_id`, property name, and
@@ -326,24 +357,24 @@ This is the result of the benchmark:
 <!-- benchmark_begin -->
 ```text
                                                                    user
-void scan                                                      0.001049
-20k facts: export: 2980KB                                      0.840193
-20k facts: import: 2980KB                                      1.033492
-50k facts: read                                                0.000179
-50k facts: read in txn                                         0.002282
-50k facts: insert                                              0.000082
-50k facts: insert in txn                                       0.000613
-50k facts: modify                                              1.427349
-50k facts: modify in txn                                       2.773065
-12k facts: large query: match 3k                              13.166170
-12k facts: large query: match 3k in txn                       18.502015
-12k facts: large query: match zero                            14.234812
-12k facts: large query: match zero in txn                     19.847547
+void scan                                                      0.001115
+20k facts: export: 2979KB                                      0.979531
+20k facts: import: 2979KB                                      1.055363
+50k facts: read                                                0.000212
+50k facts: read in txn                                         0.001724
+50k facts: insert                                              0.000081
+50k facts: insert in txn                                       0.000226
+50k facts: modify                                              1.604103
+50k facts: modify in txn                                       3.126437
+12k facts: large query: match 3k                              13.220472
+12k facts: large query: match 3k in txn                       18.484006
+12k facts: large query: match zero                            13.730576
+12k facts: large query: match zero in txn                     19.485743
 ```
 
 The results were calculated in [this GHA job][benchmark-gha]
-on 2026-05-23 at 03:40,
+on 2026-06-14 at 16:40,
 on Linux with 4 CPUs.
 <!-- benchmark_end -->
 
-[benchmark-gha]: https://github.com/yegor256/factbase/actions/runs/26322478578
+[benchmark-gha]: https://github.com/yegor256/factbase/actions/runs/27505290212

data/Rakefile

@@ -63,7 +63,7 @@ end
 desc 'Benchmark them all'
 task :benchmark, [:name, :cycles] do |_t, args|
   bname = args[:name] || 'essential'
-  cycles = (args[:cycles] || 5).to_i
+  cycles = Integer(args[:cycles] || 5)
   require_relative 'lib/factbase'
   require_relative 'lib/factbase/cached/cached_factbase'
   require_relative 'lib/factbase/indexed/indexed_factbase'
@@ -84,16 +84,11 @@ task :benchmark, [:name, :cycles] do |_t, args|
       fb = Factbase.new
       fb = Factbase::IndexedFactbase.new(fb)
       fb = Factbase::CachedFactbase.new(fb)
-      Kernel.send(File.basename(f).gsub(/\.rb$/, '').to_sym, b, fb, cycles)
+      Kernel.__send__(File.basename(f).gsub(/\.rb$/, '').to_sym, b, fb, cycles)
     end
   end
 end
 
-# Run profiling on a benchmark and generate a flamegraph.
-# To run this task, you need to have stackprof installed.
-# https://github.com/tmm1/stackprof
-# To run profiling for a specific benchmark you can run:
-#   bundle exec rake flamegraph\[bench_slow_query\]
 desc 'Profile a benchmark (e.g., flamegraph[bench_slow_query])'
 task :flamegraph, [:name] do |_t, args|
   require 'stackprof'

data/factbase.gemspec

@@ -7,7 +7,7 @@ require 'English'
 require_relative 'lib/factbase/version'
 
 Gem::Specification.new do |s|
-  s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to? :required_rubygems_version=
+  s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to?(:required_rubygems_version=)
   s.required_ruby_version = '>=3.0'
   s.name = 'factbase'
   s.version = Factbase::VERSION
@@ -25,15 +25,15 @@ Gem::Specification.new do |s|
   s.files = `git ls-files | grep -v -E '^(test/|\\.|fixtures|benchmark|renovate)'`.split($RS)
   s.rdoc_options = ['--charset=UTF-8']
   s.extra_rdoc_files = ['README.md', 'LICENSE.txt']
-  s.add_dependency 'backtrace', '~>0.4'
-  s.add_dependency 'decoor', '~>0.1'
-  s.add_dependency 'ellipsized', '~>0.3'
-  s.add_dependency 'json', '~>2.7'
-  s.add_dependency 'logger', '~>1.0'
-  s.add_dependency 'loog', '~>0.6'
-  s.add_dependency 'nokogiri', '~>1.10'
-  s.add_dependency 'others', '~>0.1'
-  s.add_dependency 'tago', '~>0.1'
-  s.add_dependency 'yaml', '~>0.3'
+  s.add_dependency('backtrace', '~>0.4')
+  s.add_dependency('decoor', '~>0.1')
+  s.add_dependency('ellipsized', '~>0.3')
+  s.add_dependency('json', '~>2.7')
+  s.add_dependency('logger', '~>1.0')
+  s.add_dependency('loog', '~>0.6')
+  s.add_dependency('nokogiri', '~>1.10')
+  s.add_dependency('others', '~>0.1')
+  s.add_dependency('tago', '~>0.1')
+  s.add_dependency('yaml', '~>0.3')
   s.metadata['rubygems_mfa_required'] = 'true'
 end

data/lib/factbase/accum.rb

@@ -27,7 +27,7 @@ class Factbase::Accum
   end
 
   def all_properties
-    @fact.all_properties
+    @fact.all_properties | @props.keys
   end
 
   others do |*args|

data/lib/factbase/cached/cached_fact.rb

@@ -24,9 +24,8 @@ class Factbase::CachedFact
     @origin.to_s
   end
 
-  # When a method is missing, this method is called.
   others do |*args|
     @cache.clear if args[0].to_s.end_with?('=')
-    @origin.send(*args)
+    @origin.__send__(*args)
   end
 end

data/lib/factbase/cached/cached_factbase.rb

@@ -22,9 +22,9 @@ class Factbase::CachedFactbase
   # @param [Factbase] origin Original factbase to decorate
   # @param [Hash] cache Cache to use
   def initialize(origin, cache = {})
-    raise 'Wrong type of original' unless origin.respond_to?(:query)
+    raise(ArgumentError, 'Wrong type of original') unless origin.respond_to?(:query)
     @origin = origin
-    raise 'Wrong type of cache' unless cache.is_a?(Hash)
+    raise(ArgumentError, 'Wrong type of cache') unless cache.is_a?(Hash)
     @cache = cache
   end
 
@@ -58,7 +58,7 @@ class Factbase::CachedFactbase
   # @return [Factbase::Churn] How many facts have been changed (zero if rolled back)
   def txn
     @origin.txn do |fbt|
-      yield Factbase::CachedFactbase.new(fbt, @cache)
+      yield(Factbase::CachedFactbase.new(fbt, @cache))
     end
   end
 end

data/lib/factbase/cached/cached_query.rb

@@ -36,13 +36,12 @@ class Factbase::CachedQuery
   def each(fb = @fb, params = {})
     return to_enum(__method__, fb, params) unless block_given?
     invalidate_if_dirty!
-    key = "each #{@origin}" # params are ignored!
-    before = @cache[key]
-    @cache[key] = @origin.each(fb, params).to_a if before.nil?
+    key = "each #{@origin}"
+    @cache[key] = @origin.each(fb, params).to_a if @cache[key].nil?
     c = 0
     @cache[key].each do |f|
       c += 1
-      yield Factbase::CachedFact.new(f, @cache)
+      yield(Factbase::CachedFact.new(f, @cache))
     end
     c
   end
@@ -54,8 +53,7 @@ class Factbase::CachedQuery
   def one(fb = @fb, params = {})
     invalidate_if_dirty!
     key = "one: #{@origin} #{params}"
-    before = @cache[key]
-    @cache[key] = @origin.one(fb, params) if before.nil?
+    @cache[key] = @origin.one(fb, params) if @cache[key].nil?
     @cache[key]
   end
 

data/lib/factbase/cached/cached_term.rb

@@ -19,8 +19,7 @@ module Factbase::CachedTerm
     return super unless static? && !abstract?
     return super if %i[head unique].include?(@op)
     key = [maps.object_id, to_s]
-    before = @cache[key]
-    @cache[key] = super if before.nil?
+    @cache[key] = super if @cache[key].nil?
     @cache[key]
   end
 end

data/lib/factbase/churn.rb

@@ -22,16 +22,16 @@ class Factbase::Churn
     if zero?
       'nothing'
     else
-      "#{@inserted}i/#{@deleted}d/#{@added}a"
+      "#{inserted}i/#{deleted}d/#{added}a"
     end
   end
 
   def zero?
-    @inserted.zero? && @deleted.zero? && @added.zero?
+    inserted.zero? && deleted.zero? && added.zero?
   end
 
   def to_i
-    @inserted + @deleted + @added
+    inserted + deleted + added
   end
 
   def append(ins, del, add)
@@ -43,10 +43,6 @@ class Factbase::Churn
   end
 
   def +(other)
-    Factbase::Churn.new(
-      @inserted + other.inserted,
-      @deleted + other.deleted,
-      @added + other.added
-    )
+    Factbase::Churn.new(inserted + other.inserted, deleted + other.deleted, added + other.added)
   end
 end

data/lib/factbase/fact.rb

@@ -4,8 +4,8 @@
 # SPDX-License-Identifier: MIT
 
 require 'json'
-require 'time'
 require 'others'
+require 'time'
 require_relative '../factbase'
 
 # A single fact in a factbase.
@@ -37,7 +37,7 @@ class Factbase::Fact
   # Convert it to a string.
   # @return [String] String representation of it (in JSON)
   def to_s
-    "[ #{@map.map { |k, v| "#{k}: #{v}" }.sort.join(', ')} ]"
+    "[ #{@map.map { |k, v| "#{k}: #{v}" }.sort!.join(', ')} ]"
   end
 
   # Get a list of all props.
@@ -50,12 +50,15 @@ class Factbase::Fact
     k = args[0].to_s
     if k.end_with?('=')
       kk = k[0..-2]
-      raise "Invalid prop name '#{kk}'" unless kk.match?(/^[a-z_][_a-zA-Z0-9]*$/)
-      raise "Prohibited prop name '#{kk}'" if methods.include?(kk.to_sym)
+      raise(ArgumentError, "Invalid prop name '#{kk}'") unless kk.match?(/^[a-z_][_a-zA-Z0-9]*$/)
+      raise(ArgumentError, "Prohibited prop name '#{kk}'") if methods.include?(kk.to_sym)
       v = args[1]
-      raise "The value of '#{kk}' can't be nil" if v.nil?
-      raise "The value of '#{kk}' can't be empty" if v == ''
-      raise "The type '#{v.class}' of '#{kk}' is not allowed" unless [String, Integer, Float, Time].include?(v.class)
+      raise(ArgumentError, "The value of '#{kk}' can't be nil") if v.nil?
+      raise(ArgumentError, "The value of '#{kk}' can't be empty") if v == ''
+      raise(ArgumentError, "The type '#{v.class}' of '#{kk}' is not allowed") unless [
+        String, Integer, Float,
+        Time
+      ].include?(v.class)
       v = v.utc if v.is_a?(Time)
       @map[kk] = [] if @map[kk].nil?
       @map[kk] << v
@@ -65,8 +68,8 @@ class Factbase::Fact
     else
       v = @map[k]
       if v.nil?
-        raise "Can't get '#{k}', the fact is empty" if @map.empty?
-        raise "Can't find '#{k}' attribute out of [#{@map.keys.join(', ')}]"
+        raise(ArgumentError, "Can't get '#{k}', the fact is empty") if @map.empty?
+        raise(ArgumentError, "Can't find '#{k}' attribute out of [#{@map.keys.join(', ')}]")
       end
       v[0]
     end

data/lib/factbase/flatten.rb

@@ -21,8 +21,8 @@ class Factbase::Flatten
   # @return [Array<HashMap>] The hashmaps, but improved
   def it
     @maps
-      .sort_by { |m| m[@sorter] || [] }
+      .sort_by { |m| Array(m[@sorter]).map(&:to_s) }
       .map { |m| m.sort.to_h }
-      .map { |m| m.transform_values { |v| v.size == 1 ? v[0] : v } }
+      .map! { |m| m.transform_values { |v| v.size == 1 ? v[0] : v } }
   end
 end

data/lib/factbase/impatient.rb

@@ -18,9 +18,9 @@ class Factbase::Impatient
   # @param [Factbase] fb The factbase to decorate
   # @param [Integer] timeout Timeout in seconds
   def initialize(fb, timeout: 15)
-    raise 'The "fb" is nil' if fb.nil?
+    raise(ArgumentError, 'The "fb" is nil') if fb.nil?
     @origin = fb
-    @timeout = timeout.to_f
+    @timeout = Float(timeout)
   end
 
   decoor(:origin)
@@ -36,7 +36,7 @@ class Factbase::Impatient
 
   def txn
     @origin.txn do |fbt|
-      yield Factbase::Impatient.new(fbt, timeout: @timeout)
+      yield(Factbase::Impatient.new(fbt, timeout: @timeout))
     end
   end
 
@@ -56,17 +56,15 @@ class Factbase::Impatient
     end
 
     def each(fb = @fb, params = {}, &)
-      a =
-        impatient('each') do
-          @fb.query(@term, @maps).each(fb, params).to_a
+      return to_enum(__method__, fb, params) unless block_given?
+      n = 0
+      impatient('each') do
+        @fb.query(@term, @maps).each(fb, params) do |f|
+          yield(f)
+          n += 1
         end
-      return a unless block_given?
-      yielded = 0
-      a.each do |f|
-        yield f
-        yielded += 1
       end
-      yielded
+      n
     end
 
     def one(fb = @fb, params = {})
@@ -86,7 +84,10 @@ class Factbase::Impatient
     def impatient(name, &)
       Timeout.timeout(@timeout, &)
     rescue Timeout::Error => e
-      raise "#{name}() timed out after #{@timeout.seconds} (#{e.message}), fb size is #{@fb.size}: #{@term}"
+      raise(
+        StandardError,
+        "#{name}() timed out after #{@timeout.seconds} (#{e.message}), fb size is #{@fb.size}: #{@term}"
+      )
     end
   end
 end

data/lib/factbase/indexed/indexed_and.rb

@@ -11,12 +11,12 @@ class Factbase::IndexedAnd
   end
 
   def predict(maps, fb, params)
-    return nil if @idx.nil?
+    return if @idx.nil?
     key = [maps.object_id, @term.operands.first, @term.op]
     r = nil
     if @term.operands.all? { |o| o.op == :eq } && @term.operands.size > 1 \
       && @term.operands.all? { |o| o.operands.first.is_a?(Symbol) && _scalar?(o.operands[1]) }
-      props = @term.operands.map { |o| o.operands.first }.sort
+      props = @term.operands.map { |o| o.operands.first }.sort!
       key = [maps.object_id, props, :multi_and_eq]
       entry = @idx[key]
       maps_array = maps.to_a
@@ -45,19 +45,24 @@ class Factbase::IndexedAnd
       j = tuples.flat_map { |t| entry[:index][t] || [] }.uniq(&:object_id)
       r = maps.respond_to?(:repack) ? maps.repack(j) : j
     else
+      fail = false
       @term.operands.each do |o|
         n = o.predict(maps, fb, params)
-        break if n.nil?
+        if n.nil?
+          fail = true
+          break
+        end
         if r.nil?
           r = n
-        elsif n.size < r.size * 8 # to skip some obvious matchings
+        elsif n.size < r.size * 8
           small, large = n.size < r.size ? [n.to_a, r.to_a] : [r.to_a, n.to_a]
           ids = Set.new(small.map(&:object_id))
           r = large.select { |f| ids.include?(f.object_id) }
         end
-        break if r.size < maps.size / 32 # it's already small enough
-        break if r.size < 128 # it's obviously already small enough
+        break if r.size < maps.size / 32
+        break if r.size < 128
       end
+      return if fail
     end
     r
   end
@@ -69,19 +74,8 @@ class Factbase::IndexedAnd
   end
 
   def _all_tuples(fact, props)
-    prop = props.first.to_s
-    tuples = []
-    tuples += (fact[prop] || []).zip
-    if props.size > 1
-      tails = _all_tuples(fact, props[1..])
-      ext = []
-      tuples.each do |t|
-        tails.each do |tail|
-          ext << (t + tail)
-        end
-      end
-      tuples = ext
-    end
-    tuples
+    values = props.map { |p| fact[p.to_s] || [] }
+    return [] if values.any?(&:empty?)
+    values[0].product(*values[1..])
   end
 end

data/lib/factbase/indexed/indexed_eq.rb

@@ -3,7 +3,11 @@
 # SPDX-FileCopyrightText: Copyright (c) 2024-2026 Yegor Bugayenko
 # SPDX-License-Identifier: MIT
 
-# Indexed term 'eq'.
+# Indexed term 'eq' that uses the hash-based inverted index for fast equality lookups.
+#
+# Author:: Yegor Bugayenko (yegor256@gmail.com)
+# Copyright:: Copyright (c) 2024-2026 Yegor Bugayenko
+# License:: MIT
 class Factbase::IndexedEq
   def initialize(term, idx)
     @term = term

data/lib/factbase/indexed/indexed_fact.rb

@@ -26,11 +26,8 @@ class Factbase::IndexedFact
     @origin.to_s
   end
 
-  # When a method is missing, this method is called.
   others do |*args|
-    # Only clear index when modifying properties on existing (non-fresh) facts
-    # Fresh facts are not in the index yet, so modifications don't affect it
     @idx.clear if args[0].to_s.end_with?('=') && !@fresh.include?(object_id)
-    @origin.send(*args)
+    @origin.__send__(*args)
   end
 end

data/lib/factbase/indexed/indexed_factbase.rb

@@ -23,9 +23,9 @@ class Factbase::IndexedFactbase
   # @param [Hash] idx Index to use
   # @param [Set] fresh The set of IDs of newly inserted facts
   def initialize(origin, idx = {}, fresh = Set.new)
-    raise 'Wrong type of original' unless origin.respond_to?(:query)
+    raise(ArgumentError, 'Wrong type of original') unless origin.respond_to?(:query)
     @origin = origin
-    raise 'Wrong type of index' unless idx.is_a?(Hash)
+    raise(ArgumentError, 'Wrong type of index') unless idx.is_a?(Hash)
     @idx = idx
     @fresh = fresh
   end
@@ -64,7 +64,7 @@ class Factbase::IndexedFactbase
     inner_idx = {}
     result =
       @origin.txn do |fbt|
-        yield Factbase::IndexedFactbase.new(fbt, inner_idx, @fresh)
+        yield(Factbase::IndexedFactbase.new(fbt, inner_idx, @fresh))
       end
     @idx.clear if result.deleted.positive? || result.added.positive?
     @fresh.clear
@@ -100,7 +100,7 @@ class Factbase::IndexedFactbase
   #
   # @param [String] bytes Binary string to import
   def import(bytes)
-    raise 'Empty input, cannot load a factbase' if bytes.empty?
+    raise(StandardError, 'Empty input, cannot load a factbase') if bytes.empty?
     data = Marshal.load(bytes)
     if data.is_a?(Hash) && data.key?(:maps)
       @origin.import(data[:maps])

data/lib/factbase/indexed/indexed_gt.rb

@@ -44,6 +44,8 @@ class Factbase::IndexedGt
   def _search(entry, target)
     idx = entry[:facts].bsearch_index { |v, _| v > target }
     return [] if idx.nil?
-    entry[:facts][idx..].map { |_, f| f }.uniq(&:object_id)
+    facts = entry[:facts][idx..].map { |_, f| f }
+    facts.uniq!(&:object_id)
+    facts
   end
 end