factbase 0.12.0 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f31200ddcd8de0d737dbabea9aefc051794f86bbae0891f8d624545912972add
-  data.tar.gz: 7c1688856cde3e72f8e9f53e846b39c7cef508a0df95cc88d0631bfae36ce07f
+  metadata.gz: cb06b280801b081a1ae2c02147b4c960017c52a0cdb2c38dcd895cff53943344
+  data.tar.gz: cde4f73ddf30a7d4b6d9f9b8dadf823c948f6bb5fa672ad180867a46ef7b9ce2
 SHA512:
-  metadata.gz: 26c83d3a288f8106bfe17856bccb9c1bde6b130384e9a4546456a76c1b6a69fff9c49954789aaeee6413f7cfae638d6f1320f1de4f7ac000b3c552b31449ebbd
-  data.tar.gz: 761d577bc112c4d542667508924406570ff449fbab87af3a18fc0ce7c8a94cccf6d40f400b1b1c3f6bd76d95a51678a680fd17feeee0b89caacbac2b56e8e6f6
+  metadata.gz: 42072d2fd692798e3dd25a16167416cc6afd601d12998a1d0a5d79b2ab18d66bc09fcf40ae11e2a53af4df6fd9f5cba56a6adf32b94edd11e5122c9992304bbc
+  data.tar.gz: e6ec47e6c0715ac9c8148bc5ac25e36f6e009dd7da34c32386a7b5d97dcdf11c6ed6e5ed17f27ca03e2ad454bf5dacae0624ec7ab5119a4396f4a4134a6f5b11

data/.github/workflows/typos.yml

@@ -16,4 +16,4 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
-      - uses: crate-ci/typos@v1.33.1
+      - uses: crate-ci/typos@v1.34.0

data/Gemfile

@@ -11,7 +11,7 @@ gem 'minitest-reporters', '~>1.7', require: false
 gem 'os', '~>1.1', require: false
 gem 'qbash', '~>0.4', require: false
 gem 'rake', '~>13.2', require: false
-gem 'rdoc', '~>6.13', require: false
+gem 'rdoc', '6.14.1', require: false # GPL
 gem 'rubocop', '~>1.74', require: false
 gem 'rubocop-minitest', '~>0.38', require: false
 gem 'rubocop-performance', '~>1.25', require: false

data/Gemfile.lock

@@ -24,7 +24,7 @@ GEM
     date (3.4.1)
     decoor (0.1.0)
     docile (1.4.1)
-    elapsed (0.0.1)
+    elapsed (0.1.0)
       loog (> 0)
       tago (> 0)
     ellipsized (0.3.0)
@@ -67,7 +67,7 @@ GEM
     racc (1.8.1)
     rainbow (3.1.1)
     rake (13.3.0)
-    rdoc (6.14.1)
+    rdoc (6.14.2)
       erb
       psych (>= 4.0.0)
     regexp_parser (2.10.0)
@@ -134,7 +134,7 @@ DEPENDENCIES
   os (~> 1.1)
   qbash (~> 0.4)
   rake (~> 13.2)
-  rdoc (~> 6.13)
+  rdoc (= 6.14.1)
   rubocop (~> 1.74)
   rubocop-minitest (~> 0.38)
   rubocop-performance (~> 1.25)

data/benchmark/bench_query.rb

@@ -6,7 +6,7 @@
 require_relative '../lib/factbase'
 
 def bench_query(bmk, fb)
-  total = 500
+  total = 20_000
   total.times do |i|
     f = fb.insert
     f.id = i
@@ -15,6 +15,7 @@ def bench_query(bmk, fb)
     f.cost = rand(1..100)
     f.foo = rand(0.0..100.0).round(3)
     f.bar = rand(100..300)
+    f.blue = 1 if rand > 0.5
     f.seenBy = "User#{i}" if i.even?
     f.zzz = "Extra#{i}" if (i % 10).zero?
   end
@@ -25,6 +26,7 @@ def bench_query(bmk, fb)
     '(gt cost 50)',
     '(eq title \'Object Thinking 5000\')',
     '(and (eq foo 42.998) (or (gt bar 200) (absent zzz)))',
+    '(and (exists foo) (not (exists blue)))',
     '(eq id (agg (always) (max id)))',
     '(join "c<=cost,b<=bar" (eq id (agg (always) (max id))))'
   ].each do |q|

data/lib/factbase/indexed/indexed_term.rb

@@ -120,11 +120,20 @@ module Factbase::IndexedTerm
       end
       r
     when :not
-      r = @operands.first.predict(maps, params)
+      if @idx[key].nil?
+        yes = @operands.first.predict(maps, params)
+        if yes.nil?
+          @idx[key] = { r: nil }
+        else
+          yes = yes.to_a.to_set
+          @idx[key] = { r: maps.to_a.reject { |m| yes.include?(m) } }
+        end
+      end
+      r = @idx[key][:r]
       if r.nil?
         nil
       else
-        (maps & []) | (maps.to_a - r.to_a)
+        (maps & []) | r
       end
     end
   end

data/lib/factbase/rules.rb

@@ -14,7 +14,7 @@ require_relative '../factbase/syntax'
 # to insert a fact without this property to lead to a runtime error. Here is how:
 #
 #  fb = Factbase.new
-#  fb = Factabase::Rules.new(fb, '(exists foo)')
+#  fb = Factbase::Rules.new(fb, '(exists foo)')
 #  fb.txn do |fbt|
 #    f = fbt.insert
 #    f.bar = 3 # No exception here

data/lib/factbase/terms/aggregates.rb

@@ -28,9 +28,9 @@ module Factbase::Aggregates
   def nth(_fact, maps, _fb)
     assert_args(2)
     pos = @operands[0]
-    raise "An integer expected, but #{pos} provided" unless pos.is_a?(Integer)
+    raise "An integer is expected, but #{pos} provided" unless pos.is_a?(Integer)
     k = @operands[1]
-    raise "A symbol expected, but #{k} provided" unless k.is_a?(Symbol)
+    raise "A symbol is expected, but #{k} provided" unless k.is_a?(Symbol)
     m = maps[pos]
     return nil if m.nil?
     m[k.to_s]
@@ -39,7 +39,7 @@ module Factbase::Aggregates
   def first(_fact, maps, _fb)
     assert_args(1)
     k = @operands[0]
-    raise "A symbol expected, but #{k} provided" unless k.is_a?(Symbol)
+    raise "A symbol is expected, but #{k} provided" unless k.is_a?(Symbol)
     first = maps[0]
     return nil if first.nil?
     first[k.to_s]
@@ -47,7 +47,7 @@ module Factbase::Aggregates
 
   def sum(_fact, maps, _fb)
     k = @operands[0]
-    raise "A symbol expected, but '#{k}' provided" unless k.is_a?(Symbol)
+    raise "A symbol is expected, but '#{k}' provided" unless k.is_a?(Symbol)
     sum = 0
     maps.each do |m|
       vv = m[k.to_s]
@@ -63,9 +63,9 @@ module Factbase::Aggregates
   def agg(fact, maps, fb)
     assert_args(2)
     selector = @operands[0]
-    raise "A term expected, but '#{selector}' provided" unless selector.is_a?(Factbase::Term)
+    raise "A term is expected, but '#{selector}' provided" unless selector.is_a?(Factbase::Term)
     term = @operands[1]
-    raise "A term expected, but '#{term}' provided" unless term.is_a?(Factbase::Term)
+    raise "A term is expected, but '#{term}' provided" unless term.is_a?(Factbase::Term)
     subset = fb.query(selector, maps).each(fb, fact).to_a
     term.evaluate(nil, subset, fb)
   end
@@ -73,7 +73,7 @@ module Factbase::Aggregates
   def empty(fact, maps, fb)
     assert_args(1)
     term = @operands[0]
-    raise "A term expected, but '#{term}' provided" unless term.is_a?(Factbase::Term)
+    raise "A term is expected, but '#{term}' provided" unless term.is_a?(Factbase::Term)
     # rubocop:disable Lint/UnreachableLoop
     fb.query(term, maps).each(fb, fact) do
       return false
@@ -84,7 +84,7 @@ module Factbase::Aggregates
 
   def _best(maps)
     k = @operands[0]
-    raise "A symbol expected, but #{k} provided" unless k.is_a?(Symbol)
+    raise "A symbol is expected, but #{k} provided" unless k.is_a?(Symbol)
     best = nil
     maps.each do |m|
       vv = m[k.to_s]

data/lib/factbase/terms/aliases.rb

@@ -14,7 +14,7 @@ module Factbase::Aliases
   def as(fact, maps, fb)
     assert_args(2)
     a = @operands[0]
-    raise "A symbol expected as first argument of 'as'" unless a.is_a?(Symbol)
+    raise "A symbol is expected as first argument of 'as'" unless a.is_a?(Symbol)
     vv = _values(1, fact, maps, fb)
     vv&.each { |v| fact.send(:"#{a}=", v) }
     true
@@ -23,13 +23,13 @@ module Factbase::Aliases
   def join(fact, maps, fb)
     assert_args(2)
     jumps = @operands[0]
-    raise "A string expected as first argument of 'join'" unless jumps.is_a?(String)
+    raise "A string is expected as first argument of 'join'" unless jumps.is_a?(String)
     jumps = jumps.split(',')
       .map(&:strip)
       .map { |j| j.split('<=').map(&:strip) }
       .map { |j| j.size == 1 ? [j[0], j[0]] : j }
     term = @operands[1]
-    raise "A term expected, but '#{term}' provided" unless term.is_a?(Factbase::Term)
+    raise "A term is expected, but '#{term}' provided" unless term.is_a?(Factbase::Term)
     subset = fb.query(term, maps).each(fb, fact).to_a
     subset.each do |s|
       jumps.each do |to, from|

data/lib/factbase/terms/debug.rb

@@ -14,7 +14,7 @@ module Factbase::Debug
   def traced(fact, maps, fb)
     assert_args(1)
     t = @operands[0]
-    raise "A term expected, but '#{t}' provided" unless t.is_a?(Factbase::Term)
+    raise "A term is expected, but '#{t}' provided" unless t.is_a?(Factbase::Term)
     r = t.evaluate(fact, maps, fb)
     puts "#{self} -> #{r}"
     r
@@ -25,12 +25,12 @@ module Factbase::Debug
     message = @operands[0]
     unless message.is_a?(String)
       raise ArgumentError,
-            "A string expected as first argument of 'assert', but '#{message}' provided"
+            "A string is expected as first argument of 'assert', but '#{message}' provided"
     end
     t = @operands[1]
     unless t.is_a?(Factbase::Term)
       raise ArgumentError,
-            "A term expected as second argument of 'assert', but '#{t}' provided"
+            "A term is expected as second argument of 'assert', but '#{t}' provided"
     end
     result = t.evaluate(fact, maps, fb)
     # Convert result to boolean-like evaluation

data/lib/factbase/terms/logical.rb

@@ -119,6 +119,6 @@ module Factbase::Logical
     val = val[0] if val.respond_to?(:each)
     return false if val.nil?
     return val if val.is_a?(TrueClass) || val.is_a?(FalseClass)
-    raise "Boolean expected, while #{val.class} received from #{@operands[pos]}"
+    raise "Boolean is expected, while #{val.class} received from #{@operands[pos]}"
   end
 end

data/lib/factbase/terms/strings.rb

@@ -25,10 +25,10 @@ module Factbase::Strings
     assert_args(2)
     str = _values(0, fact, maps, fb)
     return false if str.nil?
-    raise 'Exactly one string expected' unless str.size == 1
+    raise 'Exactly one string is expected' unless str.size == 1
     re = _values(1, fact, maps, fb)
     raise 'Regexp is nil' if re.nil?
-    raise 'Exactly one regexp expected' unless re.size == 1
+    raise 'Exactly one regexp is expected' unless re.size == 1
     str[0].to_s.match?(re[0])
   end
 end

data/lib/factbase/version.rb

@@ -9,5 +9,5 @@
 # License:: MIT
 class Factbase
   # Current version of the gem (changed by .rultor.yml on every release)
-  VERSION = '0.12.0' unless const_defined?(:VERSION)
+  VERSION = '0.13.0' unless const_defined?(:VERSION)
 end

data/lib/factbase.rb

@@ -102,8 +102,8 @@ class Factbase
   #
   # A fact, when inserted, is empty. It doesn't contain any properties.
   #
-  # The operation is thread-safe, meaning that you different threads may
-  # insert facts parallel without breaking the consistency of the factbase.
+  # The operation is thread-safe, meaning that different threads may
+  # insert facts in parallel without breaking the consistency of the factbase.
   #
   # @return [Factbase::Fact] The fact just inserted
   def insert
@@ -177,7 +177,12 @@ class Factbase
     taped = Factbase::Taped.new(before)
     catch :commit do
       require_relative 'factbase/light'
-      yield Factbase::Light.new(Factbase.new(taped))
+      commit = false
+      catch :rollback do
+        yield Factbase::Light.new(Factbase.new(taped))
+        commit = true
+      end
+      return 0 unless commit
     rescue Factbase::Rollback
       return 0
     end

data/test/factbase/terms/test_debug.rb

@@ -20,7 +20,7 @@ class TestDebug < Factbase::Test
 
   def test_traced_raises
     e = assert_raises(StandardError) { Factbase::Term.new(:traced, ['foo']).evaluate(fact, [], Factbase.new) }
-    assert_match(/A term expected, but 'foo' provided/, e.message)
+    assert_match(/A term is expected, but 'foo' provided/, e.message)
   end
 
   def test_traced_raises_when_too_many_args
@@ -81,7 +81,7 @@ class TestDebug < Factbase::Test
       assert_raises(StandardError) do
         Factbase::Term.new(:assert, [123, Factbase::Term.new(:gt, [:foo, 0])]).evaluate(fact, [], Factbase.new)
       end
-    assert_match(/A string expected as first argument of 'assert', but '123' provided/, e.message)
+    assert_match(/A string is expected as first argument of 'assert', but '123' provided/, e.message)
   end
 
   def test_assert_raises_when_second_arg_not_term
@@ -89,7 +89,7 @@ class TestDebug < Factbase::Test
       assert_raises(StandardError) do
         Factbase::Term.new(:assert, %w[message not_a_term]).evaluate(fact, [], Factbase.new)
       end
-    assert_match(/A term expected as second argument of 'assert', but 'not_a_term' provided/, e.message)
+    assert_match(/A term is expected as second argument of 'assert', but 'not_a_term' provided/, e.message)
   end
 
   def test_assert_raises_when_too_few_args

data/test/test_factbase.rb

@@ -486,6 +486,15 @@ class TestFactbase < Factbase::Test
     assert_equal(1, fb.size)
   end
 
+  def test_rolls_back
+    fb = Factbase.new
+    fb.txn do |fbt|
+      fbt.insert.foo = 1
+      throw :rollback
+    end
+    assert_equal(0, fb.size)
+  end
+
   def test_get_raise_for_empty_fact
     fb = Factbase.new
     fb.txn do |fbt|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: factbase
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.13.0
 platform: ruby
 authors:
 - Yegor Bugayenko