facio 0.1.16 → 0.1.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d340a59ed3ac5e635d5eb4f0ffd36dba7c9f48ac6e46eb2ef9f3b9d1b83c01b2
-  data.tar.gz: 056cdd8cbc0b68be37615c9077510ec506a7ac89fb18f27072ff9f8a63ad61e9
+  metadata.gz: bfe5c1e2738690ffb95ea5b7c301f0929568ee644dc30b566c15bdb0a7a54d65
+  data.tar.gz: 39d526d6b864d59834f243dad254658a371da178ccc048c2e6dfdbc4fa8c9d7d
 SHA512:
-  metadata.gz: 10e473dbee725d09d3ae2a661aaaaf865941452a49131206b5828401ab0a3d62f45a2d378b7b56a796d981d4d4803c4848399b90f75136b2446beb0fa3cd6584
-  data.tar.gz: 7178d9571ad1ef46ef5ecc0bdef1574871b872476ff2392cc54da2ddc77abb92b7f7bb76770ff6eb1b6ac9dc164a91204c4f84e0a599ff8b77de34537d01925f
+  metadata.gz: d20726eb3af4004911836e38490b4342a81c5e767006d73adc23727b7f64d50b9db18dba143afaf443b84b6a64c3abab759284ac7e84f19c12a6b6cee492c682
+  data.tar.gz: a47767c1d0403123bbb5001524613ca1ae459466c32f497602aa62eb60854f9d4eb0d0a7041d923b79c10f4bc1c207818d19057d4ecedb6be2deef608e3eeeb4

data/README.md

@@ -4,7 +4,7 @@ Command pattern for Ruby (on Rails). From Wikipedia:
 
 > In object-oriented programming, the command pattern is a behavioral design pattern in which an object is used to encapsulate all information needed to perform an action or trigger an event at a later time. This information includes the method name, the object that owns the method and values for the method parameters.
 
-It basically allows you to encapsulate bits of code for a specific purpose. It's also nicely explained by [refactoring.guru](https://refactoring.guru/design-patterns/command)
+It basically allows you to encapsulate bits of code for a specific purpose. It's also nicely explained by [refactoring.guru](https://refactoring.guru/design-patterns/command). It also makes these easier to test in isolation, not cluttering your model and/or controller.
 
 ## Installation
 

data/lib/facio/concerns/callbacks.rb

@@ -2,36 +2,42 @@ module Callbacks
   extend ActiveSupport::Concern
 
   included do
-    around_perform do |job, block|
+    around_perform :_facio_set_context_and_result_for_perform
+    around_enqueue :_facio_set_context_for_enqueue
+
+    private
+
+    def _facio_set_context_and_result_for_perform
       @context = self.class.context_class.new(arguments.first)
       @result = self.class.result_class&.new
       @performed = false
 
       if @context.valid?
         result = nil
+        @performed = true
+
         if transactional && defined?(ActiveRecord::Base)
           ActiveRecord::Base.transaction(requires_new: true) do
-            result = block.call
+            result = yield
             # This will only rollback the changes of the service, SILENTLY, however the context will be failed? already.
             # This is the most close to expected behaviour this can get.
             raise ActiveRecord::Rollback if context.failed?
           end
         else
-          result = block.call
+          result = yield
         end
 
-        @performed = true
         # Purely as a convenience, but also to enforce a standard
         context.result ||= result if @result.nil?
       end
     end
 
-    around_enqueue do |job, block|
+    def _facio_set_context_for_enqueue
       @performed = false
       @context = self.class.context_class.new(arguments.first)
       @result = self.class.result_class&.new
 
-      block.call if @context.valid?
+      yield if @context.valid?
     end
   end
 end

data/lib/facio/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Facio
-  VERSION = "0.1.16"
+  VERSION = "0.1.17"
 end

data/mise.toml

@@ -1,2 +1,2 @@
 [tools]
-ruby = "3.4.7"
+ruby = "4.0.1"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: facio
 version: !ruby/object:Gem::Version
-  version: 0.1.16
+  version: 0.1.17
 platform: ruby
 authors:
 - Tom de Grunt
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-16 00:00:00.000000000 Z
+date: 2026-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack