fabrication 2.17.0 → 2.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f77d2a10a03e1420c0e2e5ec08f156c990a088d8
-  data.tar.gz: 75d2e8a00f8cc4916c6a8837f518e6de90e9daf0
+  metadata.gz: b16cf8ca405caaf21ab076cd40a2ea7d8c2be30a
+  data.tar.gz: b785f882534a6d5139ca43bca6c8240dcd43efdb
 SHA512:
-  metadata.gz: 25cfb81ca168bab05a52c1921738dc6243f59b2a95da01f699058bd734ff10c21b893ec3a018ebee6f1b033dcd2ee7d2601dffd3700b2975998554c5c32f6a62
-  data.tar.gz: 5992742810af94e0f92496fdbc666479aacbf96ff308e0bc009a2dac68171af9662f63e080f49cddae6686b48bb87a415a501b1fdbc713da72cd3a44b36448f0
+  metadata.gz: edb17b2fe50e6b6076b921576039e25e8aee00ffcce70f0ffdde721912617d5e26db164cd8bb1d291adc578dd1a420fbc4e7304586a46ec8695803eec908b657
+  data.tar.gz: 984e757e5f90514b95cab7d32ad776d0a9b04a0550773e28b74732059d27ff39ae71d3feb3b379183f61a4b90629b970c159fce75fb15eb1d106fb6af3cc3adf

data/lib/fabrication.rb

@@ -12,6 +12,7 @@ module Fabrication
   autoload :UnfabricatableError,      'fabrication/errors/unfabricatable_error'
   autoload :UnknownFabricatorError,   'fabrication/errors/unknown_fabricator_error'
   autoload :MisplacedFabricateError,  'fabrication/errors/misplaced_fabricate_error'
+  autoload :InfiniteRecursionError,   'fabrication/errors/infinite_recursion_error'
 
   module Schematic
     autoload :Attribute,  'fabrication/schematic/attribute'

data/lib/fabrication/config.rb

@@ -53,5 +53,8 @@ module Fabrication
     def generator_for(default_generators, klass)
       (generators + default_generators).detect { |gen| gen.supports?(klass) }
     end
+
+    def recursion_limit; @recursion_limit ||= 20 end
+    def recursion_limit=(limit); @recursion_limit = limit end
   end
 end

data/lib/fabrication/errors/infinite_recursion_error.rb

@@ -0,0 +1,5 @@
+class Fabrication::InfiniteRecursionError < StandardError
+  def initialize(name)
+    super("You appear to have infinite recursion with the `#{name}` fabricator")
+  end
+end

data/lib/fabrication/schematic/definition.rb

@@ -54,11 +54,12 @@ class Fabrication::Schematic::Definition
   end
 
   def build(overrides={}, &block)
+    Fabrication.manager.prevent_recursion!
     if Fabrication.manager.to_params_stack.any?
       to_params(overrides, &block)
     else
       begin
-        Fabrication.manager.build_stack << self
+        Fabrication.manager.build_stack << name
         merge(overrides, &block).instance_eval do
           generator.new(klass).build(sorted_attributes, callbacks)
         end
@@ -69,19 +70,26 @@ class Fabrication::Schematic::Definition
   end
 
   def fabricate(overrides={}, &block)
+    Fabrication.manager.prevent_recursion!
     if Fabrication.manager.build_stack.any?
       build(overrides, &block)
     elsif Fabrication.manager.to_params_stack.any?
       to_params(overrides, &block)
     else
-      merge(overrides, &block).instance_eval do
-        generator.new(klass).create(sorted_attributes, callbacks)
+      begin
+        Fabrication.manager.create_stack << name
+        merge(overrides, &block).instance_eval do
+          generator.new(klass).create(sorted_attributes, callbacks)
+        end
+      ensure
+        Fabrication.manager.create_stack.pop
       end
     end
   end
 
   def to_params(overrides={}, &block)
-    Fabrication.manager.to_params_stack << self
+    Fabrication.manager.prevent_recursion!
+    Fabrication.manager.to_params_stack << name
     merge(overrides, &block).instance_eval do
       generator.new(klass).to_params(sorted_attributes)
     end

data/lib/fabrication/schematic/manager.rb

@@ -33,6 +33,10 @@ class Fabrication::Schematic::Manager
     schematics[name.to_sym]
   end
 
+  def create_stack
+    @create_stack ||= []
+  end
+
   def build_stack
     @build_stack ||= []
   end
@@ -56,6 +60,12 @@ class Fabrication::Schematic::Manager
     freeze
   end
 
+  def prevent_recursion!
+    (create_stack + build_stack + to_params_stack).group_by(&:to_sym).each do |name, values|
+      raise Fabrication::InfiniteRecursionError.new(name) if values.length > Fabrication::Config.recursion_limit
+    end
+  end
+
   protected
 
   def raise_if_registered(name)

data/lib/fabrication/version.rb

@@ -1,3 +1,3 @@
 module Fabrication
-  VERSION = '2.17.0'
+  VERSION = '2.18.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fabrication
 version: !ruby/object:Gem::Version
-  version: 2.17.0
+  version: 2.18.0
 platform: ruby
 authors:
 - Paul Elliott
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-07 00:00:00.000000000 Z
+date: 2017-10-09 00:00:00.000000000 Z
 dependencies: []
 description: Fabrication is an object generation framework for ActiveRecord, Mongoid,
   DataMapper, Sequel, or any other Ruby object.
@@ -26,6 +26,7 @@ files:
 - lib/fabrication/config.rb
 - lib/fabrication/cucumber/step_fabricator.rb
 - lib/fabrication/errors/duplicate_fabricator_error.rb
+- lib/fabrication/errors/infinite_recursion_error.rb
 - lib/fabrication/errors/misplaced_fabricate_error.rb
 - lib/fabrication/errors/unfabricatable_error.rb
 - lib/fabrication/errors/unknown_fabricator_error.rb
@@ -62,7 +63,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="