ezid-client 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1a8c3c449a9447e7176421f705a537c9919442a9
-  data.tar.gz: 9d16f67d27605bc7066f6dd3df2e9a9be5dc4e26
+  metadata.gz: aadca7c8873de91162829915f9f1eb4a071505a2
+  data.tar.gz: ded517161bf42799607d34c27caf5297baa60f24
 SHA512:
-  metadata.gz: 94f6cf47f52bb030e0f7cf4442ef5aedbcb31f9348ebb1e528a11e9727b2a3e94260002ff43dd2fb1240fdeadbc3b2adde341fa83e5ad6b28f44e9e0f982eedd
-  data.tar.gz: 4a70172958a729e05c2b5ba2d5a51081e5a4865135c9107111045a9993f9e5881f10d3ca50d0b180d2f1b73cc383913955111beeac1660da9f6635f17754ef01
+  metadata.gz: a8bc419ec35cbd1b0b467c3ea1e71c01066b4b0aa604bd0ac3d5e9339c91b5a74693171cd6c0a478284986fbcb6cdc3659fc6d902a77b9e2d9a601356dc1185b
+  data.tar.gz: 3a20ac6400849df2dd6ce85c422e693627357f16c54de512c812a73a886545599c328d10ae38bff7a02a15f9d307f4d4d05d104ece70e05675ad039f7974396e

data/README.md

@@ -113,7 +113,7 @@ I, [2014-12-04T15:12:48.853964 #86734]  INFO -- : EZID DELETE ark:/99999/fk4n58p
 
 ## Metadata handling
 
-In order to ease metadata management access to EZID [reserved metadata elements](http://ezid.cdlib.org/doc/apidoc.html#internal-metadata) and [metadata profiles](http://ezid.cdlib.org/doc/apidoc.html#metadata-profiles) is provided through `#method_missing` according to these heuristics:
+Accessors are provided to ease the use of EZID [reserved metadata elements](http://ezid.cdlib.org/doc/apidoc.html#internal-metadata) and [metadata profiles](http://ezid.cdlib.org/doc/apidoc.html#metadata-profiles):
 
 **Reserved elements** can be read and written using the name of the element without the leading underscore:
 

data/VERSION

@@ -1 +1 @@
-0.10.0
+0.11.0

data/lib/ezid/metadata.rb

@@ -37,7 +37,7 @@ module Ezid
     LINE_ENDING_RE = /\r?\n/
 
     # A metadata element
-    Element = Struct.new(:name, :writer)
+    Element = Struct.new(:name, :reader, :writer)
 
     # Metadata profiles
     PROFILES = {
@@ -78,11 +78,19 @@ module Ezid
 
     def self.register_element(accessor, opts={})
       if element = registered_elements[accessor.to_sym]
-        raise Error, "Element \"#{element.name}\" already registered under key :#{accessor}"
+        raise Error, "Element \"#{element.name}\" is registered under the accessor :#{accessor}."
       end
-      writer = opts.fetch(:writer, true)
-      name = opts.fetch(:name, accessor.to_s)
-      registered_elements[accessor.to_sym] = Element.new(name, writer).freeze
+      element = Element.new(opts.fetch(:name, accessor.to_s))
+      element.reader = define_reader(accessor, element.name)
+      element.writer = define_writer(accessor, element.name) if opts.fetch(:writer, true)
+      registered_elements[accessor.to_sym] = element
+    end
+
+    def self.unregister_element(accessor)
+      element = registered_elements.delete(accessor)
+      raise Error, "No element is registered under the accessor :#{accessor}." unless element
+      remove_method(element.reader)
+      remove_method(element.writer) if element.writer
     end
 
     def self.register_profile_element(profile, element)
@@ -107,9 +115,24 @@ module Ezid
       end
     end
 
+    def self.define_reader(accessor, element)
+      define_method(accessor) do
+        reader(element)
+      end
+    end
+
+    def self.define_writer(accessor, element)
+      define_method("#{accessor}=") do |value|
+        writer(element, value)
+      end
+    end
+
     private_class_method :register_elements,
                          :register_reserved_elements,
-                         :register_profile_elements
+                         :register_profile_elements,
+                         :unregister_element,
+                         :define_reader,
+                         :define_writer
 
     def initialize(data={})
       super(coerce(data))
@@ -132,24 +155,8 @@ module Ezid
       self.class.registered_elements
     end
 
-    protected
-
-      def method_missing(method, *args)
-        return registered_reader(method) if registered_reader?(method, *args)
-        return registered_writer(method, *args) if registered_writer?(method, *args)
-        super
-      end
-
     private
 
-      def registered_reader?(accessor, *args)
-        args.empty? && registered_elements.include?(accessor)
-      end
-
-      def registered_reader(accessor)
-        reader registered_elements[accessor].name
-      end
-
       def reader(element)
         value = self[element]
         if RESERVED_TIME_ELEMENTS.include?(element)
@@ -159,17 +166,6 @@ module Ezid
         value
       end
 
-      def registered_writer?(method, *args)
-        return false unless method.to_s.end_with?("=") && args.size == 1
-        accessor = method.to_s.sub("=", "").to_sym
-        registered_elements.include?(accessor) && registered_elements[accessor].writer
-      end
-
-      def registered_writer(method, *args)
-        accessor = method.to_s.sub("=", "").to_sym
-        writer(registered_elements[accessor].name, *args)
-      end
-
       def writer(element, value)
         self[element] = value
       end

data/spec/unit/metadata_spec.rb

@@ -68,10 +68,8 @@ module Ezid
 
     describe "custom element" do
       let(:element) { Metadata::Element.new("custom", true) }
-      before do
-        allow(subject.registered_elements).to receive(:include?).with(:custom) { true } 
-        allow(subject.registered_elements).to receive(:[]).with(:custom) { element } 
-      end
+      before { described_class.register_element :custom }
+      after { described_class.send(:unregister_element, :custom) }
       it "should have a reader" do
         expect(subject).to receive(:reader).with("custom")
         subject.custom

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezid-client
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - David Chandek-Stark
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-20 00:00:00.000000000 Z
+date: 2014-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler