ezcater_rubocop 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: caa54b1bc5ab26cb7d499ac8b61e01aeb94bb82de6a7de5c125cbc4a1f4c3c0a
-  data.tar.gz: 4af52c423b5e171436383e3ee85bbfdd72ef1a80e0de7f519a88e44cf21a20ab
+  metadata.gz: 59363f6017a9e7c83ac703824a241234009c10ded26a608b576342dcae476beb
+  data.tar.gz: 70ede1534ff0563c74b4c221053a9f97fccf6af899291a39e6ec366aa20fec48
 SHA512:
-  metadata.gz: 7cc9e1d28ef7cb67418d65e16e17e5d43c850c76d3b417a4a264c30a80cb43d648ed0204441e5f612b2719daf241fea818e2aace75338106c16910345137ec56
-  data.tar.gz: 1760b6cdc245067c9d46d6ea9574b1bce15c7c2c1e0dc1b59d53f733a20ac36db2cf137697754f21992d0a76e3dc2dcfba4d11b8fa15b358b5df324523175d9f
+  metadata.gz: 8fd92f50f269a93990759237b7260d1872675297ed80d37dfca8bdaac2ce9be26280663a69c3ad3beefa54010ca7b0b64d5b128a6c53bcdee7b164adc98f214c
+  data.tar.gz: a4a660828cd2df9b9c86313fc8f763f9aa127746fa2bd80ab52f7c4262bd0317b282e5aa6b95b128ea9691fb9f9abb38fb510e23f269a44c975e4340b245d997

data/CHANGELOG.md

@@ -6,6 +6,9 @@ This gem is moving onto its own [Semantic Versioning](https://semver.org/) schem
 
 Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the ezcater_rubocop gem was `v0.49.0`.
 
+## v1.4.0
+- Add `Ezcater/RubyTimeout` cop.
+
 ## v1.3.0
 - Add `Ezcater/GraphqlFieldsNaming` cop.
 

data/config/default.yml

@@ -51,3 +51,7 @@ Ezcater/StyleDig:
   Description: 'Recommend `dig` for deeply nested access.'
   Enabled: true
   AutoCorrect: false
+
+Ezcater/RubyTimeout:
+  Description: 'Disallow use of `Timeout.timeout` because it is unsafe and can cause unexpected behavior.'
+  Enabled: true

data/ezcater_rubocop.gemspec

@@ -47,7 +47,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 12.3"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec_junit_formatter"
-  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "simplecov", "< 0.18.0"
 
   spec.add_runtime_dependency "parser", "!= 2.5.1.1"
   spec.add_runtime_dependency "rubocop", "~> 0.61.1"

data/lib/ezcater_rubocop.rb

@@ -18,6 +18,7 @@ require "rubocop/cop/ezcater/direct_env_check"
 require "rubocop/cop/ezcater/graphql_fields_naming"
 require "rubocop/cop/ezcater/rails_configuration"
 require "rubocop/cop/ezcater/rails_env"
+require "rubocop/cop/ezcater/ruby_timeout"
 require "rubocop/cop/ezcater/rails_top_level_sql_execute"
 require "rubocop/cop/ezcater/require_gql_error_helpers"
 require "rubocop/cop/ezcater/rspec_match_ordered_array"

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "1.3.0"
+  VERSION = "1.4.0"
 end

data/lib/rubocop/cop/ezcater/ruby_timeout.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Ezcater
+      # Don't use Timeout.timeout because it can cause transient errors
+      #
+      # @example
+      #   # bad
+      #   Timeout.timeout(5) do
+      #     ...
+      #   end
+      #
+      #   # good
+      #   expiry_time = Time.current + 5.seconds
+      #   while Time.current < expiry_time
+      #     ...
+      #   end
+      #
+      class RubyTimeout < Cop
+        MSG = <<~END_MESSAGE.split("\n").join(" ")
+          `Timeout.timeout` is unsafe. Find an alternative to achieve the same goal.
+           Ex. Use the timeout capabilities of a networking library.
+           Ex. Iterate and check runtime after each iteration.
+        END_MESSAGE
+
+        def_node_matcher "timeout", <<-PATTERN
+          (send (const _ :Timeout) :timeout)
+        PATTERN
+
+        def on_send(node)
+          timeout(node) do
+            add_offense(node, location: :expression, message: MSG)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-22 00:00:00.000000000 Z
+date: 2020-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -84,16 +84,16 @@ dependencies:
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.18.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.18.0
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
@@ -169,6 +169,7 @@ files:
 - lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb
 - lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb
 - lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb
+- lib/rubocop/cop/ezcater/ruby_timeout.rb
 - lib/rubocop/cop/ezcater/style_dig.rb
 - lib/rubocop/rspec/language/each_selector.rb
 homepage: https://github.com/ezcater/ezcater_rubocop
@@ -191,8 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: ezCater custom cops and shared configuration