ezcater_rubocop 0.61.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1dd63f47a3bcd703e5aa60616979f405bda811f12de11488f001b16fb0898ae9
-  data.tar.gz: 3d49e4d9d83e11e04672e52ac3a8c66234d517683842b6d2a91ae63b72880aad
+  metadata.gz: 8e1c304030fe5da5102a86e477882fa12f9132b1896f0d7b24aff2ea70a99cab
+  data.tar.gz: 3aa1c18e629184ba97669e1f5a095dd932e1f8b59196627e62a94a5144c10fc6
 SHA512:
-  metadata.gz: 636d2d18f91cb5f8ca0293a88cdb3c2a5222bbf12c8969996e3e78f50c662a0037e8ad66825e2dc6ebbe4e648f37334f13fce3003042cc7eec8b7ef26f2a8a1c
-  data.tar.gz: c300ccec1951724482cc508b82b0f5aa7453d566c3a0f84ab89b4b58a62059e501d1fd3f580c9a4b4765de993eb2bfec367389010e28e28ade9cd3c23acd7ee3
+  metadata.gz: 99ee7e614217065e3d9e47a442e06924e2ab53b2ccddf79ac1edbeb429a55ef4333fe9868d23f136bf8ff78aff4f163d210b52f248cf6ab9e9a03190a51bef62
+  data.tar.gz: c09be310e90746bae51e5858f3fef846de23c11fee2944774855b5d869639a9bb5ebc78435f8b2408dc7cafc7f1927fd7b249afba7190e3cc738ad08a312f72b

data/CHANGELOG.md

@@ -2,9 +2,16 @@
 
 # Versioning
 
-NB: This gem is versioned based on the `MAJOR`.`MINOR` version of rubocop. The first release of the
+This gem is moving onto its own [Semantic Versioning](https://semver.org/) scheme starting with v1.0.0. All version bumps moving forward should increment using `MAJOR.MINOR.PATCH` based on changes.
+
+Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the
 ezcater_rubocop gem was `v0.49.0`.
 
+## v1.0.0
+
+- Begin using Semantic Versioning
+- Delete `Ezcater/PrivateAttr`
+
 ## v0.61.1
 - `Layout/IndentHash` enforces consistent style
 - `Layout/IndentArray` enforces consistent style

data/README.md

@@ -70,21 +70,10 @@ running rubocop.
 
 ## Versioning
 
-This gem is versioned based on the MAJOR.MINOR version of `rubocop`. The first
-release of the `ezcater_rubocop` gem was v0.49.0.
-
-The patch version for this gem does _not_ correspond to the patch version of
-`rubocop`. The patch version for this gem will change any time that one of its
-configurations is modified _or_ its dependency on `rubocop` is changed to require
-a different patch version.
-
-This gem also includes a dependency on `rubocop-rspec` that will be updated to
-the latest compatible version each time that the MAJOR.MINOR version of `rubocop`
-is updated.
+This gem is using [Semantic Versioning](https://semver.org/). All version bumps should increment using `MAJOR.MINOR.PATCH` based on changes.
 
 ## Custom Cops
 
-1. [PrivateAttr](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/private_attr.rb) - Require methods from the `private_attr` gem.
 1. [RailsConfiguration](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rails_configuration.rb) - Enforce use of `Rails.configuration` instead of `Rails.application.config`.
 1. [RequireGqlErrorHelpers](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/require_gql_error_helpers.rb) - Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly.
 1. [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" and "::<class method>" for example group description.

data/config/default.yml

@@ -1,7 +1,3 @@
-Ezcater/PrivateAttr:
-  Description: 'Require methods from the private_attr gem'
-  Enabled: true
-
 Ezcater/RailsConfiguration:
   Description: 'Enforce the use of `Rails.configuration` instead of `Rails.application.config`.'
   Enabled: true

data/lib/ezcater_rubocop.rb

@@ -14,7 +14,6 @@ puts "configuration from #{DEFAULT_FILES}" if RuboCop::ConfigLoader.debug?
 config = RuboCop::ConfigLoader.merge_with_default(config, path)
 RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
 
-require "rubocop/cop/ezcater/private_attr"
 require "rubocop/cop/ezcater/rails_configuration"
 require "rubocop/cop/ezcater/require_gql_error_helpers"
 require "rubocop/cop/ezcater/rspec_match_ordered_array"

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "0.61.1"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.61.1
+  version: 1.0.0
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-22 00:00:00.000000000 Z
+date: 2019-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -157,7 +157,6 @@ files:
 - ezcater_rubocop.gemspec
 - lib/ezcater_rubocop.rb
 - lib/ezcater_rubocop/version.rb
-- lib/rubocop/cop/ezcater/private_attr.rb
 - lib/rubocop/cop/ezcater/rails_configuration.rb
 - lib/rubocop/cop/ezcater/require_gql_error_helpers.rb
 - lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb

data/lib/rubocop/cop/ezcater/private_attr.rb

@@ -1,93 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Ezcater
-      # This cop checks for the use of `attr_accessor`, `attr_reader`, `attr_writer`
-      # and `alias_method` after the access modifiers `private` and `protected`
-      # and requires the use of methods from the private_attr gem instead.
-      #
-      # @example
-      #
-      #   # bad
-      #
-      #   class C
-      #     private
-      #
-      #     attr_accessor :foo
-      #     attr_reader :bar
-      #     attr_writer :baz
-      #     alias_method :foobar, foo
-      #   end
-      #
-      #
-      # @example
-      #
-      #   # good
-      #
-      #   class C
-      #     private_attr_accessor :foo
-      #     private_attr_reader :bar
-      #     private_attr_writer :baz
-      #     private_alias_method :foobar, :foo
-      #
-      #     private
-      #
-      #     def shy
-      #       puts "hi"
-      #     end
-      #   end
-      class PrivateAttr < Cop
-        ATTR_METHODS = %i(attr_accessor
-                          attr_reader
-                          attr_writer).freeze
-
-        ACCESS_AFFECTED_METHODS = (ATTR_METHODS + %i(alias_method)).to_set.freeze
-
-        MSG = "Use `%<visibility>s_%<method_name>s` instead"
-
-        def on_class(node)
-          check_node(node.children[2]) # class body
-        end
-
-        def on_module(node)
-          check_node(node.children[1]) # module body
-        end
-
-        private
-
-        def check_node(node)
-          return unless node&.begin_type?
-
-          check_scope(node)
-        end
-
-        def format_message(visibility, method_name)
-          format(MSG, visibility: visibility, method_name: method_name)
-        end
-
-        def check_scope(node, current_visibility = :public)
-          node.children.reduce(current_visibility) do |visibility, child|
-            check_child_scope(child, visibility)
-          end
-        end
-
-        def check_child_scope(node, current_visibility)
-          if node.send_type?
-            if node.access_modifier? && !node.method?(:module_function)
-              current_visibility = node.method_name
-            elsif ACCESS_AFFECTED_METHODS.include?(node.method_name) && current_visibility != :public
-              add_offense(node,
-                          location: :expression,
-                          message: format_message(current_visibility, node.method_name))
-            end
-          elsif node.kwbegin_type?
-            check_scope(node, current_visibility)
-          end
-
-          current_visibility
-        end
-      end
-    end
-  end
-end