ezcater_rubocop 0.58.1 → 0.58.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a203ce14964584cd2496e6d407959b403e776a951c23f8472af789a2e7654509
-  data.tar.gz: d540266ab1b81e502618f79fd4ad9e30788f7d85eef4a5109437a3f3ec0deb2a
+  metadata.gz: e151dd4b27ee7e5bcddac56133f15076fae095c805b8eeae79c0f31bb670eb08
+  data.tar.gz: ba22adef7ce8f2ab6a9b2459a1c0b10b519ad2ae4aa7d414c3f53a8552b9d57a
 SHA512:
-  metadata.gz: c2276b3d2a7ec7eb2cd3fafd25e581c4a105c9ad11c0dc0a7766bea19f3ef5d94163178281c947d7f06475de62a501f809da0d98cbe426a3e3748b105839846d
-  data.tar.gz: 239c0df2650f5dfe420bd628b6fd3fc650984f2a7da9aa4d413ddfba7536ca1d58c2b0328876e173b4b0df0dad4b656ff8cb98b70126fdd56f8ba50582ac9fe1
+  metadata.gz: 4fd3c2e43cf638746b08a07886ee0bcd136583bee145c60cea0cb3d4853a6a1789a978bd993a4f438610f3a72331527a928b2772015ee765d96202a1731b39fa
+  data.tar.gz: 57a591efffc15e96abc89621b7912f73dc1c6eb6d327142fa0e753e4067e8083a654eb296bbc4009babccd10af00d0aa2d6c757d0f2e509848542cb380b610b5

data/README.md

@@ -83,10 +83,11 @@ the latest compatible version each time that the MAJOR.MINOR version of `rubocop
 is updated.
 
 ## Custom Cops
+
 1. [PrivateAttr](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/private_attr.rb) - Require methods from the `private_attr` gem.
 1. [RailsConfiguration](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rails_configuration.rb) - Enforce use of `Rails.configuration` instead of `Rails.application.config`.
 1. [RequireGqlErrorHelpers](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/require_gql_error_helpers.rb) - Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly.
-1. [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" for example group description.
+1. [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" and "::<class method>" for example group description.
 1. [RspecMatchOrderedArray](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb) - Enforce use of `match_ordered_array` matcher instead of `eq` matcher. This matcher comes from the [ezcater_matchers](https://github.com/ezcater/ezcater_matchers) gem.
 1. [RspecRequireBrowserMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb) - Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly.
 1. [RspecRequireFeatureFlagMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb) - Enforce use of `mock_feature_flag` helper instead of mocking `FeatureFlag.is_active?` directly.

data/ezcater_rubocop.gemspec

@@ -47,6 +47,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec_junit_formatter"
+  spec.add_development_dependency "simplecov"
 
   spec.add_runtime_dependency "parser", "!= 2.5.1.1"
   spec.add_runtime_dependency "rubocop", "~> 0.58.2"

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "0.58.1"
+  VERSION = "0.58.2"
 end

data/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb

@@ -17,9 +17,18 @@ module RuboCop
       #   describe "self.does_stuff" do
       #     ...
       #   end
+      #
+      #   # bad
+      #   describe "::does_stuff" do
+      #     ...
+      #   end
+
       class RspecDotNotSelfDot < Cop
         SELF_DOT_REGEXP = /["']self\./
-        MSG = 'Use ".<class method>" instead of "self.<class method>" for example group description.'
+        COLON_COLON_REGEXP = /["'](\:\:)/
+
+        SELF_DOT_MSG = 'Use ".<class method>" instead of "self.<class method>" for example group description.'
+        COLON_COLON_MSG = 'Use ".<class method>" instead of "::<class method>" for example group description.'
 
         def_node_matcher :example_group_match, <<-PATTERN
           (send _ #{RuboCop::RSpec::Language::ExampleGroups::ALL.node_pattern_union} $_ ...)
@@ -27,15 +36,20 @@ module RuboCop
 
         def on_send(node)
           example_group_match(node) do |doc|
-            add_offense(doc, location: :expression, message: MSG) if doc.source.match?(SELF_DOT_REGEXP)
+            if doc.source.match?(SELF_DOT_REGEXP)
+              add_offense(doc, location: :expression, message: SELF_DOT_MSG)
+            elsif doc.source.match?(COLON_COLON_REGEXP)
+              add_offense(doc, location: :expression, message: COLON_COLON_MSG)
+            end
           end
         end
 
         def autocorrect(node)
           lambda do |corrector|
-            corrector.remove(Parser::Source::Range.new(node.source_range.source_buffer,
-                                                       node.source_range.begin_pos + 1,
-                                                       node.source_range.begin_pos + 5))
+            experession_end = node.source.match?(COLON_COLON_REGEXP) ? 3 : 6
+            corrector.replace(Parser::Source::Range.new(node.source_range.source_buffer,
+                                                        node.source_range.begin_pos + 1,
+                                                        node.source_range.begin_pos + experession_end), ".")
           end
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.58.1
+  version: 0.58.2
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-24 00:00:00.000000000 Z
+date: 2018-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement