ezcater_rubocop 0.57.0 → 0.57.1.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8943926de27d2e7dc09368390a4c99a307182ea02fa169bb9d2a99ba86215411
-  data.tar.gz: 0f281ac0be4b5091c34807f1a8ea0207a9bd4c397d559f4ca11f21e40943fd7a
+  metadata.gz: 594f9a35130cc34ff4d3cf3ab5df960fad929a7595f489ec490d421a626aa570
+  data.tar.gz: 4c45aa0ca4f30aeec78a47fa4ca6306d295aa46f29e43dec2be1b7a3cae4cde5
 SHA512:
-  metadata.gz: b36ff32b48d9459f6674c0aba02b9a7cb6bd7d43094699005b9361ef125ecd18c857b6a3e81a1afbcb32076209a8d960a193f0dd461e1e9cf117a51beca6a8c8
-  data.tar.gz: bb10cfc742a558e85976663c536a1f035e70c8a31d0f3c268e1fd23625478dd9330401e17875a8a292b6f1f0f25697dc9d594000b9edfe07e32f5d16b9822de6
+  metadata.gz: 47befdebcbbacf4e3ecf2d323b429b672e488af3e04767b1c27b280008a4e6df721e63bec6c536065d9bdba92d6458d4a8d651f189421aaa7ea2b3f81ed38ab1
+  data.tar.gz: cffce667d759c26c966fd5fe13ec74ae59ff1e974201a78dcaf9070855742b1d0c9dae51ca8f3c761dce6e17502853609ba1feae7bf736b94d34688dd23cf8c7

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,7 @@
+## What did we change?
+
+## Why are we doing this?
+
+## How was it tested?
+- [ ] Specs
+- [ ] Locally

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # ezcater_rubocop
 
+## v0.57.1
+- Add `Ezcater/RspecRequireHttpStatusMatcher` cop.
+- Enable `RSpec/Rails/HttpStatus` cop and enforce symbols.
+
 ## v0.57.0
 - Update to rubocop v0.57.2 and rubocop-rspec v1.27.0.
 - Disable new cop `Naming/MemoizedInstanceVariableName` until configuration

data/README.md

@@ -90,6 +90,7 @@ is updated.
 1. [RspecMatchOrderedArray](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb) - Enforce use of `match_ordered_array` matcher instead of `eq` matcher. This matcher comes from the [ezcater_matchers](https://github.com/ezcater/ezcater_matchers) gem.
 1. [RspecRequireBrowserMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb) - Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly.
 1. [RspecRequireFeatureFlagMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb) - Enforce use of `mock_feature_flag` helper instead of mocking `FeatureFlag.is_active?` directly.
+1. [RspecRequireHttpStatusMatcher](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb) - Use the HTTP status code matcher, like `expect(response).to have_http_status :bad_request`, rather than `expect(response.code).to eq 400`
 1. [StyleDig](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/style_dig.rb) - Recommend `dig` for deeply nested access.
 
 ## Development

data/conf/rubocop_rails.yml

@@ -15,6 +15,9 @@ Rails/RelativeDateConstant:
   # constant but does not update references to it.
   AutoCorrect: false
 
+RSpec/Rails/HttpStatus:
+  EnforcedStyle: symbolic
+
 Style/MixinUsage:
   Exclude:
   - "bin/**/*"

data/config/default.yml

@@ -24,6 +24,12 @@ Ezcater/RspecRequireFeatureFlagMock:
   Include:
     - '**/*_spec.rb'
 
+Ezcater/RspecRequireHttpStatusMatcher:
+  Description: 'Use the HTTP status code matcher, like `expect(response).to have_http_status :bad_request`, rather than `expect(response.code).to eq 400`'
+  Enabled: true
+  Include:
+    - '**/*_spec.rb'
+
 Ezcater/RequireGqlErrorHelpers:
   Description: 'Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly.'
   Enabled: true

data/lib/ezcater_rubocop.rb

@@ -20,5 +20,6 @@ require "rubocop/cop/ezcater/require_gql_error_helpers"
 require "rubocop/cop/ezcater/rspec_match_ordered_array"
 require "rubocop/cop/ezcater/rspec_require_browser_mock"
 require "rubocop/cop/ezcater/rspec_require_feature_flag_mock"
+require "rubocop/cop/ezcater/rspec_require_http_status_matcher"
 require "rubocop/cop/ezcater/rspec_dot_not_self_dot"
 require "rubocop/cop/ezcater/style_dig"

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "0.57.0"
+  VERSION = "0.57.1.rc1"
 end

data/lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Ezcater
+      # Enforce use of HTTP status code matchers rather than asserting on on random numbers.
+      #
+      # @example
+      #
+      #   # good
+      #   expect(response).to be_created
+      #   expect(response).to be_bad_request
+      #
+      #   # bad
+      #   expect(response).to have_http_status 201
+      #   expect(response).to have_http_status 400
+      class RspecRequireHttpStatusMatcher < Cop
+        MSG = "Use the `have_http_status_code` matcher, like `expect(response).to have_http_status :bad_request`, "\
+          "rather than `%<node_source>s`"
+
+        def_node_matcher :response_code_assertion, <<~PATTERN
+          (send (send _ :expect (send (send _ :response) :code)) :to (send _ :eq (int _)))
+        PATTERN
+
+        def on_send(node)
+          return unless response_code_assertion(node)
+
+          add_offense(node,
+                      location: :expression,
+                      message: format(MSG, node_source: node.source))
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.57.0
+  version: 0.57.1.rc1
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-22 00:00:00.000000000 Z
+date: 2018-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -130,6 +130,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/PULL_REQUEST_TEMPLATE.md"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -149,6 +150,7 @@ files:
 - lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb
 - lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb
 - lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb
+- lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb
 - lib/rubocop/cop/ezcater/style_dig.rb
 - lib/rubocop/rspec/language/each_selector.rb
 homepage: https://github.com/ezcater/ezcater_rubocop
@@ -167,9 +169,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.7.6