ezcater_rubocop 0.52.4 → 0.52.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 67af97a2ff53b71e3cddaf9b49f16c28513bb94eb73822f9b03b0bc52b1a846b
-  data.tar.gz: 12e5044ad545f293d6b8bcfb634792752b09a12ee6a0806c4c3e90a44ae3f0b3
+SHA1:
+  metadata.gz: 36a6c9f976b293c7d962dcc016e7ce4578f61a91
+  data.tar.gz: 3329ea5257d891dc1cf54a724f8401c2db5d634f
 SHA512:
-  metadata.gz: 04fe5b8aee985117378effaa4e722b135f371368ec10fdfe3feb80b6ff3711e957aa2adaa206d74f9ecf772c61a52e9115d32d533d70d1aacd679163825b6288
-  data.tar.gz: 9d8740e7a326daf88be4b285b5da9fd7baf70d37364ba1741ad2bfcbee009d25518c53ea20c31eb8c5ec4bcca13161d95d1b658f5dd11822f207b84a8d939f79
+  metadata.gz: dfd4b6760cf5084baf9e066065acf65c30894ede346426e92a5e93209caf673acf463b3eee7ab9b58ae835108f4e538537022c5714cb406f8b4de743e3adbd5d
+  data.tar.gz: 32228db40690919db39fd4e6c24c9727e74c254a48425cc5716003d71f922551bf561fa32ad66ea08d1fc6bd47a5a01c66d910c1fb0c0ce37ca70c634c8cbe5a

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # ezcater_rubocop
 
+## v0.52.5
+- Add `Ezcater/RspecMatchOrderedArray` cop.
+- Fix array equality matcher violations in specs.
+
 ## v0.52.4
 - Configure `Style/RegexpLiteral` cop with the `AllowInnerSlashes: true` option.
 

data/README.md

@@ -86,6 +86,7 @@ is updated.
 1. [RailsConfiguration](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rails_configuration.rb) - Enforce use of `Rails.configuration` instead of `Rails.application.config`.
 1. [RequireGqlErrorHelpers](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/require_gql_error_helpers.rb) - Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly.
 1. [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" for example group description.
+1. [RspecMatchOrderedArray](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb) - Enforce use of `match_ordered_array` matcher instead of `eq` matcher. This matcher comes from the [ezcater_matchers](https://github.com/ezcater/ezcater_matchers) gem.
 1. [RspecRequireBrowserMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb) - Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly.
 1. [RspecRequireFeatureFlagMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb) - Enforce use of `mock_feature_flag` helper instead of mocking `FeatureFlag.is_active?` directly.
 1. [StyleDig](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/style_dig.rb) - Recommend `dig` for deeply nested access.

data/lib/ezcater_rubocop.rb

@@ -15,6 +15,7 @@ RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
 require "rubocop/cop/ezcater/private_attr"
 require "rubocop/cop/ezcater/rails_configuration"
 require "rubocop/cop/ezcater/require_gql_error_helpers"
+require "rubocop/cop/ezcater/rspec_match_ordered_array"
 require "rubocop/cop/ezcater/rspec_require_browser_mock"
 require "rubocop/cop/ezcater/rspec_require_feature_flag_mock"
 require "rubocop/cop/ezcater/rspec_dot_not_self_dot"

data/lib/ezcater_rubocop/version.rb

@@ -1,3 +1,3 @@
 module EzcaterRubocop
-  VERSION = "0.52.4".freeze
+  VERSION = "0.52.5".freeze
 end

data/lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb

@@ -0,0 +1,45 @@
+module RuboCop
+  module Cop
+    module Ezcater
+      # Enforce use of `match_ordered_array` matcher instead of using `eq` matcher
+      #
+      # @example
+      #
+      #   # good
+      #   expect(foo).to match_ordered_array([1, 2, 3])
+      #   expect(foo).to match_ordered_array [1, 2, 3]
+      #
+      #   # bad
+      #   expect(foo).to eq([1, 2, 3])
+      #   expect(foo).to eq [1, 2, 3]
+      class RspecMatchOrderedArray < Cop
+        MATCH_ORDERED_ARRAY = "match_ordered_array".freeze
+        MSG = "Use the `match_ordered_array` matcher from ezcater_matchers gem "\
+          "instead of `eq` when comparing collections".freeze
+
+        def_node_matcher "eq_array", <<~PATTERN
+          (send nil? :eq (array ...))
+        PATTERN
+
+        def on_send(node)
+          eq_array(node) do
+            add_offense(node, location: :expression, message: MSG)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(
+              Parser::Source::Range.new(
+                node.source_range.source_buffer,
+                node.source_range.begin_pos,
+                node.source_range.begin_pos + 2
+              ),
+              MATCH_ORDERED_ARRAY
+            )
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.52.4
+  version: 0.52.5
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-03 00:00:00.000000000 Z
+date: 2018-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -131,6 +131,7 @@ files:
 - lib/rubocop/cop/ezcater/rails_configuration.rb
 - lib/rubocop/cop/ezcater/require_gql_error_helpers.rb
 - lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb
+- lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb
 - lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb
 - lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb
 - lib/rubocop/cop/ezcater/style_dig.rb
@@ -156,7 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: ezCater custom cops and shared configuration